70280 2011-10-17 16:02:08 -0700 Scroll animator tracing 2011-10-18 16:04:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scottbyer scottbyer jamesr webkit.review.bot oldest_to_newest 485588 0 scottbyer 2011-10-17 16:02:08 -0700 Scroll animator tracing 485589 1 111339 scottbyer 2011-10-17 16:03:05 -0700 Created attachment 111339 Patch WebKit style question here; my inclination was to create TraceEvent.h at the platform level, renamed the one in the chromium dir to TraceEventChromium.h, and have TraceEvent.h either include TraceEventChromium.h or empty define the macro, so I could remove the platform conditionals from ScrollAnimatorNone.cpp. Good impulse, or is this more minimal patch better? 485591 2 webkit.review.bot 2011-10-17 16:05:05 -0700 Attachment 111339 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485669 3 111339 nduca 2011-10-17 17:40:46 -0700 Comment on attachment 111339 Patch <3 (though darn, we really need to figure out how to avoid all the platform-chromium goop. 485673 4 jamesr 2011-10-17 17:41:22 -0700 I wonder if other platforms are interested in this tracing stuff - I could imagine a dtrace backend or whatnot. 486148 5 scottbyer 2011-10-18 10:32:57 -0700 That's why I was thinking of lifting up the header - to both get rid of the PLATFORM goop in the implementation file and to leave the path open to implement the define for other platforms. But, should that be part of this CL or another? I can go either way. The tracing stuff really helps figure out what's going on in time critical sections of code, so I could see it becoming really useful if it were carefully added (that is, not too much noise). 486178 6 111339 jamesr 2011-10-18 11:11:04 -0700 Comment on attachment 111339 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111339&action=review This is fine as-is, imo. R=me with one nit > Source/WebCore/platform/ScrollAnimatorNone.cpp:583 > + > + nit: extra newline 486265 7 111491 scottbyer 2011-10-18 13:15:09 -0700 Created attachment 111491 Remove extra line 486391 8 111491 webkit.review.bot 2011-10-18 16:04:17 -0700 Comment on attachment 111491 Remove extra line Clearing flags on attachment: 111491 Committed r97803: <http://trac.webkit.org/changeset/97803> 486392 9 webkit.review.bot 2011-10-18 16:04:21 -0700 All reviewed patches have been landed. Closing bug. 111339 2011-10-17 16:03:05 -0700 2011-10-18 13:15:01 -0700 Patch bug-70280-20111017160304.patch text/plain 3219 scottbyer U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2NTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNTZmMDA5ZDNiODQyNmEy ODQ0ODI3MGNlMDQ3ZGFjYTU2MTliNWY3Li4yN2VhYWFlOGYyMDI1OTE3MzkzYTg5NDdiNWFkZTA1 MDZmOTg2NzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTcgIFNjb3R0 IEJ5ZXIgIDxzY290dGJ5ZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNjcm9sbCBhbmltYXRv ciB0cmFjaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIGZ1bmN0aW9uYWwgZGlmZmVyZW5jZSwgbm8gdGVzdCBuZWVkZWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs QW5pbWF0b3JOb25lOjpzY3JvbGwpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JO b25lOjphbmltYXRpb25UaW1lckZpcmVkKToKKwogMjAxMS0wOS0yMiAgT2phbiBWYWZhaSAgPG9q YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGluY29ycmVjdCBoZWlnaHQgd2l0aCBoZWlnaHQ6 YXV0byBhbmQgd3JpdGluZy1tb2RlOnZlcnRpY2FsLXJsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAppbmRleCA5MzU2MjQ4ZjcwM2RmZDg4YmVjNjli ZGVmMDExMDU3ZmNkMzU1NzhmLi5kMDQ5NjVlMmU4NzYwYWM5Yzg5ZTkzOTQ3YjczYjc3ZjY0YTE1 MjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5v bmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5j cHAKQEAgLTQwLDExICs0MCwxNCBAQAogI2luY2x1ZGUgIlBsYXRmb3JtR2VzdHVyZUV2ZW50Lmgi CiAjaW5jbHVkZSAiU2Nyb2xsYWJsZUFyZWEuaCIKICNpbmNsdWRlICJTY3JvbGxiYXJUaGVtZS5o IgotI2luY2x1ZGUgIlRyYWNlRXZlbnQuaCIKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVk ZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4KIAorI2lm IFBMQVRGT1JNKENIUk9NSVVNKQorI2luY2x1ZGUgIlRyYWNlRXZlbnQuaCIKKyNlbmRpZgorCiB1 c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC00MTEsNiArNDE0 LDEwIEBAIGJvb2wgU2Nyb2xsQW5pbWF0b3JOb25lOjpzY3JvbGwoU2Nyb2xsYmFyT3JpZW50YXRp b24gb3JpZW50YXRpb24sIFNjcm9sbEdyYW51bGFyCiAgICAgaWYgKCFtX3Njcm9sbGFibGVBcmVh LT5zY3JvbGxBbmltYXRvckVuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIFNjcm9sbEFuaW1hdG9y OjpzY3JvbGwob3JpZW50YXRpb24sIGdyYW51bGFyaXR5LCBzdGVwLCBtdWx0aXBsaWVyKTsKIAor I2lmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIFRSQUNFX0VWRU5UKCJTY3JvbGxBbmltYXRvck5v bmU6OnNjcm9sbCIsIHRoaXMsIDApOworI2VuZGlmCisKICAgICAvLyBGSVhNRTogZ2V0IHRoZSB0 eXBlIHBhc3NlZCBpbi4gTW91c2VXaGVlbCBjb3VsZCBhbHNvIGJlIGJ5IGxpbmUsIGJ1dCBzaG91 bGQgc3RpbGwgaGF2ZSBkaWZmZXJlbnQKICAgICAvLyBhbmltYXRpb24gcGFyYW1ldGVycyB0aGFu IHRoZSBrZXlib2FyZC4KICAgICBQYXJhbWV0ZXJzIHBhcmFtZXRlcnM7CkBAIC01NDIsNiArNTQ5 LDEwIEBAIHZvaWQgU2Nyb2xsQW5pbWF0b3JOb25lOjp1cGRhdGVWaXNpYmxlTGVuZ3RocygpCiAK IHZvaWQgU2Nyb2xsQW5pbWF0b3JOb25lOjphbmltYXRpb25UaW1lckZpcmVkKFRpbWVyPFNjcm9s bEFuaW1hdG9yTm9uZT4qIHRpbWVyKQogeworI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIFRS QUNFX0VWRU5UKCJTY3JvbGxBbmltYXRvck5vbmU6OmFuaW1hdGlvblRpbWVyRmlyZWQiLCB0aGlz LCAwKTsKKyNlbmRpZgorCiAgICAgZG91YmxlIGN1cnJlbnRUaW1lID0gV1RGOjptb25vdG9uaWNh bGx5SW5jcmVhc2luZ1RpbWUoKTsKICAgICBkb3VibGUgZGVsdGFUb05leHRGcmFtZSA9IGNlaWwo KGN1cnJlbnRUaW1lIC0gbV9zdGFydFRpbWUpICoga0ZyYW1lUmF0ZSkgLyBrRnJhbWVSYXRlIC0g KGN1cnJlbnRUaW1lIC0gbV9zdGFydFRpbWUpOwogCkBAIC01NTIsNiArNTYzLDkgQEAgdm9pZCBT Y3JvbGxBbmltYXRvck5vbmU6OmFuaW1hdGlvblRpbWVyRmlyZWQoVGltZXI8U2Nyb2xsQW5pbWF0 b3JOb25lPiogdGltZXIpCiAgICAgICAgIGNvbnRpbnVlQW5pbWF0aW9uID0gdHJ1ZTsKIAogICAg IGlmIChtX3pvb21EYXRhLm1faXNBbmltYXRpbmcpIHsKKyNpZiBQTEFURk9STShDSFJPTUlVTSkK KyAgICAgICAgVFJBQ0VfRVZFTlQoIlNjcm9sbEFuaW1hdG9yTm9uZTo6bm90aWZ5Wm9vbUNoYW5n ZWQiLCB0aGlzLCAwKTsKKyNlbmRpZgogICAgICAgICBpZiAobV96b29tRGF0YS5tX3N0YXJ0VGlt ZSAmJiBtX3pvb21EYXRhLmFuaW1hdGVab29tKGN1cnJlbnRUaW1lICsgZGVsdGFUb05leHRGcmFt ZSkpIHsKICAgICAgICAgICAgIGNvbnRpbnVlQW5pbWF0aW9uID0gdHJ1ZTsKICAgICAgICAgICAg IG5vdGlmeVpvb21DaGFuZ2VkKFpvb21BbmltYXRpb25Db250aW51aW5nKTsKQEAgLTU2NSw2ICs1 NzksMTEgQEAgdm9pZCBTY3JvbGxBbmltYXRvck5vbmU6OmFuaW1hdGlvblRpbWVyRmlyZWQoVGlt ZXI8U2Nyb2xsQW5pbWF0b3JOb25lPiogdGltZXIpCiAgICAgICAgIGRvdWJsZSBuZXh0VGltZXJJ bnRlcnZhbCA9IG1heChrTWluaW11bVRpbWVySW50ZXJ2YWwsIGRlbHRhVG9OZXh0RnJhbWUpOwog ICAgICAgICB0aW1lci0+c3RhcnRPbmVTaG90KG5leHRUaW1lckludGVydmFsKTsKICAgICB9CisK KworI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIFRSQUNFX0VWRU5UKCJTY3JvbGxBbmltYXRv ck5vbmU6Om5vdGlmeVBvc2l0aW9uQ2hhbmdlZCIsIHRoaXMsIDApOworI2VuZGlmCiAgICAgbm90 aWZ5UG9zaXRpb25DaGFuZ2VkKCk7CiB9CiAK 111491 2011-10-18 13:15:09 -0700 2011-10-18 16:04:17 -0700 Remove extra line bug-70280-20111018131503.patch text/plain 3228 scottbyer U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3ODAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYzdmNzk4MTU3OTA2N2Y1 NTM3NDJhNWYzNWE5OWYzODJkYmE1MzhmLi5hZTMyYjU1YmJjZjIwNzJkMTdhOWU1NGM1NTU1YzA1 NmMzMGI2MmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTcgIFNjb3R0 IEJ5ZXIgIDxzY290dGJ5ZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNjcm9sbCBhbmltYXRv ciB0cmFjaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAgICAg IE5vIGZ1bmN0aW9uYWwgZGlmZmVyZW5jZSwgbm8gdGVzdCBuZWVkZWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs QW5pbWF0b3JOb25lOjpzY3JvbGwpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JO b25lOjphbmltYXRpb25UaW1lckZpcmVkKToKKwogMjAxMS0xMC0xOCAgU2hhd24gU2luZ2ggIDxz aGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFRyYWNraW5nIHVw ZGF0ZSByZWN0cyBpbiBMYXllckNocm9taXVtIGFuZCBDQ0xheWVySW1wbC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCmluZGV4IDkzNTYyNDhmNzAz ZGZkODhiZWM2OWJkZWYwMTEwNTdmY2QzNTU3OGYuLjJjZDVmM2EyNzYzMDZhN2ZhZDA2NThhY2Rl MzY1MTJkYjRhZTUzNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bEFuaW1hdG9yTm9uZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5p bWF0b3JOb25lLmNwcApAQCAtNDAsMTEgKzQwLDE0IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1HZXN0 dXJlRXZlbnQuaCIKICNpbmNsdWRlICJTY3JvbGxhYmxlQXJlYS5oIgogI2luY2x1ZGUgIlNjcm9s bGJhclRoZW1lLmgiCi0jaW5jbHVkZSAiVHJhY2VFdmVudC5oIgogI2luY2x1ZGUgPGFsZ29yaXRo bT4KICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KICNpbmNsdWRlIDx3dGYvUGFzc093blB0 ci5oPgogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisjaW5jbHVkZSAiVHJhY2VFdmVudC5oIgor I2VuZGlmCisKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAg LTQxMSw2ICs0MTQsMTAgQEAgYm9vbCBTY3JvbGxBbmltYXRvck5vbmU6OnNjcm9sbChTY3JvbGxi YXJPcmllbnRhdGlvbiBvcmllbnRhdGlvbiwgU2Nyb2xsR3JhbnVsYXIKICAgICBpZiAoIW1fc2Ny b2xsYWJsZUFyZWEtPnNjcm9sbEFuaW1hdG9yRW5hYmxlZCgpKQogICAgICAgICByZXR1cm4gU2Ny b2xsQW5pbWF0b3I6OnNjcm9sbChvcmllbnRhdGlvbiwgZ3JhbnVsYXJpdHksIHN0ZXAsIG11bHRp cGxpZXIpOwogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAgVFJBQ0VfRVZFTlQoIlNjcm9s bEFuaW1hdG9yTm9uZTo6c2Nyb2xsIiwgdGhpcywgMCk7CisjZW5kaWYKKwogICAgIC8vIEZJWE1F OiBnZXQgdGhlIHR5cGUgcGFzc2VkIGluLiBNb3VzZVdoZWVsIGNvdWxkIGFsc28gYmUgYnkgbGlu ZSwgYnV0IHNob3VsZCBzdGlsbCBoYXZlIGRpZmZlcmVudAogICAgIC8vIGFuaW1hdGlvbiBwYXJh bWV0ZXJzIHRoYW4gdGhlIGtleWJvYXJkLgogICAgIFBhcmFtZXRlcnMgcGFyYW1ldGVyczsKQEAg LTU0Miw2ICs1NDksMTAgQEAgdm9pZCBTY3JvbGxBbmltYXRvck5vbmU6OnVwZGF0ZVZpc2libGVM ZW5ndGhzKCkKIAogdm9pZCBTY3JvbGxBbmltYXRvck5vbmU6OmFuaW1hdGlvblRpbWVyRmlyZWQo VGltZXI8U2Nyb2xsQW5pbWF0b3JOb25lPiogdGltZXIpCiB7CisjaWYgUExBVEZPUk0oQ0hST01J VU0pCisgICAgVFJBQ0VfRVZFTlQoIlNjcm9sbEFuaW1hdG9yTm9uZTo6YW5pbWF0aW9uVGltZXJG aXJlZCIsIHRoaXMsIDApOworI2VuZGlmCisKICAgICBkb3VibGUgY3VycmVudFRpbWUgPSBXVEY6 Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwogICAgIGRvdWJsZSBkZWx0YVRvTmV4dEZy YW1lID0gY2VpbCgoY3VycmVudFRpbWUgLSBtX3N0YXJ0VGltZSkgKiBrRnJhbWVSYXRlKSAvIGtG cmFtZVJhdGUgLSAoY3VycmVudFRpbWUgLSBtX3N0YXJ0VGltZSk7CiAKQEAgLTU1Miw2ICs1NjMs OSBAQCB2b2lkIFNjcm9sbEFuaW1hdG9yTm9uZTo6YW5pbWF0aW9uVGltZXJGaXJlZChUaW1lcjxT Y3JvbGxBbmltYXRvck5vbmU+KiB0aW1lcikKICAgICAgICAgY29udGludWVBbmltYXRpb24gPSB0 cnVlOwogCiAgICAgaWYgKG1fem9vbURhdGEubV9pc0FuaW1hdGluZykgeworI2lmIFBMQVRGT1JN KENIUk9NSVVNKQorICAgICAgICBUUkFDRV9FVkVOVCgiU2Nyb2xsQW5pbWF0b3JOb25lOjpub3Rp Znlab29tQ2hhbmdlZCIsIHRoaXMsIDApOworI2VuZGlmCiAgICAgICAgIGlmIChtX3pvb21EYXRh Lm1fc3RhcnRUaW1lICYmIG1fem9vbURhdGEuYW5pbWF0ZVpvb20oY3VycmVudFRpbWUgKyBkZWx0 YVRvTmV4dEZyYW1lKSkgewogICAgICAgICAgICAgY29udGludWVBbmltYXRpb24gPSB0cnVlOwog ICAgICAgICAgICAgbm90aWZ5Wm9vbUNoYW5nZWQoWm9vbUFuaW1hdGlvbkNvbnRpbnVpbmcpOwpA QCAtNTY1LDYgKzU3OSwxMCBAQCB2b2lkIFNjcm9sbEFuaW1hdG9yTm9uZTo6YW5pbWF0aW9uVGlt ZXJGaXJlZChUaW1lcjxTY3JvbGxBbmltYXRvck5vbmU+KiB0aW1lcikKICAgICAgICAgZG91Ymxl IG5leHRUaW1lckludGVydmFsID0gbWF4KGtNaW5pbXVtVGltZXJJbnRlcnZhbCwgZGVsdGFUb05l eHRGcmFtZSk7CiAgICAgICAgIHRpbWVyLT5zdGFydE9uZVNob3QobmV4dFRpbWVySW50ZXJ2YWwp OwogICAgIH0KKworI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIFRSQUNFX0VWRU5UKCJTY3Jv bGxBbmltYXRvck5vbmU6Om5vdGlmeVBvc2l0aW9uQ2hhbmdlZCIsIHRoaXMsIDApOworI2VuZGlm CiAgICAgbm90aWZ5UG9zaXRpb25DaGFuZ2VkKCk7CiB9CiAK