70272 2011-10-17 14:44:58 -0700 Rename deregister* to unregister* 2011-10-17 20:11:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa adamk ggaren oliver pfeldman sam webkit.review.bot yurys oldest_to_newest 485519 0 rniwa 2011-10-17 14:44:58 -0700 There are exactly 3 functions in Source named deregisterBlah instead of unregisterBlah. We should rename them all to unregisteredBlah for consistency. 485520 1 rniwa 2011-10-17 14:45:12 -0700 Source/JavaScriptCore/runtime/JSGlobalObject.h: void deregisterWeakMap(OpaqueJSWeakObjectMap* map) Source/WebCore/inspector/front-end/ExtensionAPI.js: extensionServer.deregisterHandler("open-resource"); Source/WebCore/inspector/front-end/ExtensionAPI.js: deregisterHandler: function(command) Source/WebCore/inspector/front-end/ExtensionServer.js: WebInspector.openAnchorLocationRegistry.deregisterHandler(name); Source/WebCore/inspector/front-end/HandlerRegistry.js: deregisterHandler: function(name) 485525 2 111324 rniwa 2011-10-17 14:49:35 -0700 Created attachment 111324 cleanup 485530 3 webkit.review.bot 2011-10-17 14:51:57 -0700 Attachment 111324 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485757 4 111324 webkit.review.bot 2011-10-17 20:11:21 -0700 Comment on attachment 111324 cleanup Clearing flags on attachment: 111324 Committed r97706: <http://trac.webkit.org/changeset/97706> 485758 5 webkit.review.bot 2011-10-17 20:11:26 -0700 All reviewed patches have been landed. Closing bug. 111324 2011-10-17 14:49:35 -0700 2011-10-17 20:11:21 -0700 cleanup bug-70272-20111017144934.patch text/plain 4422 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc2NTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMTAtMTcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmVuYW1lIGRlcmVnaXN0ZXIqIHRvIHVucmVnaXN0ZXIqCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDI3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZWQgZGVyZWdpc3RlcldlYWtNYXAgdG8gdW5y ZWdpc3RlcldlYWtNYXAuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0Lmg6Cisg ICAgICAgIChKU0M6OkpTR2xvYmFsT2JqZWN0Ojp1bnJlZ2lzdGVyV2Vha01hcCk6CisKIDIwMTEt MTAtMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWMg YnVpbGQgZml4LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxP YmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0ds b2JhbE9iamVjdC5oCShyZXZpc2lvbiA5NzYzNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI5MSw3ICsyOTEsNyBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIG1fcmFyZURhdGEtPndlYWtNYXBzLmFkZCht YXApOwogICAgICAgICB9CiAKLSAgICAgICAgdm9pZCBkZXJlZ2lzdGVyV2Vha01hcChPcGFxdWVK U1dlYWtPYmplY3RNYXAqIG1hcCkKKyAgICAgICAgdm9pZCB1bnJlZ2lzdGVyV2Vha01hcChPcGFx dWVKU1dlYWtPYmplY3RNYXAqIG1hcCkKICAgICAgICAgewogICAgICAgICAgICAgaWYgKG1fcmFy ZURhdGEpCiAgICAgICAgICAgICAgICAgbV9yYXJlRGF0YS0+d2Vha01hcHMucmVtb3ZlKG1hcCk7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NzY1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDExLTEwLTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbmFtZSBkZXJlZ2lzdGVyKiB0 byB1bnJlZ2lzdGVyKgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzAyNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZW5hbWVkIGRlcmVnaXN0ZXJIYW5kbGVyIHRvIHVucmVnaXN0ZXJIYW5kbGVyLgorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanM6CisgICAgICAgIChp bmplY3RlZEV4dGVuc2lvbkFQSS5FeHRlbnNpb25TZXJ2ZXJDbGllbnQucHJvdG90eXBlLnVucmVn aXN0ZXJIYW5kbGVyKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblNl cnZlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FeHRlbnNpb25TZXJ2ZXIucHJvdG90eXBl Ll9vblNldE9wZW5SZXNvdXJjZUhhbmRsZXIpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvSGFuZGxlclJlZ2lzdHJ5LmpzOgorICAgICAgICAoZ2V0IFdlYkluc3BlY3Rvci5IYW5kbGVy UmVnaXN0cnkucHJvdG90eXBlLnVucmVnaXN0ZXJIYW5kbGVyKToKKwogMjAxMS0xMC0xMiAgT2ph biBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGRpc3BsYXk6aW5saW5lLWJs b2NrIGVsZW1lbnRzIGRvbid0IGNvcnJlY3RseSBoYW5kbGUgb3J0aG9nb25hbCB3cml0aW5nLW1v ZGVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQ SS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4 dGVuc2lvbkFQSS5qcwkocmV2aXNpb24gOTc2MzUpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qcwkod29ya2luZyBjb3B5KQpAQCAtMjU3LDcgKzI1 Nyw3IEBAIFBhbmVscy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBoYWRIYW5kbGVyID0gZXh0 ZW5zaW9uU2VydmVyLmhhc0hhbmRsZXIoIm9wZW4tcmVzb3VyY2UiKTsKIAogICAgICAgICBpZiAo IWNhbGxiYWNrKQotICAgICAgICAgICAgZXh0ZW5zaW9uU2VydmVyLmRlcmVnaXN0ZXJIYW5kbGVy KCJvcGVuLXJlc291cmNlIik7CisgICAgICAgICAgICBleHRlbnNpb25TZXJ2ZXIudW5yZWdpc3Rl ckhhbmRsZXIoIm9wZW4tcmVzb3VyY2UiKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBm dW5jdGlvbiBjYWxsYmFja1dyYXBwZXIobWVzc2FnZSkKICAgICAgICAgICAgIHsKQEAgLTYwMiw3 ICs2MDIsNyBAQCBFeHRlbnNpb25TZXJ2ZXJDbGllbnQucHJvdG90eXBlID0gewogICAgICAgICB0 aGlzLl9oYW5kbGVyc1tjb21tYW5kXSA9IGhhbmRsZXI7CiAgICAgfSwKIAotICAgIGRlcmVnaXN0 ZXJIYW5kbGVyOiBmdW5jdGlvbihjb21tYW5kKQorICAgIHVucmVnaXN0ZXJIYW5kbGVyOiBmdW5j dGlvbihjb21tYW5kKQogICAgIHsKICAgICAgICAgZGVsZXRlIHRoaXMuX2hhbmRsZXJzW2NvbW1h bmRdOwogICAgIH0sCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4 dGVuc2lvblNlcnZlci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0V4dGVuc2lvblNlcnZlci5qcwkocmV2aXNpb24gOTc2MzUpCisrKyBTb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblNlcnZlci5qcwkod29ya2luZyBj b3B5KQpAQCAtMjY0LDcgKzI2NCw3IEBAIFdlYkluc3BlY3Rvci5FeHRlbnNpb25TZXJ2ZXIucHJv dG90eXBlID0KICAgICAgICAgaWYgKG1lc3NhZ2UuaGFuZGxlclByZXNlbnQpCiAgICAgICAgICAg ICBXZWJJbnNwZWN0b3Iub3BlbkFuY2hvckxvY2F0aW9uUmVnaXN0cnkucmVnaXN0ZXJIYW5kbGVy KG5hbWUsIHRoaXMuX2hhbmRsZUFuY2hvckNsaWNrZWQuYmluZCh0aGlzLCBwb3J0KSk7CiAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgIFdlYkluc3BlY3Rvci5vcGVuQW5jaG9yTG9jYXRpb25SZWdp c3RyeS5kZXJlZ2lzdGVySGFuZGxlcihuYW1lKTsKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5v cGVuQW5jaG9yTG9jYXRpb25SZWdpc3RyeS51bnJlZ2lzdGVySGFuZGxlcihuYW1lKTsKICAgICB9 LAogCiAgICAgX2hhbmRsZUFuY2hvckNsaWNrZWQ6IGZ1bmN0aW9uKHBvcnQsIGFuY2hvcikKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGFuZGxlclJlZ2lzdHJ5Lmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGFuZGxl clJlZ2lzdHJ5LmpzCShyZXZpc2lvbiA5NzYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSGFuZGxlclJlZ2lzdHJ5LmpzCSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3 MCw3IEBAIFdlYkluc3BlY3Rvci5IYW5kbGVyUmVnaXN0cnkucHJvdG90eXBlID0KICAgICAgICAg dGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkhhbmRsZXJSZWdpc3Ry eS5FdmVudFR5cGVzLkhhbmRsZXJzVXBkYXRlZCk7CiAgICAgfSwKIAotICAgIGRlcmVnaXN0ZXJI YW5kbGVyOiBmdW5jdGlvbihuYW1lKQorICAgIHVucmVnaXN0ZXJIYW5kbGVyOiBmdW5jdGlvbihu YW1lKQogICAgIHsKICAgICAgICAgZGVsZXRlIHRoaXMuX2hhbmRsZXJzW25hbWVdOwogICAgICAg ICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuSGFuZGxlclJlZ2lz dHJ5LkV2ZW50VHlwZXMuSGFuZGxlcnNVcGRhdGVkKTsK