70268 2011-10-17 14:00:25 -0700 The TextTrack 'mode' attribute should have values DISABLED, HIDDEN, and SHOWING, not OFF, HIDDEN, and SHOWING 2011-10-18 09:06:19 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annacc annacc dbates eric.carlson webkit.review.bot oldest_to_newest 485487 0 annacc 2011-10-17 14:00:25 -0700 The whatwg spec changed slightly to use DISABLED instead of OFF for TextTrack mode: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#dom-texttrack-mode 485491 1 111319 annacc 2011-10-17 14:10:57 -0700 Created attachment 111319 Patch 485493 2 webkit.review.bot 2011-10-17 14:13:31 -0700 Attachment 111319 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource From git://git.webkit.org/WebKit 466a1d4..b98b9c1 master -> origin/master M LayoutTests/platform/chromium/test_expectations.txt M LayoutTests/ChangeLog r97647 = b98b9c1b40b87810b122fce6bb91cff107b24376 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485885 3 111319 dbates 2011-10-18 00:38:31 -0700 Comment on attachment 111319 Patch r=me 486081 4 111319 webkit.review.bot 2011-10-18 09:06:14 -0700 Comment on attachment 111319 Patch Clearing flags on attachment: 111319 Committed r97762: <http://trac.webkit.org/changeset/97762> 486082 5 webkit.review.bot 2011-10-18 09:06:19 -0700 All reviewed patches have been landed. Closing bug. 111319 2011-10-17 14:10:57 -0700 2011-10-18 09:06:14 -0700 Patch bug-70268-20111017141054.patch text/plain 2198 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2NDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZmM5YjZjYzdkZjYwNWZj ZDRhZmE3M2Q3NzM2Yjg5YjYwZDJhMGQ0Li45YjAzYzc1YzI4ZTlhYTM4YTIwNTI0YzY0YWI5ZWUy MTM3ODVlY2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTcgIEFubmEg Q2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBUZXh0VHJh Y2sgdG8gdXNlIHRoZSB3b3JkIERJU0FCTEVEIGluc3RlYWQgb2YgT0ZGIGZvciBtb2RlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDI2OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Tm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBodG1sL1RleHRUcmFjay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUZXh0VHJhY2s6OnNldE1vZGUpOiB1c2UgRGlzYWJsZWQgaW5zdGVh ZCBvZiBPZmYKKyAgICAgICAgKiBodG1sL1RleHRUcmFjay5oOiB1cGRhdGUgTW9kZSBlbnVtIHRv IHVzZSBEaXNhYmxlZCBpbnN0ZWFkIG9mIE9mZgorCiAyMDExLTEwLTE3ICBEbWl0cnkgVGl0b3Yg IDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHdpbmRvdy53ZWJraXROb3RpZmljYXRp b25zIHVzZXMgZGVhbGxvY2F0ZWQgTm90aWZpY2F0aW9uUHJlc2VudGVyIGFmdGVyIGxpdmUgSWZy YW1lIHRyYW5zZmVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2su Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2suY3BwCmluZGV4IDIzMmExM2U5ZTE0 YzVkNWIyNTEzMTlmZmI5Mzk5OWJkOTcxMjEwMGUuLjMwMWFlNzFkNzU1ZTI4YWE0OWJjZmEzYzU5 NDJlYjIyODg4ZmZiMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dFRyYWNr LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRUcmFjay5jcHAKQEAgLTg1LDcgKzg1 LDcgQEAgdm9pZCBUZXh0VHJhY2s6OnNldE1vZGUodW5zaWduZWQgc2hvcnQgbW9kZSwgRXhjZXB0 aW9uQ29kZSYgZWMpCiB7CiAgICAgLy8gNC44LjEwLjEyLjUgT24gc2V0dGluZyB0aGUgbW9kZSwg aWYgdGhlIG5ldyB2YWx1ZSBpcyBub3QgZWl0aGVyIDAsIDEsIG9yIDIsCiAgICAgLy8gdGhlIHVz ZXIgYWdlbnQgbXVzdCB0aHJvdyBhbiBJTlZBTElEX0FDQ0VTU19FUlIgZXhjZXB0aW9uLgotICAg IGlmIChtb2RlID09IFRleHRUcmFjazo6T2ZmIHx8IG1vZGUgPT0gVGV4dFRyYWNrOjpIaWRkZW4g fHwgbW9kZSA9PSBUZXh0VHJhY2s6OlNob3dpbmcpCisgICAgaWYgKG1vZGUgPT0gVGV4dFRyYWNr OjpEaXNhYmxlZCB8fCBtb2RlID09IFRleHRUcmFjazo6SGlkZGVuIHx8IG1vZGUgPT0gVGV4dFRy YWNrOjpTaG93aW5nKQogICAgICAgICBtX21vZGUgPSBzdGF0aWNfY2FzdDxNb2RlPihtb2RlKTsK ICAgICBlbHNlCiAgICAgICAgIGVjID0gSU5WQUxJRF9BQ0NFU1NfRVJSOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2suaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4 dFRyYWNrLmgKaW5kZXggOGMzYzY2M2NjYTQ0NTc1OWMyYzYyNTkyNmFkNWVjOTY2OTQyNzZkZC4u MGU2YzAyNjFmY2U2N2ViNGFlNWFmNTI0ZjE1OWNiNjM3MTVlYTFiZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2suaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1Rl eHRUcmFjay5oCkBAIC02MSw3ICs2MSw3IEBAIHB1YmxpYzoKICAgICBlbnVtIFJlYWR5U3RhdGUg eyBOb25lLCBMb2FkaW5nLCBMb2FkZWQsIEVycm9yIH07CiAgICAgUmVhZHlTdGF0ZSByZWFkeVN0 YXRlKCkgY29uc3Q7CiAKLSAgICBlbnVtIE1vZGUgeyBPZmYgPSAwLCBIaWRkZW4gPSAxLCBTaG93 aW5nID0gMiB9OworICAgIGVudW0gTW9kZSB7IERpc2FibGVkID0gMCwgSGlkZGVuID0gMSwgU2hv d2luZyA9IDIgfTsKICAgICBNb2RlIG1vZGUoKSBjb25zdDsKICAgICB2b2lkIHNldE1vZGUodW5z aWduZWQgc2hvcnQsIEV4Y2VwdGlvbkNvZGUmKTsKIAo=