70267 2011-10-17 13:36:51 -0700 CodeGeneratorGObject.pm should use g_value_get_uint() for IDL attributes of type unsigned short. 2011-10-18 15:28:30 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annacc annacc abarth dbates haraken japhet mrobinson rniwa webkit.review.bot xan.lopez oldest_to_newest 485461 0 annacc 2011-10-17 13:36:51 -0700 GetGValueTypeName() in CodeGeneratorGObject converts writable attributes of type unsigned short to g_value_get_ushort(), which is a function that does not exist! I propose changing it to instead generate g_value_get_uint(), which does exist, when it sees this type. I think this is a ligit change because GetGValueTypeName() already converts 'short' to 'int', so converting 'unsigned short' to 'uint' seems reasonable. For more info and an example, see https://bugs.webkit.org/show_bug.cgi?id=62887 485473 1 111315 annacc 2011-10-17 13:47:22 -0700 Created attachment 111315 Patch 485476 2 webkit.review.bot 2011-10-17 13:48:50 -0700 Attachment 111315 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485829 3 111315 mrobinson 2011-10-17 23:13:08 -0700 Comment on attachment 111315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111315&action=review > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1583 > -G_MAXUINT16, /* max */ > +G_MAXUINT, /* max */ Would it make more sense to use G_MAXUSHORT here? 485830 4 mrobinson 2011-10-17 23:13:51 -0700 By the way, thanks for fixing this. I really appreciate it! 485915 5 111315 xan.lopez 2011-10-18 01:48:18 -0700 Comment on attachment 111315 Patch This makes sense to me with Martin's suggestion. Thanks for the patch! 486099 6 annacc 2011-10-18 09:36:46 -0700 Thanks for the quick review. I'll change to G_MAXUSHORT and then land. 486104 7 111454 annacc 2011-10-18 09:41:01 -0700 Created attachment 111454 Patch for landing 486109 8 111454 webkit.review.bot 2011-10-18 09:43:54 -0700 Comment on attachment 111454 Patch for landing Rejecting attachment 111454 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/10124298 486111 9 111456 annacc 2011-10-18 09:46:49 -0700 Created attachment 111456 Patch for landing 486183 10 111456 webkit.review.bot 2011-10-18 11:17:44 -0700 Comment on attachment 111456 Patch for landing Clearing flags on attachment: 111456 Committed r97778: <http://trac.webkit.org/changeset/97778> 486184 11 webkit.review.bot 2011-10-18 11:17:51 -0700 All reviewed patches have been landed. Closing bug. 486219 12 rniwa 2011-10-18 12:18:43 -0700 It appears that this patch broke binding tests: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34000 486231 13 annacc 2011-10-18 12:31:56 -0700 Oops, looks like G_MAXUINT is required by the test, not G_MAXUSHORT. New patch on the way. 486236 14 111482 annacc 2011-10-18 12:40:24 -0700 Created attachment 111482 fix for binding tests 486248 15 annacc 2011-10-18 12:56:20 -0700 needs fix for binding tests 486347 16 111482 webkit.review.bot 2011-10-18 15:17:45 -0700 Comment on attachment 111482 fix for binding tests Rejecting attachment 111482 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: l Bates', u'--for..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp Hunk #1 FAILED at 1580. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Daniel Bates', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/10142103 486353 17 annacc 2011-10-18 15:28:30 -0700 Landed by hand: http://trac.webkit.org/changeset/97793 111315 2011-10-17 13:47:22 -0700 2011-10-18 09:40:58 -0700 Patch bug-70267-20111017134721.patch text/plain 3153 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2NDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0OWJmMmU1Zjc3YzZkYzAz YWFjYzIxMWEzMTU4YTE2ZTRiYTAzOWIwLi44MWQ1M2MyNzgyM2UwODE5YTgyYmUzNTY3MzU5NmVi MTdjNmNlMjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTAtMTcgIEFubmEg Q2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBDb2RlR2Vu ZXJhdG9yR09iamVjdC5wbSB0byB1c2UgZ192YWx1ZV9nZXRfdWludCgpIGluc3RlYWQgb2YgZ192 YWx1ZV9nZXRfdXNob3J0KCkKKyAgICAgICAgZm9yIElETCBhdHRyaWJ1dGVzIG9mIHR5cGUgdW5z aWduZWQgc2hvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3RzOiBzbWFsbCBjaGFuZ2UgdG8gV2ViS2l0RE9NVGVzdE9iai5jcHAKKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChH ZXRHVmFsdWVUeXBlTmFtZSk6IGNvbnZlcnQgdW5zaWduZWQgc2hvcnQgdG8gdWludCBpbnN0ZWFk IG9mIHVzaG9ydAorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2Vi S2l0RE9NVGVzdE9iai5jcHA6CisgICAgICAgICh3ZWJraXRfZG9tX3Rlc3Rfb2JqX3NldF9wcm9w ZXJ0eSk6IGV4cGVjdCBnX3ZhbHVlX2dldF91aW50IGluc3RlYWQgb2YgZ192YWx1ZV9nZXRfdXNo b3J0CisgICAgICAgICh3ZWJraXRfZG9tX3Rlc3Rfb2JqX2NsYXNzX2luaXQpOiBleHBlY3QgR19N QVhVSU5UIGluc3RlYWQgb2YgR19NQVhVSU5UMTYKKwogMjAxMS0xMC0xNyAgSmVmZiBNaWxsZXIg IDxqZWZmbUBhcHBsZS5jb20+CiAKICAgICAgICAgV2lkZ2V0IHdpbmRvdyBjb29yZGluYXRlIGZ1 bmN0aW9ucyBzaG91bGQgdXNlIHJvb3QgdmlldyBjb29yZGluYXRlIGZ1bmN0aW9ucwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVj dC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmpl Y3QucG0KaW5kZXggNzQzYzkwNmExNzFjMTg2ZTk1ZjQ5NDQ4YjFiYWIxMDk3OTAwYWUwZS4uMzY2 MjEwNjE1OGFmNzk5MjBhYjI5Nzk3YWUyMTIzNDliNmIzOTFhZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBA IC0yNDIsNyArMjQyLDcgQEAgc3ViIEdldEdWYWx1ZVR5cGVOYW1lIHsKICAgICAgICAgICAgICAg ICAgInVuc2lnbmVkIGludCIsICJ1aW50IiwKICAgICAgICAgICAgICAgICAgInVuc2lnbmVkIGxv bmcgbG9uZyIsICJ1aW50NjQiLCAKICAgICAgICAgICAgICAgICAgInVuc2lnbmVkIGxvbmciLCAi dWxvbmciLAotICAgICAgICAgICAgICAgICAidW5zaWduZWQgc2hvcnQiLCAidXNob3J0Iik7Cisg ICAgICAgICAgICAgICAgICJ1bnNpZ25lZCBzaG9ydCIsICJ1aW50Iik7CiAKICAgICByZXR1cm4g JHR5cGVzeyR0eXBlfSA/ICR0eXBlc3skdHlwZX0gOiAib2JqZWN0IjsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRl c3RPYmouY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3Qv V2ViS2l0RE9NVGVzdE9iai5jcHAKaW5kZXggM2RmYzRiYzBmYjQ0YTdlOWE3ZDBlY2IxYmNhYjQ2 ODRiYTFlNGY2Yy4uMjExNzNhODFjZTkxMWE2OGU2NzU1MGMzNDhiM2ZiNmJhZGMxOGM5YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2Vi S2l0RE9NVGVzdE9iai5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAKQEAgLTExOTgsNyArMTE5OCw3IEBAIHN0 YXRpYyB2b2lkIHdlYmtpdF9kb21fdGVzdF9vYmpfc2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVj dCwgZ3VpbnQgcHJvcF9pZCwgY29uCiAgICAgc3dpdGNoIChwcm9wX2lkKSB7CiAgICAgY2FzZSBQ Uk9QX1VOU0lHTkVEX1NIT1JUX0FUVFI6CiAgICAgewotICAgICAgICBjb3JlU2VsZi0+c2V0VW5z aWduZWRTaG9ydEF0dHIoKGdfdmFsdWVfZ2V0X3VzaG9ydCh2YWx1ZSkpKTsKKyAgICAgICAgY29y ZVNlbGYtPnNldFVuc2lnbmVkU2hvcnRBdHRyKChnX3ZhbHVlX2dldF91aW50KHZhbHVlKSkpOwog ICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBQUk9QX0lOVF9BVFRSOgpAQCAtMTU4MCw3 ICsxNTgwLDcgQEAgR19NQVhJTlQsIC8qIG1heCAqLwogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAidGVzdF9vYmpfdW5zaWduZWQtc2hv cnQtYXR0ciIsIC8qIHNob3J0IGRlc2NyaXB0aW9uICovCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJyZWFkLXdyaXRlICBndXNob3J0 IFRlc3RPYmoudW5zaWduZWQtc2hvcnQtYXR0ciIsIC8qIGxvbmdlciAtIGNvdWxkIGRvIHdpdGgg c29tZSBleHRyYSBkb2Mgc3R1ZmYgaGVyZSAqLwogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwLCAvKiBtaW4gKi8KLUdfTUFYVUlOVDE2 LCAvKiBtYXggKi8KK0dfTUFYVUlOVCwgLyogbWF4ICovCiAwLCAvKiBkZWZhdWx0ICovCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdF QktJVF9QQVJBTV9SRUFEV1JJVEUpKTsKICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3Bl cnR5KGdvYmplY3RDbGFzcywK 111454 2011-10-18 09:41:01 -0700 2011-10-18 09:46:46 -0700 Patch for landing bug-70267-20111018094100.patch text/plain 3136 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3NjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMjBlNDg5OGIzMWVlYjMw YzIxNzM4ZjEwMjdlYjFmZTMwMmQxMDIxLi5mMjhjODI5YjYwZDc0YjU2MWY1YWNkZDgwNjU4OGY4 NmEzMTIxODQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMTggIEFubmEg Q2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBDb2RlR2Vu ZXJhdG9yR09iamVjdC5wbSB0byB1c2UgZ192YWx1ZV9nZXRfdWludCgpIGluc3RlYWQgb2YgZ192 YWx1ZV9nZXRfdXNob3J0KCkKKyAgICAgICAgZm9yIElETCBhdHRyaWJ1dGVzIG9mIHR5cGUgdW5z aWduZWQgc2hvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3RzOiBzbWFsbCBjaGFuZ2UgdG8gV2ViS2l0RE9NVGVzdE9iai5jcHAKKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChH ZXRHVmFsdWVUeXBlTmFtZSk6IGNvbnZlcnQgdW5zaWduZWQgc2hvcnQgdG8gdWludCBpbnN0ZWFk IG9mIHVzaG9ydAorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktp dERPTVRlc3RPYmouY3BwOgorICAgICAgICAod2Via2l0X2RvbV90ZXN0X29ial9zZXRfcHJvcGVy dHkpOiBleHBlY3QgZ192YWx1ZV9nZXRfdWludCBpbnN0ZWFkIG9mIGdfdmFsdWVfZ2V0X3VzaG9y dAorICAgICAgICAod2Via2l0X2RvbV90ZXN0X29ial9jbGFzc19pbml0KTogZXhwZWN0IEdfTUFY VVNIT1JUIGluc3RlYWQgb2YgR19NQVhVSU5UMTYKKwogMjAxMS0xMC0xOCAgTmF0ZSBDaGFwaW4g IDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1ha2UgRG9jdW1lbnRUaHJlYWRhYmxl TG9hZGVyIGEgQ2FjaGVkUmVzb3VyY2VDbGllbnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCAzNmJmYzJl MGFlMWE3ZjgyMTY0M2Q3NmMzNmEzMzA5NTEwNTIzZGZlLi43YzU1YjE3ZmFlYjBjNWE0N2MxZDI3 ODJkZDExZmNhNTJlYzllN2U2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTI0Miw3ICsyNDIsNyBAQCBz dWIgR2V0R1ZhbHVlVHlwZU5hbWUgewogICAgICAgICAgICAgICAgICAidW5zaWduZWQgaW50Iiwg InVpbnQiLAogICAgICAgICAgICAgICAgICAidW5zaWduZWQgbG9uZyBsb25nIiwgInVpbnQ2NCIs IAogICAgICAgICAgICAgICAgICAidW5zaWduZWQgbG9uZyIsICJ1bG9uZyIsCi0gICAgICAgICAg ICAgICAgICJ1bnNpZ25lZCBzaG9ydCIsICJ1c2hvcnQiKTsKKyAgICAgICAgICAgICAgICAgInVu c2lnbmVkIHNob3J0IiwgInVpbnQiKTsKIAogICAgIHJldHVybiAkdHlwZXN7JHR5cGV9ID8gJHR5 cGVzeyR0eXBlfSA6ICJvYmplY3QiOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmNw cAppbmRleCAzZGZjNGJjMGZiNDRhN2U5YTdkMGVjYjFiY2FiNDY4NGJhMWU0ZjZjLi40ODgwNTE0 OTViZjFkMGJjZmQ3ZGUxZDVkMTdjZmIzMDEzOTcwYmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRE T01UZXN0T2JqLmNwcApAQCAtMTE5OCw3ICsxMTk4LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X2Rv bV90ZXN0X29ial9zZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBj b24KICAgICBzd2l0Y2ggKHByb3BfaWQpIHsKICAgICBjYXNlIFBST1BfVU5TSUdORURfU0hPUlRf QVRUUjoKICAgICB7Ci0gICAgICAgIGNvcmVTZWxmLT5zZXRVbnNpZ25lZFNob3J0QXR0cigoZ192 YWx1ZV9nZXRfdXNob3J0KHZhbHVlKSkpOworICAgICAgICBjb3JlU2VsZi0+c2V0VW5zaWduZWRT aG9ydEF0dHIoKGdfdmFsdWVfZ2V0X3VpbnQodmFsdWUpKSk7CiAgICAgICAgIGJyZWFrOwogICAg IH0KICAgICBjYXNlIFBST1BfSU5UX0FUVFI6CkBAIC0xNTgwLDcgKzE1ODAsNyBAQCBHX01BWElO VCwgLyogbWF4ICovCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJ0ZXN0X29ial91bnNpZ25lZC1zaG9ydC1hdHRyIiwgLyogc2hvcnQg ZGVzY3JpcHRpb24gKi8KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgInJlYWQtd3JpdGUgIGd1c2hvcnQgVGVzdE9iai51bnNpZ25lZC1z aG9ydC1hdHRyIiwgLyogbG9uZ2VyIC0gY291bGQgZG8gd2l0aCBzb21lIGV4dHJhIGRvYyBzdHVm ZiBoZXJlICovCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDAsIC8qIG1pbiAqLwotR19NQVhVSU5UMTYsIC8qIG1heCAqLworR19NQVhV U0hPUlQsIC8qIG1heCAqLwogMCwgLyogZGVmYXVsdCAqLwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfUEFSQU1fUkVBRFdS SVRFKSk7CiAgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0Q2xhc3Ms Cg== 111456 2011-10-18 09:46:49 -0700 2011-10-18 12:40:19 -0700 Patch for landing bug-70267-20111018094648.patch text/plain 3131 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3NjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMjBlNDg5OGIzMWVlYjMw YzIxNzM4ZjEwMjdlYjFmZTMwMmQxMDIxLi4zNzk3ZmNjYmY0M2E0ZjhmMWU3ZGE0MmJmMDIyY2Uw YzU4MzU1MDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMTggIEFubmEg Q2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBDb2RlR2Vu ZXJhdG9yR09iamVjdC5wbSB0byB1c2UgZ192YWx1ZV9nZXRfdWludCgpIGluc3RlYWQgb2YgZ192 YWx1ZV9nZXRfdXNob3J0KCkKKyAgICAgICAgZm9yIElETCBhdHRyaWJ1dGVzIG9mIHR5cGUgdW5z aWduZWQgc2hvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KKworICAgICAgICBU ZXN0czogc21hbGwgY2hhbmdlIHRvIFdlYktpdERPTVRlc3RPYmouY3BwCisKKyAgICAgICAgKiBi aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorICAgICAgICAoR2V0R1Zh bHVlVHlwZU5hbWUpOiBjb252ZXJ0IHVuc2lnbmVkIHNob3J0IHRvIHVpbnQgaW5zdGVhZCBvZiB1 c2hvcnQKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01U ZXN0T2JqLmNwcDoKKyAgICAgICAgKHdlYmtpdF9kb21fdGVzdF9vYmpfc2V0X3Byb3BlcnR5KTog ZXhwZWN0IGdfdmFsdWVfZ2V0X3VpbnQgaW5zdGVhZCBvZiBnX3ZhbHVlX2dldF91c2hvcnQKKyAg ICAgICAgKHdlYmtpdF9kb21fdGVzdF9vYmpfY2xhc3NfaW5pdCk6IGV4cGVjdCBHX01BWFVTSE9S VCBpbnN0ZWFkIG9mIEdfTUFYVUlOVDE2CisKIDIwMTEtMTAtMTggIE5hdGUgQ2hhcGluICA8amFw aGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBNYWtlIERvY3VtZW50VGhyZWFkYWJsZUxvYWRl ciBhIENhY2hlZFJlc291cmNlQ2xpZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5kZXggMzZiZmMyZTBhZTFh N2Y4MjE2NDNkNzZjMzZhMzMwOTUxMDUyM2RmZS4uN2M1NWIxN2ZhZWIwYzVhNDdjMWQyNzgyZGQx MWZjYTUyZWM5ZTdlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC0yNDIsNyArMjQyLDcgQEAgc3ViIEdl dEdWYWx1ZVR5cGVOYW1lIHsKICAgICAgICAgICAgICAgICAgInVuc2lnbmVkIGludCIsICJ1aW50 IiwKICAgICAgICAgICAgICAgICAgInVuc2lnbmVkIGxvbmcgbG9uZyIsICJ1aW50NjQiLCAKICAg ICAgICAgICAgICAgICAgInVuc2lnbmVkIGxvbmciLCAidWxvbmciLAotICAgICAgICAgICAgICAg ICAidW5zaWduZWQgc2hvcnQiLCAidXNob3J0Iik7CisgICAgICAgICAgICAgICAgICJ1bnNpZ25l ZCBzaG9ydCIsICJ1aW50Iik7CiAKICAgICByZXR1cm4gJHR5cGVzeyR0eXBlfSA/ICR0eXBlc3sk dHlwZX0gOiAib2JqZWN0IjsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouY3BwIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAKaW5k ZXggM2RmYzRiYzBmYjQ0YTdlOWE3ZDBlY2IxYmNhYjQ2ODRiYTFlNGY2Yy4uNDg4MDUxNDk1YmYx ZDBiY2ZkN2RlMWQ1ZDE3Y2ZiMzAxMzk3MGJmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVz dE9iai5jcHAKQEAgLTExOTgsNyArMTE5OCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9kb21fdGVz dF9vYmpfc2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgY29uCiAg ICAgc3dpdGNoIChwcm9wX2lkKSB7CiAgICAgY2FzZSBQUk9QX1VOU0lHTkVEX1NIT1JUX0FUVFI6 CiAgICAgewotICAgICAgICBjb3JlU2VsZi0+c2V0VW5zaWduZWRTaG9ydEF0dHIoKGdfdmFsdWVf Z2V0X3VzaG9ydCh2YWx1ZSkpKTsKKyAgICAgICAgY29yZVNlbGYtPnNldFVuc2lnbmVkU2hvcnRB dHRyKChnX3ZhbHVlX2dldF91aW50KHZhbHVlKSkpOwogICAgICAgICBicmVhazsKICAgICB9CiAg ICAgY2FzZSBQUk9QX0lOVF9BVFRSOgpAQCAtMTU4MCw3ICsxNTgwLDcgQEAgR19NQVhJTlQsIC8q IG1heCAqLwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAidGVzdF9vYmpfdW5zaWduZWQtc2hvcnQtYXR0ciIsIC8qIHNob3J0IGRlc2Ny aXB0aW9uICovCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJyZWFkLXdyaXRlICBndXNob3J0IFRlc3RPYmoudW5zaWduZWQtc2hvcnQt YXR0ciIsIC8qIGxvbmdlciAtIGNvdWxkIGRvIHdpdGggc29tZSBleHRyYSBkb2Mgc3R1ZmYgaGVy ZSAqLwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAwLCAvKiBtaW4gKi8KLUdfTUFYVUlOVDE2LCAvKiBtYXggKi8KK0dfTUFYVVNIT1JU LCAvKiBtYXggKi8KIDAsIC8qIGRlZmF1bHQgKi8KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0VCS0lUX1BBUkFNX1JFQURXUklURSkp OwogICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkoZ29iamVjdENsYXNzLAo= 111482 2011-10-18 12:40:24 -0700 2011-10-18 15:17:45 -0700 fix for binding tests bug-70267-20111018124023.patch text/plain 1812 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYzdmNzk4MTU3OTA2N2Y1 NTM3NDJhNWYzNWE5OWYzODJkYmE1MzhmLi45Y2Q2MTgwNTM3NTlhMGM4M2E0ZTg4MTc5MWZjMjM3 ZDgzMmJlMDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTggIEFubmEg Q2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBicm9rZW4gYmlu ZGluZyB0ZXN0cyBieSBjaGFuZ2luZyBHX01BWFVTSE9SVCB0byBHX01BWFVJTlQgaW4gV2ViS2l0 RE9NVGVzdE9iai5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlc3RzOiBmaXhpbmcgV2ViS2l0RE9NVGVzdE9iai5jcHAKKworICAgICAgICAqIGJp bmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouY3BwOgorICAgICAg ICAod2Via2l0X2RvbV90ZXN0X29ial9jbGFzc19pbml0KTogQ2hhbmdlIEdfTUFYVVNIT1JUIHRv IEdfTUFYVUlOVAorCiAyMDExLTEwLTE4ICBTaGF3biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVHJhY2tpbmcgdXBkYXRlIHJlY3RzIGluIExh eWVyQ2hyb21pdW0gYW5kIENDTGF5ZXJJbXBsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2Jq LmNwcAppbmRleCA0ODgwNTE0OTViZjFkMGJjZmQ3ZGUxZDVkMTdjZmIzMDEzOTcwYmY2Li4yMTE3 M2E4MWNlOTExYTY4ZTY3NTUwYzM0OGIzZmI2YmFkYzE4YzliIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJL aXRET01UZXN0T2JqLmNwcApAQCAtMTU4MCw3ICsxNTgwLDcgQEAgR19NQVhJTlQsIC8qIG1heCAq LwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAidGVzdF9vYmpfdW5zaWduZWQtc2hvcnQtYXR0ciIsIC8qIHNob3J0IGRlc2NyaXB0aW9u ICovCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJyZWFkLXdyaXRlICBndXNob3J0IFRlc3RPYmoudW5zaWduZWQtc2hvcnQtYXR0ciIs IC8qIGxvbmdlciAtIGNvdWxkIGRvIHdpdGggc29tZSBleHRyYSBkb2Mgc3R1ZmYgaGVyZSAqLwog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAwLCAvKiBtaW4gKi8KLUdfTUFYVVNIT1JULCAvKiBtYXggKi8KK0dfTUFYVUlOVCwgLyogbWF4 ICovCiAwLCAvKiBkZWZhdWx0ICovCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEV1JJVEUpKTsKICAgICBn X29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KGdvYmplY3RDbGFzcywK