70242 2011-10-17 08:23:12 -0700 Web Inspector: [Chromium] Different dimensions are reported for elements onscreen and in the Metrics pane 2011-11-11 06:34:54 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck johnme keishi loislo pfeldman pmuellr rik simon.fraser timothy vsevik webkit.review.bot yurys oldest_to_newest 485163 0 apavlov 2011-10-17 08:23:12 -0700 1. Search for something on google.com, inspect the results page <body> element 2. Change the page zoom, re-select the <body> element The element highlight tooltip and the Metrics pane display different dimensions for the <body> element. 485175 1 111269 apavlov 2011-10-17 08:32:22 -0700 Created attachment 111269 [PATCH] Suggested fix The patch makes use of the dimensions equal to the element's offsetWidth/offsetHeight in the tooltip. 485177 2 webkit.review.bot 2011-10-17 08:34:20 -0700 Attachment 111269 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485179 3 johnme 2011-10-17 08:39:16 -0700 By the way, having the different dimensions (size in [scaled] CSS pixels vs size in [unscaled] device pixels) available can be useful, especially in environments where scaling is common. Ideally the Metrics pane might have a menu (like the Styles pane) letting you switch between CSS pixels and device pixels (this setting would apply to both the Metrics pane and the element highlight tooltip). 485316 4 vsevik 2011-10-17 11:30:39 -0700 This patch looks good, but while looking into it I found two somewhat related problems: https://bugs.webkit.org/show_bug.cgi?id=70250 https://bugs.webkit.org/show_bug.cgi?id=70252 485894 5 apavlov 2011-10-18 01:03:54 -0700 Committed r97726: <http://trac.webkit.org/changeset/97726> 500734 6 apavlov 2011-11-11 06:34:54 -0800 *** Bug 71974 has been marked as a duplicate of this bug. *** 111269 2011-10-17 08:32:22 -0700 2011-10-19 07:47:44 -0700 [PATCH] Suggested fix elemsize.patch text/plain 3132 apavlov Y29tbWl0IGFiMDU5NzhjMDc1NzQ4Mzc0OTkyOWIwOTVjNjVjNzdmYmVhMzAyMmYKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gT2N0IDE3 IDE5OjI0OjEwIDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQzMzYwYS4uYmFm OTU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTEwLTE3ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog W0Nocm9taXVtXSBEaWZmZXJlbnQgZGltZW5zaW9ucyBhcmUgcmVwb3J0ZWQgZm9yIGVsZW1lbnRz IG9uc2NyZWVuIGFuZCBpbiB0aGUgTWV0cmljcyBwYW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDI0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5j cHA6CisKIDIwMTEtMTAtMTIgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZml4IGhhbmRsaW5nIG9mIHNvdXJjZSBtYXBw aW5nIGVudHJpZXMgd2l0aCBubyBtYXBwaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvRE9NTm9kZUhpZ2hsaWdodGVyLmNwcAppbmRleCA1ZjI4NjIyLi5mMjZjOGEwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hsaWdodGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hsaWdodGVyLmNwcApAQCAtNDEs NyArNDEsOSBAQAogI2luY2x1ZGUgIk5vZGUuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVk ZSAiUmFuZ2UuaCIKKyNpbmNsdWRlICJSZW5kZXJCb3hNb2RlbE9iamVjdC5oIgogI2luY2x1ZGUg IlJlbmRlcklubGluZS5oIgorI2luY2x1ZGUgIlJlbmRlck9iamVjdC5oIgogI2luY2x1ZGUgIlNl dHRpbmdzLmgiCiAjaW5jbHVkZSAiU3R5bGVkRWxlbWVudC5oIgogI2luY2x1ZGUgIlRleHRSdW4u aCIKQEAgLTIxOCw3ICsyMjAsNyBAQCBUT09MVElQX0ZPTlRfRkFNSUxJRVMoMSwgbmV3IEF0b21p Y1N0cmluZygiZGVqYXZ1IHNhbnMgbW9ubyIpKQogICAgIH0KIH0KIAotdm9pZCBkcmF3RWxlbWVu dFRpdGxlKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgTm9kZSogbm9kZSwgY29uc3QgTGF5b3V0 UmVjdCYgYm91bmRpbmdCb3gsIGNvbnN0IExheW91dFJlY3QmIGFuY2hvckJveCwgY29uc3QgRmxv YXRSZWN0JiBvdmVybGF5UmVjdCwgV2ViQ29yZTo6U2V0dGluZ3MqIHNldHRpbmdzKQordm9pZCBk cmF3RWxlbWVudFRpdGxlKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgTm9kZSogbm9kZSwgUmVu ZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgTGF5b3V0UmVjdCYgYm91bmRpbmdCb3gsIGNvbnN0 IExheW91dFJlY3QmIGFuY2hvckJveCwgY29uc3QgRmxvYXRSZWN0JiBvdmVybGF5UmVjdCwgV2Vi Q29yZTo6U2V0dGluZ3MqIHNldHRpbmdzKQogewogCiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChD b2xvciwgYmFja2dyb3VuZENvbG9yLCAoMjU1LCAyNTUsIDE5NCkpOwpAQCAtMjYzLDEwICsyNjUs MTIgQEAgdm9pZCBkcmF3RWxlbWVudFRpdGxlKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgTm9k ZSogbm9kZSwgY29uc3QgTGF5b3V0UmVjdCYgYm8KICAgICAgICAgfQogICAgIH0KIAotICAgIFN0 cmluZyB3aWR0aE51bWJlclBhcnQgPSAiICIgKyBTdHJpbmc6Om51bWJlcihib3VuZGluZ0JveC53 aWR0aCgpKTsKKyAgICBSZW5kZXJCb3hNb2RlbE9iamVjdCogbW9kZWxPYmplY3QgPSByZW5kZXJl ci0+aXNCb3hNb2RlbE9iamVjdCgpID8gdG9SZW5kZXJCb3hNb2RlbE9iamVjdChyZW5kZXJlcikg OiAwOworCisgICAgU3RyaW5nIHdpZHRoTnVtYmVyUGFydCA9ICIgIiArIFN0cmluZzo6bnVtYmVy KG1vZGVsT2JqZWN0ID8gYWRqdXN0Rm9yQWJzb2x1dGVab29tKG1vZGVsT2JqZWN0LT5vZmZzZXRX aWR0aCgpLCBtb2RlbE9iamVjdCkgOiBib3VuZGluZ0JveC53aWR0aCgpKTsKICAgICBub2RlVGl0 bGUgKz0gd2lkdGhOdW1iZXJQYXJ0ICsgcHhTdHJpbmc7CiAgICAgbm9kZVRpdGxlICs9IHRpbWVz U3RyaW5nOwotICAgIFN0cmluZyBoZWlnaHROdW1iZXJQYXJ0ID0gU3RyaW5nOjpudW1iZXIoYm91 bmRpbmdCb3guaGVpZ2h0KCkpOworICAgIFN0cmluZyBoZWlnaHROdW1iZXJQYXJ0ID0gU3RyaW5n OjpudW1iZXIobW9kZWxPYmplY3QgPyBhZGp1c3RGb3JBYnNvbHV0ZVpvb20obW9kZWxPYmplY3Qt Pm9mZnNldEhlaWdodCgpLCBtb2RlbE9iamVjdCkgOiBib3VuZGluZ0JveC5oZWlnaHQoKSk7CiAg ICAgbm9kZVRpdGxlICs9IGhlaWdodE51bWJlclBhcnQgKyBweFN0cmluZzsKIAogICAgIEZvbnRE ZXNjcmlwdGlvbiBkZXNjOwpAQCAtNDQyLDcgKzQ0Niw3IEBAIHZvaWQgZHJhd05vZGVIaWdobGln aHQoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBIaWdobGlnaHREYXRhKiBoaWdobGlnaHREYXRh KQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAoaGlnaGxpZ2h0RGF0YS0+c2hvd0luZm8pCi0g ICAgICAgIGRyYXdFbGVtZW50VGl0bGUoY29udGV4dCwgbm9kZSwgYm91bmRpbmdCb3gsIHRpdGxl QW5jaG9yQm94LCBvdmVybGF5UmVjdCwgY29udGFpbmluZ0ZyYW1lLT5zZXR0aW5ncygpKTsKKyAg ICAgICAgZHJhd0VsZW1lbnRUaXRsZShjb250ZXh0LCBub2RlLCByZW5kZXJlciwgYm91bmRpbmdC b3gsIHRpdGxlQW5jaG9yQm94LCBvdmVybGF5UmVjdCwgY29udGFpbmluZ0ZyYW1lLT5zZXR0aW5n cygpKTsKIH0KIAogdm9pZCBkcmF3UmVjdEhpZ2hsaWdodChHcmFwaGljc0NvbnRleHQmIGNvbnRl eHQsIERvY3VtZW50KiBkb2N1bWVudCwgSGlnaGxpZ2h0RGF0YSogaGlnaGxpZ2h0RGF0YSkK