70240 2011-10-17 08:07:23 -0700 Move CSSRule specific virtuals from StyleBase down into CSSRule. 2011-10-18 05:45:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling dglazkov gustavo.noronha gustavo koivisto webkit.review.bot xan.lopez oldest_to_newest 485150 0 kling 2011-10-17 08:07:23 -0700 The isFooRule() virtuals and insertedIntoParent() can be moved down to CSSRule now. 485152 1 111266 kling 2011-10-17 08:11:34 -0700 Created attachment 111266 Proposed patch 485154 2 webkit.review.bot 2011-10-17 08:13:28 -0700 Attachment 111266 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485173 3 111266 gyuyoung.kim 2011-10-17 08:31:01 -0700 Comment on attachment 111266 Proposed patch Attachment 111266 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10086090 485180 4 kling 2011-10-17 08:40:59 -0700 (In reply to comment #3) > (From update of attachment 111266 [details]) > Attachment 111266 [details] did not pass efl-ews (efl): > Output: http://queues.webkit.org/results/10086090 D'oh. XSLImportRule still uses isImportRule(). 485410 5 111266 gustavo.noronha 2011-10-17 12:51:58 -0700 Comment on attachment 111266 Proposed patch Attachment 111266 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10086597 485607 6 111266 webkit.review.bot 2011-10-17 16:21:13 -0700 Comment on attachment 111266 Proposed patch Attachment 111266 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10120018 485981 7 kling 2011-10-18 05:45:10 -0700 Committed r97742: <http://trac.webkit.org/changeset/97742> 111266 2011-10-17 08:11:34 -0700 2011-10-17 16:21:13 -0700 Proposed patch bug-70240.diff text/plain 4266 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MzhmMzMxLi5mOThjMjhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzMg QEAKIDIwMTEtMTAtMTcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIE1vdmUgQ1NTUnVsZSBzcGVjaWZpYyB2aXJ0dWFscyBmcm9tIFN0eWxlQmFzZSBkb3duIGlu dG8gQ1NTUnVsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcwMjQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTW92ZSBhbGwgdGhlIGlzRm9vUnVsZSgpIHZpcnR1YWxzIHRvIENTU1J1bGUgc2luY2UgdGhl eSBvbmx5IG1ha2Ugc2Vuc2UgZm9yIGl0cworICAgICAgICBzdWJjbGFzc2VzLiBpc1J1bGUoKSBy ZW1haW5zIGluIFN0eWxlQmFzZSBzaW5jZSB3ZSBzdGlsbCBuZWVkIGl0IGZvciB0aGUgcGFyZW50 CisgICAgICAgIGNoYWluIHRyYXZlcnNhbC4KKworICAgICAgICBBbHNvIG1vdmVkIGluc2VydGVk SW50b1BhcmVudCgpIGFuZCByZW1vdmVkIGl0cyB1c2FnZSBpbiBYU0xTdHlsZVNoZWV0IHNpbmNl IGl0CisgICAgICAgIGlzIG9ubHkgcmVpbXBsZW1lbnRlZCBieSBDU1NJbXBvcnRSdWxlLgorCisg ICAgICAgICogY3NzL1N0eWxlQmFzZS5oOgorICAgICAgICAqIGNzcy9DU1NSdWxlLmg6CisgICAg ICAgIChXZWJDb3JlOjpDU1NSdWxlOjppc0NoYXJzZXRSdWxlKToKKyAgICAgICAgKFdlYkNvcmU6 OkNTU1J1bGU6OmlzRm9udEZhY2VSdWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1J1bGU6Omlz SW1wb3J0UnVsZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlOjppc0tleWZyYW1lUnVsZSk6 CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlOjppc0tleWZyYW1lc1J1bGUpOgorICAgICAgICAo V2ViQ29yZTo6Q1NTUnVsZTo6aXNNZWRpYVJ1bGUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVs ZTo6aXNQYWdlUnVsZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlOjppc1N0eWxlUnVsZSk6 CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlOjppbnNlcnRlZEludG9QYXJlbnQpOgorICAgICAg ICAqIHhtbC9YU0xTdHlsZVNoZWV0Lmg6CisgICAgICAgIChXZWJDb3JlOjpYU0xTdHlsZVNoZWV0 OjphcHBlbmQpOgorCisyMDExLTEwLTE3ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9y Zz4KKwogICAgICAgICBNZWRpYUxpc3Q6IFJlbW92ZSBpbmhlcml0YW5jZSBmcm9tIFN0eWxlQmFz ZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMjAz CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmggYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUnVsZS5oCmluZGV4IDY0YWEyZTQuLjJjZTc2NWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1J1 bGUuaApAQCAtNTEsNiArNTEsMTcgQEAgcHVibGljOgogICAgIENTU1N0eWxlU2hlZXQqIHBhcmVu dFN0eWxlU2hlZXQoKSBjb25zdDsKICAgICBDU1NSdWxlKiBwYXJlbnRSdWxlKCkgY29uc3Q7CiAK KyAgICB2aXJ0dWFsIGJvb2wgaXNDaGFyc2V0UnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CisgICAgdmlydHVhbCBib29sIGlzRm9udEZhY2VSdWxlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7 IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNJbXBvcnRSdWxlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7 IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNLZXlmcmFtZVJ1bGUoKSBjb25zdCB7IHJldHVybiBmYWxz ZTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc0tleWZyYW1lc1J1bGUoKSBjb25zdCB7IHJldHVybiBm YWxzZTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc01lZGlhUnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CisgICAgdmlydHVhbCBib29sIGlzUGFnZVJ1bGUoKSBjb25zdCB7IHJldHVybiBmYWxz ZTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc1N0eWxlUnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNl OyB9CisKKyAgICB2aXJ0dWFsIHZvaWQgaW5zZXJ0ZWRJbnRvUGFyZW50KCkgeyB9CisKICAgICB2 aXJ0dWFsIFN0cmluZyBjc3NUZXh0KCkgY29uc3QgPSAwOwogICAgIHZvaWQgc2V0Q3NzVGV4dChj b25zdCBTdHJpbmcmLCBFeGNlcHRpb25Db2RlJik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZUJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJhc2UuaAppbmRl eCBhOGU0NGEyLi5iMWViYzljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVC YXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlQmFzZS5oCkBAIC00NywxOSArNDcs MTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyByZXR1cm5zIHRoZSB1cmwgb2Yg dGhlIHN0eWxlIHNoZWV0IHRoaXMgb2JqZWN0IGJlbG9uZ3MgdG8KICAgICAgICAgS1VSTCBiYXNl VVJMKCkgY29uc3Q7CiAKLSAgICAgICAgdmlydHVhbCBib29sIGlzQ1NTU3R5bGVTaGVldCgpIGNv bnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0KLSAgICAgICAgdmlydHVhbCBib29sIGlzQ2hhcnNldFJ1 bGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQotICAgICAgICB2aXJ0dWFsIGJvb2wgaXNGb250 RmFjZVJ1bGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQotICAgICAgICB2aXJ0dWFsIGJvb2wg aXNJbXBvcnRSdWxlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KLSAgICAgICAgdmlydHVhbCBi b29sIGlzS2V5ZnJhbWVSdWxlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KLSAgICAgICAgdmly dHVhbCBib29sIGlzS2V5ZnJhbWVzUnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAg ICAgIHZpcnR1YWwgYm9vbCBpc01lZGlhUnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0g ICAgICAgIHZpcnR1YWwgYm9vbCBpc1BhZ2VSdWxlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0K ICAgICAgICAgdmlydHVhbCBib29sIGlzUnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0g ICAgICAgIHZpcnR1YWwgYm9vbCBpc1N0eWxlUnVsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CiAKICAgICAgICAgdmlydHVhbCBib29sIGlzU3R5bGVTaGVldCgpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CisgICAgICAgIHZpcnR1YWwgYm9vbCBpc0NTU1N0eWxlU2hlZXQoKSBjb25zdCB7IHJl dHVybiBmYWxzZTsgfQogICAgICAgICB2aXJ0dWFsIGJvb2wgaXNYU0xTdHlsZVNoZWV0KCkgY29u c3QgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgICAgICB2aXJ0dWFsIGJvb2wgaXNNdXRhYmxlU3R5 bGVEZWNsYXJhdGlvbigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CkBAIC03MCw4ICs2MSw2IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBib29sIHVzZVN0cmljdFBhcnNpbmcoKSBj b25zdCB7IHJldHVybiAhbV9wYXJlbnQgfHwgbV9wYXJlbnQtPnVzZVN0cmljdFBhcnNpbmcoKTsg fQogCi0gICAgICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRlZEludG9QYXJlbnQoKSB7IH0KLQogICAg ICAgICBTdHlsZVNoZWV0KiBzdHlsZXNoZWV0KCk7CiAgICAgICAgIE5vZGUqIG5vZGUoKTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hTTFN0eWxlU2hlZXQuaCBiL1NvdXJjZS9X ZWJDb3JlL3htbC9YU0xTdHlsZVNoZWV0LmgKaW5kZXggNDc2MDcyMi4uMmNmNGIwNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hTTFN0eWxlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS94bWwvWFNMU3R5bGVTaGVldC5oCkBAIC0xMDIsOSArMTAyLDcgQEAgcHVibGljOgogcHJp dmF0ZToKICAgICB2b2lkIGFwcGVuZChQYXNzUmVmUHRyPFN0eWxlQmFzZT4gY2hpbGQpCiAgICAg ewotICAgICAgICBTdHlsZUJhc2UqIGMgPSBjaGlsZC5nZXQoKTsKICAgICAgICAgbV9jaGlsZHJl bi5hcHBlbmQoY2hpbGQpOwotICAgICAgICBjLT5pbnNlcnRlZEludG9QYXJlbnQoKTsKICAgICB9 CiAKICAgICBYU0xTdHlsZVNoZWV0KE5vZGUqIHBhcmVudE5vZGUsIGNvbnN0IFN0cmluZyYgb3Jp Z2luYWxVUkwsIGNvbnN0IEtVUkwmIGZpbmFsVVJMLCBib29sIGVtYmVkZGVkKTsK