70232 2011-10-17 07:08:19 -0700 [Chromium] Add a missing semi-colon in ExternalPopupMenu.cpp 2011-10-17 18:33:21 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peter peter eric fishd webkit.review.bot oldest_to_newest 485116 0 peter 2011-10-17 07:08:19 -0700 Missing semi-colon. Patch upcoming. 485118 1 111259 peter 2011-10-17 07:09:31 -0700 Created attachment 111259 Patch 485121 2 webkit.review.bot 2011-10-17 07:11:28 -0700 Attachment 111259 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Last 3072 characters of output: LayoutTests/platform/chromium-win/fast/events/reveal-link-when-focused-expected.txt M LayoutTests/platform/chromium-win/fast/dom/34176-expected.txt M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.png M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.txt M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.png M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug8950-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug51140-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug51140-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug26553-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug46623-1-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug8950-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt M LayoutTests/ChangeLog W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/fast/selectors/017-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/fast/selectors/061-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug46623-1-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug51140-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug8950-expected.png r97619 = ec92ce482c58a93dc36cff53dd99607e5a1796a1 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485714 3 111259 webkit.review.bot 2011-10-17 18:33:16 -0700 Comment on attachment 111259 Patch Clearing flags on attachment: 111259 Committed r97694: <http://trac.webkit.org/changeset/97694> 485715 4 webkit.review.bot 2011-10-17 18:33:21 -0700 All reviewed patches have been landed. Closing bug. 111259 2011-10-17 07:09:31 -0700 2011-10-17 18:33:16 -0700 Patch external-popup.patch text/plain 1240 peter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNTBlMjVlMy4uM2IxZDFhNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMC0xNyAgUGV0ZXIgQmV2 ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBBZGQgYSBt aXNzaW5nIHNlbWktY29sb24gaW4gRXh0ZXJuYWxQb3B1cE1lbnUuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDIzMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL0V4dGVybmFsUG9wdXBNZW51 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6RXh0ZXJuYWxQb3B1cE1lbnU6OmRpZEFjY2VwdEluZGlj ZXMpOgorCiAyMDExLTEwLTE3ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtDaHJvbWl1bV0gV2ViIEluc3BlY3RvcjogZG9uJ3QgY2hlY2sgZm9yIGRl YnVnZ2VyIHBhdXNlIGRldGFpbHMgaW4gaW50ZXJhY3RpdmUgdWkgdGVzdHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcAppbmRleCAyMGFlN2Ni Li45YjgwN2M1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FeHRlcm5h bFBvcHVwTWVudS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRXh0ZXJuYWxQ b3B1cE1lbnUuY3BwCkBAIC0xMjAsNyArMTIwLDcgQEAgdm9pZCBFeHRlcm5hbFBvcHVwTWVudTo6 ZGlkQWNjZXB0SW5kaWNlcyhjb25zdCBXZWJWZWN0b3I8aW50PiYgaW5kaWNlcykKICNpZiBFTkFC TEUoTk9fTElTVEJPWF9SRU5ERVJJTkcpCiAgICAgaWYgKCFtX3BvcHVwTWVudUNsaWVudCkgewog ICAgICAgICBtX3dlYkV4dGVybmFsUG9wdXBNZW51ID0gMDsKLSAgICAgICAgcmV0dXJuCisgICAg ICAgIHJldHVybjsKICAgICB9CiAKICAgICAvLyBDYWxsaW5nIG1ldGhvZHMgb24gdGhlIFBvcHVw TWVudUNsaWVudCBtaWdodCBsZWFkIHRvIHRoaXMgb2JqZWN0IGJlaW5nCg==