70226 2011-10-17 03:43:36 -0700 CSS/XSLStyleSheet: Remove insert() and remove(). 2011-10-17 04:38:06 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling oldest_to_newest 485035 0 kling 2011-10-17 03:43:36 -0700 These methods are internal to WebKit and not part of the CSSOM. 485036 1 111240 kling 2011-10-17 03:44:47 -0700 Created attachment 111240 Proposed patch 485037 2 111240 kenneth 2011-10-17 03:47:09 -0700 Comment on attachment 111240 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=111240&action=review > Source/WebCore/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + shouldn't you add some reasoning for the change? 485041 3 111240 koivisto 2011-10-17 03:54:53 -0700 Comment on attachment 111240 Proposed patch r=me, with changes discussed in irc: Keep remove() so you don't need to use the external api functions for internal stuff. 485053 4 kling 2011-10-17 04:38:06 -0700 Committed r97605: <http://trac.webkit.org/changeset/97605> 111240 2011-10-17 03:44:47 -0700 2011-10-17 03:54:53 -0700 Proposed patch bug-70226.diff text/plain 5155 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNGE5NDhkLi41NWQ4OTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMTAtMTcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIENTUy9YU0xTdHlsZVNoZWV0OiBSZW1vdmUgaW5zZXJ0KCkgYW5kIHJlbW92ZSgpLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAyMjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9DU1NTdHls ZVNoZWV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2hlZXQ6Omluc2VydFJ1bGUp OgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTaGVldDo6ZGVsZXRlUnVsZSk6CisgICAgICAg ICogY3NzL0NTU1N0eWxlU2hlZXQuaDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3R5 bGVTaGVldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZVNoZWV0OjpyZXBh cnNlU3R5bGVTaGVldCk6CisgICAgICAgICogc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTVkdGb250RmFjZUVsZW1lbnQ6OnJlbW92ZUZyb21NYXBwZWRFbGVt ZW50U2hlZXQpOgorICAgICAgICAqIHhtbC9YU0xTdHlsZVNoZWV0Lmg6CisKIDIwMTEtMTAtMTYg IEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIE1lZGlhTGlzdDog UmVtb3ZlIGluaGVyaXRhbmNlIGZyb20gU3R5bGVCYXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxl U2hlZXQuY3BwCmluZGV4IDMzNTQ3MzAuLjMwMTZjMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5 bGVTaGVldC5jcHAKQEAgLTEwMSwyMyArMTAxLDYgQEAgdm9pZCBDU1NTdHlsZVNoZWV0OjphcHBl bmQoUGFzc1JlZlB0cjxDU1NSdWxlPiBjaGlsZCkKICAgICBjLT5pbnNlcnRlZEludG9QYXJlbnQo KTsKIH0KIAotdm9pZCBDU1NTdHlsZVNoZWV0OjppbnNlcnQodW5zaWduZWQgaW5kZXgsIFBhc3NS ZWZQdHI8Q1NTUnVsZT4gY2hpbGQpCi17Ci0gICAgQ1NTUnVsZSogYyA9IGNoaWxkLmdldCgpOwot ICAgIGlmIChpbmRleCA+PSBsZW5ndGgoKSkKLSAgICAgICAgbV9jaGlsZHJlbi5hcHBlbmQoY2hp bGQpOwotICAgIGVsc2UKLSAgICAgICAgbV9jaGlsZHJlbi5pbnNlcnQoaW5kZXgsIGNoaWxkKTsK LSAgICBjLT5pbnNlcnRlZEludG9QYXJlbnQoKTsKLX0KLQotdm9pZCBDU1NTdHlsZVNoZWV0Ojpy ZW1vdmUodW5zaWduZWQgaW5kZXgpCi17Ci0gICAgaWYgKGluZGV4ID49IGxlbmd0aCgpKQotICAg ICAgICByZXR1cm47Ci0gICAgbV9jaGlsZHJlbi5yZW1vdmUoaW5kZXgpOwotfQotCiBDU1NSdWxl ICpDU1NTdHlsZVNoZWV0Ojpvd25lclJ1bGUoKSBjb25zdAogewogICAgIHJldHVybiAocGFyZW50 KCkgJiYgcGFyZW50KCktPmlzUnVsZSgpKSA/IHN0YXRpY19jYXN0PENTU1J1bGUqPihwYXJlbnQo KSkgOiAwOwpAQCAtMTU2LDcgKzEzOSw5IEBAIHVuc2lnbmVkIENTU1N0eWxlU2hlZXQ6Omluc2Vy dFJ1bGUoY29uc3QgU3RyaW5nJiBydWxlLCB1bnNpZ25lZCBpbmRleCwgRXhjZXB0aW9uCiAgICAg ICAgIH0KICAgICB9CiAKLSAgICBpbnNlcnQoaW5kZXgsIHIucmVsZWFzZSgpKTsKKyAgICBDU1NS dWxlKiBjID0gci5nZXQoKTsKKyAgICBtX2NoaWxkcmVuLmluc2VydChpbmRleCwgci5yZWxlYXNl KCkpOworICAgIGMtPmluc2VydGVkSW50b1BhcmVudCgpOwogICAgIAogICAgIHN0eWxlU2hlZXRD aGFuZ2VkKCk7CiAgICAgCkBAIC0xOTMsNyArMTc4LDcgQEAgdm9pZCBDU1NTdHlsZVNoZWV0Ojpk ZWxldGVSdWxlKHVuc2lnbmVkIGluZGV4LCBFeGNlcHRpb25Db2RlJiBlYykKIAogICAgIGVjID0g MDsKICAgICBpdGVtKGluZGV4KS0+c2V0UGFyZW50KDApOwotICAgIHJlbW92ZShpbmRleCk7Cisg ICAgbV9jaGlsZHJlbi5yZW1vdmUoaW5kZXgpOwogICAgIHN0eWxlU2hlZXRDaGFuZ2VkKCk7CiB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVldC5oCmluZGV4IDZkY2IzNDIuLjVkMDY5NTQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmgKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuaApAQCAtMTA2LDggKzEwNiw2IEBAIHB1YmxpYzoK ICAgICBib29sIGhhc1N5bnRhY3RpY2FsbHlWYWxpZENTU0hlYWRlcigpIGNvbnN0IHsgcmV0dXJu IG1faGFzU3ludGFjdGljYWxseVZhbGlkQ1NTSGVhZGVyOyB9CiAKICAgICB2b2lkIGFwcGVuZChQ YXNzUmVmUHRyPENTU1J1bGU+KTsKLSAgICB2b2lkIGluc2VydCh1bnNpZ25lZCBpbmRleCwgUGFz c1JlZlB0cjxDU1NSdWxlPik7Ci0gICAgdm9pZCByZW1vdmUodW5zaWduZWQgaW5kZXgpOwogCiAg ICAgdW5zaWduZWQgbGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gbV9jaGlsZHJlbi5zaXplKCk7IH0K ICAgICBDU1NSdWxlKiBpdGVtKHVuc2lnbmVkIGluZGV4KSB7IHJldHVybiBpbmRleCA8IGxlbmd0 aCgpID8gbV9jaGlsZHJlbi5hdChpbmRleCkuZ2V0KCkgOiAwOyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKaW5kZXggYTBjZDU3NS4uZWQ4 ZTBlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxl U2hlZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNo ZWV0LmNwcApAQCAtNTc1LDggKzU3NSwxMCBAQCBTdHJpbmcgSW5zcGVjdG9yU3R5bGVTaGVldDo6 ZmluYWxVUkwoKSBjb25zdAogCiB2b2lkIEluc3BlY3RvclN0eWxlU2hlZXQ6OnJlcGFyc2VTdHls ZVNoZWV0KGNvbnN0IFN0cmluZyYgdGV4dCkKIHsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwLCBz aXplID0gbV9wYWdlU3R5bGVTaGVldC0+bGVuZ3RoKCk7IGkgPCBzaXplOyArK2kpCi0gICAgICAg IG1fcGFnZVN0eWxlU2hlZXQtPnJlbW92ZSgwKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwLCBz aXplID0gbV9wYWdlU3R5bGVTaGVldC0+bGVuZ3RoKCk7IGkgPCBzaXplOyArK2kpIHsKKyAgICAg ICAgRXhjZXB0aW9uQ29kZSBlYzsKKyAgICAgICAgbV9wYWdlU3R5bGVTaGVldC0+ZGVsZXRlUnVs ZSgwLCBlYyk7CisgICAgfQogICAgIG1fcGFnZVN0eWxlU2hlZXQtPnBhcnNlU3RyaW5nKHRleHQs IG1fcGFnZVN0eWxlU2hlZXQtPnVzZVN0cmljdFBhcnNpbmcoKSk7CiAgICAgbV9wYWdlU3R5bGVT aGVldC0+c3R5bGVTaGVldENoYW5nZWQoKTsKICAgICBtX2luc3BlY3RvclN0eWxlcy5jbGVhcigp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmNwcAppbmRleCA3NzBhNjg2 Li5lOTc4MDdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmNwcApA QCAtMzQ1LDcgKzM0NSw4IEBAIHZvaWQgU1ZHRm9udEZhY2VFbGVtZW50OjpyZW1vdmVGcm9tTWFw cGVkRWxlbWVudFNoZWV0KCkKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtYXBwZWRF bGVtZW50U2hlZXQtPmxlbmd0aCgpOyArK2kpIHsKICAgICAgICAgaWYgKG1hcHBlZEVsZW1lbnRT aGVldC0+aXRlbShpKSA9PSBtX2ZvbnRGYWNlUnVsZSkgewotICAgICAgICAgICAgbWFwcGVkRWxl bWVudFNoZWV0LT5yZW1vdmUoaSk7CisgICAgICAgICAgICBFeGNlcHRpb25Db2RlIGVjOworICAg ICAgICAgICAgbWFwcGVkRWxlbWVudFNoZWV0LT5kZWxldGVSdWxlKGksIGVjKTsKICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv eG1sL1hTTFN0eWxlU2hlZXQuaCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YU0xTdHlsZVNoZWV0LmgK aW5kZXggZTUwZDI4Zi4uNDc2MDcyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hT TFN0eWxlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMU3R5bGVTaGVldC5oCkBA IC0xMDcsMjMgKzEwNyw2IEBAIHByaXZhdGU6CiAgICAgICAgIGMtPmluc2VydGVkSW50b1BhcmVu dCgpOwogICAgIH0KIAotICAgIHZvaWQgaW5zZXJ0KHVuc2lnbmVkIGluZGV4LCBQYXNzUmVmUHRy PFN0eWxlQmFzZT4gY2hpbGQpCi0gICAgewotICAgICAgICBTdHlsZUJhc2UqIGMgPSBjaGlsZC5n ZXQoKTsKLSAgICAgICAgaWYgKGluZGV4ID49IGxlbmd0aCgpKQotICAgICAgICAgICAgbV9jaGls ZHJlbi5hcHBlbmQoY2hpbGQpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBtX2NoaWxkcmVu Lmluc2VydChpbmRleCwgY2hpbGQpOwotICAgICAgICBjLT5pbnNlcnRlZEludG9QYXJlbnQoKTsK LSAgICB9Ci0KLSAgICB2b2lkIHJlbW92ZSh1bnNpZ25lZCBpbmRleCkKLSAgICB7Ci0gICAgICAg IGlmIChpbmRleCA+PSBsZW5ndGgoKSkKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgbV9j aGlsZHJlbi5yZW1vdmUoaW5kZXgpOwotICAgIH0KLQogICAgIFhTTFN0eWxlU2hlZXQoTm9kZSog cGFyZW50Tm9kZSwgY29uc3QgU3RyaW5nJiBvcmlnaW5hbFVSTCwgY29uc3QgS1VSTCYgZmluYWxV UkwsIGJvb2wgZW1iZWRkZWQpOwogI2lmICFVU0UoUVhNTFFVRVJZKQogICAgIFhTTFN0eWxlU2hl ZXQoWFNMSW1wb3J0UnVsZSogcGFyZW50SW1wb3J0LCBjb25zdCBTdHJpbmcmIG9yaWdpbmFsVVJM LCBjb25zdCBLVVJMJiBmaW5hbFVSTCk7Cg==