70218 2011-10-16 23:51:25 -0700 [Soup] ApplicationCache download fails when response is cached by network layer 2011-10-20 00:13:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 donggwan.kim webkit-unassigned ap oldest_to_newest 484958 0 donggwan.kim 2011-10-16 23:51:25 -0700 Repro Step 1. Build WebKit with libsoup in which SOUP_CACHE is enabled. 2. connect to http://html5demos.com/offlineapp 3. If 304(Not modified) response is received when Application Cache request for html5demos.css or h5utils-offline.js, then downloads failed Cause For current implementation of ApplicationCacheGroup, if 304 response is received for resource that is not cached by ApplicationCacheGroup, then downloads failed. If ApplicationCacheGroup requests resource when it downloads complete by SubResourceLoader and is cached by libsoup, then could get 304 response. In case of this, downloads failed. 484961 1 111219 donggwan.kim 2011-10-16 23:54:52 -0700 Created attachment 111219 first patch for this bug 485326 2 111219 ap 2011-10-17 11:46:50 -0700 Comment on attachment 111219 first patch for this bug Some comments: 1. Fixes should have regression tests. 2. WebCore assumes that network layer doesn't pass 304 if it has the data. Soup should just transform the response as if it was not cached. 3. The proposed code doesn't work correctly anyway, as the response cached by Soup won't be saved in application cache. 487370 3 donggwan.kim 2011-10-20 00:13:38 -0700 Fixed by libsoup 111219 2011-10-16 23:54:52 -0700 2011-10-17 11:46:49 -0700 first patch for this bug patch text/plain 2725 donggwan.kim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NTg5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTYgIERvbmdnd2Fu IEtpbSAgPGRvbmdnd2FuLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggRG93bmxvYWQg cHJvYmxlbSBvZiBBcHBsaWNhdGlvbkNhY2hlIHdpdGggMzA0KE5vdCBNb2RpZmllZCkgcmVzcG9u c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMjE4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBsb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25D YWNoZUdyb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxpY2F0aW9uQ2FjaGVHcm91cDo6 ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKwogMjAxMS0xMC0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIEFsd2F5cyBkaXNhYmxlIEVOQUJMRShPTl9GSVJTVF9URVhU QVJFQV9GT0NVU19TRUxFQ1RfQUxMKSBhbmQgZGVsZXRlIGFzc29jaWF0ZWQgY29kZQpJbmRleDog U291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9u Q2FjaGVHcm91cC5jcHAJKHJldmlzaW9uIDk3NTgyKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVy L2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUx OCwxOCArNTE4LDE4IEBAIHZvaWQgQXBwbGljYXRpb25DYWNoZUdyb3VwOjpkaWRSZWNlaXZlUmUK ICAgICBpZiAoIW1fbmV3ZXN0Q2FjaGUpCiAgICAgICAgIEFTU0VSVCghKHR5cGUgJiBBcHBsaWNh dGlvbkNhY2hlUmVzb3VyY2U6Ok1hc3RlcikpOwogCi0gICAgaWYgKG1fbmV3ZXN0Q2FjaGUgJiYg cmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSA9PSAzMDQpIHsgLy8gTm90IG1vZGlmaWVkLgotICAg ICAgICBBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2UqIG5ld2VzdENhY2hlZFJlc291cmNlID0gbV9u ZXdlc3RDYWNoZS0+cmVzb3VyY2VGb3JVUkwodXJsKTsKLSAgICAgICAgaWYgKG5ld2VzdENhY2hl ZFJlc291cmNlKSB7Ci0gICAgICAgICAgICBtX2NhY2hlQmVpbmdVcGRhdGVkLT5hZGRSZXNvdXJj ZShBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2U6OmNyZWF0ZSh1cmwsIG5ld2VzdENhY2hlZFJlc291 cmNlLT5yZXNwb25zZSgpLCB0eXBlLCBuZXdlc3RDYWNoZWRSZXNvdXJjZS0+ZGF0YSgpLCBuZXdl c3RDYWNoZWRSZXNvdXJjZS0+cGF0aCgpKSk7Ci0gICAgICAgICAgICBtX3BlbmRpbmdFbnRyaWVz LnJlbW92ZShtX2N1cnJlbnRIYW5kbGUtPmZpcnN0UmVxdWVzdCgpLnVybCgpKTsKLSAgICAgICAg ICAgIG1fY3VycmVudEhhbmRsZS0+Y2FuY2VsKCk7Ci0gICAgICAgICAgICBtX2N1cnJlbnRIYW5k bGUgPSAwOwotICAgICAgICAgICAgLy8gTG9hZCB0aGUgbmV4dCByZXNvdXJjZSwgaWYgYW55Lgot ICAgICAgICAgICAgc3RhcnRMb2FkaW5nRW50cnkoKTsKLSAgICAgICAgICAgIHJldHVybjsKKyAg ICBpZiAocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSA9PSAzMDQpIHsgLy8gTm90IG1vZGlmaWVk LgorICAgICAgICBpZiAobV9uZXdlc3RDYWNoZSkgeworICAgICAgICAgICAgQXBwbGljYXRpb25D YWNoZVJlc291cmNlKiBuZXdlc3RDYWNoZWRSZXNvdXJjZSA9IG1fbmV3ZXN0Q2FjaGUtPnJlc291 cmNlRm9yVVJMKHVybCk7CisgICAgICAgICAgICBpZiAobmV3ZXN0Q2FjaGVkUmVzb3VyY2UpCisg ICAgICAgICAgICAgICAgbV9jYWNoZUJlaW5nVXBkYXRlZC0+YWRkUmVzb3VyY2UoQXBwbGljYXRp b25DYWNoZVJlc291cmNlOjpjcmVhdGUodXJsLCBuZXdlc3RDYWNoZWRSZXNvdXJjZS0+cmVzcG9u c2UoKSwgdHlwZSwgbmV3ZXN0Q2FjaGVkUmVzb3VyY2UtPmRhdGEoKSwgbmV3ZXN0Q2FjaGVkUmVz b3VyY2UtPnBhdGgoKSkpOwogICAgICAgICB9Ci0gICAgICAgIC8vIFRoZSBzZXJ2ZXIgY291bGQg cmV0dXJuIDMwNCBmb3IgYW4gdW5jb25kaXRpb25hbCByZXF1ZXN0IC0gaW4gdGhpcyBjYXNlLCB3 ZSBoYW5kbGUgdGhlIHJlc3BvbnNlIGFzIGEgbm9ybWFsIGVycm9yLgorICAgICAgICBtX3BlbmRp bmdFbnRyaWVzLnJlbW92ZShtX2N1cnJlbnRIYW5kbGUtPmZpcnN0UmVxdWVzdCgpLnVybCgpKTsK KyAgICAgICAgbV9jdXJyZW50SGFuZGxlLT5jYW5jZWwoKTsKKyAgICAgICAgbV9jdXJyZW50SGFu ZGxlID0gMDsKKyAgICAgICAgLy8gTG9hZCB0aGUgbmV4dCByZXNvdXJjZSwgaWYgYW55LgorICAg ICAgICBzdGFydExvYWRpbmdFbnRyeSgpOworICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAg aWYgKHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkgLyAxMDAgIT0gMiB8fCByZXNwb25zZS51cmwo KSAhPSBtX2N1cnJlbnRIYW5kbGUtPmZpcnN0UmVxdWVzdCgpLnVybCgpKSB7Cg==