70210 2011-10-16 18:58:35 -0700 REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails 2011-10-17 14:40:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69881 1 tkent arv ap arv darin ggaren webkit.review.bot oldest_to_newest 484870 0 tkent 2011-10-16 18:58:35 -0700 fast/js/stack-overflow-arrity-catch.html has been failing since r97566. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fjs%2Fstack-overflow-arrity-catch.html&showExpectations=true&showLargeExpectations=true --- e:\b\build\slave\Webkit_Win\build\layout-test-results\fast/js/stack-overflow-arrity-catch-expected.txt +++ e:\b\build\slave\Webkit_Win\build\layout-test-results\fast/js/stack-overflow-arrity-catch-actual.txt @@ -3,6 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". +Should not get here #2! PASS gotRightCatch is true PASS successfullyParsed is true 484871 1 tkent 2011-10-16 19:00:01 -0700 This looks v8-only. 484932 2 tkent 2011-10-16 22:43:41 -0700 I confirmed that reverting the change for stack-overflow-arrity-catch.html in r97566 fixed the failure. I have no idea why the following two lines affect the result :-D <p id="description"></p> <div id="console"></div> 485390 3 arv 2011-10-17 12:31:32 -0700 The thing that changed was that debug now calls a different function which makes its stack depth 2 instead of 1. I'm not sure this has ever worked as expected for V8. It seems like the assumptions are JSC specific. Also, if I change the debug() calls to simple bool assignment and check the values after the stack overflow has been handled we always reach 'Should not get here #2!'. It seems like the call to debug throws when we are at the deepest allowed call stack already which explains why we didn't get any debug output from this before. I'm going to clean up the test and add it to chromiums test expectations. 485478 4 111317 arv 2011-10-17 13:50:19 -0700 Created attachment 111317 Patch 485482 5 webkit.review.bot 2011-10-17 13:52:32 -0700 Attachment 111317 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485516 6 arv 2011-10-17 14:40:37 -0700 Committed r97651: <http://trac.webkit.org/changeset/97651> 111317 2011-10-17 13:50:19 -0700 2011-10-17 14:10:20 -0700 Patch bug-70210-20111017135018.patch text/plain 3672 arv U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NzcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMTAwYzg5MWFmODg1YzM3ZGNkNDJk NmJhNDcxYjE1ZDBjMzIyMDU0Li5hMjBlMDJhNmRjNTkxZDMwZjJhZThkMTcyN2Y5ZGQ5MjMxNWZm YzRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMTcgIEVyaWsgQXJ2aWRzc29uICA8 YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHI5NzU2NikgZmFzdC9qcy9z dGFjay1vdmVyZmxvdy1hcnJpdHktY2F0Y2guaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAyMTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdGhlIHRlc3QgdG8gbm90IGNhbGwg ZGVidWcoKSBpbnNpZGUgdGhlIHRlc3QgZnVuY3Rpb25zIHNpbmNlIHRoYXQgZmFpbHMgb24gVjgK KyAgICAgICAgYmVjYXVzZSB3ZSBhcmUgYWxyZWFkeSBhdCB0aGUgbWF4aW11bSBhbGxvd2VkIHN0 YWNrIGRlcHRoLgorCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvc3RhY2stb3ZlcmZs b3ctYXJyaXR5LWNhdGNoLmpzOgorICAgICAgICAodGVzdDEpOiBDaGFuZ2VkIHRvIG5vdCBjYWxs IGRlYnVnIGJ1dCBzZXQgYSBib29sZWFuIHZhcmlhYmxlIHRoYXQgaXMgbGF0ZXIgY2hlY2tlZC4K KyAgICAgICAgKHRlc3QyKTogRGl0dG8uCisgICAgICAgICogZmFzdC9qcy9zdGFjay1vdmVyZmxv dy1hcnJpdHktY2F0Y2gtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0xMC0xNiAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCB3ZWVrZW5kIGdh cmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3N0 YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0 LXRlc3RzL3N0YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC5qcwppbmRleCBkOTkwYzViYjE0ZGNj MjQzY2MyNWNiNDVmMzI2OTU4YjA4YzcwYmMyLi40MmY2OTU5ZjM5NDNhZWQ4NDQxNjFiZjA0NzVh MTJhMGQwZDEyNDM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0 cy9zdGFjay1vdmVyZmxvdy1hcnJpdHktY2F0Y2guanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9q cy9zY3JpcHQtdGVzdHMvc3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNhdGNoLmpzCkBAIC03LDcgKzcs NyBAQCBmdW5jdGlvbiBmdW5jV2l0aDIwQXJncyhhcmcxLCBhcmcyLCBhcmczLCBhcmc0LCBhcmc1 LCBhcmc2LCBhcmc3LCBhcmc4LAogICAgIGRlYnVnKCJFUlJPUjogU2hvdWxkbid0IGFycml2ZSBp biAyMCBhcmcgZnVuY3Rpb24hIik7CiB9CiAKLWdvdFJpZ2h0Q2F0Y2ggPSBmYWxzZTsKK3ZhciBn b3RSaWdodENhdGNoID0gZmFsc2UsIGdvdFdyb25nQ2F0Y2gxID0gZmFsc2UsIGdvdFdyb25nQ2F0 Y2gyID0gZmFsc2U7CiAKIGZ1bmN0aW9uIHRlc3QxKCkKIHsKQEAgLTE5LDcgKzE5LDcgQEAgZnVu Y3Rpb24gdGVzdDEoKQogICAgICAgICB0cnkgewogICAgICAgICAgICAgdmFyIGR1bW15ID0gbmV3 IFJlZ0V4cCgnYXxifGMnKTsKICAgICAgICAgfSBjYXRjaChlcnIpIHsKLSAgICAgICAgICAgIGRl YnVnKCdTaG91bGQgbm90IGdldCBoZXJlICMxIScpOworICAgICAgICAgICAgZ290V3JvbmdDYXRj aDEgPSB0cnVlOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICB0cnkgewpAQCAtMzUsNyAr MzUsNyBAQCBmdW5jdGlvbiB0ZXN0MigpCiAgICAgdHJ5IHsKICAgICAgICAgdmFyIGR1bW15ID0g bmV3IERhdGUoKTsKICAgICB9IGNhdGNoKGVycikgewotICAgICAgICBkZWJ1ZygnU2hvdWxkIG5v dCBnZXQgaGVyZSAjMiEnKTsKKyAgICAgICAgZ290V3JvbmdDYXRjaDIgPSB0cnVlOwogICAgIH0K ICAgICAKICAgICB0cnkgewpAQCAtNTQsNSArNTQsNyBAQCBmdW5jdGlvbiB0ZXN0MigpCiB0ZXN0 MSgpOwogCiBzaG91bGRCZVRydWUoImdvdFJpZ2h0Q2F0Y2giKTsKK3Nob3VsZEJlRmFsc2UoImdv dFdyb25nQ2F0Y2gxIik7CitzaG91bGRCZUZhbHNlKCJnb3RXcm9uZ0NhdGNoMiIpOwogCiB2YXIg c3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv anMvc3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNhdGNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvanMvc3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNhdGNoLWV4cGVjdGVkLnR4dAppbmRleCAx OWEzNWUyMDU5ZTE0OTI0NmY3ZjhkOWJlNDQ5NTcyNmFhYTc5ODUxLi43OWQyYzU2MWZmMWU0NWRl NDk1YTY2NjZhNTU0ODkzZDgzODBmZGE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2pz L3N0YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9qcy9zdGFjay1vdmVyZmxvdy1hcnJpdHktY2F0Y2gtZXhwZWN0ZWQudHh0CkBAIC00 LDYgKzQsOCBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogCiAKIFBBU1MgZ290UmlnaHRDYXRj aCBpcyB0cnVlCitQQVNTIGdvdFdyb25nQ2F0Y2gxIGlzIGZhbHNlCitQQVNTIGdvdFdyb25nQ2F0 Y2gyIGlzIGZhbHNlCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09N UExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dAppbmRleCA2MThjZjY0MjY2YzU1NmQwM2E5Yjg3YjE4MjcwYmZmOWQ1NDQyZTdl Li45YTE2MWU5ZmFlYzk2NGM3YzBjNmIzZWMwNjNiMjVhMDlhOGExNjkzIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0z ODIzLDMgKzM4MjMsNiBAQCBCVUdXSzcwMDEzIFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9jYW52YXMt dHJhbnNmb3Jtcy1maWxsUmVjdC1zaGFkb3cuaHRtbCA9IFBBU1MgQwogQlVHV0s3MDA2NiBTS0lQ IDogZmFzdC9oaWRwaSA9IFRJTUVPVVQKIEJVR1dLNzAwNjkgOiBodHRwL3Rlc3RzL3NlY3VyaXR5 L2NvbnRlbnRTZWN1cml0eVBvbGljeS94c2wtdW5hZmZlY3RlZC1ieS1zdHlsZS1zcmMtMS5waHAg PSBNSVNTSU5HCiBCVUdXSzcwMTUxIDogZmFzdC9jc3MvY2xpcC10ZXh0LWluLXNjYWxlZC1kaXYu aHRtbCA9IEZBSUwKKworLy8gVjggaGFuZGxlcyBzdGFjayBvdmVyZmxvdyBleGNlcHRpb25zIGRp ZmZlcmVudGx5IHRoYW4gSlNDCitCVUdXSzcwMjEwIDogZmFzdC9qcy9zdGFjay1vdmVyZmxvdy1h cnJpdHktY2F0Y2guaHRtbCA9IEZBSUwK