70207 2011-10-16 18:20:29 -0700 After deleting __defineSetter__, it is absent but appears in name list 2011-10-17 14:50:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 0 erights webkit-unassigned barraclough erights webkit.review.bot oldest_to_newest 484862 0 erights 2011-10-16 18:20:29 -0700 Below I delete __defineSetter__ on Object.prototype. Afterwards, it reappears on the end of the list returned by Object.getOwnPropertyNames but otherwise appears to be truly deleted. This is a new problem, in that Safari Version 5.0.6 (5533.22.3) instead has the problem described by issue 61014, namely that delete reports that it successfully deleted __defineSetter__, but it seems to still be there in all the ways tested below. So is this a new bug introduced in trying to fix issue 61014 ? > var gopn = Object.getOwnPropertyNames > var gopd = Object.getOwnPropertyDescriptor > gopn(Object.prototype) constructor,__defineSetter__,valueOf,__lookupGetter__,toLocaleString,__defineGetter__,hasOwnProperty,propertyIsEnumerable,toString,__lookupSetter__,isPrototypeOf > var desc = gopd(Object.prototype, '__defineSetter__') > JSON.stringify(desc) {"writable":true,"enumerable":false,"configurable":true} > desc.value function __defineSetter__() { [native code] } > delete Object.prototype.__defineSetter__; true > gopn(Object.prototype) constructor,toString,valueOf,__lookupGetter__,toLocaleString,__defineGetter__,hasOwnProperty,propertyIsEnumerable,__lookupSetter__,isPrototypeOf,__defineSetter__ > var desc = gopd(Object.prototype, '__defineSetter__') > desc === undefined true > Object.prototype.__defineSetter__ === undefined true > '__defineSetter__' in Object.prototype false 484863 1 erights 2011-10-16 18:21:26 -0700 This occurs on WebKit Nightly r97567. 484943 2 barraclough 2011-10-16 23:04:15 -0700 Ah, good catch, thank you Mark. This will be related to r61014, the fix to that should be expanded to cover Object.getOwnPropertyNames - this should be easy to resolve. I'll look into this. 485511 3 111322 barraclough 2011-10-17 14:35:26 -0700 Created attachment 111322 Fix 485514 4 webkit.review.bot 2011-10-17 14:38:00 -0700 Attachment 111322 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485526 5 barraclough 2011-10-17 14:50:28 -0700 Fixed in r97655 111322 2011-10-17 14:35:26 -0700 2011-10-17 14:38:11 -0700 Fix 70207.patch text/plain 3616 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc2NTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMTAtMTcgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDIwNwor ICAgICAgICBBZnRlciBkZWxldGluZyBfX2RlZmluZVNldHRlcl9fLCBpdCBpcyBhYnNlbnQgYnV0 IGFwcGVhcnMgaW4gbmFtZSBsaXN0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNP YmplY3Q6OmdldE93blByb3BlcnR5TmFtZXMpOgorICAgICAgICAgICAgLSBUaGlzIHNob3VsZCBj aGVjayB3aGV0aGVyIHN0YXRpYyBmdW5jdGlvbnMgaGF2ZSBiZWVuIHJlaWZpZWQuCisKIDIwMTEt MTAtMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWMg YnVpbGQgZml4LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0 LmNwcAkocmV2aXNpb24gOTc2MzkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U09iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUyMSw3ICs1MjEsOCBAQCB2b2lkIEpTT2Jq ZWN0OjpnZXRQcm9wZXJ0eU5hbWVzKEV4ZWNTdGF0CiB2b2lkIEpTT2JqZWN0OjpnZXRPd25Qcm9w ZXJ0eU5hbWVzKEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVydHlOYW1lQXJyYXkmIHByb3BlcnR5TmFt ZXMsIEVudW1lcmF0aW9uTW9kZSBtb2RlKQogewogICAgIHN0cnVjdHVyZSgpLT5nZXRQcm9wZXJ0 eU5hbWVzKGV4ZWMtPmdsb2JhbERhdGEoKSwgcHJvcGVydHlOYW1lcywgbW9kZSk7Ci0gICAgZ2V0 Q2xhc3NQcm9wZXJ0eU5hbWVzKGV4ZWMsIGNsYXNzSW5mbygpLCBwcm9wZXJ0eU5hbWVzLCBtb2Rl KTsKKyAgICBpZiAoIXN0YXRpY0Z1bmN0aW9uc1JlaWZpZWQoKSkKKyAgICAgICAgZ2V0Q2xhc3NQ cm9wZXJ0eU5hbWVzKGV4ZWMsIGNsYXNzSW5mbygpLCBwcm9wZXJ0eU5hbWVzLCBtb2RlKTsKIH0K IAogYm9vbCBKU09iamVjdDo6dG9Cb29sZWFuKEV4ZWNTdGF0ZSopIGNvbnN0CkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiA5NzY1MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDExLTEwLTE3ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xv dWdoQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzAyMDcKKyAgICAgICAgQWZ0ZXIgZGVsZXRpbmcgX19kZWZpbmVTZXR0ZXJfXywg aXQgaXMgYWJzZW50IGJ1dCBhcHBlYXJzIGluIG5hbWUgbGlzdAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9kZWxldGUtc3ludGF4LWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9kZWxldGUtc3ludGF4 LmpzOgorICAgICAgICAgICAgLSBBZGRlZCB0ZXN0IGNhc2UgZm9yIGdldE93blByb3BlcnR5TmFt ZXMuCisKIDIwMTEtMTAtMTcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmVtb3Zpbmcgc3VwcHJlc3Npb25zIGZvciB0aGUgZnVsbHNjcmVlbi8gdGVzdHMg LSBpdCBsb29rcwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9kZWxldGUtc3ludGF4LWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2RlbGV0ZS1zeW50YXgt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NzYzOSkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvZGVs ZXRlLXN5bnRheC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAg UEFTUyBNYXRoLnRhbiBpcyBudWxsCiBQQVNTIFJlZ0V4cC5wcm90b3R5cGUuY29tcGlsZSBpcyBy ZWdFeHBQcm90b3R5cGVDb21waWxlCiBQQVNTIFJlZ0V4cC5wcm90b3R5cGUuZXhlYyBpcyB1bmRl ZmluZWQKIFBBU1MgUmVnRXhwLnByb3RvdHlwZS50ZXN0IGlzIG51bGwKK1BBU1MgU3RyaW5nKE9i amVjdC5nZXRPd25Qcm9wZXJ0eU5hbWVzKE9iamVjdC5wcm90b3R5cGUpKSBpcyAiY29uc3RydWN0 b3IsdmFsdWVPZixfX2xvb2t1cEdldHRlcl9fLHRvTG9jYWxlU3RyaW5nLF9fZGVmaW5lR2V0dGVy X18saGFzT3duUHJvcGVydHkscHJvcGVydHlJc0VudW1lcmFibGUsdG9TdHJpbmcsX19sb29rdXBT ZXR0ZXJfXyxpc1Byb3RvdHlwZU9mIgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQog CiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9k ZWxldGUtc3ludGF4LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0 LXRlc3RzL2RlbGV0ZS1zeW50YXguanMJKHJldmlzaW9uIDk3NjM5KQorKysgTGF5b3V0VGVzdHMv ZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGVsZXRlLXN5bnRheC5qcwkod29ya2luZyBjb3B5KQpAQCAt NjgsNSArNjgsOSBAQCBzaG91bGRCZSgiUmVnRXhwLnByb3RvdHlwZS5jb21waWxlIiwgInJlCiBz aG91bGRCZSgiUmVnRXhwLnByb3RvdHlwZS5leGVjIiwgInVuZGVmaW5lZCIpOwogc2hvdWxkQmUo IlJlZ0V4cC5wcm90b3R5cGUudGVzdCIsICJudWxsIik7CiAKKy8vIENoZWNrIHRoYXQgb25jZSBh IHByb3BlcnR5IGlzIGRlbGV0ZWQgaXRzIG5hbWUgaXMgcmVtb3ZlZCBmcm9tIHRoZSBwcm9wZXJ0 eSBuYW1lIGFycmF5LgorZGVsZXRlIE9iamVjdC5wcm90b3R5cGUuX19kZWZpbmVTZXR0ZXJfXzsK K3Nob3VsZEJlKCJTdHJpbmcoT2JqZWN0LmdldE93blByb3BlcnR5TmFtZXMoT2JqZWN0LnByb3Rv dHlwZSkpIiwgJyJjb25zdHJ1Y3Rvcix2YWx1ZU9mLF9fbG9va3VwR2V0dGVyX18sdG9Mb2NhbGVT dHJpbmcsX19kZWZpbmVHZXR0ZXJfXyxoYXNPd25Qcm9wZXJ0eSxwcm9wZXJ0eUlzRW51bWVyYWJs ZSx0b1N0cmluZyxfX2xvb2t1cFNldHRlcl9fLGlzUHJvdG90eXBlT2YiJyk7CisKIHZhciBzdWNj ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwogCg==