70192 2011-10-15 19:08:35 -0700 Remove unused ENABLE(SKIA_GPU) 2013-03-28 20:24:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68012 1 abarth abarth dbates eric jamesr junov kbr kennyluck reed webkit.review.bot oldest_to_newest 484705 0 abarth 2011-10-15 19:08:35 -0700 Remove unused ENABLE(SKIA_GPU) 484706 1 111163 abarth 2011-10-15 19:09:29 -0700 Created attachment 111163 Patch 484716 2 111163 dbates 2011-10-15 19:42:22 -0700 Comment on attachment 111163 Patch For completeness, references to ENABLE(SKIA_GPU) were replaced with USE(SKIA) or an analogous run-time check in <http://trac.webkit.org/changeset/85017>. Obviously, we didn't remove SKIA_GPU references in Source/WebKit/chromium/features.gypi. 484729 3 111163 webkit.review.bot 2011-10-15 21:19:03 -0700 Comment on attachment 111163 Patch Clearing flags on attachment: 111163 Committed r97570: <http://trac.webkit.org/changeset/97570> 484730 4 webkit.review.bot 2011-10-15 21:19:07 -0700 All reviewed patches have been landed. Closing bug. 865976 5 kennyluck 2013-03-28 20:24:54 -0700 (In reply to comment #2) > (From update of attachment 111163 [details]) > For completeness, references to ENABLE(SKIA_GPU) were replaced with USE(SKIA) or an analogous run-time check in <http://trac.webkit.org/changeset/85017>. Obviously, we didn't remove SKIA_GPU references in Source/WebKit/chromium/features.gypi. It seems that ENABLE_RUBY, introduced temporarily by Bug 28420, was not removed from features.gypi either. I am not sure about ENABLE_SANDBOX, V8_SCRIPT_DEBUG_SERVER. These two were introduced in r88548 but there are not listed on http://trac.webkit.org/wiki/FeatureFlags . 111163 2011-10-15 19:09:29 -0700 2011-10-15 21:19:03 -0700 Patch bug-70192-20111015190931.patch text/plain 1345 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NzU2OCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTAtMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZW1vdmUgdW51c2VkIEVOQUJMRShTS0lBX0dQVSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgZG8gbm90IGFwcGVhciB0byBiZSBhbnkgcmVm ZXJlbmNlcyB0byB0aGlzIG1hY3JvLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAx MS0xMC0xNSAgVmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFtDaHJvbWl1bV0gUG9wdWxhdGUgV2ViTW91c2VFdmVudCBtb3ZlbWVudFgvWSBvbiBNYWMKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDk3NTY1KQorKysg U291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCSh3b3JraW5nIGNvcHkpCkBAIC03 OSw3ICs3OSw2IEBACiAgICAgICAnRU5BQkxFX1JVQlk9MScsCiAgICAgICAnRU5BQkxFX1NBTkRC T1g9MScsCiAgICAgICAnRU5BQkxFX1NIQVJFRF9XT1JLRVJTPTEnLAotICAgICAgJ0VOQUJMRV9T S0lBX0dQVT08KHVzZV9za2lhX2dwdSknLAogICAgICAgJ0VOQUJMRV9TS0lBX1RFWFQ9PChlbmFi bGVfc2tpYV90ZXh0KScsCiAgICAgICAnRU5BQkxFX1NNT09USF9TQ1JPTExJTkc9MScsCiAgICAg ICAnRU5BQkxFX1NRTF9EQVRBQkFTRT0xJywKQEAgLTExNCw3ICsxMTMsNiBAQAogICAgICAgJ2Vu YWJsZV9za2lhX3RleHQlJzogMCwKICAgICAgICdlbmFibGVfc3ZnJSc6IDEsCiAgICAgICAnZW5h YmxlX3RvdWNoX2V2ZW50cyUnOiAxLAotICAgICAgJ3VzZV9za2lhX2dwdSUnOiAwLAogICAgICAg J3VzZV9za2lhJSc6IDAsCiAgICAgICAnZW5hYmxlX3RvdWNoX2ljb25fbG9hZGluZyUnIDogMCwK ICAgICAgICdlbmFibGVfY3NzM19mbGV4Ym94JSc6IDAsCg==