70190 2011-10-15 17:56:00 -0700 [GTK] Avoid unecessarily calling gtk_widget_size_allocate on plugin widgets 2011-10-20 00:48:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia gustavo pnormand xan.lopez oldest_to_newest 484692 0 mrobinson 2011-10-15 17:56:00 -0700 gtk_widget_size_allocate is called on plugin widgets that are scrolled off the page or haven't changed position. Since gtk_widget_size_allocate is an expensive operation we should only call it when necessary. This causes poor scrolling performance on pages with many plugins. 484695 1 111159 mrobinson 2011-10-15 18:02:53 -0700 Created attachment 111159 Patch 484962 2 111159 cgarcia 2011-10-17 00:03:55 -0700 Comment on attachment 111159 Patch LGTM 484969 3 111159 xan.lopez 2011-10-17 00:27:39 -0700 Comment on attachment 111159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111159&action=review > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:517 > + m_windowRect = IntRect(-1, -1, 1, 1); My understanding is that -1, -1 as an allocation is a sort of magic value that you are not meant to use from "user space". > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:581 > + // gtk_widget_size_allocate is expensive, so don't call it unless the allocation has changed. Perhaps it's better to note here that we don't care about some things size_allocate does even when the allocation is the same, like invalidating the area. 484974 4 mrobinson 2011-10-17 00:40:19 -0700 (In reply to comment #3) > (From update of attachment 111159 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111159&action=review > > > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:517 > > + m_windowRect = IntRect(-1, -1, 1, 1); > > My understanding is that -1, -1 as an allocation is a sort of magic value that you are not meant to use from "user space". Is there some place that talks about this? From a brief look at the GTK+ source code, this just seems like the allocation GTK+ uses when creating a widget. I also found in testing that GTK+ would return this allocation if I placed the widget anywhere offscreen. I do not think it's a problem to use a weird allocation, since we are implementing our own container. > > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:581 > > + // gtk_widget_size_allocate is expensive, so don't call it unless the allocation has changed. > > Perhaps it's better to note here that we don't care about some things size_allocate does even when the allocation is the same, like invalidating the area. Okay. I can expand this comment to indicate that Flash is drawing into the window so we don't care what size_allocate does wrt to invalidations. 484977 5 111159 xan.lopez 2011-10-17 00:47:23 -0700 Comment on attachment 111159 Patch I'm fine with this being committed, just try to double check sometime if what we are doing with allocations is kosher. 485879 6 111401 mrobinson 2011-10-18 00:26:02 -0700 Created attachment 111401 Patch with no magic allocation 485880 7 mrobinson 2011-10-18 00:27:18 -0700 (In reply to comment #5) > (From update of attachment 111159 [details]) > I'm fine with this being committed, just try to double check sometime if what we are doing with allocations is kosher. I couldn't raise any expert opinions on #gtk+, so I rewrote the patch to remove the funky allocation. I think it's actually a little more explicit this way. Do you mind taking another look? 485891 8 111401 xan.lopez 2011-10-18 00:56:50 -0700 Comment on attachment 111401 Patch with no magic allocation This makes sense to me. 486809 9 mrobinson 2011-10-19 08:24:14 -0700 Committed r97865: <http://trac.webkit.org/changeset/97865> 487365 10 pnormand 2011-10-19 23:47:35 -0700 It seems this patch broke plugins/resize-from-plugin.html Double checking now... --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/plugins/resize-from-plugin-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/plugins/resize-from-plugin-actual.txt @@ -7,6 +7,6 @@ Test for NPP_SetWindow calls sent while a plug-in resizes itself. -x: 0, y: 0, width: 200, height: 200, clipRect: (0, 0, 0, 0) +x: 0, y: 0, width: 200, height: 200, clipRect: (0, 0, 200, 142) Height and width should equal 200, and the plug-in size should not change on scroll. 487382 11 pnormand 2011-10-20 00:41:25 -0700 (In reply to comment #10) > It seems this patch broke plugins/resize-from-plugin.html > Double checking now... Yep, confirmed! What should we do then? 487392 12 pnormand 2011-10-20 00:48:25 -0700 (In reply to comment #11) > (In reply to comment #10) > > It seems this patch broke plugins/resize-from-plugin.html > > Double checking now... > > Yep, confirmed! What should we do then? See bug 70481 111159 2011-10-15 18:02:53 -0700 2011-10-18 00:25:59 -0700 Patch bug-70190-20111015180253.patch text/plain 3286 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYWU0YTYwZWMxYWE0Mjc0 ODBmOWI3OTBlOTlkYTQ2YTdmOWFhNDdiLi42Y2ZjY2QyZGU1M2U1NmRjYTBhZmZiYzg1M2U5ZTNl ZTViZWQ0YTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMTAtMTUgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEF2b2lk IHVuZWNlc3NhcmlseSBjYWxsaW5nIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSBvbiBwbHVnaW4g d2lkZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzAxOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bnN0ZWFkIG9mIGFsd2F5cyBjYWxsaW5nIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSBvbiBldmVy eSBzaW5nbGUgcGx1Z2luCisgICAgICAgIHdpZGdldCBkdXJpbmcgc2Nyb2xsaW5nLCBvbmx5IGNh bGwgaXQgb24gd2lkZ2V0cyB0aGF0IGFyZSBib3RoIGluIHRoZSB2aWV3CisgICAgICAgIGFuZCB0 aGF0IGhhdmUgbW92ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBJdCdzIGRpZmZpY3VsdCB0 byB0ZXN0IHNjcm9sbGluZyBwZXJmb3JtYW5jZSBpbiBhbgorICAgICAgICBhdXRvbWF0ZWQgd2F5 LgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKTogUmV2ZXJzZSB0aGUgaWYg c3RhdGVtZW50IGRldGVjdGluZyBhCisgICAgICAgIGNsaXBwZWQgb3V0IHBsdWdpbi4gSXQgd2Fz IGluY29ycmVjdC4gQWxzbyBhbGxvY2F0ZSBvZmYtc2NyZWVuIHBsdWdpbnMgdG8gYSB0aW55Cisg ICAgICAgIHJlY3Qgb2ZmIHRoZSBzY3JlZW4uCisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3 Ojp1cGRhdGVXaWRnZXRBbGxvY2F0aW9uQW5kQ2xpcCk6IElmIHRoZSBjdXJyZW50IGFsbG9jYXRp b24gb2YKKyAgICAgICAgdGhlIHBsdWdpbiB3aWRnZXQgaGFzIG5vdCBjaGFuZ2VkLCBkbyBub3Qg Y2FsbCBndGtfd2lkZ2V0X3NpemVfYWxsb2NhdGUuCisKIDIwMTEtMTAtMTUgIExhc3psbyBHb21i b3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gW1N5bWJpYW5d IFJlbW92ZSBzdXBwb3J0IGZvciB0aGUgU3ltYmlhbiBwbGF0Zm9ybSBmb3IgdGhlIFF0V2ViS2l0 IHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdH dGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKaW5k ZXggZGJjMzc0YTNmYWExZDdlZDQ5NTNkOGIwYzMwNWI3YmZhZWJjZjAyZC4uOWI0ZDUyODE0Y2Mx N2NjZDNlMzI3OThkNTE3NGYxMWVjZDAxYmE2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTUwNCwxMyArNTA0LDE3IEBAIHZvaWQgUGx1Z2lu Vmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCgpCiAgICAgaWYgKG1faXNXaW5kb3dlZCAmJiAhcGxh dGZvcm1QbHVnaW5XaWRnZXQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gSWYgd2lkdGgg b3IgaGVpZ2h0IGFyZSBudWxsLCBzZXQgdGhlIGNsaXBSZWN0IHRvIG51bGwsIGluZGljYXRpbmcg dGhhdAotICAgIC8vIHRoZSBwbHVnaW4gaXMgbm90IHZpc2libGUvc2Nyb2xsZWQgb3V0LgotICAg IGlmICghbV9jbGlwUmVjdC5pc0VtcHR5KCkpIHsKKyAgICBpZiAobV9jbGlwUmVjdC5pc0VtcHR5 KCkpIHsKKyAgICAgICAgLy8gSWYgd2lkdGggb3IgaGVpZ2h0IGFyZSBudWxsLCBzZXQgdGhlIGNs aXBSZWN0IHRvIG51bGwsCisgICAgICAgIC8vIGluZGljYXRpbmcgdGhhdCB0aGUgcGx1Z2luIGlz IG5vdCB2aXNpYmxlL3Njcm9sbGVkIG91dC4KICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5s ZWZ0ID0gMDsKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IDA7CiAgICAgICAg IG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0gMDsKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVj dC5ib3R0b20gPSAwOworCisgICAgICAgIC8vIFNldCB0aGUgd2lkZ2V0IGFsbG9jYXRpb24gdG8g dmVyeSBzbWFsbCBhbmQgb2ZmIHRoZSBwYWdlLiBUaGlzIGVuc3VyZXMgdGhhdCB3ZQorICAgICAg ICAvLyBkb24ndCBrZWVwIGNhbGxpbmcgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRlIGZvciB3aWRn ZXRzIHRoYXQgYXJlIGNsaXBwZWQgb3V0LgorICAgICAgICBtX3dpbmRvd1JlY3QgPSBJbnRSZWN0 KC0xLCAtMSwgMSwgMSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8gQ2xpcHBpbmcgcmVjdGFu Z2xlIG9mIHRoZSBwbHVnLWluOyB0aGUgb3JpZ2luIGlzIHRoZSB0b3AgbGVmdCBjb3JuZXIgb2Yg dGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4gCiAgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVm dCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3QueCgpOwpAQCAtNTcyLDggKzU3NiwxMyBAQCB2 b2lkIFBsdWdpblZpZXc6OnVwZGF0ZVdpZGdldEFsbG9jYXRpb25BbmRDbGlwKCkKICAgICB9CiAK ICAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb24obV9kZWxheWVkQWxsb2NhdGlvbik7Ci0gICAg Z3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKHdpZGdldCwgJmFsbG9jYXRpb24pOwogICAgIG1fZGVs YXllZEFsbG9jYXRpb24gPSBJbnRSZWN0KCk7CisKKyAgICAvLyBndGtfd2lkZ2V0X3NpemVfYWxs b2NhdGUgaXMgZXhwZW5zaXZlLCBzbyBkb24ndCBjYWxsIGl0IHVubGVzcyB0aGUgYWxsb2NhdGlv biBoYXMgY2hhbmdlZC4KKyAgICBHdGtBbGxvY2F0aW9uIGN1cnJlbnRBbGxvY2F0aW9uOworICAg IGd0a193aWRnZXRfZ2V0X2FsbG9jYXRpb24od2lkZ2V0LCAmY3VycmVudEFsbG9jYXRpb24pOwor ICAgIGlmIChhbGxvY2F0aW9uICE9IGN1cnJlbnRBbGxvY2F0aW9uKQorICAgICAgICBndGtfd2lk Z2V0X3NpemVfYWxsb2NhdGUod2lkZ2V0LCAmYWxsb2NhdGlvbik7CiB9CiAKIHZvaWQgUGx1Z2lu Vmlldzo6c2V0UGFyZW50VmlzaWJsZShib29sIHZpc2libGUpCg== 111401 2011-10-18 00:26:02 -0700 2011-10-18 00:56:50 -0700 Patch with no magic allocation bug-70190-20111018002601.patch text/plain 3240 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYWU0YTYwZWMxYWE0Mjc0 ODBmOWI3OTBlOTlkYTQ2YTdmOWFhNDdiLi5hMDI3ZTkwODM4OGU5ODFhYzIwNWYxNzIyZjVmNmRl M2MzZmE2ZmM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMTAtMTUgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEF2b2lk IHVuZWNlc3NhcmlseSBjYWxsaW5nIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSBvbiBwbHVnaW4g d2lkZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzAxOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bnN0ZWFkIG9mIGFsd2F5cyBjYWxsaW5nIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSBvbiBldmVy eSBzaW5nbGUgcGx1Z2luCisgICAgICAgIHdpZGdldCBkdXJpbmcgc2Nyb2xsaW5nLCBvbmx5IGNh bGwgaXQgb24gd2lkZ2V0cyB0aGF0IGFyZSBib3RoIGluIHRoZSB2aWV3CisgICAgICAgIGFuZCB0 aGF0IGhhdmUgbW92ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBJdCdzIGRpZmZpY3VsdCB0 byB0ZXN0IHNjcm9sbGluZyBwZXJmb3JtYW5jZSBpbiBhbgorICAgICAgICBhdXRvbWF0ZWQgd2F5 LgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKTogUmV2ZXJzZSB0aGUgaWYg c3RhdGVtZW50IGRldGVjdGluZyBhCisgICAgICAgIGNsaXBwZWQgb3V0IHBsdWdpbi4gSXQgd2Fz IGluY29ycmVjdC4KKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnVwZGF0ZVdpZGdldEFs bG9jYXRpb25BbmRDbGlwKTogSWYgdGhlIGN1cnJlbnQgYWxsb2NhdGlvbiBvZgorICAgICAgICB0 aGUgcGx1Z2luIHdpZGdldCBoYXMgbm90IGNoYW5nZWQgb3IgaWYgdGhlIHdpZGdldCByZW1haW5z IHNjcm9sbGVkIG91dCwgZG8gbm90IGNhbGwKKyAgICAgICAgZ3RrX3dpZGdldF9zaXplX2FsbG9j YXRlLgorCiAyMDExLTEwLTE1ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lh LmNvbT4KIAogICAgICAgICBbUXRdIFtTeW1iaWFuXSBSZW1vdmUgc3VwcG9ydCBmb3IgdGhlIFN5 bWJpYW4gcGxhdGZvcm0gZm9yIHRoZSBRdFdlYktpdCBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs dWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCmluZGV4IGRiYzM3NGEzZmFhMWQ3ZWQ0OTUzZDhi MGMzMDViN2JmYWViY2YwMmQuLmY4MDQxN2E1NzFkYzBhNzczMDc4MzliYmNkMGU1YmFmYjMyNTI4 MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBA IC01MDQsOSArNTA0LDkgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkK ICAgICBpZiAobV9pc1dpbmRvd2VkICYmICFwbGF0Zm9ybVBsdWdpbldpZGdldCgpKQogICAgICAg ICByZXR1cm47CiAKLSAgICAvLyBJZiB3aWR0aCBvciBoZWlnaHQgYXJlIG51bGwsIHNldCB0aGUg Y2xpcFJlY3QgdG8gbnVsbCwgaW5kaWNhdGluZyB0aGF0Ci0gICAgLy8gdGhlIHBsdWdpbiBpcyBu b3QgdmlzaWJsZS9zY3JvbGxlZCBvdXQuCi0gICAgaWYgKCFtX2NsaXBSZWN0LmlzRW1wdHkoKSkg eworICAgIGlmIChtX2NsaXBSZWN0LmlzRW1wdHkoKSkgeworICAgICAgICAvLyBJZiB3aWR0aCBv ciBoZWlnaHQgYXJlIG51bGwsIHNldCB0aGUgY2xpcFJlY3QgdG8gbnVsbCwKKyAgICAgICAgLy8g aW5kaWNhdGluZyB0aGF0IHRoZSBwbHVnaW4gaXMgbm90IHZpc2libGUvc2Nyb2xsZWQgb3V0Lgog ICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQgPSAwOwogICAgICAgICBtX25wV2luZG93 LmNsaXBSZWN0LnJpZ2h0ID0gMDsKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSAw OwpAQCAtNTcyLDggKzU3MiwyNSBAQCB2b2lkIFBsdWdpblZpZXc6OnVwZGF0ZVdpZGdldEFsbG9j YXRpb25BbmRDbGlwKCkKICAgICB9CiAKICAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb24obV9k ZWxheWVkQWxsb2NhdGlvbik7Ci0gICAgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKHdpZGdldCwg JmFsbG9jYXRpb24pOwogICAgIG1fZGVsYXllZEFsbG9jYXRpb24gPSBJbnRSZWN0KCk7CisKKyAg ICAvLyBUaGUgZ29hbCBpcyB0byBhdm9pZCBjYWxsaW5nIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0 ZSB3aGVuIG5lY2Vzc2FyeS4KKyAgICAvLyBJdCBibG9ja3MgdGhlIG1haW4gbG9vcCBhbmQgaWYg dGhlIHdpZGdldCBpcyBvZmZzY3JlZW4gb3IgaGFzbid0IG1vdmVkCisgICAgLy8gaXQgaXNuJ3Qg cmVxdWlyZWQuCisKKyAgICAvLyBEb24ndCBkbyBhbnl0aGluZyBpZiB0aGUgYWxsb2NhdGlvbiBo YXMgbm90IGNoYW5nZWQuCisgICAgR3RrQWxsb2NhdGlvbiBjdXJyZW50QWxsb2NhdGlvbjsKKyAg ICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKHdpZGdldCwgJmN1cnJlbnRBbGxvY2F0aW9uKTsK KyAgICBpZiAoY3VycmVudEFsbG9jYXRpb24gPT0gYWxsb2NhdGlvbikKKyAgICAgICAgcmV0dXJu OworCisgICAgLy8gRG9uJ3QgZG8gYW55dGhpbmcgaWYgYm90aCB0aGUgb2xkIGFuZCB0aGUgbmV3 IGFsbG9jYXRpb25zIGFyZSBvdXRzaWRlIHRoZSBmcmFtZS4KKyAgICBJbnRSZWN0IGN1cnJlbnRB bGxvY2F0aW9uUmVjdChjdXJyZW50QWxsb2NhdGlvbik7CisgICAgY3VycmVudEFsbG9jYXRpb25S ZWN0LmludGVyc2VjdChmcmFtZVJlY3QoKSk7CisgICAgaWYgKGN1cnJlbnRBbGxvY2F0aW9uUmVj dC5pc0VtcHR5KCkgJiYgbV9jbGlwUmVjdC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKwor ICAgIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSh3aWRnZXQsICZhbGxvY2F0aW9uKTsKIH0KIAog dm9pZCBQbHVnaW5WaWV3OjpzZXRQYXJlbnRWaXNpYmxlKGJvb2wgdmlzaWJsZSkK