70180 2011-10-15 14:05:27 -0700 [GTK] GtkAdjustment watcher updates adjustments too lazily 2011-10-25 09:52:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68757 1 mrobinson mrobinson cgarcia gustavo webkit.review.bot xan.lopez oldest_to_newest 484635 0 mrobinson 2011-10-15 14:05:27 -0700 The timeout GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater has a low enough priority that sometimes scrollbars become out of sync with the page contents. I've seen this cause drawing artifacts as well. We just need to boost the priority slightly. 484636 1 111144 mrobinson 2011-10-15 14:11:00 -0700 Created attachment 111144 Patch 484955 2 111144 cgarcia 2011-10-16 23:45:52 -0700 Comment on attachment 111144 Patch LGTM 489287 3 111144 gustavo 2011-10-24 05:45:33 -0700 Comment on attachment 111144 Patch I hate these priority problems =( I think it makes sense as it is, but just out of curiosity, did you try having it set to something like G_PRIORITY_HIGH_IDLE itself, which would guarantee it's ran before any GTK+ layout is performed? 490069 4 111144 mrobinson 2011-10-25 09:38:33 -0700 Comment on attachment 111144 Patch Landing this now, since I think Alex wants it for the release. To answer kov's question, I'm pretty sure I did test G_PRIORITY_HIGH_IDLE without much luck. 490075 5 111144 webkit.review.bot 2011-10-25 09:51:57 -0700 Comment on attachment 111144 Patch Clearing flags on attachment: 111144 Committed r98352: <http://trac.webkit.org/changeset/98352> 490076 6 webkit.review.bot 2011-10-25 09:52:02 -0700 All reviewed patches have been landed. Closing bug. 111144 2011-10-15 14:11:00 -0700 2011-10-25 09:51:57 -0700 Patch bug-70180-20111015141100.patch text/plain 2466 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBjN2FkYjY5Zjhm MzNkZmZlNzU4NDA2ZjJhNTQwNDY0MDBiZWFmODdmLi5mMzhkNWMxOWU3ZmU1YWFmOTk0YTg4Mzc3 OWJlNTc4NmZmZTUzMzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEt MTAtMTUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIEd0a0FkanVzdG1lbnQgd2F0Y2hlciB1cGRhdGVzIGFkanVzdG1lbnRzIHRvbyBsYXpp bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMTgw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5jcmVh c2UgdGhlIHByaW9yaXR5IG9mIHRoZSBHdGtBZGp1c3RtZW50cyB1cGRhdGUgaW4gR3RrQWRqdXN0 bWVudFdhdGNoZXIuIFRoaXMKKyAgICAgICAgbWVhbnMgdGhhdCBhZGp1c3RtZW50cyB3aWxsIG1v cmUgcXVpY2tseSByZXByZXNlbnQgdGhlIHN0YXRlIG9mIHRoZSBXZWJLaXRXZWJWaWV3CisgICAg ICAgIHdoZW4gaXQgc2Nyb2xscy4gVGhpcyBmaXhlcyBvdXQtb2Ytc3luYyBzY3JvbGxiYXJzIGFu ZCBzb21lIHZpc3VhbCBhcnRpZmFjdHMuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9HdGtB ZGp1c3RtZW50V2F0Y2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Okd0a0FkanVzdG1lbnRXYXRj aGVyOjp1cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzTGF0ZXIpOiBVc2UgYSB0aW1lb3V0 CisgICAgICAgIHdpdGggdGhlIGRlZmF1bHQgcHJpb3JpdHkuCisKIDIwMTEtMTAtMTIgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSB0aGUgaW50ZXJmYWNl IG9mIGxvY2F0aW9uQW5kTGVuZ3RoRnJvbVJhbmdlIGFuZCByYW5nZUZyb21Mb2NhdGlvbkFuZExl bmd0aCBjb25zaXN0ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3Vw cG9ydC9HdGtBZGp1c3RtZW50V2F0Y2hlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9HdGtBZGp1c3RtZW50V2F0Y2hlci5jcHAKaW5kZXggYjIzMmM5ZGU5OTVhMDkzNTVk ZDlmMDdjYzFmYzA0MjM5NGY1MzU1ZS4uZWViNzc5NjJmMGZjYTJlMmRiZTk2OWQxYzVjZDAxZjZh ZmRjYWNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvR3Rr QWRqdXN0bWVudFdhdGNoZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0d0a0FkanVzdG1lbnRXYXRjaGVyLmNwcApAQCAtODMsOSArODMsOCBAQCB2b2lkIEd0a0Fk anVzdG1lbnRXYXRjaGVyOjp1cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzTGF0ZXIoKSBj b25zdAogICAgIC8vIFRoZSBmYWN0IHRoYXQgdGhpcyBtZXRob2Qgd2FzIGNhbGxlZCBtZWFucyB0 aGF0IHdlIG5lZWQgdG8gdXBkYXRlIHRoZSBzY3JvbGxiYXJzLCBidXQgYXQgdGhlCiAgICAgLy8g dGltZSBvZiBpbnZvY2F0aW9uIHRoZXkgYXJlIG5vdCB1cGRhdGVkIHRvIHJlZmxlY3QgdGhlIHNj cm9sbCB5ZXQuIFdlIHNldCBhIHNob3J0IHRpbWVvdXQKICAgICAvLyBoZXJlLCB3aGljaCBtZWFu cyB0aGF0IHRoZXkgd2lsbCBiZSB1cGRhdGVkIGFzIHNvb24gYXMgV2ViS2l0IHJldHVybnMgdG8g dGhlIG1haW4gbG9vcC4KLSAgICBtX3VwZGF0ZUFkanVzdG1lbnRDYWxsYmFja0lkID0gZ190aW1l b3V0X2FkZF9mdWxsKEdfUFJJT1JJVFlfSElHSF9JRExFICsgMTAsIDAsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWludGVycHJldF9jYXN0 PEdTb3VyY2VGdW5jPih1cGRhdGVBZGp1c3RtZW50Q2FsbGJhY2spLCAKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0X2Nhc3Q8dm9pZCo+ KHN0YXRpY19jYXN0PGNvbnN0IHZvaWQqPih0aGlzKSksIDApOworICAgIG1fdXBkYXRlQWRqdXN0 bWVudENhbGxiYWNrSWQgPSBnX3RpbWVvdXRfYWRkKDAsIHJlaW50ZXJwcmV0X2Nhc3Q8R1NvdXJj ZUZ1bmM+KHVwZGF0ZUFkanVzdG1lbnRDYWxsYmFjayksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3RfY2FzdDx2b2lkKj4oc3RhdGljX2Nhc3Q8 Y29uc3Qgdm9pZCo+KHRoaXMpKSk7CiB9CiAKIHN0YXRpYyB2b2lkIGFkanVzdG1lbnRWYWx1ZUNo YW5nZWRDYWxsYmFjayhHdGtBZGp1c3RtZW50KiBhZGp1c3RtZW50LCBHdGtBZGp1c3RtZW50V2F0 Y2hlciogd2F0Y2hlcikK