70170 2011-10-14 23:16:53 -0700 [EFL] Some dirty areas are ignored without repainting. 2011-11-02 00:21:48 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html P2 Normal --- 67112 0 kevin.cs.oh webkit-unassigned gyuyoung.kim hyuki.kim leandro lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 484493 0 kevin.cs.oh 2011-10-14 23:16:53 -0700 Dirty area is not update properly while animation with requestAnimationFrame enabled for EFL port. Visit here http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html. 491370 1 112643 kevin.cs.oh 2011-10-27 00:12:19 -0700 Created attachment 112643 Proposed patch 491426 2 ryuan.choi 2011-10-27 02:29:26 -0700 *** Bug 70900 has been marked as a duplicate of this bug. *** 491428 3 ryuan.choi 2011-10-27 02:31:06 -0700 Informal r+ on my side. 491494 4 rakuco 2011-10-27 06:04:49 -0700 Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen? 491541 5 kevin.cs.oh 2011-10-27 07:10:37 -0700 (In reply to comment #4) > Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen? I guess you missed applying a submitted patch for bug67112 before. This will enable requestAnimationFrame JS API so that you can see 2 clocks and some changing numbers. 493116 6 hyuki.kim 2011-10-30 18:25:48 -0700 > Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen? Hi, Kubo, I think that you can notice the reason why this patch is reasonable if you check www.daum.net. Just go to www.daum.net and scroll down 2 times. and then click daum title image on top of the left cornor of website without this patch first. And finally use this patch for the same checking. 493117 7 hyuki.kim 2011-10-30 18:26:07 -0700 LGTM. 493269 8 rakuco 2011-10-31 06:13:34 -0700 (In reply to comment #5) > (In reply to comment #4) > > Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen? > > I guess you missed applying a submitted patch for bug67112 before. This will enable requestAnimationFrame JS API so that you can see 2 clocks and some changing numbers. Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right? 493270 9 rakuco 2011-10-31 06:14:16 -0700 (In reply to comment #8) > Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right? BTW, if that's the issue, doesn't it need to be fixed in the tiled backing store too? 493275 10 hyuki.kim 2011-10-31 06:31:30 -0700 (In reply to comment #9) > (In reply to comment #8) > > Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right? > > BTW, if that's the issue, doesn't it need to be fixed in the tiled backing store too? You are right. Tiled view also requires it. 493280 11 rakuco 2011-10-31 06:36:27 -0700 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right? > > > > BTW, if that's the issue, doesn't it need to be fixed in the tiled backing store too? > > You are right. > Tiled view also requires it. OK, so if this is the issue that this patch fixes, you have my informal r+, even though it'd be better to fix both backing stores in a single patch. 494448 12 112643 eric 2011-11-01 23:12:33 -0700 Comment on attachment 112643 Proposed patch rubber-stamp. This really should be tested, but I don't think EFL has DumpREnderTree yet... Does it? If so, we could use repaint tests. 494465 13 112643 webkit.review.bot 2011-11-02 00:21:43 -0700 Comment on attachment 112643 Proposed patch Clearing flags on attachment: 112643 Committed r99041: <http://trac.webkit.org/changeset/99041> 494466 14 webkit.review.bot 2011-11-02 00:21:48 -0700 All reviewed patches have been landed. Closing bug. 112643 2011-10-27 00:12:19 -0700 2011-11-02 00:21:42 -0700 Proposed patch P70170.patch text/plain 1706 kevin.cs.oh ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzNDdmODJjLi5mNmU1NTgyIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjYgIENoYW5nU2VvayBPaCAgPHNoaXZhbWlkb3dAZ21h aWwuY29tPgorCisgICAgICAgIFtFRkxdIERpcnR5IGFyZWEgaXMgbm90IHVwZGF0ZWQgd2l0aCBy ZXF1ZXN0QW5pbWF0aW9uRnJhbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MDE3MAorCisgICAgICAgIFNvbWUgYWRkaXRpb25hbCBkaXJ0eSBhcmVh cyBjYXVzZWQgYnkgcmUtbGF5b3V0IGhhdmUgaWdub3JlZAorICAgICAgICBzaW5jZSB1cGRhdGVM YXlvdXRBbmRTeXRsZUlmTmVlZGVSZWN1cnNpdmUgaXMgY2FsbGVkIGFmdGVyIGdhdGhlcmluZyBk aXJ0eSBhcmVhIHRvIHJlcGFpbnQuCisgICAgICAgIFNvIGV3a192aWV3X2xheW91dF9pZl9uZWVk ZWRfcmVjdXJzaXZlIGlzIHJlbG9jYXRlZCBiZWZvcmUgZ2V0dGluZyBkaXJ0eSBhcmVhcy4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGV3ay9ld2tf dmlld19zaW5nbGUuY3BwOgorICAgICAgICAoX2V3a192aWV3X3NpbmdsZV9zbWFydF9yZXBhaW50 c19wcm9jZXNzKToKKwogMjAxMS0xMC0yNSAgS3dhbmdIeXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBGaXggb2NjdXJyZW5jZSBvZiB1bnBhaW50ZWQgdGlsZXMgd2hp bGUgc2Nyb2xsaW5nIGFuZCB6b29taW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3X3NpbmdsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdf c2luZ2xlLmNwcAppbmRleCA3ZGNiYjJjLi4xODY2MThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXdfc2luZ2xlLmNwcApAQCAtNDI5LDYgKzQyOSw4IEBAIHN0YXRpYyBFaW5hX0Jv b2wgX2V3a192aWV3X3NpbmdsZV9zbWFydF9yZXBhaW50c19wcm9jZXNzKEV3a19WaWV3X1NtYXJ0 X0RhdGEqIHNtCiAgICAgICAgIGdvdG8gZXJyb3JfdGlsZXI7CiAgICAgfQogCisgICAgZXdrX3Zp ZXdfbGF5b3V0X2lmX25lZWRlZF9yZWN1cnNpdmUoc21hcnREYXRhLT5fcHJpdik7CisKICAgICBw ciA9IGV3a192aWV3X3JlcGFpbnRzX2dldChzbWFydERhdGEtPl9wcml2LCAmY291bnQpOwogICAg IHByX2VuZCA9IHByICsgY291bnQ7CiAgICAgZm9yICg7IHByIDwgcHJfZW5kOyBwcisrKQpAQCAt NDQxLDggKzQ0Myw2IEBAIHN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X3NpbmdsZV9zbWFydF9y ZXBhaW50c19wcm9jZXNzKEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtCiAgICAgICAgIGdvdG8gZXJy b3JfaXRlcmF0b3I7CiAgICAgfQogCi0gICAgZXdrX3ZpZXdfbGF5b3V0X2lmX25lZWRlZF9yZWN1 cnNpdmUoc21hcnREYXRhLT5fcHJpdik7Ci0KICAgICBpbnQgc3gsIHN5OwogICAgIGV3a19mcmFt ZV9zY3JvbGxfcG9zX2dldChzbWFydERhdGEtPm1haW5fZnJhbWUsICZzeCwgJnN5KTsKIAo=