70154 2011-10-14 15:53:47 -0700 watchlist: Add a validation check for the email names in the list. 2011-10-14 16:12:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 levin levin abarth levin+watchlist webkit.review.bot oldest_to_newest 484381 0 levin 2011-10-14 15:53:47 -0700 watchlist: Add a validation check for the email names in the list. 484383 1 111102 levin 2011-10-14 15:58:41 -0700 Created attachment 111102 Patch 484385 2 111102 abarth 2011-10-14 16:01:49 -0700 Comment on attachment 111102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111102&action=review > Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:137 > + raise Exception("The email alias %s which is in the watchlist is not listed as a contributor in committers.py" % email) I see that we've already using Exception in this class, but it's usually good form to use a subclass of exception so that folks can catch these parse errors without catching all manner of exceptions. (Just a general note. Nothing that needs to be addressed now.) 484390 3 levin 2011-10-14 16:12:37 -0700 Committed as http://trac.webkit.org/changeset/97530 111102 2011-10-14 15:58:41 -0700 2011-10-14 16:11:44 -0700 Patch bug-70154-20111014155840.patch text/plain 5149 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZTI1YzJmNWZkZmIxMmU3YjdmN2RlYzdlNTYyZDM5NjZh ZDlmZWEyLi4yM2IxYzNjY2Q3MmYyMDk2ZDkxYzI5ZDhlNGU1YjIxMDA2ZTUzNGVlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMTAtMTQgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCisgICAg ICAgIHdhdGNobGlzdDogQWRkIGEgdmFsaWRhdGlvbiBjaGVjayBmb3IgdGhlIGVtYWlsIG5hbWVz IGluIHRoZSBsaXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzAxNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJZiBhbiBlbWFpbCBpcyBsaXN0ZWQgd2hpY2ggZG9lc24ndCBoYXZlIGEgYnVnemlsbGEg bG9nIGluLCB0aGVuIGFueSBlbWFpbHMKKyAgICAgICAgYWRkZWQgdG8gdGhlIGJ1ZyBhbG9uZyB3 aXRoIHRoYXQgZW1haWwgd2lsbCBmYWlsIHRvIGhhcHBlbiwgc28gdHJ5IHRvIHByZXZlbnQgdGhp cworICAgICAgICBmcm9tIGhhcHBlbmluZyBieSB2YWxpZGF0aW5nIHRoYXQgZW1haWxzIGFkZGVk IHRvIHRoZSB3YXRjaGxpc3QgYXJlIGtub3duIHRvIGJlCisgICAgICAgIGNvbnRyaWJ1dG9ycy4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5 OiBBZGQgbXkgb3RoZXIgZW1haWwgYWxpYXNlcyBmb3IgYnVnemlsbGEuCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9jb21tb24vd2F0Y2hsaXN0L3dhdGNobGlzdHBhcnNlci5weTogQWRkIHRo ZSBjaGVjay4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0 Y2hsaXN0cGFyc2VyX3VuaXR0ZXN0LnB5OiBBIHVuaXQgdGVzdCBmb3IgdGhlIGNoZWNrLgorCisy MDExLTEwLTE0ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KKwogICAgICAgICB3 YXRjaGxpc3Q6IElmIHRoZSBzdHlsZSBjaGVjayBmYWlscywgdGhlbiB0aGUgd2F0Y2hsaXN0IHdp bGwgbm90IGJlIHJ1bi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY5NDg0CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L2NvbmZpZy9jb21taXR0ZXJzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29u ZmlnL2NvbW1pdHRlcnMucHkKaW5kZXggNjc3NjE2MDc3YTdiNTAwYzY3MTUxNTNiNjdkMmQ0Yzcy Zjc1NzI4NS4uNTk3NmM0MTk4YzE3ZWIxMTM5ZmFlZDFlNzk1NGNiYmZhNDQ0N2Y5YyAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkK QEAgLTM1Nyw3ICszNTcsNyBAQCByZXZpZXdlcnNfbGlzdCA9IFsKICAgICBSZXZpZXdlcigiRGF2 aWQgSGFycmlzb24iLCAiaGFycmlzb25AYXBwbGUuY29tIiwgImhhcnJpc29uIiksCiAgICAgUmV2 aWV3ZXIoIkRhdmlkIEh5YXR0IiwgImh5YXR0QGFwcGxlLmNvbSIsIFsiZGh5YXR0IiwgImh5YXR0 Il0pLAogICAgIFJldmlld2VyKCJEYXZpZCBLaWx6ZXIiLCBbImRka2lsemVyQHdlYmtpdC5vcmci LCAiZGRraWx6ZXJAYXBwbGUuY29tIl0sICJkZGtpbHplciIpLAotICAgIFJldmlld2VyKCJEYXZp ZCBMZXZpbiIsICJsZXZpbkBjaHJvbWl1bS5vcmciLCAiZGF2ZV9sZXZpbiIpLAorICAgIFJldmll d2VyKCJEYXZpZCBMZXZpbiIsIFsibGV2aW5AY2hyb21pdW0ub3JnIiwgImxldmluK3RocmVhZGlu Z0BjaHJvbWl1bS5vcmciLCAibGV2aW4rd2F0Y2hsaXN0QGNocm9taXVtLm9yZyJdLCAiZGF2ZV9s ZXZpbiIpLAogICAgIFJldmlld2VyKCJEZWFuIEphY2tzb24iLCAiZGlub0BhcHBsZS5jb20iLCAi ZGlubyIpLAogICAgIFJldmlld2VyKCJEaW1pdHJpIEdsYXprb3YiLCAiZGdsYXprb3ZAY2hyb21p dW0ub3JnIiwgImRnbGF6a292IiksCiAgICAgUmV2aWV3ZXIoIkRpcmsgUHJhbmtlIiwgImRwcmFu a2VAY2hyb21pdW0ub3JnIiwgImRwcmFua2UiKSwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL3dhdGNobGlzdC93YXRjaGxpc3RwYXJzZXIucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0Y2hsaXN0cGFyc2VyLnB5CmluZGV4IDdj M2Q2MDAwZGMzZWM1M2Q4MmVhNGQ4ZDJhZGQzYjk0NzlmM2IyMDMuLjdjNWI0NmNmYjRmNmM5NzE1 OTU2N2JmOWYzMDg4NjRkMzM5YmM5M2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL3dhdGNobGlzdC93YXRjaGxpc3RwYXJzZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vd2F0Y2hsaXN0L3dhdGNobGlzdHBhcnNlci5weQpAQCAtMzUsNiAr MzUsNyBAQCBmcm9tIHdlYmtpdHB5LmNvbW1vbi53YXRjaGxpc3QuY2hhbmdlZGxpbmVwYXR0ZXJu IGltcG9ydCBDaGFuZ2VkTGluZVBhdHRlcm4KIGZyb20gd2Via2l0cHkuY29tbW9uLndhdGNobGlz dC5maWxlbmFtZXBhdHRlcm4gaW1wb3J0IEZpbGVuYW1lUGF0dGVybgogZnJvbSB3ZWJraXRweS5j b21tb24ud2F0Y2hsaXN0LndhdGNobGlzdCBpbXBvcnQgV2F0Y2hMaXN0CiBmcm9tIHdlYmtpdHB5 LmNvbW1vbi53YXRjaGxpc3Qud2F0Y2hsaXN0cnVsZSBpbXBvcnQgV2F0Y2hMaXN0UnVsZQorZnJv bSB3ZWJraXRweS5jb21tb24uY29uZmlnLmNvbW1pdHRlcnMgaW1wb3J0IENvbW1pdHRlckxpc3QK IAogCiBjbGFzcyBXYXRjaExpc3RQYXJzZXIob2JqZWN0KToKQEAgLTEyOSw2ICsxMzAsMTIgQEAg Y2xhc3MgV2F0Y2hMaXN0UGFyc2VyKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3ZhbGlkYXRlX2Rl ZmluaXRpb25zKGNjX2RlZmluaXRpb25zX3NldCwgc2VsZi5fQ0NfUlVMRVMsIHdhdGNoX2xpc3Qp CiAgICAgICAgIHNlbGYuX3ZhbGlkYXRlX2RlZmluaXRpb25zKG1lc3NhZ2VzX2RlZmluaXRpb25z X3NldCwgc2VsZi5fTUVTU0FHRV9SVUxFUywgd2F0Y2hfbGlzdCkKIAorICAgICAgICBjb250cmli dXRvcnMgPSBDb21taXR0ZXJMaXN0KCkKKyAgICAgICAgZm9yIGNjX3J1bGUgaW4gd2F0Y2hfbGlz dC5jY19ydWxlczoKKyAgICAgICAgICAgIGZvciBlbWFpbCBpbiBjY19ydWxlLmluc3RydWN0aW9u cygpOgorICAgICAgICAgICAgICAgIGlmIG5vdCBjb250cmlidXRvcnMuY29udHJpYnV0b3JfYnlf ZW1haWwoZW1haWwpOgorICAgICAgICAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIlRoZSBl bWFpbCBhbGlhcyAlcyB3aGljaCBpcyBpbiB0aGUgd2F0Y2hsaXN0IGlzIG5vdCBsaXN0ZWQgYXMg YSBjb250cmlidXRvciBpbiBjb21taXR0ZXJzLnB5IiAlIGVtYWlsKQorCiAgICAgZGVmIF92ZXJp ZnlfYWxsX2RlZmluaXRpb25zX2FyZV91c2VkKHNlbGYsIHdhdGNoX2xpc3QsIHVzZWRfZGVmaW5p dGlvbnMpOgogICAgICAgICBkZWZpbml0aW9uc19ub3RfdXNlZCA9IHNldCh3YXRjaF9saXN0LmRl ZmluaXRpb25zLmtleXMoKSkKICAgICAgICAgZGVmaW5pdGlvbnNfbm90X3VzZWQuZGlmZmVyZW5j ZV91cGRhdGUodXNlZF9kZWZpbml0aW9ucykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3dhdGNobGlzdC93YXRjaGxpc3RwYXJzZXJfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0Y2hsaXN0cGFyc2VyX3VuaXR0 ZXN0LnB5CmluZGV4IDMwMWNhNWU3YWQ2YmUzOTk0Njc3ZDQyNjBmZDAzOTFkYTVmOGViZTYuLjJi MGQ1N2E3MDIzOTdkZjliODM3MGNlNGI3Yjc4YTczYjU1ODZiYmMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3dhdGNobGlzdC93YXRjaGxpc3RwYXJzZXJfdW5pdHRl c3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vd2F0Y2hsaXN0L3dhdGNo bGlzdHBhcnNlcl91bml0dGVzdC5weQpAQCAtMTE3LDYgKzExNywyMiBAQCBjbGFzcyBXYXRjaExp c3RQYXJzZXJUZXN0KHdlYmtpdHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3Nl cnRSYWlzZXNSZWdleHAoRXhjZXB0aW9uLCByJ0EgcnVsZSBmb3IgZGVmaW5pdGlvbiAiV2F0Y2hM aXN0MSIgaXMgZW1wdHksIHNvIGl0IHNob3VsZCBiZSBkZWxldGVkLicsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHNlbGYuX3dhdGNoX2xpc3RfcGFyc2VyLnBhcnNlLCB3YXRjaF9s aXN0KQogCisgICAgZGVmIHRlc3RfY2NfcnVsZV93aXRoX2ludmFsaWRfZW1haWwoc2VsZik6Cisg ICAgICAgIHdhdGNoX2xpc3QgPSAoCisgICAgICAgICAgICAneycKKyAgICAgICAgICAgICcgICAg IkRFRklOSVRJT05TIjogeycKKyAgICAgICAgICAgICcgICAgICAgICJXYXRjaExpc3QxIjogeycK KyAgICAgICAgICAgICcgICAgICAgICAgICAiZmlsZW5hbWUiOiByIi4qXFxNeUZpbGVOYW1lXFwu Y3BwIiwnCisgICAgICAgICAgICAnICAgICAgICB9LCcKKyAgICAgICAgICAgICcgICAgIH0sJwor ICAgICAgICAgICAgJyAgICAiQ0NfUlVMRVMiOiB7JworICAgICAgICAgICAgJyAgICAgICAgIldh dGNoTGlzdDEiOiBbImxldmluK2JhZCtlbWFpbEBjaHJvbWl1bS5vcmciXSwnCisgICAgICAgICAg ICAnICAgICB9LCcKKyAgICAgICAgICAgICd9JykKKworICAgICAgICBzZWxmLmFzc2VydFJhaXNl c1JlZ2V4cChFeGNlcHRpb24sIHInVGhlIGVtYWlsIGFsaWFzIGxldmluXCtiYWRcK2VtYWlsQGNo cm9taXVtLm9yZyB3aGljaCBpcyBpbiB0aGUgd2F0Y2hsaXN0IGlzIG5vdCBsaXN0ZWQgYXMgYSBj b250cmlidXRvciBpbiBjb21taXR0ZXJzXC5weScsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHNlbGYuX3dhdGNoX2xpc3RfcGFyc2VyLnBhcnNlLCB3YXRjaF9saXN0KQorCiAgICAg ZGVmIHRlc3RfZW1wdHlfbWVzc2FnZV9ydWxlKHNlbGYpOgogICAgICAgICB3YXRjaF9saXN0ID0g KAogICAgICAgICAgICAgJ3snCg==