70148 2011-10-14 14:33:23 -0700 Should switch to CoreUI version of CorrectionDot, GrammarDot, and SpellingDot 2011-10-14 15:13:23 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 484304 0 bdakin 2011-10-14 14:33:23 -0700 GraphicsContextMac should access the CoreUI mages for CorrectionDot, GrammarDot, and SpellingDot. Patch forthcoming. <rdar://problem/10208281> 484336 1 111090 bdakin 2011-10-14 15:08:09 -0700 Created attachment 111090 Patch 484343 2 bdakin 2011-10-14 15:13:23 -0700 Committed fix with revision 97517. 111090 2011-10-14 15:08:09 -0700 2011-10-14 15:10:05 -0700 Patch for-review.txt text/plain 3804 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NTA4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMTQgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MDE0OAorICAgICAgICBTaG91bGQgc3dpdGNoIHRvIENvcmVVSSB2 ZXJzaW9uIG9mIENvcnJlY3Rpb25Eb3QsIEdyYW1tYXJEb3QsIGFuZCBTcGVsbGluZ0RvdAorICAg ICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDIwODI4 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug TlMqRG90IHdoZW5ldmVyIGl0J3MgYXZhaWxhYmxlLCBhbmQgZmFsbGJhY2sgdG8gKkRvdCBvbmx5 IHdoZW4gaXQgaXMgbm90LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGlj c0NvbnRleHRNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVQYXR0ZXJuQ29sb3IpOgor ICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZUZvclRleHRDaGVja2lu Zyk6CisKIDIwMTEtMTAtMTQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAg ICAgICAgIEluc3BlY3RvcjogUmVtb3ZlIFN0eWxlQmFzZSB1c2FnZS4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHRNYWMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29u dGV4dE1hYy5tbQkocmV2aXNpb24gOTc0ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC04Miw5 ICs4MiwxMyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0ZvY3VzUmluZyhjb25zCiB9CiAK IAotc3RhdGljIE5TQ29sb3IqIGNyZWF0ZVBhdHRlcm5Db2xvcihOU1N0cmluZyogbmFtZSwgTlND b2xvciogZGVmYXVsdENvbG9yLCBib29sJiB1c2luZ0RvdCkKK3N0YXRpYyBOU0NvbG9yKiBjcmVh dGVQYXR0ZXJuQ29sb3IoTlNTdHJpbmcqIGZpcnN0Q2hvaWNlTmFtZSwgTlNTdHJpbmcqIHNlY29u ZENob2ljZU5hbWUsIE5TQ29sb3IqIGRlZmF1bHRDb2xvciwgYm9vbCYgdXNpbmdEb3QpCiB7Ci0g ICAgTlNJbWFnZSAqaW1hZ2UgPSBbTlNJbWFnZSBpbWFnZU5hbWVkOm5hbWVdOworICAgIC8vIEV2 ZW50dWFsbHkgd2Ugc2hvdWxkIGJlIGFibGUgdG8gZ2V0IHJpZCBvZiB0aGUgc2Vjb25kQ2hvaWNl TmFtZS4gRm9yIHRoZSB0aW1lIGJlaW5nIHdlIG5lZWQgYm90aCB0byBrZWVwCisgICAgLy8gdGhp cyB3b3JraW5nIG9uIGFsbCBwbGF0Zm9ybXMuCisgICAgTlNJbWFnZSAqaW1hZ2UgPSBbTlNJbWFn ZSBpbWFnZU5hbWVkOmZpcnN0Q2hvaWNlTmFtZV07CisgICAgaWYgKCFpbWFnZSkKKyAgICAgICAg aW1hZ2UgPSBbTlNJbWFnZSBpbWFnZU5hbWVkOnNlY29uZENob2ljZU5hbWVdOwogICAgIEFTU0VS VChpbWFnZSk7IC8vIGlmIGltYWdlIGlzIG5vdCBhdmFpbGFibGUsIHdlIHdhbnQgdG8ga25vdwog ICAgIE5TQ29sb3IgKmNvbG9yID0gKGltYWdlID8gW05TQ29sb3IgY29sb3JXaXRoUGF0dGVybklt YWdlOmltYWdlXSA6IG5pbCk7CiAgICAgaWYgKGNvbG9yKQpAQCAtMTExLDcgKzExNSw3IEBAIHZv aWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZUZvclRleHRDaGUKICAgICAgICAgewogICAgICAg ICAgICAgLy8gQ29uc3RhbnRzIGZvciBzcGVsbGluZyBwYXR0ZXJuIGNvbG9yLgogICAgICAgICAg ICAgc3RhdGljIGJvb2wgdXNpbmdEb3RGb3JTcGVsbGluZyA9IGZhbHNlOwotICAgICAgICAgICAg REVGSU5FX1NUQVRJQ19MT0NBTChSZXRhaW5QdHI8TlNDb2xvcj4sIHNwZWxsaW5nUGF0dGVybkNv bG9yLCAoY3JlYXRlUGF0dGVybkNvbG9yKEAiU3BlbGxpbmdEb3QiLCBbTlNDb2xvciByZWRDb2xv cl0sIHVzaW5nRG90Rm9yU3BlbGxpbmcpKSk7CisgICAgICAgICAgICBERUZJTkVfU1RBVElDX0xP Q0FMKFJldGFpblB0cjxOU0NvbG9yPiwgc3BlbGxpbmdQYXR0ZXJuQ29sb3IsIChjcmVhdGVQYXR0 ZXJuQ29sb3IoQCJOU1NwZWxsaW5nRG90IiwgQCJTcGVsbGluZ0RvdCIsIFtOU0NvbG9yIHJlZENv bG9yXSwgdXNpbmdEb3RGb3JTcGVsbGluZykpKTsKICAgICAgICAgICAgIHVzaW5nRG90ID0gdXNp bmdEb3RGb3JTcGVsbGluZzsKICAgICAgICAgICAgIHBhdHRlcm5Db2xvciA9IHNwZWxsaW5nUGF0 dGVybkNvbG9yLmdldCgpOwogICAgICAgICAgICAgYnJlYWs7CkBAIC0xMjAsNyArMTI0LDcgQEAg dm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdMaW5lRm9yVGV4dENoZQogICAgICAgICB7CiAgICAg ICAgICAgICAvLyBDb25zdGFudHMgZm9yIGdyYW1tYXIgcGF0dGVybiBjb2xvci4KICAgICAgICAg ICAgIHN0YXRpYyBib29sIHVzaW5nRG90Rm9yR3JhbW1hciA9IGZhbHNlOwotICAgICAgICAgICAg REVGSU5FX1NUQVRJQ19MT0NBTChSZXRhaW5QdHI8TlNDb2xvcj4sIGdyYW1tYXJQYXR0ZXJuQ29s b3IsIChjcmVhdGVQYXR0ZXJuQ29sb3IoQCJHcmFtbWFyRG90IiwgW05TQ29sb3IgZ3JlZW5Db2xv cl0sIHVzaW5nRG90Rm9yR3JhbW1hcikpKTsKKyAgICAgICAgICAgIERFRklORV9TVEFUSUNfTE9D QUwoUmV0YWluUHRyPE5TQ29sb3I+LCBncmFtbWFyUGF0dGVybkNvbG9yLCAoY3JlYXRlUGF0dGVy bkNvbG9yKEAiTlNHcmFtbWFyRG90IiwgQCJHcmFtbWFyRG90IiwgW05TQ29sb3IgZ3JlZW5Db2xv cl0sIHVzaW5nRG90Rm9yR3JhbW1hcikpKTsKICAgICAgICAgICAgIHVzaW5nRG90ID0gdXNpbmdE b3RGb3JHcmFtbWFyOwogICAgICAgICAgICAgcGF0dGVybkNvbG9yID0gZ3JhbW1hclBhdHRlcm5D b2xvci5nZXQoKTsKICAgICAgICAgICAgIGJyZWFrOwpAQCAtMTMxLDcgKzEzNSw3IEBAIHZvaWQg R3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZUZvclRleHRDaGUKICAgICAgICAgewogICAgICAgICAg ICAgLy8gQ29uc3RhbnRzIGZvciBzcGVsbGluZyBwYXR0ZXJuIGNvbG9yLgogICAgICAgICAgICAg c3RhdGljIGJvb2wgdXNpbmdEb3RGb3JTcGVsbGluZyA9IGZhbHNlOwotICAgICAgICAgICAgREVG SU5FX1NUQVRJQ19MT0NBTChSZXRhaW5QdHI8TlNDb2xvcj4sIHNwZWxsaW5nUGF0dGVybkNvbG9y LCAoY3JlYXRlUGF0dGVybkNvbG9yKEAiQ29ycmVjdGlvbkRvdCIsIFtOU0NvbG9yIGJsdWVDb2xv cl0sIHVzaW5nRG90Rm9yU3BlbGxpbmcpKSk7CisgICAgICAgICAgICBERUZJTkVfU1RBVElDX0xP Q0FMKFJldGFpblB0cjxOU0NvbG9yPiwgc3BlbGxpbmdQYXR0ZXJuQ29sb3IsIChjcmVhdGVQYXR0 ZXJuQ29sb3IoQCJOU0NvcnJlY3Rpb25Eb3QiLCBAIkNvcnJlY3Rpb25Eb3QiLCBbTlNDb2xvciBi bHVlQ29sb3JdLCB1c2luZ0RvdEZvclNwZWxsaW5nKSkpOwogICAgICAgICAgICAgdXNpbmdEb3Qg PSB1c2luZ0RvdEZvclNwZWxsaW5nOwogICAgICAgICAgICAgcGF0dGVybkNvbG9yID0gc3BlbGxp bmdQYXR0ZXJuQ29sb3IuZ2V0KCk7CiAgICAgICAgICAgICBicmVhazsK