70135 2011-10-14 12:51:37 -0700 [WebKit2][gtk] Re-enable running TestWebKitSettings 2011-12-09 01:02:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 70127 1 nayankk nayankk cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 484208 0 nayankk 2011-10-14 12:51:37 -0700 Re-enable running TestWebKitSettings which was skipped as part of https://bugs.webkit.org/show_bug.cgi?id=70129 due to the bug https://bugs.webkit.org/show_bug.cgi?id=70127. 484210 1 111058 nayankk 2011-10-14 12:55:15 -0700 Created attachment 111058 Re-enable running TestWebKitSettings 517510 2 111058 mrobinson 2011-12-08 10:09:25 -0800 Comment on attachment 111058 Re-enable running TestWebKitSettings Thanks for fixing this. 518110 3 118530 nayankk 2011-12-08 22:02:42 -0800 Created attachment 118530 Re-enable running TestWebKitSettings Unskip 2 skipped tests 518111 4 webkit.review.bot 2011-12-08 22:05:06 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 518170 5 118530 webkit.review.bot 2011-12-09 01:02:40 -0800 Comment on attachment 118530 Re-enable running TestWebKitSettings Clearing flags on attachment: 118530 Committed r102444: <http://trac.webkit.org/changeset/102444> 518171 6 webkit.review.bot 2011-12-09 01:02:48 -0800 All reviewed patches have been landed. Closing bug. 111058 2011-10-14 12:55:15 -0700 2011-12-08 22:02:25 -0800 Re-enable running TestWebKitSettings EnableTest.diff text/plain 1654 nayankk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzNDFiNzk1Li44MjI0MzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTAtMTQgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KKwor ICAgICAgICBbV2ViS2l0Ml1bZ3RrXSBSZS1lbmFibGUgcnVubmluZyBUZXN0V2ViS2l0U2V0dGlu Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMTM1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmUtZW5h YmxlIHJ1bm5pbmcgVGVzdFdlYktpdFNldHRpbmdzIHdoaWNoIHdhcyBza2lwcGVkIGFzIHBhcnQK KyAgICAgICAgb2YgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMTI5 IGR1ZSB0byB0aGUKKyAgICAgICAgYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MDEyNy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RX ZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0U2V0dGluZ3MpOiBSdW4gVGVz dFdlYktpdFNldHRpbmdzIHRlc3QKKwogMjAxMS0xMC0xNCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjk3Mzc1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVz dHMvVGVzdFdlYktpdFNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggNjEwZGQwOS4uMGNlMzdmZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdl YktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90 ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwCkBAIC0zNiw5ICszNiw2IEBACiAKIHN0YXRpYyB2 b2lkIHRlc3RXZWJLaXRTZXR0aW5ncyhUZXN0KiwgZ2NvbnN0cG9pbnRlcikKIHsKLSAgICAvKiBT a2lwIHJ1bm5pbmcgdGhpcyB0ZXN0IGZvciBub3cgdGlsbCBhIGJ1ZyBpbiBXS1ByZWZlcmVuY2Vz Q3JlYXRlCi0gICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcw MTI3IGdldHMgZml4ZWQuICovCi0jaWYgMAogICAgIFdlYktpdFNldHRpbmdzKiBzZXR0aW5ncyA9 IHdlYmtpdF9zZXR0aW5nc19uZXcoKTsKIAogICAgIC8vIEphdmFTY3JpcHQgaXMgZW5hYmxlZCBi eSBkZWZhdWx0LgpAQCAtMTAyLDcgKzk5LDYgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdFNldHRp bmdzKFRlc3QqLCBnY29uc3Rwb2ludGVyKQogICAgIGdfYXNzZXJ0KHdlYmtpdF9zZXR0aW5nc19n ZXRfZW5hYmxlX2h5cGVybGlua19hdWRpdGluZyhzZXR0aW5ncykpOwogCiAgICAgZ19vYmplY3Rf dW5yZWYoR19PQkpFQ1Qoc2V0dGluZ3MpKTsKLSNlbmRpZgogfQogCiB2b2lkIGJlZm9yZUFsbCgp Cg== 118530 2011-12-08 22:02:42 -0800 2011-12-09 01:02:40 -0800 Re-enable running TestWebKitSettings bug-70135-20111209113240.patch text/plain 2823 nayankk U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWJhYmMzZjRlZTM2MGM3 ODhhYTljYTAwNzYwODQ2NjkzMmMxNzhkYi4uYjFlYTZhZDhhY2Y1NzBhMDliZWU0MzBjNmJkNmI0 ZmZjMmFjMmY4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA4ICBOYXlh biBLdW1hciBLICA8bmF5YW5ra0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW1dlYktpdDJdW2d0 a10gUmUtZW5hYmxlIHJ1bm5pbmcgVGVzdFdlYktpdFNldHRpbmdzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDEzNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWVuYWJsZSBydW5uaW5nIFRlc3RXZWJL aXRTZXR0aW5ncyB3aGljaCB3YXMgc2tpcHBlZCBhcyBwYXJ0CisgICAgICAgIG9mIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDEyOSBkdWUgdG8gdGhlCisgICAgICAg IGJ1ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAxMjcuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwOgor ICAgICAgICAodGVzdFdlYktpdFNldHRpbmdzKTogUnVuIHRlc3RXZWJLaXRTZXR0aW5ncy4KKyAg ICAgICAgKHRlc3RXZWJLaXRTZXR0aW5nc05ld1dpdGhTZXR0aW5ncyk6IFJ1biB0ZXN0V2ViS2l0 U2V0dGluZ3NOZXdXaXRoU2V0dGluZ3MuCisKIDIwMTEtMTItMDggIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRm9yY2VkIGNvbXBvc2l0aW5nIG1vZGUg YnJlYWtzIGRpc3BsYXkgb2YgZnVsbC1wYWdlIFBERnMgaW4gV0syCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFNldHRp bmdzLmNwcAppbmRleCBjNDlkOTVhNDAzZWQ5MjdlYTI2NjE5NmQyOWFkOTI3MWI5YTQzNGFiLi45 M2U5YzljZDI3MWJhYTQyYTU2MTJhYTIwMDczYTM4NGExNGZhN2RjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRT ZXR0aW5ncy5jcHAKQEAgLTM3LDkgKzM3LDYgQEAKIAogc3RhdGljIHZvaWQgdGVzdFdlYktpdFNl dHRpbmdzKFRlc3QqLCBnY29uc3Rwb2ludGVyKQogewotICAgIC8qIFNraXAgcnVubmluZyB0aGlz IHRlc3QgZm9yIG5vdyB0aWxsIGEgYnVnIGluIFdLUHJlZmVyZW5jZXNDcmVhdGUKLSAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAxMjcgZ2V0cyBmaXhlZC4g Ki8KLSNpZiAwCiAgICAgV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzID0gd2Via2l0X3NldHRpbmdz X25ldygpOwogCiAgICAgLy8gSmF2YVNjcmlwdCBpcyBlbmFibGVkIGJ5IGRlZmF1bHQuCkBAIC0x ODgsMTQgKzE4NSwxMCBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViS2l0U2V0dGluZ3MoVGVzdCosIGdj b25zdHBvaW50ZXIpCiAgICAgZ19hc3NlcnQod2Via2l0X3NldHRpbmdzX2dldF9lbmFibGVfZnVs bHNjcmVlbihzZXR0aW5ncykpOwogCiAgICAgZ19vYmplY3RfdW5yZWYoR19PQkpFQ1Qoc2V0dGlu Z3MpKTsKLSNlbmRpZgogfQogCiB2b2lkIHRlc3RXZWJLaXRTZXR0aW5nc05ld1dpdGhTZXR0aW5n cyhUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogewotICAgIC8qIFNraXAgcnVubmluZyB0aGlz IHRlc3QgZm9yIG5vdyB0aWxsIGEgYnVnIGluIFdLUHJlZmVyZW5jZXNDcmVhdGUKLSAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAxMjcgZ2V0cyBmaXhlZC4g Ki8KLSNpZiAwCiAgICAgR1JlZlB0cjxXZWJLaXRTZXR0aW5ncz4gc2V0dGluZ3MgPSBhZG9wdEdS ZWYod2Via2l0X3NldHRpbmdzX25ld193aXRoX3NldHRpbmdzKCJlbmFibGUtamF2YXNjcmlwdCIs IEZBTFNFLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiYXV0by1sb2FkLWltYWdlcyIsIEZB TFNFLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAibG9hZC1pY29ucy1pZ25vcmluZy1pbWFn ZS1sb2FkLXNldHRpbmciLCBUUlVFLApAQCAtMjA0LDcgKzE5Nyw2IEBAIHZvaWQgdGVzdFdlYktp dFNldHRpbmdzTmV3V2l0aFNldHRpbmdzKFRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAg Z19hc3NlcnQoIXdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2phdmFzY3JpcHQoc2V0dGluZ3Mu Z2V0KCkpKTsKICAgICBnX2Fzc2VydCghd2Via2l0X3NldHRpbmdzX2dldF9hdXRvX2xvYWRfaW1h Z2VzKHNldHRpbmdzLmdldCgpKSk7CiAgICAgZ19hc3NlcnQod2Via2l0X3NldHRpbmdzX2dldF9s b2FkX2ljb25zX2lnbm9yaW5nX2ltYWdlX2xvYWRfc2V0dGluZyhzZXR0aW5ncy5nZXQoKSkpOwot I2VuZGlmCiB9CiAKIHZvaWQgYmVmb3JlQWxsKCkK