70131 2011-10-14 12:12:42 -0700 [Qt] Enable fullscreen api on Qt 2011-10-19 06:35:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70111 70132 1 cshu cshu hausmann laszlo.gombos ossy webkit.review.bot oldest_to_newest 484157 0 cshu 2011-10-14 12:12:42 -0700 The feature was partially compiled because of flaw in features.pri. 484172 1 111048 cshu 2011-10-14 12:22:00 -0700 Created attachment 111048 patch 1 484349 2 111048 webkit.review.bot 2011-10-14 15:16:54 -0700 Comment on attachment 111048 patch 1 Clearing flags on attachment: 111048 Committed r97518: <http://trac.webkit.org/changeset/97518> 484350 3 webkit.review.bot 2011-10-14 15:16:59 -0700 All reviewed patches have been landed. Closing bug. 486684 4 hausmann 2011-10-19 05:07:42 -0700 Hmm, why do we enable this compile flag when we don't actually implement support for it? 486709 5 cshu 2011-10-19 06:02:21 -0700 (In reply to comment #4) > Hmm, why do we enable this compile flag when we don't actually implement support for it? Before the patch, the flag was partially enabled: ENABLE_FULLSCREEN_API was set to 1 but FEATURE_DEFINES_JAVASCRIPT was not set properly. It looked more like a bug to me than something did intentionally. We should either remove them completely or finish the rest of the support. 486713 6 hausmann 2011-10-19 06:07:58 -0700 I think your patch was good because it fixed that inconsistency (between the build flags and the idl generator defines). But perhaps we should change the default to be false. What do you think? 486732 7 cshu 2011-10-19 06:35:01 -0700 (In reply to comment #6) > I think your patch was good because it fixed that inconsistency (between the build flags and the idl generator defines). But perhaps we should change the default to be false. What do you think? That makes sense. I may not be able to continue this effort in the short term. I will provide a patch to disable them. 111048 2011-10-14 12:22:00 -0700 2011-10-14 15:16:54 -0700 patch 1 70131_1.patch text/plain 5385 cshu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NDg5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAtMTQgIENoYW5nIFNo dSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIEVuYWJsZSBmdWxsc2NyZWVuIGFw aSBvbiBRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzAxMzEKKworICAgICAgICBBcyBhIHJlc3VsdCwgd2UgaGF2ZSAzIHBhc3NlZCB0ZXN0cy4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZlYXR1cmVz LnByaToKKwogMjAxMS0xMC0xNCAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgRG9uJ3QgYXNzZXJ0IHRoYXQgQ1NTUnVsZXMgYXJlIENTU1J1bGVzLgpJbmRleDog U291cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2ZlYXR1cmVzLnByaQkocmV2aXNpb24gOTc0NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9mZWF0dXJl cy5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTE3Niw5ICsxNzYsNyBAQCBzeW1iaWFufG1hZW1vNXxt YWVtbzYgewogICAgIH0KIH0KIAotd2Via2l0MiB7Ci0gICAgIWNvbnRhaW5zKERFRklORVMsIEVO QUJMRV9GVUxMU0NSRUVOX0FQST0uKTogREVGSU5FUyArPSBFTkFCTEVfRlVMTFNDUkVFTl9BUEk9 MQotfQorIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9GVUxMU0NSRUVOX0FQST0uKTogREVGSU5F UyArPSBFTkFCTEVfRlVMTFNDUkVFTl9BUEk9MQogCiAjIyBGb3J3YXJkIGVuYWJsZWQgZmVhdHVy ZSBtYWNyb3MgdG8gSmF2YVNjcmlwdCBlbmFibGVkIGZlYXR1cmVzIG1hY3JvcwogRkVBVFVSRV9E RUZJTkVTX0pBVkFTQ1JJUFQgPSBMQU5HVUFHRV9KQVZBU0NSSVBUPTEKQEAgLTIxNCw2ICsyMTIs NyBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfTUVESUFfU1RBVElTVElDCiBjb250YWlucyhE RUZJTkVTLCBFTkFCTEVfTUVESUFfU1RSRUFNPTEpOiBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQ VCArPSBFTkFCTEVfTUVESUFfU1RSRUFNPTEKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9WSURF T19UUkFDSz0xKTogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxFX1ZJREVPX1RS QUNLPTEKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBX1RSQU5TRkVSX0lURU1TPTEpOiBG RUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfREFUQV9UUkFOU0ZFUl9JVEVNUz0x Citjb250YWlucyhERUZJTkVTLCBFTkFCTEVfRlVMTFNDUkVFTl9BUEk9MSk6IEZFQVRVUkVfREVG SU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9GVUxMU0NSRUVOX0FQST0xCiAKICMgVXNlZCB0byBj b21wdXRlIGRlZmF1bHRzIGZvciB0aGUgYnVpbGQtd2Via2l0IHNjcmlwdAogIyBEb24ndCBwbGFj ZSBhbnl0aGluZyBhZnRlciB0aGlzIQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTc0ODkpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0x MC0xNCAgQ2hhbmcgU2h1ICA8Y3NodUB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gRW5hYmxl IGZ1bGxzY3JlZW4gYXBpIG9uIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MDEzMQorCisgICAgICAgIEFzIGEgcmVzdWx0LCB3ZSBoYXZlIDMgcGFz c2VkIHRlc3RzLgorICAgICAgICBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWFwaS5odG1sCisgICAg ICAgIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLW5vdC1hbGxvd2VkLmh0bWwKKyAgICAg ICAgZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtYW5jZXN0b3ItZHVyaW5nLXRyYW5zaXRp b24uaHRtbAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vcXQtd2syL1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBl ZDoKKwogMjAxMS0xMC0xNCAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtDaHJvbWl1bV0gVXBkYXRlIGV4cGVjdGF0aW9ucyBhZnRlciByOTc0ODEu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBlZAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBlZAkocmV2aXNpb24gOTc0NjMpCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAt MjQwLDE1ICsyNDAsNiBAQCBzdmcvVzNDLVNWRy0xLjEvc3RydWN0LWNvbmQtMDItdC5zdmcKIGh0 dHAvdGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2xv Z291dC5odG1sCiAKLSMgV2ViS2l0MiBuZWVkcyBmdWxsc2NyZWVuIHN1cHBvcnQKLWZ1bGxzY3Jl ZW4vZnVsbC1zY3JlZW4tY3NzLmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLWFs bG93ZWQuaHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtbm90LWFsbG93ZWQuaHRt bAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtYW5jZXN0b3IuaHRtbAotZnVsbHNjcmVl bi9mdWxsLXNjcmVlbi1yZW1vdmUuaHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZXF1ZXN0 Lmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tdHdpY2UuaHRtbAotCiAjIFVuZXhwbGFpbmVk IGZhaWx1cmVzIHRoYXQgd2VyZSBmb3JtZXJseSBpbiB0aGUgc2V0Q2FuT3BlbldpbmRvd3Mgb3Ig c2V0Q2xvc2VSZW1haW5pbmdXaW5kb3dzV2hlbkNvbXBsZXRlIGxpc3RzLgogaHR0cC90ZXN0cy9z ZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtY2FsbC5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5 L2ZyYW1lTmF2aWdhdGlvbi9vcGVuZXIuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CShyZXZpc2lvbiA5NzQ2MykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHdv cmtpbmcgY29weSkKQEAgLTY1LDEwICs2NSw2IEBAIGZhc3QvbG9hZGVyL3N0b3AtcHJvdmlzaW9u YWwtbG9hZHMuaHRtbAogIyAgICAgICBEaXNhYmxlZCBmZWF0dXJlcy4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIwogIyA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0gIwogCi0jIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkgaXMgZGlzYWJsZWQuCi1mdWxsc2NyZWVu Ci1wbHVnaW5zL2Z1bGxzY3JlZW4tcGx1Z2lucy1kb250LXJlbG9hZC5odG1sCi0KICMgRU5BQkxF KElOUFVUX0NPTE9SKSBpcyBkaXNhYmxlZC4KIGZhc3QvZm9ybXMvY29sb3IKIApAQCAtMjM2LDYg KzIzMiwzMyBAQCBodHRwL3Rlc3RzL211bHRpcGFydAogIyBIaURQSSB0ZXN0cyByZXF1aXJlIHRl c3QgaW5mcmFzdHJ1Y3R1cmUgZW5oYW5jZW1lbnRzCiBmYXN0L2hpZHBpCiAKKyMgW1F0XSBRdFdl YktpdCBuZWVkcyBmdWxsc2NyZWVuIGFwaSBzdXBwb3J0CisjIDxodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAxMzI+CitmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNhbmNl bC5odG1sCitmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWNzcy5odG1sCitmdWxsc2NyZWVuL2Z1bGwt c2NyZWVuLWZyYW1lc2V0Lmh0bWwKK2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLWFsbG93 ZWQuaHRtbAorZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtbGVnYWN5Lmh0bWwKK2Z1bGxz Y3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLXpJbmRleC5odG1sCitmdWxsc2NyZWVuL2Z1bGwtc2Ny ZWVuLWtleWJvYXJkLWRpc2FibGVkLmh0bWwKK2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4ta2V5Ym9h cmQtZW5hYmxlZC5odG1sCitmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXBsYWNlaG9sZGVyLmh0bWwK K2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcmVtb3ZlLWFuY2VzdG9yLWFmdGVyLmh0bWwKK2Z1bGxz Y3JlZW4vZnVsbC1zY3JlZW4tcmVtb3ZlLWFuY2VzdG9yLmh0bWwKK2Z1bGxzY3JlZW4vZnVsbC1z Y3JlZW4tcmVtb3ZlLWNoaWxkcmVuLmh0bWwKK2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcmVtb3Zl Lmh0bWwKK2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcmVtb3ZlLXNpYmxpbmcuaHRtbAorZnVsbHNj cmVlbi9mdWxsLXNjcmVlbi1yZW5kZXItaW5saW5lLmh0bWwKK2Z1bGxzY3JlZW4vZnVsbC1zY3Jl ZW4tcmVxdWVzdC5odG1sCitmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXN0YWNraW5nLWNvbnRleHQu aHRtbAorZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi10d2ljZS5odG1sCitmdWxsc2NyZWVuL2Z1bGwt c2NyZWVuLXpJbmRleC1hZnRlci5odG1sCitmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXpJbmRleC5o dG1sCitmdWxsc2NyZWVuL3BhcmVudC1mbG93LWlubGluZS13aXRoLWJsb2NrLWNoaWxkLmh0bWwK K2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUuaHRtbAorZnVsbHNjcmVlbi92aWRl by1zcGVjaWZpZWQtc2l6ZS5odG1sCitwbHVnaW5zL2Z1bGxzY3JlZW4tcGx1Z2lucy1kb250LXJl bG9hZC5odG1sCisKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKICMgICAgICAgRHJhZyBhbmQgRHJv cCBTdXBwb3J0IGluIERSVC4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICMKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09ICMK