70098 2011-10-14 04:54:26 -0700 [TexMap][QT] The BGRA32PremultimpliedBuffer should not inherit the RefCounted class. 2011-10-17 19:24:42 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 dongseong.hwang webkit-unassigned noam webkit.review.bot oldest_to_newest 483908 0 dongseong.hwang 2011-10-14 04:54:26 -0700 TextureMapperGL has BGRA32PremultimpliedBuffer using OwnPtr, not PefPtr. It causes following assertion fail, RefCountedBase::m_deletionHasBegun. 483912 1 110994 dongseong.hwang 2011-10-14 04:59:22 -0700 Created attachment 110994 patch 483976 2 110994 noam 2011-10-14 07:45:14 -0700 Comment on attachment 110994 patch I understand the problem, but I believe that this is not the right solution. The right solution would be to make it not RefCounted, unless you have reasons otherwise. 485190 3 111271 dongseong.hwang 2011-10-17 09:04:56 -0700 Created attachment 111271 patch I agree with you. 485194 4 webkit.review.bot 2011-10-17 09:08:11 -0700 Attachment 111271 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485608 5 dongseong.hwang 2011-10-17 16:21:25 -0700 I've checked 'check-webkit-style'. Why does Chromium bot fail style test? 485650 6 noam 2011-10-17 17:11:56 -0700 (In reply to comment #5) > I've checked 'check-webkit-style'. > Why does Chromium bot fail style test? flaky bots. ignore... 485747 7 111271 webkit.review.bot 2011-10-17 19:24:38 -0700 Comment on attachment 111271 patch Clearing flags on attachment: 111271 Committed r97703: <http://trac.webkit.org/changeset/97703> 485748 8 webkit.review.bot 2011-10-17 19:24:42 -0700 All reviewed patches have been landed. Closing bug. 110994 2011-10-14 04:59:22 -0700 2011-10-17 09:05:54 -0700 patch 0001-TexMap-QT-Prevent-a-RefCounted-object-from-using-Own.patch text/plain 3541 dongseong.hwang RnJvbSBkNDkxZGM0M2M3Y2ZmYzA3NjJmZDYyODc3MWI1OGFlZmIxOTVkMzMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFRodSwgMTMgT2N0IDIwMTEgMTI6MTQ6MzggKzA5MDAKU3ViamVjdDogW1BBVENI XSBbVGV4TWFwXVtRVF0gUHJldmVudCBhIFJlZkNvdW50ZWQgb2JqZWN0IGZyb20gdXNpbmcgT3du UHRyIGluIFRleE1hcC4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MDA5OAoKVGV4dHVyZU1hcHBlckdMIGhhcyBCR1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlciB1c2lu ZyBPd25QdHIsIG5vdCBSZWZQdHIuCkl0IGNhdXNlcyBmb2xsb3dpbmcgYXNzZXJ0aW9uIGZhaWws IFJlZkNvdW50ZWRCYXNlOjptX2RlbGV0aW9uSGFzQmVndW4uCi0tLQogU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysr KwogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZXh0dXJlTWFwcGVyR0wuY3BwICAgfCAg ICAyICstCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL1RleHR1cmVNYXBwZXJHTC5oICAg ICB8ICAgIDIgKy0KIC4uLi9wbGF0Zm9ybS9ncmFwaGljcy9xdC9UZXh0dXJlTWFwcGVyUXQuY3Bw ICAgICAgIHwgICAgNCArKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDMxOTc5OTAuLmIyMDZhZjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAxMS0xMC0xNCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBj b21wYW55MTAwLm5ldD4KKworICAgICAgICBbVGV4TWFwXVtRVF0gUHJldmVudCBhIFJlZkNvdW50 ZWQgb2JqZWN0IGZyb20gdXNpbmcgT3duUHRyIGluIFRleE1hcC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDk4CisKKyAgICAgICAgVGV4dHVyZU1h cHBlckdMIGhhcyBCR1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlciB1c2luZyBPd25QdHIsIG5vdCBS ZWZQdHIuCisgICAgICAgIEl0IGNhdXNlcyBmb2xsb3dpbmcgYXNzZXJ0aW9uIGZhaWwsIFJlZkNv dW50ZWRCYXNlOjptX2RlbGV0aW9uSGFzQmVndW4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVy ZU1hcHBlckdMLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVy ZU1hcHBlckdMLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVGV4dHVyZU1hcHBl clF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJHUkEzMlByZW11bHRpbXBsaWVkQnVmZmVyOjpj cmVhdGUpOgorCiAyMDExLTEwLTE0ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29t PgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10gQ2hhbmdlIC13ZWJraXQtZmxvdyB0byAtd2Via2l0 LWZsb3ctaW50bwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL1RleHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCA4YzhiZjAxLi44ZWM5ZGQ4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVy ZU1hcHBlckdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvVGV4dHVyZU1hcHBlckdMLmNwcApAQCAtMjY2LDcgKzI2Niw3IEBAIHByaXZhdGU6CiAgICAg RmxvYXRTaXplIG1fcmVsYXRpdmVTaXplOwogICAgIGJvb2wgbV9vcGFxdWU7CiAgICAgSW50U2l6 ZSBtX3RleHR1cmVTaXplOwotICAgIE93blB0cjxCR1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlcj4g bV9idWZmZXI7CisgICAgUmVmUHRyPEJHUkEzMlByZW11bHRpbXBsaWVkQnVmZmVyPiBtX2J1ZmZl cjsKICAgICBJbnRSZWN0IG1fZGlydHlSZWN0OwogICAgIEdMdWludCBtX2ZibzsKICAgICBHTHVp bnQgbV9yYm87CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvVGV4dHVyZU1hcHBlckdMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdMLmgKaW5kZXggM2Q0ODk2ZS4uNDgxMTIxZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL1RleHR1cmVNYXBw ZXJHTC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZXh0 dXJlTWFwcGVyR0wuaApAQCAtNjksNyArNjksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBQbGF0 Zm9ybUdyYXBoaWNzQ29udGV4dCogYmVnaW5QYWludChjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3Qs IGJvb2wgb3BhcXVlKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGVuZFBhaW50KCkgPSAwOwogICAg IHZpcnR1YWwgdm9pZCogZGF0YSgpID0gMDsKLSAgICBzdGF0aWMgUGFzc093blB0cjxCR1JBMzJQ cmVtdWx0aW1wbGllZEJ1ZmZlcj4gY3JlYXRlKCk7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8QkdS QTMyUHJlbXVsdGltcGxpZWRCdWZmZXI+IGNyZWF0ZSgpOwogfTsKIAogc3RhdGljIGlubGluZSBp bnQgbmV4dFBvd2VyT2ZUd28oaW50IG51bSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L1RleHR1cmVNYXBwZXJRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9UZXh0dXJlTWFwcGVyUXQuY3BwCmluZGV4IGY0MWE0MjEuLjBl NDVhZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1Rl eHR1cmVNYXBwZXJRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvVGV4dHVyZU1hcHBlclF0LmNwcApAQCAtMjUxLDkgKzI1MSw5IEBAIHByaXZhdGU6CiAgICAg UUltYWdlIG1faW1hZ2U7CiB9OwogCi1QYXNzT3duUHRyPEJHUkEzMlByZW11bHRpbXBsaWVkQnVm ZmVyPiBCR1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlcjo6Y3JlYXRlKCkKK1Bhc3NSZWZQdHI8QkdS QTMyUHJlbXVsdGltcGxpZWRCdWZmZXI+IEJHUkEzMlByZW11bHRpbXBsaWVkQnVmZmVyOjpjcmVh dGUoKQogewotICAgIHJldHVybiBhZG9wdFB0cihuZXcgQkdSQTMyUHJlbXVsdGltcGxpZWRCdWZm ZXJRdCgpKTsKKyAgICByZXR1cm4gYWRvcHRSZWYobmV3IEJHUkEzMlByZW11bHRpbXBsaWVkQnVm ZmVyUXQoKSk7CiB9CiAKIHVpbnQ2NF90IHVpZEZvckltYWdlKEltYWdlKiBpbWFnZSkKLS0gCjEu Ny40LjEKCg== 111271 2011-10-17 09:04:56 -0700 2011-10-17 19:24:38 -0700 patch 0001-TexMap-QT-The-BGRA32PremultimpliedBuffer-should-not-.patch text/plain 2475 dongseong.hwang RnJvbSBkZDIwNjhjNzQ2YzE2YTg5NDczZmY5YWM3YmJmNzNkMmYxNGViZGEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFR1ZSwgMTggT2N0IDIwMTEgMDE6MDE6MTQgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbVGV4TWFwXVtRVF0gVGhlIEJHUkEzMlByZW11bHRpbXBsaWVkQnVmZmVyIHNob3VsZCBub3QK IGluaGVyaXQgdGhlIFJlZkNvdW50ZWQgY2xhc3MuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzAwOTgKClRoZSBCaXRtYXBUZXh0dXJlIGhhcyBhIEJHUkEzMlByZW11 bHRpbXBsaWVkQnVmZmVyIG9iamVjdCB1c2luZyBPd25QdHIsIG5vdCBSZWZQdHIuCkl0IGNhdXNl cyBmb2xsb3dpbmcgYXNzZXJ0aW9uIGZhaWwsIFJlZkNvdW50ZWRCYXNlOjptX2RlbGV0aW9uSGFz QmVndW4uCkl0IGlzIGJldHRlciB0aGF0IHRoZSBCR1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlciBk b2VzIG5vdCBpbmhlcml0IHRoZSBSZWZDb3VudGVkCmJlY2F1c2UgdGhlIEJpdG1hcFRleHR1cmUg b25seSBoYXMgYW5kIHVzZXMgYSBCR1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlciBvYmplY3QuCi0t LQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDE0ICsrKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL1RleHR1cmVN YXBwZXJHTC5oICAgICB8ICAgIDMgKystCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY0MzM2MGEuLjM0MmYzNGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0xMC0xNyAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0 ZWxsYUBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBbVGV4TWFwXVtRVF0gVGhlIEJHUkEzMlBy ZW11bHRpbXBsaWVkQnVmZmVyIHNob3VsZCBub3QgaW5oZXJpdCB0aGUgUmVmQ291bnRlZCBjbGFz cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDk4 CisKKyAgICAgICAgVGhlIEJpdG1hcFRleHR1cmUgaGFzIGEgQkdSQTMyUHJlbXVsdGltcGxpZWRC dWZmZXIgb2JqZWN0IHVzaW5nIE93blB0ciwgbm90IFJlZlB0ci4KKyAgICAgICAgSXQgY2F1c2Vz IGZvbGxvd2luZyBhc3NlcnRpb24gZmFpbCwgUmVmQ291bnRlZEJhc2U6Om1fZGVsZXRpb25IYXNC ZWd1bi4KKyAgICAgICAgSXQgaXMgYmV0dGVyIHRoYXQgdGhlIEJHUkEzMlByZW11bHRpbXBsaWVk QnVmZmVyIGRvZXMgbm90IGluaGVyaXQgdGhlIFJlZkNvdW50ZWQKKyAgICAgICAgYmVjYXVzZSB0 aGUgQml0bWFwVGV4dHVyZSBvbmx5IGhhcyBhbmQgdXNlcyBhIEJHUkEzMlByZW11bHRpbXBsaWVk QnVmZmVyIG9iamVjdC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZXh0dXJlTWFwcGVyR0wuaDoKKwog MjAxMS0xMC0xMiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXggaGFuZGxpbmcgb2Ygc291cmNlIG1hcHBpbmcgZW50 cmllcyB3aXRoIG5vIG1hcHBpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdMLmgKaW5kZXggM2Q0ODk2ZS4uNmY0 YzI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Blbmds L1RleHR1cmVNYXBwZXJHTC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L29wZW5nbC9UZXh0dXJlTWFwcGVyR0wuaApAQCAtNjMsNyArNjMsOCBAQCBwcml2YXRlOgogfTsK IAogLy8gQW4gb2Zmc2NyZWVuIGJ1ZmZlciB0byBiZSByZW5kZXJlZCBieSBzb2Z0d2FyZS4KLWNs YXNzIEJHUkEzMlByZW11bHRpbXBsaWVkQnVmZmVyIDogcHVibGljIFJlZkNvdW50ZWQ8QkdSQTMy UHJlbXVsdGltcGxpZWRCdWZmZXI+IHsKK2NsYXNzIEJHUkEzMlByZW11bHRpbXBsaWVkQnVmZmVy IHsKKyAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5C R1JBMzJQcmVtdWx0aW1wbGllZEJ1ZmZlcigpIHsgfQogICAgIHZpcnR1YWwgUGxhdGZvcm1HcmFw aGljc0NvbnRleHQqIGJlZ2luUGFpbnQoY29uc3QgSW50UmVjdCYgZGlydHlSZWN0LCBib29sIG9w YXF1ZSkgPSAwOwotLSAKMS43LjUuNAoK