70096 2011-10-14 02:40:05 -0700 DFG JIT 32_64 - Performance fix for ResolveGlobal 2011-10-14 10:22:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 483871 0 yuqiang.xian 2011-10-14 02:40:05 -0700 Check structure of global object should be a pointer comparison instead of tag and payload pair comparison. This fix improves SunSpider by 7% on Linux 32, with bitops-bitwise-and improved by 4.75X. 483875 1 110986 yuqiang.xian 2011-10-14 02:47:30 -0700 Created attachment 110986 the patch Also two trivial fixes for successful 32-bit build are included. 484049 2 110986 webkit.review.bot 2011-10-14 10:22:45 -0700 Comment on attachment 110986 the patch Clearing flags on attachment: 110986 Committed r97477: <http://trac.webkit.org/changeset/97477> 484050 3 webkit.review.bot 2011-10-14 10:22:49 -0700 All reviewed patches have been landed. Closing bug. 110986 2011-10-14 02:47:30 -0700 2011-10-14 10:22:45 -0700 the patch 70096.patch text/plain 4062 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc0NTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTEtMTAtMTQgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgREZHIEpJVCAzMl82NCAtIFBlcmZvcm1hbmNlIGZpeCBmb3IgUmVzb2x2ZUdsb2JhbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAwOTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdHJ1Y3R1cmUg Y2hlY2sgb2YgZ2xvYmFsIG9iamVjdCBzaG91bGQgYmUgYSBwb2ludGVyIGNvbXBhcmlzb24KKyAg ICAgICAgaW5zdGVhZCBvZiBhIHRhZyBhbmQgcGF5bG9hZCBwYWlyIGNvbXBhcmlzb24uIFRoaXMg Zml4IGltcHJvdmVzCisgICAgICAgIFN1blNwaWRlciBieSA3JSBvbiBMaW51eCAzMiwgd2l0aCBi aXRvcHMtYml0d2lzZS1hbmQgaW1wcm92ZWQgYnkgNC43NVguCisgICAgICAgIEFsc28gdHdvIHRy aXZpYWwgZml4ZXMgZm9yIHN1Y2Nlc3NmdWwgMzItYml0IGJ1aWxkIGFyZSBpbmNsdWRlZC4KKwor ICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgICogZGZnL0RGR1Nw ZWN1bGF0aXZlSklUMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklU Ojpjb21waWxlKToKKwogMjAxMS0xMC0xMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIFNwZWN1bGF0aW9uIGZhaWx1cmVzIGluIFZhbHVlVG9JbnQzMiBhcmUgY2F1 c2luZyBhIDJ4IHNsb3ctZG93bgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCShyZXZpc2lvbiA5NzQ1NCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTg1NCw3ICs4NTQsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxl KE5vZGUmIG5vZGUpCiAgICAgfQogCiAgICAgY2FzZSBWYWx1ZVRvSW50MzI6IHsKLSAgICAgICAg Y29tcGlsZVZhbHVlVG9JbnQzMihub2RlLmNoaWxkMSgpKTsKKyAgICAgICAgY29tcGlsZVZhbHVl VG9JbnQzMihub2RlKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogCkBAIC0yMzMyLDE1ICsyMzMy LDEyIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAg Ly8gQ2hlY2sgU3RydWN0dXJlIG9mIGdsb2JhbCBvYmplY3QKICAgICAgICAgbV9qaXQubW92ZShK SVRDb21waWxlcjo6VHJ1c3RlZEltbVB0cihtX2ppdC5jb2RlQmxvY2soKS0+Z2xvYmFsT2JqZWN0 KCkpLCBnbG9iYWxPYmplY3RHUFIpOwogICAgICAgICBtX2ppdC5tb3ZlKEpJVENvbXBpbGVyOjpU cnVzdGVkSW1tUHRyKHJlc29sdmVJbmZvQWRkcmVzcyksIHJlc29sdmVJbmZvR1BSKTsKLSAgICAg ICAgbV9qaXQubG9hZDMyKEpJVENvbXBpbGVyOjpBZGRyZXNzKHJlc29sdmVJbmZvR1BSLCBPQkpF Q1RfT0ZGU0VUT0YoR2xvYmFsUmVzb2x2ZUluZm8sIHN0cnVjdHVyZSkgKyBPQkpFQ1RfT0ZGU0VU T0YoRW5jb2RlZFZhbHVlRGVzY3JpcHRvciwgYXNCaXRzLnRhZykpLCByZXN1bHRUYWdHUFIpOwot ICAgICAgICBtX2ppdC5sb2FkMzIoSklUQ29tcGlsZXI6OkFkZHJlc3MocmVzb2x2ZUluZm9HUFIs IE9CSkVDVF9PRkZTRVRPRihHbG9iYWxSZXNvbHZlSW5mbywgc3RydWN0dXJlKSArIE9CSkVDVF9P RkZTRVRPRihFbmNvZGVkVmFsdWVEZXNjcmlwdG9yLCBhc0JpdHMucGF5bG9hZCkpLCByZXN1bHRQ YXlsb2FkR1BSKTsKKyAgICAgICAgbV9qaXQubG9hZFB0cihKSVRDb21waWxlcjo6QWRkcmVzcyhy ZXNvbHZlSW5mb0dQUiwgT0JKRUNUX09GRlNFVE9GKEdsb2JhbFJlc29sdmVJbmZvLCBzdHJ1Y3R1 cmUpKSwgcmVzdWx0UGF5bG9hZEdQUik7CiAKLSAgICAgICAgSklUQ29tcGlsZXI6Okp1bXBMaXN0 IHN0cnVjdHVyZXNOb3RNYXRjaDsKLSAgICAgICAgc3RydWN0dXJlc05vdE1hdGNoLmFwcGVuZCht X2ppdC5icmFuY2gzMihKSVRDb21waWxlcjo6Tm90RXF1YWwsIHJlc3VsdFRhZ0dQUiwgSklUQ29t cGlsZXI6OkFkZHJlc3MoZ2xvYmFsT2JqZWN0R1BSLCBKU0NlbGw6OnN0cnVjdHVyZU9mZnNldCgp ICsgT0JKRUNUX09GRlNFVE9GKEVuY29kZWRWYWx1ZURlc2NyaXB0b3IsIGFzQml0cy50YWcpKSkp OwotICAgICAgICBzdHJ1Y3R1cmVzTm90TWF0Y2guYXBwZW5kKG1faml0LmJyYW5jaDMyKEpJVENv bXBpbGVyOjpOb3RFcXVhbCwgcmVzdWx0UGF5bG9hZEdQUiwgSklUQ29tcGlsZXI6OkFkZHJlc3Mo Z2xvYmFsT2JqZWN0R1BSLCBKU0NlbGw6OnN0cnVjdHVyZU9mZnNldCgpICsgT0JKRUNUX09GRlNF VE9GKEVuY29kZWRWYWx1ZURlc2NyaXB0b3IsIGFzQml0cy5wYXlsb2FkKSkpKTsKKyAgICAgICAg SklUQ29tcGlsZXI6Okp1bXAgc3RydWN0dXJlc05vdE1hdGNoID0gbV9qaXQuYnJhbmNoUHRyKEpJ VENvbXBpbGVyOjpOb3RFcXVhbCwgcmVzdWx0UGF5bG9hZEdQUiwgSklUQ29tcGlsZXI6OkFkZHJl c3MoZ2xvYmFsT2JqZWN0R1BSLCBKU0NlbGw6OnN0cnVjdHVyZU9mZnNldCgpKSk7CiAKICAgICAg ICAgLy8gRmFzdCBjYXNlCi0gICAgICAgIG1faml0LmxvYWQzMihKSVRDb21waWxlcjo6QWRkcmVz cyhnbG9iYWxPYmplY3RHUFIsIEpTT2JqZWN0OjpvZmZzZXRPZlByb3BlcnR5U3RvcmFnZSgpKSwg cmVzdWx0UGF5bG9hZEdQUik7CisgICAgICAgIG1faml0LmxvYWRQdHIoSklUQ29tcGlsZXI6OkFk ZHJlc3MoZ2xvYmFsT2JqZWN0R1BSLCBKU09iamVjdDo6b2Zmc2V0T2ZQcm9wZXJ0eVN0b3JhZ2Uo KSksIHJlc3VsdFBheWxvYWRHUFIpOwogICAgICAgICBtX2ppdC5sb2FkMzIoSklUQ29tcGlsZXI6 OkFkZHJlc3MocmVzb2x2ZUluZm9HUFIsIE9CSkVDVF9PRkZTRVRPRihHbG9iYWxSZXNvbHZlSW5m bywgb2Zmc2V0KSksIHJlc29sdmVJbmZvR1BSKTsKICAgICAgICAgbV9qaXQubG9hZDMyKEpJVENv bXBpbGVyOjpCYXNlSW5kZXgocmVzdWx0UGF5bG9hZEdQUiwgcmVzb2x2ZUluZm9HUFIsIEpJVENv bXBpbGVyOjpUaW1lc0VpZ2h0LCBPQkpFQ1RfT0ZGU0VUT0YoRW5jb2RlZFZhbHVlRGVzY3JpcHRv ciwgYXNCaXRzLnRhZykpLCByZXN1bHRUYWdHUFIpOwogICAgICAgICBtX2ppdC5sb2FkMzIoSklU Q29tcGlsZXI6OkJhc2VJbmRleChyZXN1bHRQYXlsb2FkR1BSLCByZXNvbHZlSW5mb0dQUiwgSklU Q29tcGlsZXI6OlRpbWVzRWlnaHQsIE9CSkVDVF9PRkZTRVRPRihFbmNvZGVkVmFsdWVEZXNjcmlw dG9yLCBhc0JpdHMucGF5bG9hZCkpLCByZXN1bHRQYXlsb2FkR1BSKTsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiA5 NzQ1NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSwxMCBAQAogCiAjaWYgRU5BQkxFKERGR19KSVQp CiAKKyNpZiBVU0UoSlNWQUxVRTMyXzY0KQorI2luY2x1ZGUgIkRGR0pJVENvbXBpbGVySW5saW5l TWV0aG9kcy5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIAog I2lmbmRlZiBOREVCVUcK