70092 2011-10-14 00:02:05 -0700 [GTK] r97438: Inconsistent use of flattening vs flattering in function names/comments 2011-10-14 10:03:35 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 plaes webkit-unassigned mrobinson nayankk webkit.review.bot oldest_to_newest 483808 0 plaes 2011-10-14 00:02:05 -0700 Patch landed in r97438 uses inconsistently both flattening and flattering (PROP_ENABLE_FRAME_FLATTERING) and giving a wild shot I guess the variant with 'r' is wrong. 483817 1 mrobinson 2011-10-14 00:25:53 -0700 Thanks for catch that. Flattening is indeed the correct spelling. 483910 2 110993 nayankk 2011-10-14 04:54:40 -0700 Created attachment 110993 Property name correction. Thanks for this catch. Attached is the patch to correct the spelling as 'FLATTENING'. 484034 3 110993 webkit.review.bot 2011-10-14 10:03:30 -0700 Comment on attachment 110993 Property name correction. Clearing flags on attachment: 110993 Committed r97474: <http://trac.webkit.org/changeset/97474> 484035 4 webkit.review.bot 2011-10-14 10:03:35 -0700 All reviewed patches have been landed. Closing bug. 110993 2011-10-14 04:54:40 -0700 2011-10-14 10:03:30 -0700 Property name correction. 0001-Property-name-correction.patch text/plain 4347 nayankk RnJvbSBkM2ZkZTM0YjIwMTIzNmU3YTBmN2VjODlkOThlYTJiNjk4OGNlZjE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXlhbiBLdW1hciBLIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4K RGF0ZTogRnJpLCAxNCBPY3QgMjAxMSAxNzoyMjowNiArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIFBy b3BlcnR5IG5hbWUgY29ycmVjdGlvbgoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcCAgIHwgICAgOCArKysrLS0t LQogLi4uL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAgfCAg ICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCmluZGV4IDk5MmRjYjYuLmY1MzYxYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxMS0xMC0xNCAgTmF5YW4gS3VtYXIgSyAgPG5heWFua2tAbW90b3JvbGEuY29tPgor CisgICAgICAgIFtHVEtdIHI5NzQzODogSW5jb25zaXN0ZW50IHVzZSBvZiBmbGF0dGVuaW5nIHZz IGZsYXR0ZXJpbmcgaW4gZnVuY3Rpb24gbmFtZXMvY29tbWVudHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDkyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgdGhlIG1pc3Mtc3BlbGxpbmcgb2Yg J1BST1BfRU5BQkxFX0ZSQU1FX0ZMQVRURU5JTkcnIGFzICdQUk9QX0VOQUJMRV9GUkFNRV9GTEFU VEVSSU5HJworICAgICAgICBpbnRyb2R1Y2VkIHdpdGggY2hhbmdlIHNldCByOTc0MzguCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3 ZWJLaXRTZXR0aW5nc1NldFByb3BlcnR5KTogUHJvcGVydHkgbmFtZSBjb3JyZWN0aW9uLgorICAg ICAgICAod2ViS2l0U2V0dGluZ3NHZXRQcm9wZXJ0eSk6IFByb3BlcnR5IG5hbWUgY29ycmVjdGlv bi4KKyAgICAgICAgKHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KTogUHJvcGVydHkgbmFtZSBj b3JyZWN0aW9uLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRT ZXR0aW5ncy5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0U2V0dGluZ3MpOiBTcGVsbGluZyBjb3Jy ZWN0aW9uLgorCiAyMDExLTEwLTEzICBOYXlhbiBLdW1hciBLICA8bmF5YW5ra0Btb3Rvcm9sYS5j b20+CiAKICAgICAgICAgW0dUS11bV0VCS0lUMl0gQWRkIFdlYktpdFNldHRpbmdzIEdUSysgQVBJ LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0 dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGlu Z3MuY3BwCmluZGV4IGMyZGNkM2EuLmVjZTYzNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTcxLDcgKzcxLDcgQEAg ZW51bSB7CiAgICAgUFJPUF9FTkFCTEVfSFRNTDVfTE9DQUxfU1RPUkFHRSwKICAgICBQUk9QX0VO QUJMRV9IVE1MNV9EQVRBQkFTRSwKICAgICBQUk9QX0VOQUJMRV9YU1NfQVVESVRPUiwKLSAgICBQ Uk9QX0VOQUJMRV9GUkFNRV9GTEFUVEVSSU5HLAorICAgIFBST1BfRU5BQkxFX0ZSQU1FX0ZMQVRU RU5JTkcsCiAgICAgUFJPUF9FTkFCTEVfUExVR0lOUywKICAgICBQUk9QX0VOQUJMRV9KQVZBLAog ICAgIFBST1BfSkFWQVNDUklQVF9DQU5fT1BFTl9XSU5ET1dTX0FVVE9NQVRJQ0FMTFksCkBAIC0x MDQsNyArMTA0LDcgQEAgc3RhdGljIHZvaWQgd2ViS2l0U2V0dGluZ3NTZXRQcm9wZXJ0eShHT2Jq ZWN0KiBvYmplY3QsIGd1aW50IHByb3BJZCwgY29uc3QgR1ZhbHUKICAgICBjYXNlIFBST1BfRU5B QkxFX1hTU19BVURJVE9SOgogICAgICAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV94c3Nf YXVkaXRvcihzZXR0aW5ncywgZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSkpOwogICAgICAgICBi cmVhazsKLSAgICBjYXNlIFBST1BfRU5BQkxFX0ZSQU1FX0ZMQVRURVJJTkc6CisgICAgY2FzZSBQ Uk9QX0VOQUJMRV9GUkFNRV9GTEFUVEVOSU5HOgogICAgICAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0 X2VuYWJsZV9mcmFtZV9mbGF0dGVuaW5nKHNldHRpbmdzLCBnX3ZhbHVlX2dldF9ib29sZWFuKHZh bHVlKSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgUFJPUF9FTkFCTEVfUExVR0lOUzoKQEAg LTE1MSw3ICsxNTEsNyBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0dldFByb3BlcnR5KEdP YmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBHVmFsdWUqIHZhbAogICAgIGNhc2UgUFJPUF9F TkFCTEVfWFNTX0FVRElUT1I6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFsdWUsIHdl YmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX3hzc19hdWRpdG9yKHNldHRpbmdzKSk7CiAgICAgICAg IGJyZWFrOwotICAgIGNhc2UgUFJPUF9FTkFCTEVfRlJBTUVfRkxBVFRFUklORzoKKyAgICBjYXNl IFBST1BfRU5BQkxFX0ZSQU1FX0ZMQVRURU5JTkc6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xl YW4odmFsdWUsIHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmcoc2V0 dGluZ3MpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX0VOQUJMRV9QTFVHSU5TOgpA QCAtMzEzLDcgKzMxMyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0 KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICoKICAgICAqLwogICAgIGdfb2JqZWN0 X2NsYXNzX2luc3RhbGxfcHJvcGVydHkoZ09iamVjdENsYXNzLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgUFJPUF9FTkFCTEVfRlJBTUVfRkxBVFRFUklORywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1BfRU5BQkxFX0ZSQU1FX0ZMQVRURU5JTkcs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVh bigiZW5hYmxlLWZyYW1lLWZsYXR0ZW5pbmciLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiRW5hYmxlIGZyYW1lIGZsYXR0ZW5pbmci KSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF8oIldoZXRoZXIgdG8gZW5hYmxlIGZyYW1lIGZsYXR0ZW5pbmcuIiksCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGlu Z3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktp dFNldHRpbmdzLmNwcAppbmRleCA0ZTFhNjgwLi4wY2UzN2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRTZXR0 aW5ncy5jcHAKQEAgLTczLDcgKzczLDcgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdFNldHRpbmdz KFRlc3QqLCBnY29uc3Rwb2ludGVyKQogICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX3hz c19hdWRpdG9yKHNldHRpbmdzLCBGQUxTRSk7CiAgICAgZ19hc3NlcnQoIXdlYmtpdF9zZXR0aW5n c19nZXRfZW5hYmxlX3hzc19hdWRpdG9yKHNldHRpbmdzKSk7CiAKLSAgICAvLyBGcmFtZSBmbGF0 dGVyaW5nIGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQuCisgICAgLy8gRnJhbWUgZmxhdHRlbmluZyBp cyBkaXNhYmxlZCBieSBkZWZhdWx0LgogICAgIGdfYXNzZXJ0KCF3ZWJraXRfc2V0dGluZ3NfZ2V0 X2VuYWJsZV9mcmFtZV9mbGF0dGVuaW5nKHNldHRpbmdzKSk7CiAgICAgd2Via2l0X3NldHRpbmdz X3NldF9lbmFibGVfZnJhbWVfZmxhdHRlbmluZyhzZXR0aW5ncywgVFJVRSk7CiAgICAgZ19hc3Nl cnQod2Via2l0X3NldHRpbmdzX2dldF9lbmFibGVfZnJhbWVfZmxhdHRlbmluZyhzZXR0aW5ncykp OwotLSAKMS43LjUuNAoK