70090 2011-10-13 23:00:46 -0700 [EFL] Remove const modifier from ctx_menu functions 2011-10-18 07:15:27 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 483772 0 g.czajkowski 2011-10-13 23:00:46 -0700 Functions ewk_context_menu_show and ewk_context_menu_custom_get have got const modifer to ensure that Ewk_Context_Menu won't be changed. The methods emit events through evas_object_smart_callback_call with Ewk_Context_Menu as parameter which is converted to void *. In this case an application which receives those events may change Ewk_Context_Menu. Additionaly the name of ewk_context_menu_custom_get has been changed to ewk_context_menu_customize because an application is able to modify the items of context menu. 483775 1 110963 g.czajkowski 2011-10-13 23:02:46 -0700 Created attachment 110963 proposed patch 483873 2 110963 gyuyoung.kim 2011-10-14 02:42:55 -0700 Comment on attachment 110963 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=110963&action=review This patch needs to rebase. > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:304 > +Ewk_Context_Menu* ewk_context_menu_customize(Ewk_Context_Menu* o) o was changed by menu. > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:319 > +void ewk_context_menu_show(Ewk_Context_Menu* o) ditto. 483888 3 110989 g.czajkowski 2011-10-14 03:22:36 -0700 Created attachment 110989 updated patch 483893 4 g.czajkowski 2011-10-14 03:30:30 -0700 (In reply to comment #2) > (From update of attachment 110963 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110963&action=review > > This patch needs to rebase. > > > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:304 > > +Ewk_Context_Menu* ewk_context_menu_customize(Ewk_Context_Menu* o) > > o was changed by menu. > > > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:319 > > +void ewk_context_menu_show(Ewk_Context_Menu* o) > > ditto. Yes, you're right. Thanks. 483902 5 110989 rakuco 2011-10-14 04:42:45 -0700 Comment on attachment 110989 updated patch Informal r+. 483904 6 110989 gyuyoung.kim 2011-10-14 04:48:49 -0700 Comment on attachment 110989 updated patch LGTM. 486038 7 110989 webkit.review.bot 2011-10-18 07:15:23 -0700 Comment on attachment 110989 updated patch Clearing flags on attachment: 110989 Committed r97749: <http://trac.webkit.org/changeset/97749> 486039 8 webkit.review.bot 2011-10-18 07:15:27 -0700 All reviewed patches have been landed. Closing bug. 110963 2011-10-13 23:02:46 -0700 2011-10-14 03:22:36 -0700 proposed patch remove_const_modifier_from_context_menu.patch text/plain 2990 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjY2IyODhlLi4zOGVkZmQ4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTEtMTAtMTIgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGNvbnN0IG1vZGlmaWVy IGZyb20gY3R4X21lbnUgZnVuY3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzAwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGdW5jdGlvbnMgZXdrX2NvbnRleHRfbWVudV9zaG93IGFuZCBld2tf Y29udGV4dF9tZW51X2N1c3RvbV9nZXQgaGF2ZSBnb3QgY29uc3QKKyAgICAgICAgbW9kaWZlciB0 byBlbnN1cmUgdGhhdCBFd2tfQ29udGV4dF9NZW51IHdvbid0IGJlIGNoYW5nZWQuIFRoZSBtZXRo b2RzIGVtaXQgZXZlbnRzCisgICAgICAgIHRocm91Z2ggZXZhc19vYmplY3Rfc21hcnRfY2FsbGJh Y2tfY2FsbCB3aXRoIEV3a19Db250ZXh0X01lbnUgYXMgcGFyYW1ldGVyIHdoaWNoCisgICAgICAg IGlzIGNvbnZlcnRlZCB0byB2b2lkICouIEluIHRoaXMgY2FzZSBhbiBhcHBsaWNhdGlvbiB3aGlj aCByZWNlaXZlcyB0aG9zZSBldmVudHMKKyAgICAgICAgbWF5IGNoYW5nZSBFd2tfQ29udGV4dF9N ZW51LgorCisgICAgICAgIEFkZGl0aW9uYWx5IHRoZSBuYW1lIG9mIGV3a19jb250ZXh0X21lbnVf Y3VzdG9tX2dldCBoYXMgYmVlbiBjaGFuZ2VkIHRvIGV3a19jb250ZXh0X21lbnVfY3VzdG9taXpl CisgICAgICAgIGJlY2F1c2UgYW4gYXBwbGljYXRpb24gaXMgYWJsZSB0byBtb2RpZnkgdGhlIGl0 ZW1zIG9mIGNvbnRleHQgbWVudS4KKworICAgICAgICAqIGV3ay9ld2tfY29udGV4dG1lbnUuY3Bw OgorICAgICAgICAoZXdrX2NvbnRleHRfbWVudV9jdXN0b21pemUpOgorICAgICAgICAoZXdrX2Nv bnRleHRfbWVudV9zaG93KToKKyAgICAgICAgKiBld2svZXdrX3ByaXZhdGUuaDoKKwogMjAxMS0x MC0xMCAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9mdXNpb24ubW9iaT4KIAogICAg ICAgICBbRUZMXSBEbyBub3QgY2FjaGUgYSBmcmFtZSdzIGNvbnRlbnRzIHNpemUuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2NvbnRleHRtZW51LmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuY3BwCmluZGV4IGFhMTYxOWYuLjRmMTIyZTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuY3BwCkBAIC0zMDEsNyAr MzAxLDcgQEAgdm9pZCBld2tfY29udGV4dF9tZW51X2l0ZW1fYXBwZW5kKEV3a19Db250ZXh0X01l bnUqIG8sIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbSYKICAqCiAgKiBAc2VlIGV3a19jb250ZXh0 X21lbnVfaXRlbV9saXN0X2dldAogICovCi1Fd2tfQ29udGV4dF9NZW51KiBld2tfY29udGV4dF9t ZW51X2N1c3RvbV9nZXQoY29uc3QgRXdrX0NvbnRleHRfTWVudSogbykKK0V3a19Db250ZXh0X01l bnUqIGV3a19jb250ZXh0X21lbnVfY3VzdG9taXplKEV3a19Db250ZXh0X01lbnUqIG8pCiB7CiAg ICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKG8sIDApOwogCkBAIC0zMTYsNyArMzE2 LDcgQEAgRXdrX0NvbnRleHRfTWVudSogZXdrX2NvbnRleHRfbWVudV9jdXN0b21fZ2V0KGNvbnN0 IEV3a19Db250ZXh0X01lbnUqIG8pCiAgKgogICogQHBhcmFtIG8gdGhlIGNvbnRleHQgbWVudSBv YmplY3QKICAqLwotdm9pZCBld2tfY29udGV4dF9tZW51X3Nob3coY29uc3QgRXdrX0NvbnRleHRf TWVudSogbykKK3ZvaWQgZXdrX2NvbnRleHRfbWVudV9zaG93KEV3a19Db250ZXh0X01lbnUqIG8p CiB7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4obyk7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19wcml2YXRlLmgKaW5kZXggZjM4OTliZC4uZmU0NzVlZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19wcml2YXRlLmgKQEAgLTE2Nyw4ICsxNjcsOCBAQCBFaW5hX0xpc3QqIGV3a19oaXN0b3J5 X2l0ZW1fY2hpbGRyZW5fZ2V0KGNvbnN0IEV3a19IaXN0b3J5X0l0ZW0qIGl0ZW0pOwogRXdrX0Nv bnRleHRfTWVudSogZXdrX2NvbnRleHRfbWVudV9uZXcoRXZhc19PYmplY3QqIHZpZXcsIFdlYkNv cmU6OkNvbnRleHRNZW51Q29udHJvbGxlciogY29udHJvbGxlcik7CiBFaW5hX0Jvb2wgZXdrX2Nv bnRleHRfbWVudV9mcmVlKEV3a19Db250ZXh0X01lbnUqIG8pOwogdm9pZCBld2tfY29udGV4dF9t ZW51X2l0ZW1fYXBwZW5kKEV3a19Db250ZXh0X01lbnUqIG8sIFdlYkNvcmU6OkNvbnRleHRNZW51 SXRlbSYgY29yZSk7Ci1Fd2tfQ29udGV4dF9NZW51KiBld2tfY29udGV4dF9tZW51X2N1c3RvbV9n ZXQoY29uc3QgRXdrX0NvbnRleHRfTWVudSogbyk7Ci12b2lkIGV3a19jb250ZXh0X21lbnVfc2hv dyhjb25zdCBFd2tfQ29udGV4dF9NZW51KiBvKTsKK0V3a19Db250ZXh0X01lbnUqIGV3a19jb250 ZXh0X21lbnVfY3VzdG9taXplKEV3a19Db250ZXh0X01lbnUqIG8pOwordm9pZCBld2tfY29udGV4 dF9tZW51X3Nob3coRXdrX0NvbnRleHRfTWVudSogbyk7CiAjZW5kaWYKIAogY29uc3QgRWluYV9S ZWN0YW5nbGUqIGV3a192aWV3X3JlcGFpbnRzX2dldChjb25zdCBFd2tfVmlld19Qcml2YXRlX0Rh dGEqIHByaXYsIHNpemVfdCogY291bnQpOwo= 110989 2011-10-14 03:22:36 -0700 2011-10-18 07:15:23 -0700 updated patch remove_const_modifier_from_context_menu.patch text/plain 3062 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA1OWVmMmM4Li4wZWM5NzcyIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTEtMTAtMTQgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGNvbnN0IG1vZGlmaWVy IGZyb20gY3R4X21lbnUgZnVuY3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzAwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGdW5jdGlvbnMgZXdrX2NvbnRleHRfbWVudV9zaG93IGFuZCBld2tf Y29udGV4dF9tZW51X2N1c3RvbV9nZXQKKyAgICAgICAgaGF2ZSBnb3QgY29uc3QgbW9kaWZlciB0 byBlbnN1cmUgdGhhdCBFd2tfQ29udGV4dF9NZW51IHdvbid0IGJlCisgICAgICAgIGNoYW5nZWQu IFRoZSBtZXRob2RzIGVtaXQgZXZlbnRzIHRocm91Z2gKKyAgICAgICAgZXZhc19vYmplY3Rfc21h cnRfY2FsbGJhY2tfY2FsbCB3aXRoIEV3a19Db250ZXh0X01lbnUgYXMgcGFyYW1ldGVyCisgICAg ICAgIHdoaWNoIGlzIGNvbnZlcnRlZCB0byB2b2lkICouIEluIHRoaXMgY2FzZSBhbiBhcHBsaWNh dGlvbiB3aGljaAorICAgICAgICByZWNlaXZlcyB0aG9zZSBldmVudHMgbWF5IGNoYW5nZSBFd2tf Q29udGV4dF9NZW51LgorCisgICAgICAgIEFkZGl0aW9uYWx5IHRoZSBuYW1lIG9mIGV3a19jb250 ZXh0X21lbnVfY3VzdG9tX2dldCBoYXMgYmVlbiBjaGFuZ2VkCisgICAgICAgIHRvIGV3a19jb250 ZXh0X21lbnVfY3VzdG9taXplIGJlY2F1c2UgYW4gYXBwbGljYXRpb24gaXMgYWJsZSB0bworICAg ICAgICBtb2RpZnkgdGhlIGl0ZW1zIG9mIGNvbnRleHQgbWVudS4KKworICAgICAgICAqIGV3ay9l d2tfY29udGV4dG1lbnUuY3BwOgorICAgICAgICAoZXdrX2NvbnRleHRfbWVudV9jdXN0b21pemUp OgorICAgICAgICAoZXdrX2NvbnRleHRfbWVudV9zaG93KToKKyAgICAgICAgKiBld2svZXdrX3By aXZhdGUuaDoKKwogMjAxMS0xMC0xMyAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9m dXNpb24ubW9iaT4KIAogICAgICAgICBbRUZMXTogTW92ZSBmcm9tIEZpbGVDaG9vc2VyU2V0dGlu Z3MgZGVwcmVjYXRlZEFjY2VwdFR5cGUgdG8gYWNjZXB0TUlNRVR5cGVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2NvbnRleHRtZW51LmNwcCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuY3BwCmluZGV4IDYyMWM3OWMuLjY5OGIyMDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuY3BwCkBAIC0zMDEsNyArMzAxLDcg QEAgdm9pZCBld2tfY29udGV4dF9tZW51X2l0ZW1fYXBwZW5kKEV3a19Db250ZXh0X01lbnUqIG1l bnUsIFdlYkNvcmU6OkNvbnRleHRNZW51SXQKICAqCiAgKiBAc2VlIGV3a19jb250ZXh0X21lbnVf aXRlbV9saXN0X2dldAogICovCi1Fd2tfQ29udGV4dF9NZW51KiBld2tfY29udGV4dF9tZW51X2N1 c3RvbV9nZXQoY29uc3QgRXdrX0NvbnRleHRfTWVudSogbWVudSkKK0V3a19Db250ZXh0X01lbnUq IGV3a19jb250ZXh0X21lbnVfY3VzdG9taXplKEV3a19Db250ZXh0X01lbnUqIG1lbnUpCiB7CiAg ICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKG1lbnUsIDApOwogCkBAIC0zMTYsNyAr MzE2LDcgQEAgRXdrX0NvbnRleHRfTWVudSogZXdrX2NvbnRleHRfbWVudV9jdXN0b21fZ2V0KGNv bnN0IEV3a19Db250ZXh0X01lbnUqIG1lbnUpCiAgKgogICogQHBhcmFtIG8gdGhlIGNvbnRleHQg bWVudSBvYmplY3QKICAqLwotdm9pZCBld2tfY29udGV4dF9tZW51X3Nob3coY29uc3QgRXdrX0Nv bnRleHRfTWVudSogbWVudSkKK3ZvaWQgZXdrX2NvbnRleHRfbWVudV9zaG93KEV3a19Db250ZXh0 X01lbnUqIG1lbnUpCiB7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4obWVudSk7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXggZTk2NmE1My4uNjY5ODUxZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTE2Nyw4ICsxNjcsOCBAQCBFaW5hX0xp c3QqIGV3a19oaXN0b3J5X2l0ZW1fY2hpbGRyZW5fZ2V0KGNvbnN0IEV3a19IaXN0b3J5X0l0ZW0q IGl0ZW0pOwogRXdrX0NvbnRleHRfTWVudSogZXdrX2NvbnRleHRfbWVudV9uZXcoRXZhc19PYmpl Y3QqIHZpZXcsIFdlYkNvcmU6OkNvbnRleHRNZW51Q29udHJvbGxlciogY29udHJvbGxlcik7CiBF aW5hX0Jvb2wgZXdrX2NvbnRleHRfbWVudV9mcmVlKEV3a19Db250ZXh0X01lbnUqIG8pOwogdm9p ZCBld2tfY29udGV4dF9tZW51X2l0ZW1fYXBwZW5kKEV3a19Db250ZXh0X01lbnUqIG8sIFdlYkNv cmU6OkNvbnRleHRNZW51SXRlbSYgY29yZSk7Ci1Fd2tfQ29udGV4dF9NZW51KiBld2tfY29udGV4 dF9tZW51X2N1c3RvbV9nZXQoY29uc3QgRXdrX0NvbnRleHRfTWVudSogbyk7Ci12b2lkIGV3a19j b250ZXh0X21lbnVfc2hvdyhjb25zdCBFd2tfQ29udGV4dF9NZW51KiBvKTsKK0V3a19Db250ZXh0 X01lbnUqIGV3a19jb250ZXh0X21lbnVfY3VzdG9taXplKEV3a19Db250ZXh0X01lbnUqIG8pOwor dm9pZCBld2tfY29udGV4dF9tZW51X3Nob3coRXdrX0NvbnRleHRfTWVudSogbyk7CiAjZW5kaWYK IAogY29uc3QgRWluYV9SZWN0YW5nbGUqIGV3a192aWV3X3JlcGFpbnRzX2dldChjb25zdCBFd2tf Vmlld19Qcml2YXRlX0RhdGEqIHByaXYsIHNpemVfdCogY291bnQpOwo=