<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>70089</bug_id>
          
          <creation_ts>2011-10-13 22:56:39 -0700</creation_ts>
          <short_desc>Speculation failures in ValueToInt32 are causing a 2x slow-down in Kraken/stanford-crypto-pbkdf2</short_desc>
          <delta_ts>2011-10-14 00:07:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>oliver</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>483771</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-10-13 22:56:39 -0700</bug_when>
    <thetext>Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483773</commentid>
    <comment_count>1</comment_count>
      <attachid>110961</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-10-13 23:01:15 -0700</bug_when>
    <thetext>Created attachment 110961
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483774</commentid>
    <comment_count>2</comment_count>
      <attachid>110962</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-10-13 23:02:35 -0700</bug_when>
    <thetext>Created attachment 110962
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483776</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-13 23:02:56 -0700</bug_when>
    <thetext>Attachment 110961 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1

Source/JavaScriptCore/dfg/DFGOperations.h:64:  DFG_OPERATION is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483778</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-13 23:04:53 -0700</bug_when>
    <thetext>Attachment 110962 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1

Source/JavaScriptCore/dfg/DFGOperations.h:64:  DFG_OPERATION is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483779</commentid>
    <comment_count>5</comment_count>
      <attachid>110962</attachid>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2011-10-13 23:05:11 -0700</bug_when>
    <thetext>Comment on attachment 110962
the patch

actually I think i see a problem</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483782</commentid>
    <comment_count>6</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2011-10-13 23:07:49 -0700</bug_when>
    <thetext>I think we need to ensure the result of the call is zero extended to fill the register.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483787</commentid>
    <comment_count>7</comment_count>
      <attachid>110968</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-10-13 23:10:53 -0700</bug_when>
    <thetext>Created attachment 110968
fixed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483789</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-13 23:15:02 -0700</bug_when>
    <thetext>Attachment 110968 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1

Source/JavaScriptCore/dfg/DFGOperations.h:64:  DFG_OPERATION is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483811</commentid>
    <comment_count>9</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-10-14 00:07:16 -0700</bug_when>
    <thetext>Landed in r97446.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>110961</attachid>
            <date>2011-10-13 23:01:15 -0700</date>
            <delta_ts>2011-10-13 23:02:35 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>fixtoint_patch_1.diff</filename>
            <type>text/plain</type>
            <size>4654</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc0NDIpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK
KzIwMTEtMTAtMTMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBT
cGVjdWxhdGlvbiBmYWlsdXJlcyBpbiBWYWx1ZVRvSW50MzIgYXJlIGNhdXNpbmcgYSAyeCBzbG93
LWRvd24KKyAgICAgICAgaW4gS3Jha2VuL3N0YW5mb3JkLWNyeXB0by1wYmtkZjIKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDg5CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB3ZSBjYW4n
dCB0cnVuY2F0ZSB0byBJbnQzMiB1c2luZyBtYWNoaW5lIGNvZGUsIHRoZW4gZG9uJ3QgZmFpbAor
ICAgICAgICBzcGVjdWxhdGlvbi4gSnVzdCBjYWxsIEpTQzo6dG9JbnQzMi4KKworICAgICAgICAq
IGRmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkRGRzo6Y2FsbE9wZXJh
dGlvbik6CisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuaDoKKyAgICAgICAgKiBkZmcvREZH
U3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpj
b21waWxlVmFsdWVUb0ludDMyKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5j
cHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDEx
LTEwLTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAg
ICAgUmVuYW1lIHZpcnR1YWwgZ2V0Q29uc3RydWN0RGF0YSB0byBnZXRDb25zdHJ1Y3REYXRhVmly
dHVhbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9y
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2Vu
ZXJhdG9yLmgJKHJldmlzaW9uIDk3NDIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E
RkdKSVRDb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNDUsNiArMTA0NSwxMyBA
QCBwcm90ZWN0ZWQ6CiAKICAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hl
Y2tTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOwogICAgIH0KKyAgICBKSVRDb21waWxlcjo6
Q2FsbCBjYWxsT3BlcmF0aW9uKFpfREZHT3BlcmF0aW9uX0Qgb3BlcmF0aW9uLCBHUFJSZWcgcmVz
dWx0LCBGUFJSZWcgYXJnMSkKKyAgICB7CisgICAgICAgIG1faml0Lm1vdmVEb3VibGUoYXJnMSwg
RlBSSW5mbzo6YXJndW1lbnRGUFIwKTsKKyAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9
IG1faml0LmFwcGVuZENhbGwob3BlcmF0aW9uKTsKKyAgICAgICAgbV9qaXQubW92ZShHUFJJbmZv
OjpyZXR1cm5WYWx1ZUdQUiwgcmVzdWx0KTsKKyAgICAgICAgcmV0dXJuIGNhbGw7CisgICAgfQog
ICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oSl9ERkdPcGVyYXRpb25fRUdJIG9w
ZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFyZzEsIHZvaWQqIHBvaW50ZXIpCiAgICAg
ewogICAgICAgICByZXR1cm4gY2FsbE9wZXJhdGlvbigoSl9ERkdPcGVyYXRpb25fRVBQKW9wZXJh
dGlvbiwgcmVzdWx0LCBhcmcxLCBwb2ludGVyKTsKQEAgLTEyNjUsNiArMTI3MiwxNCBAQCBwcm90
ZWN0ZWQ6CiAgICAgfQogCiAgICAgLy8gVGhlc2UgbWV0aG9kcyBhZGQgY2FsbHMgdG8gQysrIGhl
bHBlciBmdW5jdGlvbnMuCisgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihaX0RG
R09wZXJhdGlvbl9EIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgRlBSUmVnIGFyZzEpCisgICAg
eworICAgICAgICByZXNldENhbGxBcmd1bWVudHMoKTsKKyAgICAgICAgYWRkQ2FsbEFyZ3VtZW50
KGFyZzEpOworICAgICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsID0gbV9qaXQuYXBwZW5kQ2Fs
bChvcGVyYXRpb24pOworICAgICAgICBtX2ppdC5tb3ZlKEdQUkluZm86OnJldHVyblZhbHVlR1BS
LCByZXN1bHQpOworICAgICAgICByZXR1cm4gY2FsbDsKKyAgICB9CiAgICAgSklUQ29tcGlsZXI6
OkNhbGwgY2FsbE9wZXJhdGlvbihKX0RGR09wZXJhdGlvbl9FUCBvcGVyYXRpb24sIEdQUlJlZyBy
ZXN1bHRUYWcsIEdQUlJlZyByZXN1bHRQYXlsb2FkLCB2b2lkKiBwb2ludGVyKQogICAgIHsKICAg
ICAgICAgcmVzZXRDYWxsQXJndW1lbnRzKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGZnL0RGR09wZXJhdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGZnL0RGR09wZXJhdGlvbnMuaAkocmV2aXNpb24gOTc0MjApCisrKyBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsNyBA
QCBleHRlcm4gIkMiIHsKICAgICBJOiBJZGVudGlmaWVyKgogICAgIEc6IEdsb2JhbFJlc29sdmVJ
bmZvKgogKi8KK3R5cGVkZWYgaW50MzJfdCBERkdfT1BFUkFUSU9OICgqWl9ERkdPcGVyYXRpb25f
RCkoZG91YmxlKTsKIHR5cGVkZWYgSlNDZWxsKiBERkdfT1BFUkFUSU9OICgqQ19ERkdPcGVyYXRp
b25fRSkoRXhlY1N0YXRlKik7CiB0eXBlZGVmIEpTQ2VsbCogREZHX09QRVJBVElPTiAoKkNfREZH
T3BlcmF0aW9uX0VDKShFeGVjU3RhdGUqLCBKU0NlbGwqKTsKIHR5cGVkZWYgRW5jb2RlZEpTVmFs
dWUgREZHX09QRVJBVElPTiAoKkpfREZHT3BlcmF0aW9uX0VBKShFeGVjU3RhdGUqLCBKU0FycmF5
Kik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp
dmVKSVQ2NC5jcHAJKHJldmlzaW9uIDk3NDIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm
Zy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxMyw2ICsxMDEz
LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogCiAgICAgY2Fz
ZSBWYWx1ZUFkZDoKICAgICBjYXNlIEFyaXRoQWRkOiB7CisgICAgICAgIHByaW50ZigiQ29tcGls
aW5nIEFkZDogc2hvdWxkU3BlY0ludCA9ICVkLCBjYW5TcGVjSW50ID0gJWRcbiIsIE5vZGU6OnNo
b3VsZFNwZWN1bGF0ZUludGVnZXIoYXQobm9kZS5jaGlsZDEoKSksIGF0KG5vZGUuY2hpbGQyKCkp
KSwgbm9kZS5jYW5TcGVjdWxhdGVJbnRlZ2VyKCkpOwogICAgICAgICBpZiAoTm9kZTo6c2hvdWxk
U3BlY3VsYXRlSW50ZWdlcihhdChub2RlLmNoaWxkMSgpKSwgYXQobm9kZS5jaGlsZDIoKSkpICYm
IG5vZGUuY2FuU3BlY3VsYXRlSW50ZWdlcigpKSB7CiAgICAgICAgICAgICBpZiAoaXNJbnQzMkNv
bnN0YW50KG5vZGUuY2hpbGQxKCkpKSB7CiAgICAgICAgICAgICAgICAgaW50MzJfdCBpbW0xID0g
dmFsdWVPZkludDMyQ29uc3RhbnQobm9kZS5jaGlsZDEoKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24gOTc0MjAp
CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29y
a2luZyBjb3B5KQpAQCAtNjE3LDcgKzYxNyw5IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBp
bGVWYWx1ZVRvSW50MzIKICAgICAgICAgICAgIEdQUlJlZyBncHIgPSByZXN1bHQuZ3ByKCk7CiAg
ICAgICAgICAgICBKSVRDb21waWxlcjo6SnVtcCB0cnVuY2F0ZWRUb0ludGVnZXIgPSBtX2ppdC5i
cmFuY2hUcnVuY2F0ZURvdWJsZVRvSW50MzIoZnByLCBncHIsIEpJVENvbXBpbGVyOjpCcmFuY2hJ
ZlRydW5jYXRlU3VjY2Vzc2Z1bCk7CiAgICAgICAgICAgICAKLSAgICAgICAgICAgIHNwZWN1bGF0
aW9uQ2hlY2sobV9qaXQuanVtcCgpKTsKKyAgICAgICAgICAgIHNpbGVudFNwaWxsQWxsUmVnaXN0
ZXJzKGdwcik7CisgICAgICAgICAgICBjYWxsT3BlcmF0aW9uKHRvSW50MzIsIGdwciwgZnByKTsK
KyAgICAgICAgICAgIHNpbGVudEZpbGxBbGxSZWdpc3RlcnMoZ3ByKTsKICAgICAgICAgICAgIAog
ICAgICAgICAgICAgdHJ1bmNhdGVkVG9JbnRlZ2VyLmxpbmsoJm1faml0KTsKICAgICAgICAgICAg
IGludGVnZXJSZXN1bHQoZ3ByLCBtX2NvbXBpbGVJbmRleCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>110962</attachid>
            <date>2011-10-13 23:02:35 -0700</date>
            <delta_ts>2011-10-13 23:10:53 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>fixtoint_patch_2.diff</filename>
            <type>text/plain</type>
            <size>3880</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc0NDIpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK
KzIwMTEtMTAtMTMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBT
cGVjdWxhdGlvbiBmYWlsdXJlcyBpbiBWYWx1ZVRvSW50MzIgYXJlIGNhdXNpbmcgYSAyeCBzbG93
LWRvd24KKyAgICAgICAgaW4gS3Jha2VuL3N0YW5mb3JkLWNyeXB0by1wYmtkZjIKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDg5CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB3ZSBjYW4n
dCB0cnVuY2F0ZSB0byBJbnQzMiB1c2luZyBtYWNoaW5lIGNvZGUsIHRoZW4gZG9uJ3QgZmFpbAor
ICAgICAgICBzcGVjdWxhdGlvbi4gSnVzdCBjYWxsIEpTQzo6dG9JbnQzMi4KKworICAgICAgICAq
IGRmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkRGRzo6Y2FsbE9wZXJh
dGlvbik6CisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuaDoKKyAgICAgICAgKiBkZmcvREZH
U3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpj
b21waWxlVmFsdWVUb0ludDMyKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5j
cHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDEx
LTEwLTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAg
ICAgUmVuYW1lIHZpcnR1YWwgZ2V0Q29uc3RydWN0RGF0YSB0byBnZXRDb25zdHJ1Y3REYXRhVmly
dHVhbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9y
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2Vu
ZXJhdG9yLmgJKHJldmlzaW9uIDk3NDIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E
RkdKSVRDb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNDUsNiArMTA0NSwxMyBA
QCBwcm90ZWN0ZWQ6CiAKICAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hl
Y2tTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOwogICAgIH0KKyAgICBKSVRDb21waWxlcjo6
Q2FsbCBjYWxsT3BlcmF0aW9uKFpfREZHT3BlcmF0aW9uX0Qgb3BlcmF0aW9uLCBHUFJSZWcgcmVz
dWx0LCBGUFJSZWcgYXJnMSkKKyAgICB7CisgICAgICAgIG1faml0Lm1vdmVEb3VibGUoYXJnMSwg
RlBSSW5mbzo6YXJndW1lbnRGUFIwKTsKKyAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9
IG1faml0LmFwcGVuZENhbGwob3BlcmF0aW9uKTsKKyAgICAgICAgbV9qaXQubW92ZShHUFJJbmZv
OjpyZXR1cm5WYWx1ZUdQUiwgcmVzdWx0KTsKKyAgICAgICAgcmV0dXJuIGNhbGw7CisgICAgfQog
ICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oSl9ERkdPcGVyYXRpb25fRUdJIG9w
ZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFyZzEsIHZvaWQqIHBvaW50ZXIpCiAgICAg
ewogICAgICAgICByZXR1cm4gY2FsbE9wZXJhdGlvbigoSl9ERkdPcGVyYXRpb25fRVBQKW9wZXJh
dGlvbiwgcmVzdWx0LCBhcmcxLCBwb2ludGVyKTsKQEAgLTEyNjUsNiArMTI3MiwxNCBAQCBwcm90
ZWN0ZWQ6CiAgICAgfQogCiAgICAgLy8gVGhlc2UgbWV0aG9kcyBhZGQgY2FsbHMgdG8gQysrIGhl
bHBlciBmdW5jdGlvbnMuCisgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihaX0RG
R09wZXJhdGlvbl9EIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgRlBSUmVnIGFyZzEpCisgICAg
eworICAgICAgICByZXNldENhbGxBcmd1bWVudHMoKTsKKyAgICAgICAgYWRkQ2FsbEFyZ3VtZW50
KGFyZzEpOworICAgICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsID0gbV9qaXQuYXBwZW5kQ2Fs
bChvcGVyYXRpb24pOworICAgICAgICBtX2ppdC5tb3ZlKEdQUkluZm86OnJldHVyblZhbHVlR1BS
LCByZXN1bHQpOworICAgICAgICByZXR1cm4gY2FsbDsKKyAgICB9CiAgICAgSklUQ29tcGlsZXI6
OkNhbGwgY2FsbE9wZXJhdGlvbihKX0RGR09wZXJhdGlvbl9FUCBvcGVyYXRpb24sIEdQUlJlZyBy
ZXN1bHRUYWcsIEdQUlJlZyByZXN1bHRQYXlsb2FkLCB2b2lkKiBwb2ludGVyKQogICAgIHsKICAg
ICAgICAgcmVzZXRDYWxsQXJndW1lbnRzKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGZnL0RGR09wZXJhdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGZnL0RGR09wZXJhdGlvbnMuaAkocmV2aXNpb24gOTc0MjApCisrKyBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsNyBA
QCBleHRlcm4gIkMiIHsKICAgICBJOiBJZGVudGlmaWVyKgogICAgIEc6IEdsb2JhbFJlc29sdmVJ
bmZvKgogKi8KK3R5cGVkZWYgaW50MzJfdCBERkdfT1BFUkFUSU9OICgqWl9ERkdPcGVyYXRpb25f
RCkoZG91YmxlKTsKIHR5cGVkZWYgSlNDZWxsKiBERkdfT1BFUkFUSU9OICgqQ19ERkdPcGVyYXRp
b25fRSkoRXhlY1N0YXRlKik7CiB0eXBlZGVmIEpTQ2VsbCogREZHX09QRVJBVElPTiAoKkNfREZH
T3BlcmF0aW9uX0VDKShFeGVjU3RhdGUqLCBKU0NlbGwqKTsKIHR5cGVkZWYgRW5jb2RlZEpTVmFs
dWUgREZHX09QRVJBVElPTiAoKkpfREZHT3BlcmF0aW9uX0VBKShFeGVjU3RhdGUqLCBKU0FycmF5
Kik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZl
SklULmNwcAkocmV2aXNpb24gOTc0MjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG
R1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjE3LDcgKzYxNyw5IEBAIHZv
aWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVWYWx1ZVRvSW50MzIKICAgICAgICAgICAgIEdQUlJl
ZyBncHIgPSByZXN1bHQuZ3ByKCk7CiAgICAgICAgICAgICBKSVRDb21waWxlcjo6SnVtcCB0cnVu
Y2F0ZWRUb0ludGVnZXIgPSBtX2ppdC5icmFuY2hUcnVuY2F0ZURvdWJsZVRvSW50MzIoZnByLCBn
cHIsIEpJVENvbXBpbGVyOjpCcmFuY2hJZlRydW5jYXRlU3VjY2Vzc2Z1bCk7CiAgICAgICAgICAg
ICAKLSAgICAgICAgICAgIHNwZWN1bGF0aW9uQ2hlY2sobV9qaXQuanVtcCgpKTsKKyAgICAgICAg
ICAgIHNpbGVudFNwaWxsQWxsUmVnaXN0ZXJzKGdwcik7CisgICAgICAgICAgICBjYWxsT3BlcmF0
aW9uKHRvSW50MzIsIGdwciwgZnByKTsKKyAgICAgICAgICAgIHNpbGVudEZpbGxBbGxSZWdpc3Rl
cnMoZ3ByKTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgdHJ1bmNhdGVkVG9JbnRlZ2VyLmxp
bmsoJm1faml0KTsKICAgICAgICAgICAgIGludGVnZXJSZXN1bHQoZ3ByLCBtX2NvbXBpbGVJbmRl
eCk7Cg==
</data>
<flag name="review"
          id="108634"
          type_id="1"
          status="-"
          setter="barraclough"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>110968</attachid>
            <date>2011-10-13 23:10:53 -0700</date>
            <delta_ts>2011-10-13 23:19:43 -0700</delta_ts>
            <desc>fixed patch</desc>
            <filename>fixtoint_patch_3.diff</filename>
            <type>text/plain</type>
            <size>3893</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc0NDIpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK
KzIwMTEtMTAtMTMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBT
cGVjdWxhdGlvbiBmYWlsdXJlcyBpbiBWYWx1ZVRvSW50MzIgYXJlIGNhdXNpbmcgYSAyeCBzbG93
LWRvd24KKyAgICAgICAgaW4gS3Jha2VuL3N0YW5mb3JkLWNyeXB0by1wYmtkZjIKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDg5CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB3ZSBjYW4n
dCB0cnVuY2F0ZSB0byBJbnQzMiB1c2luZyBtYWNoaW5lIGNvZGUsIHRoZW4gZG9uJ3QgZmFpbAor
ICAgICAgICBzcGVjdWxhdGlvbi4gSnVzdCBjYWxsIEpTQzo6dG9JbnQzMi4KKworICAgICAgICAq
IGRmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkRGRzo6Y2FsbE9wZXJh
dGlvbik6CisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuaDoKKyAgICAgICAgKiBkZmcvREZH
U3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpj
b21waWxlVmFsdWVUb0ludDMyKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5j
cHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDEx
LTEwLTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAg
ICAgUmVuYW1lIHZpcnR1YWwgZ2V0Q29uc3RydWN0RGF0YSB0byBnZXRDb25zdHJ1Y3REYXRhVmly
dHVhbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9y
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2Vu
ZXJhdG9yLmgJKHJldmlzaW9uIDk3NDIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E
RkdKSVRDb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNDUsNiArMTA0NSwxMyBA
QCBwcm90ZWN0ZWQ6CiAKICAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hl
Y2tTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOwogICAgIH0KKyAgICBKSVRDb21waWxlcjo6
Q2FsbCBjYWxsT3BlcmF0aW9uKFpfREZHT3BlcmF0aW9uX0Qgb3BlcmF0aW9uLCBHUFJSZWcgcmVz
dWx0LCBGUFJSZWcgYXJnMSkKKyAgICB7CisgICAgICAgIG1faml0Lm1vdmVEb3VibGUoYXJnMSwg
RlBSSW5mbzo6YXJndW1lbnRGUFIwKTsKKyAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9
IG1faml0LmFwcGVuZENhbGwob3BlcmF0aW9uKTsKKyAgICAgICAgbV9qaXQuemVyb0V4dGVuZDMy
VG9QdHIoR1BSSW5mbzo6cmV0dXJuVmFsdWVHUFIsIHJlc3VsdCk7CisgICAgICAgIHJldHVybiBj
YWxsOworICAgIH0KICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsT3BlcmF0aW9uKEpfREZHT3Bl
cmF0aW9uX0VHSSBvcGVyYXRpb24sIEdQUlJlZyByZXN1bHQsIEdQUlJlZyBhcmcxLCB2b2lkKiBw
b2ludGVyKQogICAgIHsKICAgICAgICAgcmV0dXJuIGNhbGxPcGVyYXRpb24oKEpfREZHT3BlcmF0
aW9uX0VQUClvcGVyYXRpb24sIHJlc3VsdCwgYXJnMSwgcG9pbnRlcik7CkBAIC0xMjY1LDYgKzEy
NzIsMTQgQEAgcHJvdGVjdGVkOgogICAgIH0KIAogICAgIC8vIFRoZXNlIG1ldGhvZHMgYWRkIGNh
bGxzIHRvIEMrKyBoZWxwZXIgZnVuY3Rpb25zLgorICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxP
cGVyYXRpb24oWl9ERkdPcGVyYXRpb25fRCBvcGVyYXRpb24sIEdQUlJlZyByZXN1bHQsIEZQUlJl
ZyBhcmcxKQorICAgIHsKKyAgICAgICAgcmVzZXRDYWxsQXJndW1lbnRzKCk7CisgICAgICAgIGFk
ZENhbGxBcmd1bWVudChhcmcxKTsKKyAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9IG1f
aml0LmFwcGVuZENhbGwob3BlcmF0aW9uKTsKKyAgICAgICAgbV9qaXQubW92ZShHUFJJbmZvOjpy
ZXR1cm5WYWx1ZUdQUiwgcmVzdWx0KTsKKyAgICAgICAgcmV0dXJuIGNhbGw7CisgICAgfQogICAg
IEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oSl9ERkdPcGVyYXRpb25fRVAgb3BlcmF0
aW9uLCBHUFJSZWcgcmVzdWx0VGFnLCBHUFJSZWcgcmVzdWx0UGF5bG9hZCwgdm9pZCogcG9pbnRl
cikKICAgICB7CiAgICAgICAgIHJlc2V0Q2FsbEFyZ3VtZW50cygpOwpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmgJKHJldmlzaW9uIDk3NDIwKQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAg
LTYxLDYgKzYxLDcgQEAgZXh0ZXJuICJDIiB7CiAgICAgSTogSWRlbnRpZmllcioKICAgICBHOiBH
bG9iYWxSZXNvbHZlSW5mbyoKICovCit0eXBlZGVmIGludDMyX3QgREZHX09QRVJBVElPTiAoKlpf
REZHT3BlcmF0aW9uX0QpKGRvdWJsZSk7CiB0eXBlZGVmIEpTQ2VsbCogREZHX09QRVJBVElPTiAo
KkNfREZHT3BlcmF0aW9uX0UpKEV4ZWNTdGF0ZSopOwogdHlwZWRlZiBKU0NlbGwqIERGR19PUEVS
QVRJT04gKCpDX0RGR09wZXJhdGlvbl9FQykoRXhlY1N0YXRlKiwgSlNDZWxsKik7CiB0eXBlZGVm
IEVuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gKCpKX0RGR09wZXJhdGlvbl9FQSkoRXhlY1N0
YXRlKiwgSlNBcnJheSopOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj
dWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E
RkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDk3NDIwKQorKysgU291cmNlL0phdmFTY3Jp
cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxNyw3
ICs2MTcsOSBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlVmFsdWVUb0ludDMyCiAgICAg
ICAgICAgICBHUFJSZWcgZ3ByID0gcmVzdWx0LmdwcigpOwogICAgICAgICAgICAgSklUQ29tcGls
ZXI6Okp1bXAgdHJ1bmNhdGVkVG9JbnRlZ2VyID0gbV9qaXQuYnJhbmNoVHJ1bmNhdGVEb3VibGVU
b0ludDMyKGZwciwgZ3ByLCBKSVRDb21waWxlcjo6QnJhbmNoSWZUcnVuY2F0ZVN1Y2Nlc3NmdWwp
OwogICAgICAgICAgICAgCi0gICAgICAgICAgICBzcGVjdWxhdGlvbkNoZWNrKG1faml0Lmp1bXAo
KSk7CisgICAgICAgICAgICBzaWxlbnRTcGlsbEFsbFJlZ2lzdGVycyhncHIpOworICAgICAgICAg
ICAgY2FsbE9wZXJhdGlvbih0b0ludDMyLCBncHIsIGZwcik7CisgICAgICAgICAgICBzaWxlbnRG
aWxsQWxsUmVnaXN0ZXJzKGdwcik7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIHRydW5jYXRl
ZFRvSW50ZWdlci5saW5rKCZtX2ppdCk7CiAgICAgICAgICAgICBpbnRlZ2VyUmVzdWx0KGdwciwg
bV9jb21waWxlSW5kZXgpOwo=
</data>
<flag name="review"
          id="108640"
          type_id="1"
          status="+"
          setter="barraclough"
    />
          </attachment>
      

    </bug>

</bugzilla>