70086 2011-10-13 20:36:52 -0700 When incremental loading is suppressed for composited content, black flashes can occur before the first paint 2012-02-10 15:57:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 72106 73641 1 aestes aestes darin sam simon.fraser oldest_to_newest 483741 0 aestes 2011-10-13 20:36:52 -0700 When incremental loading is suppressed for composited content, black flashes can occur before the first paint 483742 1 aestes 2011-10-13 20:37:42 -0700 <rdar://problem/10242404> 484310 2 111081 aestes 2011-10-14 14:41:53 -0700 Created attachment 111081 Patch 484322 3 111081 simon.fraser 2011-10-14 14:52:15 -0700 Comment on attachment 111081 Patch Andy and I are still discussing this. 500602 4 aestes 2011-11-11 02:12:07 -0800 After talking to Simon I agree the better approach here is to freeze the layer tree during loading, similar to what we do in WebKit2 to prevent flashes when navigating away from a composited page. I'm going to do this in three steps: - Consolidate the two Mac code paths that install run loop observers for layer tree syncing into a single class that has the ability to install and uninstall the observer. - Add the layer tree freezing logic for Mac WebKit1 and WebKit2 using this new class. - Add a separate implementation for Apple's Windows port, which uses a different mechanism for layer tree syncing. 554468 5 sam 2012-02-10 15:57:58 -0800 Andy fixed this another way. 111081 2011-10-14 14:41:53 -0700 2011-10-14 14:52:15 -0700 Patch bug-70086-20111014144201.patch text/plain 4164 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogOTczNzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MTVjMTUzYjRiOWUzZWFl NTRhYTkxNzJiYWI3YTU1ZWUwZDFhNjA1Li40MTI1ZWU5MTA2Zjg5NDFjMzQyZDY1ZjQ3NmI0NTdl N2RjZGVjZWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTEtMTAtMTQgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFdoZW4gaW5jcmVtZW50YWwgbG9h ZGluZyBpcyBzdXBwcmVzc2VkIGZvciBjb21wb3NpdGVkIGNvbnRlbnQsIGJsYWNrIGZsYXNoZXMg Y2FuIG9jY3VyIGJlZm9yZSB0aGUgZmlyc3QgcGFpbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByZXZpb3VzIGFwcHJvYWNoIHRvIHN1cHByZXNz aW5nIGRpc3BsYXkgb2YgY29tcG9zaXRlZCBjb250ZW50CisgICAgICAgIGludm9sdmVkIHN1cHBy ZXNzaW5nIHVwZGF0ZXMgdG8gdGhlIGxheWVyIHRyZWUgaGllcmFyY2h5LCBidXQgbm90IHRoZQor ICAgICAgICBjcmVhdGlvbiBvZiBsYXllciBiYWNraW5nIHN0b3JlcyB0aGF0IGhhcHBlbnMgZHVy aW5nIHN0eWxlIGNvbXB1dGF0aW9uLgorICAgICAgICBTaW5jZSBzdXBwcmVzc2lvbiBvZiBiYWNr aW5nIHN0b3JlIGNyZWF0aW9uIGlzIGFsc28gc3VmZmljaWVudCB0bworICAgICAgICBzdXBwcmVz cyBsYXllciB0cmVlIHVwZGF0ZXMsIG1vdmUgdGhlIGNoZWNrIGluCisgICAgICAgIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoKSB0bworICAgICAgICBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZUJhY2tpbmcoKS4KKworICAgICAgICBXZSBjYW4gYWxz byByZW1vdmUgdGhlIGNhbGwgdG8KKyAgICAgICAgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRh dGVDb21wb3NpdGluZ0xheWVycygpIGZyb20KKyAgICAgICAgRG9jdW1lbnQ6OmltcGxpY2l0Q2xv c2UoKSwgc2luY2UgYSBiYWNraW5nIHN0b3JlIHdpbGwgYmUgYXV0b21hdGljYWxseQorICAgICAg ICBjcmVhdGVkIGFuZCBhIGxheWVyIHRyZWUgdXBkYXRlIHdpbGwgYmUgc2NoZWR1bGVkIHdoZW4g dGhlIGZ1bGwgc3R5bGUKKyAgICAgICAgcmVjYWxjIGhhcHBlbnMgYXQgZG9jdW1lbnQgbG9hZCB0 aW1lLgorCisgICAgICAgIE5vIHRlc3RzIGN1cnJlbnRseSBwb3NzaWJsZS4gVGVzdGluZyB0aGlz IHdvdWxkIHJlcXVpcmUgdGhlIGFiaWxpdHkgZm9yCisgICAgICAgIERSVCB0byBkdW1wIHN0YXRl IHdoaWxlIHJlc291cmNlcyBhcmUgbG9hZGluZywgd2hpY2ggaXQgZG9lc24ndAorICAgICAgICBj dXJyZW50bHkgZG8uCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OmltcGxpY2l0Q2xvc2UpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21w b3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZUJhY2tpbmcpOgorCiAyMDExLTEwLTEzICBTaGVyaWZm IEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByOTczNjIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCBhNDE5Yjcz Njg0NWMxYTRiNmUwNWE4MmU3ZmNkNDQwYTQwOTlhMTY0Li43YmZiNjU3N2FiNTg4YWI4NTQ2MTlk OWNkMDFiZjE3N2UyMmU3YzhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTIyMjUsMTIg KzIyMjUsOCBAQCB2b2lkIERvY3VtZW50OjppbXBsaWNpdENsb3NlKCkKICAgICB9CiAKICAgICAv LyBJZiBwYWludGluZyBhbmQgY29tcG9zaXRpbmcgbGF5ZXIgdXBkYXRlcyB3ZXJlIHN1cHByZXNz ZWQgcGVuZGluZyB0aGUgbG9hZCBldmVudCwgZG8gdGhlc2UgYWN0aW9ucyBub3cuCi0gICAgaWYg KHJlbmRlcmVyKCkgJiYgc2V0dGluZ3MoKSAmJiBzZXR0aW5ncygpLT5zdXBwcmVzc0luY3JlbWVu dGFsUmVuZGVyaW5nKCkpIHsKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAg ICAgIHZpZXcoKS0+dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoKTsKLSNlbmRpZgorICAgIGlmIChy ZW5kZXJlcigpICYmIHNldHRpbmdzKCkgJiYgc2V0dGluZ3MoKS0+c3VwcHJlc3NJbmNyZW1lbnRh bFJlbmRlcmluZygpKQogICAgICAgICByZW5kZXJlcigpLT5yZXBhaW50KCk7Ci0gICAgfQogCiAj aWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShDSFJPTUlVTSkKICAgICBpZiAoZiAmJiByZW5k ZXJPYmplY3QgJiYgdGhpcyA9PSB0b3BEb2N1bWVudCgpICYmIEFYT2JqZWN0Q2FjaGU6OmFjY2Vz c2liaWxpdHlFbmFibGVkKCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZjI2MjdkZTY2MTJiOTc3OGQ5ZTMxMzY1OWVk YzJkZWZiMDU0NjMyYS4uMTI2YmVhZGFiMzA3M2I2NmQyMmNiZmMxZjM0MjEyMzM5MmRmM2I0NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5jcHAKQEAgLTI0NCwxMCArMjQ0LDYgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVw ZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzVGltZXJGaXJlZChUaW1lcjxSZW5kZXJMYXllckMKIHZvaWQg UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyhDb21wb3NpdGlu Z1VwZGF0ZVR5cGUgdXBkYXRlVHlwZSwgUmVuZGVyTGF5ZXIqIHVwZGF0ZVJvb3QpCiB7CiAgICAg bV91cGRhdGVDb21wb3NpdGluZ0xheWVyc1RpbWVyLnN0b3AoKTsKLSAgICAKLSAgICAvLyBDb21w b3NpdGluZyBsYXllcnMgd2lsbCBiZSB1cGRhdGVkIGluIERvY3VtZW50OjppbXBsaWNpdENsb3Nl KCkgaWYgc3VwcHJlc3NlZCBoZXJlLgotICAgIGlmICghbV9yZW5kZXJWaWV3LT5kb2N1bWVudCgp LT52aXN1YWxVcGRhdGVzQWxsb3dlZCgpKQotICAgICAgICByZXR1cm47CiAKICAgICBpZiAobV9m b3JjZUNvbXBvc2l0aW5nTW9kZSAmJiAhbV9jb21wb3NpdGluZykKICAgICAgICAgZW5hYmxlQ29t cG9zaXRpbmdNb2RlKHRydWUpOwpAQCAtMzM0LDYgKzMzMCwxMiBAQCB2b2lkIFJlbmRlckxheWVy Q29tcG9zaXRvcjo6dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoQ29tcG9zaXRpbmdVcGRhdGVUeXBl IHVwZGF0ZQogCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQmFja2luZyhSZW5k ZXJMYXllciogbGF5ZXIsIENvbXBvc2l0aW5nQ2hhbmdlUmVwYWludCBzaG91bGRSZXBhaW50KQog eworICAgIC8vIERvIG5vdCBjcmVhdGUgYSBiYWNraW5nIHN0b3JlIGlmIHZpc3VhbCB1cGRhdGVz IGFyZSB0byBiZSBzdXBwcmVzc2VkLAorICAgIC8vIHRodXMgcHJldmVudGluZyBjb21wb3NpdGVk IGNvbnRlbnQgZnJvbSBiZWluZyBkaXNwbGF5ZWQuIEEgYmFja2luZyBzdG9yZQorICAgIC8vIHdp bGwgYmUgY3JlYXRlZCBsYXRlciB3aGVuIERvY3VtZW50OjpyZWNhbGNTdHlsZSgpIGlzIGNhbGxl ZCBhdCBsb2FkIHRpbWUuCisgICAgaWYgKCFtX3JlbmRlclZpZXctPmRvY3VtZW50KCktPnZpc3Vh bFVwZGF0ZXNBbGxvd2VkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGJvb2wgbGF5 ZXJDaGFuZ2VkID0gZmFsc2U7CiAKICAgICBpZiAobmVlZHNUb0JlQ29tcG9zaXRlZChsYXllcikp IHsK