70074 2011-10-13 16:41:58 -0700 Redundant comparison in AccessibilityObject.cpp updateAXLineStartForVisiblePosition 2011-10-14 10:56:51 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rsleevi rniwa aboxhall cfleizach morrita rniwa thakis oldest_to_newest 483640 0 rsleevi 2011-10-13 16:41:58 -0700 This was reported upstream to Chromium by way of PVS Studio ( http://www.viva64.com/en/b/0113/ ), Fragment N11 http://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp?annotate=blame&rev=96973#L481 Line 487: while (true) { tempPosition = startPosition.previous(); if (tempPosition.isNull() || tempPosition.isNull()) break; Position p = tempPosition.deepEquivalent(); The bug is that the conditional checks if tempPosition.isNull() twice. It's not clear what is meant to be checked here - startPosition.isNull() ? It was introduced in http://trac.webkit.org/changeset/92451 483692 1 rniwa 2011-10-13 18:04:11 -0700 Ok, this is definitely a typo. The second isNull check is redundant and can be removed. 484018 2 111023 rniwa 2011-10-14 09:35:15 -0700 Created attachment 111023 cleanup 484028 3 111023 cfleizach 2011-10-14 09:52:34 -0700 Comment on attachment 111023 cleanup r=me 484064 4 111023 rniwa 2011-10-14 10:56:48 -0700 Comment on attachment 111023 cleanup Clearing flags on attachment: 111023 Committed r97479: <http://trac.webkit.org/changeset/97479> 484065 5 rniwa 2011-10-14 10:56:51 -0700 All reviewed patches have been landed. Closing bug. 111023 2011-10-14 09:35:15 -0700 2011-10-14 10:56:47 -0700 cleanup bug-70074-20111014093515.patch text/plain 1401 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NDcyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTQgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVkdW5kYW50IGNvbXBhcmlzb24g aW4gQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgdXBkYXRlQVhMaW5lU3RhcnRGb3JWaXNpYmxlUG9z aXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcw MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlZCByZWR1bmRhbnQgY29kZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1cGRhdGVBWExpbmVTdGFydEZvclZp c2libGVQb3NpdGlvbik6CisKIDIwMTEtMTAtMTMgIEFya28gU2FoYSAgPGFya29AbW90b3JvbGEu Y29tPgogCiAgICAgICAgIE1pY3JvZGF0YTogQmFzaWMgaW1wbGVtZW50YXRpb24gb2YgZG9jdW1l bnQuZ2V0SXRlbXMoKSBtZXRob2QuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHJldmlzaW9uIDk3NDcwKQorKysg U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDg2LDcgKzQ4Niw3IEBAIHN0YXRpYyBWaXNpYmxlUG9zaXRpb24gdXBk YXRlQVhMaW5lU3RhcnQKICAgICBWaXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiA9IHZpc2li bGVQb3NpdGlvbjsKICAgICB3aGlsZSAodHJ1ZSkgewogICAgICAgICB0ZW1wUG9zaXRpb24gPSBz dGFydFBvc2l0aW9uLnByZXZpb3VzKCk7Ci0gICAgICAgIGlmICh0ZW1wUG9zaXRpb24uaXNOdWxs KCkgfHwgdGVtcFBvc2l0aW9uLmlzTnVsbCgpKQorICAgICAgICBpZiAodGVtcFBvc2l0aW9uLmlz TnVsbCgpKQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIFBvc2l0aW9uIHAgPSB0ZW1wUG9z aXRpb24uZGVlcEVxdWl2YWxlbnQoKTsKICAgICAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9 IHAuZGVwcmVjYXRlZE5vZGUoKS0+cmVuZGVyZXIoKTsK