70073 2011-10-13 16:38:49 -0700 land-cowboy should at least check style. 2011-10-14 11:25:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth ojan webkit.review.bot oldest_to_newest 483634 0 dglazkov 2011-10-13 16:38:49 -0700 land-cowboy should at least check style. 483636 1 110930 dglazkov 2011-10-13 16:39:25 -0700 Created attachment 110930 Patch 483639 2 dglazkov 2011-10-13 16:40:23 -0700 This has bitten me for the last time! 483654 3 110930 abarth 2011-10-13 16:54:58 -0700 Comment on attachment 110930 Patch Ok. I relent. In the past, my position has been that cowboys don't check style, but I have to admit now that this command has passed into more common usage and not everyone who uses it is a real cowboy. We should a command called land-cowboy-for-realz that skips CheckStyle and ConfirmDiff. :) 483677 4 110930 webkit.review.bot 2011-10-13 17:28:24 -0700 Comment on attachment 110930 Patch Clearing flags on attachment: 110930 Committed r97427: <http://trac.webkit.org/changeset/97427> 483678 5 webkit.review.bot 2011-10-13 17:28:28 -0700 All reviewed patches have been landed. Closing bug. 483756 6 abarth 2011-10-13 22:07:42 -0700 abarth@quadzen:~/svn/webkit$ wkp land-cowboy Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Change author: Adam Barth <abarth@webkit.org>. Running 'svn update' to update ChangeLog files. At revision 97439. Editing the LayoutTests/ChangeLog file. -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info -- LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files Are you sure you want to continue? [Y/n]: Was that diff correct? [Y/n]: 483757 7 abarth 2011-10-13 22:08:04 -0700 Can we silence that warning? It's bogus for land-cowboy. 484013 8 dglazkov 2011-10-14 09:12:52 -0700 (In reply to comment #7) > Can we silence that warning? It's bogus for land-cowboy. Makes sense. Lemme see what I can do. 484095 9 dglazkov 2011-10-14 11:25:54 -0700 https://bugs.webkit.org/show_bug.cgi?id=70119 110930 2011-10-13 16:39:25 -0700 2011-10-13 17:28:24 -0700 Patch bug-70073-20111013163924.patch text/plain 1199 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTc0MTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMzI5MGY2N2NlYWU0ODhhMTJjYWFmNmI3NmQ3MTEyZjMw ZDVkYTE5Li4xYmE1YWVmMWRlMzdlNzEwMTVlMzFmYjYzZjBhMWNmMWFkYjQ5ZmNmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMTMgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K KworICAgICAgICBsYW5kLWNvd2JveSBzaG91bGQgYXQgbGVhc3QgY2hlY2sgc3R5bGUuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDA3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5OiBBZGRlZCBDaGVja1N0eWxlIHN0ZXAgdG8g TGFuZENvd2JveSBjb21tYW5kLgorCiAyMDExLTEwLTEzICBCZXRoIERha2luICA8YmRha2luQGFw cGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzAwNTAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9kb3dubG9hZC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3du bG9hZC5weQppbmRleCA1ZWNjOWRiMGI4YTkyMGQ5ZGZkNzhjMTIwMzc0NGRiMjcxYWU5YzA1Li41 NDczZGFmOTQ5NzRjZTAzN2MyYjYwYThlOTIwNmU5MzJlYWNiYTllIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5CkBAIC0xMTgsNiArMTE4 LDcgQEAgY2xhc3MgTGFuZENvd2JveShBYnN0cmFjdFNlcXVlbmNlZENvbW1hbmQpOgogICAgIHN0 ZXBzID0gWwogICAgICAgICBzdGVwcy5QcmVwYXJlQ2hhbmdlTG9nLAogICAgICAgICBzdGVwcy5F ZGl0Q2hhbmdlTG9nLAorICAgICAgICBzdGVwcy5DaGVja1N0eWxlLAogICAgICAgICBzdGVwcy5D b25maXJtRGlmZiwKICAgICAgICAgc3RlcHMuQnVpbGQsCiAgICAgICAgIHN0ZXBzLlJ1blRlc3Rz LAo=