70047 2011-10-13 12:46:43 -0700 [Qt][WK2] WebViews are emitting loadFailed for "private" error codes 2011-10-13 14:15:41 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jesus jesus kenneth kling menard oldest_to_newest 483407 0 jesus 2011-10-13 12:46:43 -0700 Both QDesktopWebView and QTouchWebView are emitting loadFailed for all sort of errors. This includes errors like the ones defined in Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp, which are private since their domain is "WebKit" and whose error codes are not exposed anywhere in our API. We should filter these by not emitting this signal for private errors since there is no way for the users of our API to check them (no enums...). They could be exposed but I believe it would just pollute our API as this sort of errors are more related to WebKit internals than to user's actions or decisions. 483413 1 110890 jesus 2011-10-13 12:57:12 -0700 Created attachment 110890 Patch 483416 2 110890 kenneth 2011-10-13 12:59:53 -0700 Comment on attachment 110890 Patch Possible to test this? 483430 3 jesus 2011-10-13 13:20:43 -0700 (In reply to comment #2) > (From update of attachment 110890 [details]) > Possible to test this? I don't think so =/. Maybe only if the test rely on private stuff... but I'm not sure it makes sense. The good thing about this patch is that if anyone ever thinks these errors should emit loadFailed it's easy to remove those lines. Plus, other ports do the same on their FrameLoaderClient implementation in WebKit1 and we ourselves used to do the same in FrameLoaderClientQt::shouldFallBack. So I guess we are safe here... Can I land it, Kenneth? 483466 4 kenneth 2011-10-13 14:04:22 -0700 Sure! 483477 5 110890 jesus 2011-10-13 14:15:33 -0700 Comment on attachment 110890 Patch Clearing flags on attachment: 110890 Committed r97398: <http://trac.webkit.org/changeset/97398> 483478 6 jesus 2011-10-13 14:15:41 -0700 All reviewed patches have been landed. Closing bug. 110890 2011-10-13 12:57:12 -0700 2011-10-13 14:15:33 -0700 Patch bug-70047-20111013165652.patch text/plain 1896 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogOTczODcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0YWFlOTVlZGM3MDllMjRi NDI4MDYzMTJiZTM1ZWI5ZGYwYzkwZmQ2Li4zMTE4MzhhYTc5NGZjZTFhYjM3NWQ1YmNkYmU1OWQz NjU2MWZmMzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMTMgIEplc3Vz IFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgorCisgICAg ICAgIFtRdF1bV0syXSBXZWJWaWV3cyBhcmUgZW1pdHRpbmcgbG9hZEZhaWxlZCBmb3IgInByaXZh dGUiIGVycm9yIGNvZGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MDA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJvdGggUURlc2t0b3BXZWJWaWV3IGFuZCBRVG91Y2hXZWJWaWV3IGFyZSBlbWl0dGlu ZyBsb2FkRmFpbGVkIGZvciBwcml2YXRlIGVycm9ycworICAgICAgICBsaWtlIHRoZSBvbmVzIGRl ZmluZWQgaW4gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJF cnJvcnNRdC5jcHAuCisKKyAgICAgICAgV2Ugbm93IGZpbHRlciB0aGVzZSBieSBub3QgZW1pdHRp bmcgdGhpcyBzaWduYWwgZm9yIEZyYW1lTG9hZEludGVycnVwdGVkQnlQb2xpY3lDaGFuZ2UsCisg ICAgICAgIFBsdWdJbldpbGxIYW5kbGVMb2FkIGFuZCBDYW5jZWxsYXRpb24sIGZvbGxvd2luZyBw cmV2aW91cyBkZWNpc2lvbnMgZnJvbSBXZWJLaXQgMS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9x dC9DbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKGRpc3BhdGNoTG9hZEZhaWxlZCk6CisKIDIwMTEt MTAtMTMgIFJhdmkgUGhhbmVlbmRyYSBLYXNpYmhhdGxhICA8cmF2aS5rYXNpYmhhdGxhQG1vdG9y b2xhLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgVGV4dENoZWNrZXIgZm9yIFdlYktpdDIgR1RL KwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L0NsaWVudEltcGwuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L0NsaWVudEltcGwuY3BwCmluZGV4IDhmZjhl ZDgyNTM3NjljYTM2NWJjOTc4MGE2MjUwZTExYTE5NjUxMDcuLmMwMDNkZmNkMTY5ZWIxYjFhYTMw ZDBjM2E1NGU0MjY0YjhhM2MwZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9DbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvQ2xp ZW50SW1wbC5jcHAKQEAgLTc0LDYgKzc0LDExIEBAIHN0YXRpYyB2b2lkIGRpc3BhdGNoTG9hZEZh aWxlZChXS0ZyYW1lUmVmIGZyYW1lLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvLCBXS0Vycm9yCiAg ICAgICAgIHJldHVybjsKIAogICAgIHRvUXRXZWJQYWdlUHJveHkoY2xpZW50SW5mbyktPnVwZGF0 ZU5hdmlnYXRpb25BY3Rpb25zKCk7CisKKyAgICBpbnQgZXJyb3JDb2RlID0gV0tFcnJvckdldEVy cm9yQ29kZShlcnJvcik7CisgICAgaWYgKHRvSW1wbChlcnJvciktPnBsYXRmb3JtRXJyb3IoKS5p c0NhbmNlbGxhdGlvbigpIHx8IGVycm9yQ29kZSA9PSBrV0tFcnJvckNvZGVGcmFtZUxvYWRJbnRl cnJ1cHRlZEJ5UG9saWN5Q2hhbmdlIHx8IGVycm9yQ29kZSA9PSBrV0tFcnJvckNvZGVQbHVnSW5X aWxsSGFuZGxlTG9hZCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgdG9RdFdlYlBhZ2VQcm94eShj bGllbnRJbmZvKS0+bG9hZERpZEZhaWwoUVdlYkVycm9yUHJpdmF0ZTo6Y3JlYXRlUVdlYkVycm9y KGVycm9yKSk7CiB9CiAK