70045 2011-10-13 12:22:54 -0700 Crash in DeleteSelectionCommand::handleGeneralDelete 2011-10-13 13:57:40 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 rniwa rniwa darin enrica morrita ojan tkent tony webkit.review.bot oldest_to_newest 483385 0 rniwa 2011-10-13 12:22:54 -0700 Stack trace: 0x6846a438 [chrome.dll - htmlediting.cpp:976 WebCore::caretMaxOffset(WebCore::Node const *) 0x684ab73d [chrome.dll - deleteselectioncommand.cpp:420 WebCore::DeleteSelectionCommand::handleGeneralDelete() 0x684ac9b7 [chrome.dll - deleteselectioncommand.cpp:800 WebCore::DeleteSelectionCommand::doApply() 0x6847a1d2 [chrome.dll - editcommand.cpp:92 WebCore::EditCommand::apply() 0x68493734 [chrome.dll - compositeeditcommand.cpp:102 WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::EditCommand>) 0x6849471c [chrome.dll - compositeeditcommand.cpp:406 WebCore::CompositeEditCommand::deleteSelection(bool,bool,bool,bool) 0x68497858 [chrome.dll - inserttextcommand.cpp:110 WebCore::InsertTextCommand::doApply() 0x6847a1d2 [chrome.dll - editcommand.cpp:92 WebCore::EditCommand::apply() 0x684937be [chrome.dll - compositeeditcommand.cpp:113 WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::CompositeEditCommand>,WebCore::VisibleSelection const &) 0x6843eda3 [chrome.dll - typingcommand.cpp:397 WebCore::TypingCommand::insertTextRunWithoutNewlines(WTF::String const &,bool) 0x6843ecdb [chrome.dll - typingcommand.cpp:384 WebCore::TypingCommand::insertText(WTF::String const &,bool) 0x6843e9f0 [chrome.dll - typingcommand.cpp:307 WebCore::TypingCommand::doApply() 0x6847a1d2 [chrome.dll - editcommand.cpp:92 WebCore::EditCommand::apply() 0x6847a3a9 [chrome.dll - editcommand.cpp:224 WebCore::applyCommand(WTF::PassRefPtr<WebCore::EditCommand>) 0x6843e716 [chrome.dll - typingcommand.cpp:208 WebCore::TypingCommand::insertText(WebCore::Document *,WTF::String const &,WebCore::VisibleSelection const &,unsigned int,WebCore::TypingCommand::TextCompositionType) 0x6841d63c [chrome.dll - editor.cpp:1099 WebCore::Editor::insertTextWithoutSendingTextEvent(WTF::String const &,bool,WebCore::TextEvent *) 0x6841b4a7 [chrome.dll - editor.cpp:176 WebCore::Editor::handleTextEvent(WebCore::TextEvent *) 0x685a81f5 [chrome.dll - node.cpp:2793 WebCore::Node::defaultEventHandler(WebCore::Event *) 483390 1 110888 rniwa 2011-10-13 12:25:56 -0700 Created attachment 110888 fixes the crash 483431 2 rniwa 2011-10-13 13:23:10 -0700 http://crbug.com/99408 We have 21 crash reports in Chromium. 483444 3 110888 darin 2011-10-13 13:39:51 -0700 Comment on attachment 110888 fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=110888&action=review > Source/WebCore/ChangeLog:10 > + No new tests because we don't have a reduction. Disappointing. 483452 4 110888 rniwa 2011-10-13 13:52:56 -0700 Comment on attachment 110888 fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=110888&action=review Thanks for the review. >> Source/WebCore/ChangeLog:10 >> + No new tests because we don't have a reduction. > > Disappointing. Yeah I know :( 483459 5 rniwa 2011-10-13 13:57:40 -0700 Committed r97395: <http://trac.webkit.org/changeset/97395> 110888 2011-10-13 12:25:56 -0700 2011-10-13 13:52:56 -0700 fixes the crash bug-70045-20111013122555.patch text/plain 1582 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMTMgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ3Jhc2ggaW4gRGVsZXRlU2VsZWN0 aW9uQ29tbWFuZDo6aGFuZGxlR2VuZXJhbERlbGV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFeGl0IGVhcmx5IHdoZW4gbV91cHN0cmVhbVN0YXJ0IGlz IG51bGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugd2UgZG9uJ3QgaGF2ZSBhIHJl ZHVjdGlvbi4KKworICAgICAgICAqIGVkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEZWxldGVTZWxlY3Rpb25Db21tYW5kOjpoYW5kbGVHZW5lcmFs RGVsZXRlKToKKwogMjAxMS0xMC0xMyAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBEZXByZWNhdGUgZXZlbnQubGF5ZXJYIGFuZCBldmVudC5sYXll clkgaW4gV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlv bkNvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRl U2VsZWN0aW9uQ29tbWFuZC5jcHAJKHJldmlzaW9uIDk3MzQ3KQorKysgU291cmNlL1dlYkNvcmUv ZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDA4 LDkgKzQwOCwxMiBAQCB2b2lkIERlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6OmRlbGV0ZVRleHRGCiAK IHZvaWQgRGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6aGFuZGxlR2VuZXJhbERlbGV0ZSgpCiB7Cisg ICAgaWYgKG1fdXBzdHJlYW1TdGFydC5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAg aW50IHN0YXJ0T2Zmc2V0ID0gbV91cHN0cmVhbVN0YXJ0LmRlcHJlY2F0ZWRFZGl0aW5nT2Zmc2V0 KCk7CiAgICAgTm9kZSogc3RhcnROb2RlID0gbV91cHN0cmVhbVN0YXJ0LmRlcHJlY2F0ZWROb2Rl KCk7Ci0gICAgCisKICAgICAvLyBOZXZlciByZW1vdmUgdGhlIHN0YXJ0IGJsb2NrIHVubGVzcyBp dCdzIGEgdGFibGUsIGluIHdoaWNoIGNhc2Ugd2Ugd29uJ3QgbWVyZ2UgY29udGVudCBpbi4KICAg ICBpZiAoc3RhcnROb2RlID09IG1fc3RhcnRCbG9jayAmJiBzdGFydE9mZnNldCA9PSAwICYmIGNh bkhhdmVDaGlsZHJlbkZvckVkaXRpbmcoc3RhcnROb2RlKSAmJiAhc3RhcnROb2RlLT5oYXNUYWdO YW1lKHRhYmxlVGFnKSkgewogICAgICAgICBzdGFydE9mZnNldCA9IDA7Cg==