70036 2011-10-13 10:18:21 -0700 compile error in WebCore::WorkerContext::importScript() 2011-10-14 11:25:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 0 sanachan.y webkit-unassigned webkit.review.bot oldest_to_newest 483269 0 110868 sanachan.y 2011-10-13 10:18:21 -0700 Created attachment 110868 Include ExceptionCode.h instead In WebCore::WorkerContext::importScript() method, a compile error like 'SYNTAX_ERR is not defined' occurs when compile switches are set to :- - ENABLE_WORKERS=1 - ENABLE_FILE_SYSTEM=0 Include dom/ExceptionCode.h instead, like the attached candidate patch. I don't know about WebKit's commit policy so that I set commit-queue to '?'. 483275 1 webkit.review.bot 2011-10-13 10:22:17 -0700 Attachment 110868 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 484004 2 111019 sanachan.y 2011-10-14 08:51:28 -0700 Created attachment 111019 Patch2 improved according to the found errors by WebKit Review Bot 484040 3 111019 darin 2011-10-14 10:11:44 -0700 Comment on attachment 111019 Patch2 I’d rather see an unconditional include of ExceptionCode.h instead of the #else, but this is OK. 484091 4 111019 webkit.review.bot 2011-10-14 11:25:15 -0700 Comment on attachment 111019 Patch2 Clearing flags on attachment: 111019 Committed r97482: <http://trac.webkit.org/changeset/97482> 484092 5 webkit.review.bot 2011-10-14 11:25:19 -0700 All reviewed patches have been landed. Closing bug. 110868 2011-10-13 10:18:21 -0700 2011-10-14 08:51:28 -0700 Include ExceptionCode.h instead Patch.txt text/plain 1079 sanachan.y SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKOODquODk+OCuOODp+ODsyA5NzM2NykKKysrIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwko5L2c5qWt44Kz44OU44O8KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEwLTE0 IFl1amkgU2FuYWNoYW4gPHNhbmFjaGFuLnlAZ21haWwuY29tPgorCisJSW5jbHVkZSBkb20vRXhj ZXB0aW9uQ29kZS5oIGluc3RlYWQgb2YgRmlsZXN5c3RlbSBBUElzIGhlYWRlcnMKKwl0byBmaXgg Y29tcGlsZSBlcnJvciB3aGVuIEVOQUJMRV9XT1JLRVJTPTEgYW5kIEVOQUJMRV9GSUxFX1NZU1RF TT0wCisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpPXh4eHh4eAorCisJUmV2 aWV3ZWQgYnkgeHh4eC4KKworCSogd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNwcDoKKworCiAyMDEx LTEwLTEzICBEZWVwYWsgU2hlcnZlZ2hhciAgPGJwd3Y2NEBtb3Rvcm9sYS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjk1MzgxKTogU3RhbmRhbG9uZSB2aWRlbyBjYW4gYmUgZm9jdXNlZCBh bmQgZHJhd3MgYSBmb2N1cyByaW5nLgpJbmRleDogU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3Jr ZXJDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtl ckNvbnRleHQuY3BwCSjjg6rjg5Pjgrjjg6fjg7MgOTczNjcpCisrKyBTb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCSjkvZzmpa3jgrPjg5Tjg7wpCkBAIC04Miw2ICs4Miw4 IEBACiAjaW5jbHVkZSAiRmlsZVN5c3RlbUNhbGxiYWNrcy5oIgogI2luY2x1ZGUgIkxvY2FsRmls ZVN5c3RlbS5oIgogI2luY2x1ZGUgIlN5bmNDYWxsYmFja0hlbHBlci5oIgorI2Vsc2UKKyNpbmNs dWRlICJFeGNlcHRpb25Db2RlLmgiCiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgewo= 111019 2011-10-14 08:51:28 -0700 2011-10-14 11:25:15 -0700 Patch2 Patch2.txt text/plain 1136 sanachan.y SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKOODquODk+OCuOODp+ODsyA5NzQ2OSkKKysrIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwko5L2c5qWt44Kz44OU44O8KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEwLTE0 IFl1amkgU2FuYWNoYW4gPHNhbmFjaGFuLnlAZ21haWwuY29tPgorCisgICAgICAgIEluY2x1ZGUg ZG9tL0V4Y2VwdGlvbkNvZGUuaCBpbnN0ZWFkIG9mIEZpbGVzeXN0ZW0gQVBJcyBoZWFkZXJzCisg ICAgICAgIHRvIGZpeCBjb21waWxlIGVycm9yIHdoZW4gRU5BQkxFX1dPUktFUlM9MSBhbmQgRU5B QkxFX0ZJTEVfU1lTVEVNPTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcwMDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 V29ya2VyQ29udGV4dDo6aW1wb3J0U2NyaXB0KToKKwogMjAxMS0xMC0xNCAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3RyaWN0ZXIgbWFuYWdlbWVudCBvZiBX ZWJLaXRDU1NLZXlmcmFtZVJ1bGVzLgpJbmRleDogU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3Jr ZXJDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtl ckNvbnRleHQuY3BwCSjjg6rjg5Pjgrjjg6fjg7MgOTc0NjkpCisrKyBTb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCSjkvZzmpa3jgrPjg5Tjg7wpCkBAIC04Miw2ICs4Miw4 IEBACiAjaW5jbHVkZSAiRmlsZVN5c3RlbUNhbGxiYWNrcy5oIgogI2luY2x1ZGUgIkxvY2FsRmls ZVN5c3RlbS5oIgogI2luY2x1ZGUgIlN5bmNDYWxsYmFja0hlbHBlci5oIgorI2Vsc2UKKyNpbmNs dWRlICJFeGNlcHRpb25Db2RlLmgiCiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgewo=