70030 2011-10-13 09:01:21 -0700 AX: webkit won't always send live region notifications 2011-10-17 09:46:46 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach oldest_to_newest 483221 0 cfleizach 2011-10-13 09:01:21 -0700 Webkit purposefully does not send live region notifications if some client has not accessed the AX tree in between the last live region update (ostensibly to improve performance) However, this is problematic because if a screen reader misses one notification it has no idea what happened and the only recourse is to rescan the page for changes. I believe the correct thing to do is to always send notifications. 483224 1 110855 cfleizach 2011-10-13 09:05:15 -0700 Created attachment 110855 patch 485211 2 cfleizach 2011-10-17 09:26:32 -0700 rdar://10276628 485225 3 cfleizach 2011-10-17 09:46:46 -0700 http://trac.webkit.org/changeset/97627 110855 2011-10-13 09:05:15 -0700 2011-10-17 09:14:38 -0700 patch patch.txt text/plain 7113 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MzY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTAtMTMgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogd2Via2l0IHdvbid0 IGFsd2F5cyBzZW5kIGxpdmUgcmVnaW9uIG5vdGlmaWNhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDMwCisKKyAgICAgICAgV2Via2l0IHB1 cnBvc2VmdWxseSBkb2VzIG5vdCBzZW5kIGxpdmUgcmVnaW9uIG5vdGlmaWNhdGlvbnMgaWYgc29t ZSBBVCBjbGllbnQgaGFzIG5vdCBhY2Nlc3NlZCB0aGUgQVggdHJlZSBpbiBiZXR3ZWVuIAorICAg ICAgICB0aGUgbGFzdCBsaXZlIHJlZ2lvbiB1cGRhdGUgKG9zdGVuc2libHkgdG8gaW1wcm92ZSBw ZXJmb3JtYW5jZSkuCisgICAgICAgIEhvd2V2ZXIsIHRoaXMgaXMgcHJvYmxlbWF0aWMgaWYgYSBz Y3JlZW4gcmVhZGVyIG1pc3NlcyBvbmUgbm90aWZpY2F0aW9uLi4uIGl0IGhhcyBubyBpZGVhIHdo YXQgaGFwcGVuZWQgYW5kIHRoZSBvbmx5IAorICAgICAgICByZWNvdXJzZSBpcyB0byByZXNjYW4g dGhlIHBhZ2UgZm9yIGNoYW5nZXMuIFRoZSBjb3JyZWN0IHRoaW5nIHRvIGRvIGlzIHRvIGFsd2F5 cyBzZW5kIG5vdGlmaWNhdGlvbnMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1saXZl cmVnaW9ucy1ub3RpZmljYXRpb25zLWFsd2F5cy1zZW50Lmh0bWwKKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpjaGlsZHJlbkNoYW5nZWQpOgorCiAyMDExLTEw LTEzICBEZWVwYWsgU2hlcnZlZ2hhciAgPGJwd3Y2NEBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTiAocjk1MzgxKTogU3RhbmRhbG9uZSB2aWRlbyBjYW4gYmUgZm9jdXNlZCBhbmQg ZHJhd3MgYSBmb2N1cyByaW5nLgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiA5 NzI5OSkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0MzAsMjAgKzM0MzAsMTggQEAKICAgICAg ICAgICAgIHNlbnRDaGlsZHJlbkNoYW5nZWQgPSB0cnVlOwogICAgICAgICB9CiAgICAgICAgIAot ICAgICAgICAvLyBPbmx5IGRvIHdvcmsgaWYgdGhlIGNoaWxkcmVuIGhhdmVuJ3QgYmVlbiBtYXJr ZWQgZGlydHkuIFRoaXMgaGFzIHRoZSBlZmZlY3Qgb2YgYmxvY2tpbmcKLSAgICAgICAgLy8gZnV0 dXJlIGxpdmUgcmVnaW9uIGNoYW5nZSBub3RpZmljYXRpb25zIHVudGlsIHRoZSBBWCB0cmVlIGhh cyBiZWVuIGFjY2Vzc2VkIGFnYWluLiBUaGlzCi0gICAgICAgIC8vIGlzIGEgZ29vZCBwZXJmb3Jt YW5jZSB3aW4gZm9yIGFsbCBwYXJ0aWVzLgotICAgICAgICBpZiAoIWF4UGFyZW50LT5uZWVkc1Rv VXBkYXRlQ2hpbGRyZW4oKSkgewotICAgICAgICAgICAgYXhQYXJlbnQtPnNldE5lZWRzVG9VcGRh dGVDaGlsZHJlbigpOwotICAgICAgICAgICAgCi0gICAgICAgICAgICAvLyBJZiB0aGlzIGVsZW1l bnQgc3VwcG9ydHMgQVJJQSBsaXZlIHJlZ2lvbnMsIHRoZW4gbm90aWZ5IHRoZSBBVCBvZiBjaGFu Z2VzLgotICAgICAgICAgICAgaWYgKGF4UGFyZW50LT5zdXBwb3J0c0FSSUFMaXZlUmVnaW9uKCkp Ci0gICAgICAgICAgICAgICAgYXhPYmplY3RDYWNoZSgpLT5wb3N0Tm90aWZpY2F0aW9uKGF4UGFy ZW50LT5yZW5kZXJlcigpLCBBWE9iamVjdENhY2hlOjpBWExpdmVSZWdpb25DaGFuZ2VkLCB0cnVl KTsKKyAgICAgICAgYXhQYXJlbnQtPnNldE5lZWRzVG9VcGRhdGVDaGlsZHJlbigpOworICAgICAg ICAKKyAgICAgICAgLy8gVGhlc2Ugbm90aWZpY2F0aW9ucyBhbHdheXMgbmVlZCB0byBiZSBzZW50 IGJlY2F1c2Ugc2NyZWVucmVhZGVycyBhcmUgcmVsaWFudCBvbiB0aGVtIHRvIHBlcmZvcm0uIAor ICAgICAgICAvLyBJbiBvdGhlciB3b3JkcywgdGhleSBuZWVkIHRvIGJlIHNlbnQgZXZlbiB3aGVu IHRoZSBzY3JlZW4gcmVhZGVyIGhhcyBub3QgYWNjZXNzZWQgdGhpcyBsaXZlIHJlZ2lvbiBzaW5j ZSB0aGUgbGFzdCB1cGRhdGUuCiAKLSAgICAgICAgICAgIC8vIElmIHRoaXMgZWxlbWVudCBpcyBh biBBUklBIHRleHQgY29udHJvbCwgbm90aWZ5IHRoZSBBVCBvZiBjaGFuZ2VzLgotICAgICAgICAg ICAgaWYgKGF4UGFyZW50LT5pc0FSSUFUZXh0Q29udHJvbCgpICYmICFheFBhcmVudC0+aXNOYXRp dmVUZXh0Q29udHJvbCgpICYmICFheFBhcmVudC0+bm9kZSgpLT5pc0NvbnRlbnRFZGl0YWJsZSgp KQotICAgICAgICAgICAgICAgIGF4T2JqZWN0Q2FjaGUoKS0+cG9zdE5vdGlmaWNhdGlvbihheFBh cmVudC0+cmVuZGVyZXIoKSwgQVhPYmplY3RDYWNoZTo6QVhWYWx1ZUNoYW5nZWQsIHRydWUpOwot ICAgICAgICB9CisgICAgICAgIC8vIElmIHRoaXMgZWxlbWVudCBzdXBwb3J0cyBBUklBIGxpdmUg cmVnaW9ucywgdGhlbiBub3RpZnkgdGhlIEFUIG9mIGNoYW5nZXMuCisgICAgICAgIGlmIChheFBh cmVudC0+c3VwcG9ydHNBUklBTGl2ZVJlZ2lvbigpKQorICAgICAgICAgICAgYXhPYmplY3RDYWNo ZSgpLT5wb3N0Tm90aWZpY2F0aW9uKGF4UGFyZW50LT5yZW5kZXJlcigpLCBBWE9iamVjdENhY2hl OjpBWExpdmVSZWdpb25DaGFuZ2VkLCB0cnVlKTsKKyAgICAgICAgCisgICAgICAgIC8vIElmIHRo aXMgZWxlbWVudCBpcyBhbiBBUklBIHRleHQgY29udHJvbCwgbm90aWZ5IHRoZSBBVCBvZiBjaGFu Z2VzLgorICAgICAgICBpZiAoYXhQYXJlbnQtPmlzQVJJQVRleHRDb250cm9sKCkgJiYgIWF4UGFy ZW50LT5pc05hdGl2ZVRleHRDb250cm9sKCkgJiYgIWF4UGFyZW50LT5ub2RlKCktPmlzQ29udGVu dEVkaXRhYmxlKCkpCisgICAgICAgICAgICBheE9iamVjdENhY2hlKCktPnBvc3ROb3RpZmljYXRp b24oYXhQYXJlbnQtPnJlbmRlcmVyKCksIEFYT2JqZWN0Q2FjaGU6OkFYVmFsdWVDaGFuZ2VkLCB0 cnVlKTsKICAgICB9CiB9CiAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NzM2NykKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTEw LTEzICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6 IHdlYmtpdCB3b24ndCBhbHdheXMgc2VuZCBsaXZlIHJlZ2lvbiBub3RpZmljYXRpb25zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDAzMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVnaW9ucy1ub3RpZmljYXRpb25zLWFsd2F5cy1zZW50 LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp dHkvYXJpYS1saXZlcmVnaW9ucy1ub3RpZmljYXRpb25zLWFsd2F5cy1zZW50Lmh0bWw6IEFkZGVk LgorCiAyMDExLTEwLTEzICBEZWVwYWsgU2hlcnZlZ2hhciAgPGJwd3Y2NEBtb3Rvcm9sYS5jb20+ CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjk1MzgxKTogU3RhbmRhbG9uZSB2aWRlbyBjYW4gYmUg Zm9jdXNlZCBhbmQgZHJhd3MgYSBmb2N1cyByaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVnaW9ucy1ub3RpZmljYXRpb25zLWFsd2F5 cy1zZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vz c2liaWxpdHkvYXJpYS1saXZlcmVnaW9ucy1ub3RpZmljYXRpb25zLWFsd2F5cy1zZW50Lmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9h cmlhLWxpdmVyZWdpb25zLW5vdGlmaWNhdGlvbnMtYWx3YXlzLXNlbnQuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw1NCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQg SFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0i Li4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdD4K K3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiByb2xlPSJncm91cCIgdGFiaW5kZXg9MCBp ZD0ibGl2ZXJlZ2lvbiIgYXJpYS1saXZlPSJwb2xpdGUiIGFyaWEtcmVsZXZhbnQ9ImFkZGl0aW9u cyI+CitUZXN0Cis8L2Rpdj4KKworPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJj b25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3Rz IHRoYXQgQVJJQSBsaXZlIHJlZ2lvbiBub3RpZmljYXRpb25zIGFyZSBzZW50IGV2ZW4gd2hlbiBh biBhc3Npc3RpdmUgdGVjaG5vbG9neSBpcyBub3QgYWNjZXNzaW5nIHRoZW0gZGlyZWN0bHkgb24g ZWFjaCB1cGRhdGUuIik7CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVy KSB7CisgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7 CisKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxpdmVyZWdpb24iKS5mb2N1cygp OworICAgICAgICBsaXZlUmVnaW9uID0gd2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZv Y3VzZWRFbGVtZW50OworCisgICAgICAgIHZhciBsaXZlUmVnaW9uQ2hhbmdlQ291bnQgPSAwOwor ICAgICAgICBmdW5jdGlvbiBhcmlhQ2FsbGJhY2sobm90aWZpY2F0aW9uKSB7CisgICAgICAgICAg IGlmIChub3RpZmljYXRpb24gPT0gIkFYTGl2ZVJlZ2lvbkNoYW5nZWQiKSB7CisgICAgICAgICAg ICAgICBsaXZlUmVnaW9uQ2hhbmdlQ291bnQrKzsKKyAgICAgICAgICAgICAgIGlmIChsaXZlUmVn aW9uQ2hhbmdlQ291bnQgPT0gMykgeworICAgICAgICAgICAgICAgICAgIGxpdmVSZWdpb24ucmVt b3ZlTm90aWZpY2F0aW9uTGlzdGVuZXIoKTsKKyAgICAgICAgICAgICAgICAgICB3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgICAgfQorICAgICAg ICAgICB9CisgICAgICAgIH0KKyAgICAgICAgdmFyIGFkZGVkTm90aWZpY2F0aW9uID0gbGl2ZVJl Z2lvbi5hZGROb3RpZmljYXRpb25MaXN0ZW5lcihhcmlhQ2FsbGJhY2spOworICAgICAgICBzaG91 bGRCZSgiYWRkZWROb3RpZmljYXRpb24iLCAidHJ1ZSIpOworCisgICAgICAgIC8vIHRoaXMgc2hv dWxkIHRyaWdnZXIgb3VyIGxpdmUgcmVnaW9uIGNhbGxiYWNrIGZvciBhIG5ldyBlbGVtZW50Lgor ICAgICAgICBmb3IgKHZhciBrID0gMDsgayA8IDM7IGsrKykgeworICAgICAgICAgICB2YXIgdGV4 dE5vZGUgPSBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgidGVzdCIgKyBrKTsKKyAgICAgICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxpdmVyZWdpb24iKS5hcHBlbmRDaGlsZCh0ZXh0Tm9k ZSk7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwor PC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVnaW9ucy1ub3RpZmljYXRp b25zLWFsd2F5cy1zZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWxpdmVyZWdpb25zLW5vdGlmaWNhdGlvbnMt YWx3YXlzLXNlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1saXZlcmVnaW9ucy1ub3RpZmljYXRpb25zLWFs d2F5cy1zZW50LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorVGVz dCB0ZXN0MHRlc3QxdGVzdDIKK1RoaXMgdGVzdHMgdGhhdCBBUklBIGxpdmUgcmVnaW9uIG5vdGlm aWNhdGlvbnMgYXJlIHNlbnQgZXZlbiB3aGVuIGFuIGFzc2lzdGl2ZSB0ZWNobm9sb2d5IGlzIG5v dCBhY2Nlc3NpbmcgdGhlbSBkaXJlY3RseSBvbiBlYWNoIHVwZGF0ZS4KKworT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgorCisKK1BBU1MgYWRkZWROb3RpZmljYXRpb24gaXMgdHJ1ZQorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK