70016 2011-10-13 04:33:04 -0700 [WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError. 2011-10-14 13:57:22 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 70040 1 nayankk webkit-unassigned webkit.review.bot oldest_to_newest 483115 0 nayankk 2011-10-13 04:33:04 -0700 Documentation is missing for WebKitPluginError and WebKitPolicyError 483120 1 110826 nayankk 2011-10-13 04:43:36 -0700 Created attachment 110826 Add missing documentation 483204 2 110826 mrobinson 2011-10-13 08:32:51 -0700 Comment on attachment 110826 Add missing documentation View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review Looks good, except for one small nit. > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58 > + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown url should actually say "URI" This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug. 483312 3 110879 nayankk 2011-10-13 10:57:55 -0700 Created attachment 110879 Add missing documentation 483313 4 110826 nayankk 2011-10-13 10:59:17 -0700 Comment on attachment 110826 Add missing documentation View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review >> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58 >> + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown > > url should actually say "URI" > > This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug. Bug https://bugs.webkit.org/show_bug.cgi?id=70040has been raised to rename this enum. I will submit the patch for this rename soon. 484261 5 110879 webkit.review.bot 2011-10-14 13:57:18 -0700 Comment on attachment 110879 Add missing documentation Clearing flags on attachment: 110879 Committed r97503: <http://trac.webkit.org/changeset/97503> 484262 6 webkit.review.bot 2011-10-14 13:57:22 -0700 All reviewed patches have been landed. Closing bug. 110826 2011-10-13 04:43:36 -0700 2011-10-13 10:59:17 -0700 Add missing documentation AddDocumentation.diff text/plain 2688 nayankk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YmMzYzQwLi44MWIxYzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMTMgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KKwor ICAgICAgICBbV2ViS2l0Ml1bZ3RrXSBBZGQgZG9jdW1lbnRhdGlvbiBmb3IgV2ViS2l0UGx1Z2lu RXJyb3IgYW5kIFdlYktpdFBvbGljeUVycm9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAwMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVycm9yLmg6CisK IDIwMTEtMTAtMTIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAg ICAgICBQYXNzIFBhcnNlZCBBY2NlcHQgQXR0cmlidXRlIE1JTUUgVHlwZXMgdG8gV2ViS2l0IENs aWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dEVycm9yLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFcnJvci5o CmluZGV4IGZhNTA2ZWYuLjBmZGViY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdEVycm9yLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0RXJyb3IuaApAQCAtNDIsNyArNDIsNiBAQCBHX0JFR0lOX0RFQ0xTCiAg KiBAV0VCS0lUX05FVFdPUktfRVJST1JfRklMRV9ET0VTX05PVF9FWElTVDogTG9hZCBmYWlsdXJl IGR1ZSB0byBtaXNzaW5nIGZpbGUKICAqCiAgKiBFbnVtIHZhbHVlcyB1c2VkIHRvIGRlbm90ZSB0 aGUgdmFyaW91cyBuZXR3b3JrIGVycm9ycy4KLSAqCiAgKiovCiB0eXBlZGVmIGVudW0gewogICAg IFdFQktJVF9ORVRXT1JLX0VSUk9SX0ZBSUxFRCA9IDM5OSwKQEAgLTUyLDYgKzUxLDE2IEBAIHR5 cGVkZWYgZW51bSB7CiAgICAgV0VCS0lUX05FVFdPUktfRVJST1JfRklMRV9ET0VTX05PVF9FWElT VCA9IDMwMwogfSBXZWJLaXROZXR3b3JrRXJyb3I7CiAKKy8qKgorICogV2ViS2l0UG9saWN5RXJy b3I6CisgKiBAV0VCS0lUX1BPTElDWV9FUlJPUl9GQUlMRUQ6IEdlbmVyaWMgbG9hZCBmYWlsdXJl IGR1ZSB0byBwb2xpY3kgZXJyb3IKKyAqIEBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9TSE9X X01JTUVfVFlQRTogTG9hZCBmYWlsdXJlIGR1ZSB0byB1bnN1cHBvcnRlZCBtaW1lIHR5cGUKKyAq IEBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9TSE9XX1VSTDogTG9hZCBmYWlsdXJlIGR1ZSB0 byB1cmwgdGhhdCBjYW4gbm90IGJlIHNob3duCisgKiBAV0VCS0lUX1BPTElDWV9FUlJPUl9GUkFN RV9MT0FEX0lOVEVSUlVQVEVEX0JZX1BPTElDWV9DSEFOR0U6IExvYWQgZmFpbHVyZSBkdWUgdG8g ZnJhbWUgbG9hZCBpbnRlcnJ1cHRpb24gYnkgcG9saWN5IGNoYW5nZQorICogQFdFQktJVF9QT0xJ Q1lfRVJST1JfQ0FOTk9UX1VTRV9SRVNUUklDVEVEX1BPUlQ6IExvYWQgZmFpbHVyZSBkdWUgdG8g cG9ydCByZXN0cmljdGlvbgorICoKKyAqIEVudW0gdmFsdWVzIHVzZWQgdG8gZGVub3RlIHRoZSB2 YXJpb3VzIHBvbGljeSBlcnJvcnMuCisgKiovCiB0eXBlZGVmIGVudW0gewogICAgIFdFQktJVF9Q T0xJQ1lfRVJST1JfRkFJTEVEID0gMTk5LAogICAgIFdFQktJVF9QT0xJQ1lfRVJST1JfQ0FOTk9U X1NIT1dfTUlNRV9UWVBFID0gMTAwLApAQCAtNjAsNiArNjksMTcgQEAgdHlwZWRlZiBlbnVtIHsK ICAgICBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9VU0VfUkVTVFJJQ1RFRF9QT1JUID0gMTAz CiB9IFdlYktpdFBvbGljeUVycm9yOwogCisvKioKKyAqIFdlYktpdFBsdWdpbkVycm9yOgorICog QFdFQktJVF9QTFVHSU5fRVJST1JfRkFJTEVEOiBHZW5lcmljIHBsdWdpbiBsb2FkIGZhaWx1cmUK KyAqIEBXRUJLSVRfUExVR0lOX0VSUk9SX0NBTk5PVF9GSU5EX1BMVUdJTjogTG9hZCBmYWlsdXJl IGR1ZSB0byBtaXNzaW5nIHBsdWdpbgorICogQFdFQktJVF9QTFVHSU5fRVJST1JfQ0FOTk9UX0xP QURfUExVR0lOOiBMb2FkIGZhaWx1cmUgZHVlIHRvIGluYWJpbGl0eSB0byBsb2FkIHBsdWdpbgor ICogQFdFQktJVF9QTFVHSU5fRVJST1JfSkFWQV9VTkFWQUlMQUJMRTogTG9hZCBmYWlsdWUgZHVl IHRvIG1pc3NpbmcgSmF2YSBzdXBwb3J0IHRoYXQgaXMgcmVxdWlyZWQgdG8gbG9hZCBwbHVnaW4K KyAqIEBXRUJLSVRfUExVR0lOX0VSUk9SX0NPTk5FQ1RJT05fQ0FOQ0VMTEVEOiBMb2FkIGZhaWx1 cmUgZHVlIHRvIGNvbm5lY3Rpb24gY2FuY2VsbGF0aW9uCisgKiBAV0VCS0lUX1BMVUdJTl9FUlJP Ul9XSUxMX0hBTkRMRV9MT0FEOiBMb2FkIGZhaWx1cmUgc2luY2UgcGx1Z2luIGhhbmRsZXMgdGhl IGxvYWQKKyAqCisgKiBFbnVtIHZhbHVlcyB1c2VkIHRvIGRlbm90ZSB0aGUgdmFyaW91cyBwbHVn aW4gZXJyb3JzLgorICoqLwogdHlwZWRlZiBlbnVtIHsKICAgICBXRUJLSVRfUExVR0lOX0VSUk9S X0ZBSUxFRCA9IDI5OSwKICAgICBXRUJLSVRfUExVR0lOX0VSUk9SX0NBTk5PVF9GSU5EX1BMVUdJ TiA9IDIwMCwK 110879 2011-10-13 10:57:55 -0700 2011-10-14 13:57:18 -0700 Add missing documentation DocumentationAddition.diff text/plain 2688 nayankk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YmMzYzQwLi44MWIxYzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMTMgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KKwor ICAgICAgICBbV2ViS2l0Ml1bZ3RrXSBBZGQgZG9jdW1lbnRhdGlvbiBmb3IgV2ViS2l0UGx1Z2lu RXJyb3IgYW5kIFdlYktpdFBvbGljeUVycm9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAwMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVycm9yLmg6CisK IDIwMTEtMTAtMTIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAg ICAgICBQYXNzIFBhcnNlZCBBY2NlcHQgQXR0cmlidXRlIE1JTUUgVHlwZXMgdG8gV2ViS2l0IENs aWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dEVycm9yLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFcnJvci5o CmluZGV4IGZhNTA2ZWYuLjM0OTI0ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdEVycm9yLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0RXJyb3IuaApAQCAtNDIsNyArNDIsNiBAQCBHX0JFR0lOX0RFQ0xTCiAg KiBAV0VCS0lUX05FVFdPUktfRVJST1JfRklMRV9ET0VTX05PVF9FWElTVDogTG9hZCBmYWlsdXJl IGR1ZSB0byBtaXNzaW5nIGZpbGUKICAqCiAgKiBFbnVtIHZhbHVlcyB1c2VkIHRvIGRlbm90ZSB0 aGUgdmFyaW91cyBuZXR3b3JrIGVycm9ycy4KLSAqCiAgKiovCiB0eXBlZGVmIGVudW0gewogICAg IFdFQktJVF9ORVRXT1JLX0VSUk9SX0ZBSUxFRCA9IDM5OSwKQEAgLTUyLDYgKzUxLDE2IEBAIHR5 cGVkZWYgZW51bSB7CiAgICAgV0VCS0lUX05FVFdPUktfRVJST1JfRklMRV9ET0VTX05PVF9FWElT VCA9IDMwMwogfSBXZWJLaXROZXR3b3JrRXJyb3I7CiAKKy8qKgorICogV2ViS2l0UG9saWN5RXJy b3I6CisgKiBAV0VCS0lUX1BPTElDWV9FUlJPUl9GQUlMRUQ6IEdlbmVyaWMgbG9hZCBmYWlsdXJl IGR1ZSB0byBwb2xpY3kgZXJyb3IKKyAqIEBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9TSE9X X01JTUVfVFlQRTogTG9hZCBmYWlsdXJlIGR1ZSB0byB1bnN1cHBvcnRlZCBtaW1lIHR5cGUKKyAq IEBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9TSE9XX1VSTDogTG9hZCBmYWlsdXJlIGR1ZSB0 byBVUkkgdGhhdCBjYW4gbm90IGJlIHNob3duCisgKiBAV0VCS0lUX1BPTElDWV9FUlJPUl9GUkFN RV9MT0FEX0lOVEVSUlVQVEVEX0JZX1BPTElDWV9DSEFOR0U6IExvYWQgZmFpbHVyZSBkdWUgdG8g ZnJhbWUgbG9hZCBpbnRlcnJ1cHRpb24gYnkgcG9saWN5IGNoYW5nZQorICogQFdFQktJVF9QT0xJ Q1lfRVJST1JfQ0FOTk9UX1VTRV9SRVNUUklDVEVEX1BPUlQ6IExvYWQgZmFpbHVyZSBkdWUgdG8g cG9ydCByZXN0cmljdGlvbgorICoKKyAqIEVudW0gdmFsdWVzIHVzZWQgdG8gZGVub3RlIHRoZSB2 YXJpb3VzIHBvbGljeSBlcnJvcnMuCisgKiovCiB0eXBlZGVmIGVudW0gewogICAgIFdFQktJVF9Q T0xJQ1lfRVJST1JfRkFJTEVEID0gMTk5LAogICAgIFdFQktJVF9QT0xJQ1lfRVJST1JfQ0FOTk9U X1NIT1dfTUlNRV9UWVBFID0gMTAwLApAQCAtNjAsNiArNjksMTcgQEAgdHlwZWRlZiBlbnVtIHsK ICAgICBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9VU0VfUkVTVFJJQ1RFRF9QT1JUID0gMTAz CiB9IFdlYktpdFBvbGljeUVycm9yOwogCisvKioKKyAqIFdlYktpdFBsdWdpbkVycm9yOgorICog QFdFQktJVF9QTFVHSU5fRVJST1JfRkFJTEVEOiBHZW5lcmljIHBsdWdpbiBsb2FkIGZhaWx1cmUK KyAqIEBXRUJLSVRfUExVR0lOX0VSUk9SX0NBTk5PVF9GSU5EX1BMVUdJTjogTG9hZCBmYWlsdXJl IGR1ZSB0byBtaXNzaW5nIHBsdWdpbgorICogQFdFQktJVF9QTFVHSU5fRVJST1JfQ0FOTk9UX0xP QURfUExVR0lOOiBMb2FkIGZhaWx1cmUgZHVlIHRvIGluYWJpbGl0eSB0byBsb2FkIHBsdWdpbgor ICogQFdFQktJVF9QTFVHSU5fRVJST1JfSkFWQV9VTkFWQUlMQUJMRTogTG9hZCBmYWlsdWUgZHVl IHRvIG1pc3NpbmcgSmF2YSBzdXBwb3J0IHRoYXQgaXMgcmVxdWlyZWQgdG8gbG9hZCBwbHVnaW4K KyAqIEBXRUJLSVRfUExVR0lOX0VSUk9SX0NPTk5FQ1RJT05fQ0FOQ0VMTEVEOiBMb2FkIGZhaWx1 cmUgZHVlIHRvIGNvbm5lY3Rpb24gY2FuY2VsbGF0aW9uCisgKiBAV0VCS0lUX1BMVUdJTl9FUlJP Ul9XSUxMX0hBTkRMRV9MT0FEOiBMb2FkIGZhaWx1cmUgc2luY2UgcGx1Z2luIGhhbmRsZXMgdGhl IGxvYWQKKyAqCisgKiBFbnVtIHZhbHVlcyB1c2VkIHRvIGRlbm90ZSB0aGUgdmFyaW91cyBwbHVn aW4gZXJyb3JzLgorICoqLwogdHlwZWRlZiBlbnVtIHsKICAgICBXRUJLSVRfUExVR0lOX0VSUk9S X0ZBSUxFRCA9IDI5OSwKICAgICBXRUJLSVRfUExVR0lOX0VSUk9SX0NBTk5PVF9GSU5EX1BMVUdJ TiA9IDIwMCwK