70009 2011-10-13 01:53:44 -0700 16% of total time loading html5 spec (PerformanceTests/Parser/html5-full-render.html) is spent under updateWidgetIfNecessary 2013-01-29 19:19:09 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 45049 68944 1 eric eric abarth ap dglazkov esprehn kling koivisto laszlo.gombos mario.bensi simon.fraser tonikitoo webkit.review.bot oldest_to_newest 483067 0 eric 2011-10-13 01:53:44 -0700 16% of total time loading html5 spec (PerformanceTests/Parser/html5-full-render.html) is spent under updateWidgetIfNecessary Running (Self) Symbol Name 4690.0ms 21.7% WebCore::HTMLConstructionSite::insertHTMLElement(WebCore::AtomicHTMLToken&) 4546.0ms 21.0% WTF::PassRefPtr<WebCore::Element> WebCore::HTMLConstructionSite::attach<WebCore::Element>(WebCore::ContainerNode*, WTF::PassRefPtr<WebCore::Element>) 4348.0ms 20.1% WebCore::Element::attach() 3491.0ms 16.1% WebCore::ContainerNode::resumePostAttachCallbacks() 3486.0ms 16.1% WebCore::ContainerNode::dispatchPostAttachCallbacks() 3485.0ms 16.1% WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary() 3485.0ms 16.1% WebCore::Document::updateStyleIfNeeded() 3485.0ms 16.1% WebCore::Document::recalcStyle(WebCore::Node::StyleChange) basically we're updating style more often than we need to due to *two* <object> tags in the spec. Post attach-callbacks for the loss. 483078 1 110814 eric 2011-10-13 02:21:47 -0700 Created attachment 110814 Patch 483088 2 110814 webkit.review.bot 2011-10-13 03:07:59 -0700 Comment on attachment 110814 Patch Attachment 110814 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10056165 New failing tests: svg/custom/getsvgdocument.html 483195 3 110814 simon.fraser 2011-10-13 08:20:03 -0700 Comment on attachment 110814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110814&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:171 > if (!needsWidgetUpdate() || useFallbackContent() || isImageType()) Do any of these require that style has been updated? 483345 4 abarth 2011-10-13 11:37:27 -0700 > Do any of these require that style has been updated? I asked Eric that last night and he said no. 483353 5 ap 2011-10-13 11:50:24 -0700 The test failure on EWS looks related to the change. 483356 6 eric 2011-10-13 11:58:34 -0700 Must be one of them. I will revert the change. I guess that's why I shouldn't write changes at 2am. :) 483370 7 abarth 2011-10-13 12:12:26 -0700 > I will revert the change. The change never landed, as far as I can tell. 486349 8 110814 eric 2011-10-18 15:18:32 -0700 Comment on attachment 110814 Patch This patch can't work it seems. I'm not sure what race the current code is depending on, but removing this style update will cause the load never to get kicked off for an <object> tag, and thus not correctly delay the onload event for the window, causing the getSVGDocument() test to fail. 486351 9 eric 2011-10-18 15:19:33 -0700 I spent some time investigating if I could disentangle the load from the renderer to no avail. I'll come back to this, but after I finish NRWT. This is part of the general idea of finally making display: none plugins load properly. 110814 2011-10-13 02:21:47 -0700 2011-10-18 15:18:32 -0700 Patch bug-70009-20111013022146.patch text/plain 2340 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTczNTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZjBjNjMzYWM5MGUyZmVj YjYxMzE1MzE5NDQ2ZDZiNTUyODIzZjIwLi44NzdmMjYxYWI5YjFhNzllNDU5ZjhmYzRkZDc5NzE0 ZjNmMzY4OWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMTAtMTMgIEVyaWMg U2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIDE2JSBvZiB0b3RhbCB0aW1lIGxv YWRpbmcgaHRtbDUgc3BlYyAoUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvaHRtbDUtZnVsbC1yZW5k ZXIuaHRtbCkgaXMgc3BlbnQgdW5kZXIgdXBkYXRlV2lkZ2V0SWZOZWNlc3NhcnkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMDA5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyB1bmNsZWFyIGlmIHRo aXMgaXMganVzdCBhIGJlbmNobWFyayB3aW4sIG9yIGEgd2luIGluIHRoZSB3aWxkIGFzIHdlbGwu CisgICAgICAgIEkgc3VzcGVjdCB0aGF0IHRoaXMgd2lsbCByZWR1Y2Ugb3VyIG51bWJlciBvciBz dHlsZSByZWNhbGNzIHdoZW4gbG9hZGluZworICAgICAgICBzb21lIHdlYnBhZ2VzLCB3aGljaCBp cyBnb29kLgorCisgICAgICAgIEEgYmV0dGVyIGZpeCB3b3VsZCBoYXZlIGJlZW4gdG8gbW92ZSBm cmFtZSBoYW5kbGluZyBvdXQgb2YgdGhlIHJlbmRlcnRyZWUKKyAgICAgICAgb3IgcmVtb3ZlIHRo ZSB3aG9sZSBwb3N0LWF0dGFjaCBjYWxsYmFjayBzeXN0ZW0sIGJ1dCBib3RoIG9mIHRob3NlIGFy ZSBtdWNoCisgICAgICAgIGxhcmdlciBjaGFuZ2VzIGZvciBhbm90aGVyIGRheS4KKworICAgICAg ICBUaGlzIHdhcyBhIDE0LjYlIHNwZWVkdXAgb24gdGhlIGh0bWw1LWZ1bGwtcmVuZGVyLmh0bWwg YmVuY2htYXJrLiA6KQorICAgICAgICA0MTc2OW1zIGZvciByOTczNTIgYmVmb3JlIHRoaXMgcGF0 Y2gsIGFuZCAzNTY0OW1zIGFmdGVyLgorCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnVw ZGF0ZVdpZGdldElmTmVjZXNzYXJ5KToKKyAgICAgICAgIC0gV2UgZG8gbm90IG5lZWQgdG8gdXBk YXRlIHN0eWxlIHRvIGNoZWNrIHRoZXNlIDMgYm9vbHMuCisKIDIwMTEtMTAtMTMgIEtlbnQgVGFt dXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjg5OTE1KTog PGlucHV0IHR5cGU9ZW1haWwgbXVsdGlwbGU+IGRvbid0IHNob3cgdGhlIGRlZmF1bHQgdmFsdWUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCmluZGV4 IDFjMDgzOTBkNTg0ZTcxN2I4MGUwZGY5YWZiMTkzOTY3NTlmMzU4MWMuLjcwNDdkNWVhYzQyODFj OTJhNzIwZDE0OGI3ZmRjNWQzNTBlNDFjN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcApAQCAtMTY1LDExICsxNjUsMTQgQEAgdm9pZCBIVE1M UGx1Z0luSW1hZ2VFbGVtZW50OjpkZXRhY2goKQogCiB2b2lkIEhUTUxQbHVnSW5JbWFnZUVsZW1l bnQ6OnVwZGF0ZVdpZGdldElmTmVjZXNzYXJ5KCkKIHsKLSAgICBkb2N1bWVudCgpLT51cGRhdGVT dHlsZUlmTmVlZGVkKCk7Ci0KKyAgICAvLyBUaGlzIGlzIGNhbGxlZCBhcyBhIHBvc3QtYXR0YWNo IGNhbGxiYWNrLCBkdXJpbmcgcGFyc2luZywgYW5kIGNhbiBjYXVzZQorICAgIC8vIHVzIHRvIHVw ZGF0ZSBzdHlsZSBtb3JlIG9mdGVuIHRoYXQgd2UgbmVlZC4gQmFpbCB3aXRob3V0IHVwZGF0aW5n CisgICAgLy8gc3R5bGUgaWYgd2UgY2FuIGdldCBhd2F5IHdpdGggaXQuCiAgICAgaWYgKCFuZWVk c1dpZGdldFVwZGF0ZSgpIHx8IHVzZUZhbGxiYWNrQ29udGVudCgpIHx8IGlzSW1hZ2VUeXBlKCkp CiAgICAgICAgIHJldHVybjsKIAorICAgIGRvY3VtZW50KCktPnVwZGF0ZVN0eWxlSWZOZWVkZWQo KTsKKyAgICAKICAgICBpZiAoIXJlbmRlckVtYmVkZGVkT2JqZWN0KCkgfHwgcmVuZGVyRW1iZWRk ZWRPYmplY3QoKS0+cGx1Z2luQ3Jhc2hlZE9yV2FzTWlzc2luZygpKQogICAgICAgICByZXR1cm47 CiAK