70002 2011-10-12 23:36:48 -0700 [EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes 2011-10-13 16:36:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck rakuco gyuyoung.kim joepeck leandro lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 483021 0 joepeck 2011-10-12 23:36:48 -0700 In r97336 and r97338 WebCore::FileChooserSettings deprecated its "acceptType" string in favor of a Vector<String> of MIME types "acceptMIMETypes". EFL should transition from the deprecated value to the new value. It looks to me as though the string was exposed to EFL API "ewk_view_run_open_panel". It sounds possible to update that from a char* to an Eina_List of strings. WebCore::FileChooserSettings is a struct of parameters for a <input type="file"> File Upload Dialog. Its passed to ports via ChomeClient::runOpenPanel. The deprecated string value was the unparsed "accept" attribute from the <input>. The new Vector value is the parsed MIME types from that "accept" attribute. This way all ports share the same parsing code for the different mime types listed in the "accept" attribute. The changes: <http://trac.webkit.org/changeset/97336> <http://trac.webkit.org/changeset/97338> Introduced in the following: <http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients 483363 1 110884 rakuco 2011-10-13 12:07:05 -0700 Created attachment 110884 Proposed patch 483364 2 rakuco 2011-10-13 12:07:39 -0700 Hi, Joseph. There are no EFL reviewers, so it'd be nice if you could take a look at the patch yourself. 483391 3 110884 joepeck 2011-10-13 12:31:35 -0700 Comment on attachment 110884 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=110884&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:3265 > + * @param accept_types @c Eina_List of accepted MIME types as char pointers. The list and the items will be freed automatically. > * @selected_filenames List of files selected. > * > * @return @EINA_FALSE if user canceled file selection; @EINA_TRUE if confirmed. > */ > -Eina_Bool ewk_view_run_open_panel(Evas_Object* ewkView, Evas_Object* frame, Eina_Bool allowsMultipleFiles, const char* acceptTypes, Eina_List** selectedFilenames) > +Eina_Bool ewk_view_run_open_panel(Evas_Object* ewkView, Evas_Object* frame, Eina_Bool allowsMultipleFiles, const Vector<String>& acceptMIMETypes, Eina_List** selectedFilenames) I have a bunch of questions! Still r? until they are answered. The patch itself looks good though! The documentation and function seem at odds. I can't tell if the documentation is for the API's run_open_panel or for this ewk_view_run_open_panel. The parameter names "mostly" match the API function and not this function. Could you clarify that. I also found it interesting that you passed the Vector<String> into this function, instead of an Eina_List, and do the conversion here instead of in ChromeClientEfl. It looks like most of the ewk functions in this file take Eina* types and not WTF/WebCore types. I suppose it doesn't matter as long as the API calls have the right types but it would be nice to be consistent. One more consistency question. The rest of the file uses namespace prefixed types for WTF::Vector and WTF::String. You should probably follow suit there. 483393 4 joepeck 2011-10-13 12:33:29 -0700 (In reply to comment #2) > Hi, Joseph. There are no EFL reviewers, so it'd be nice if you could take a look > at the patch yourself. Sure! Thanks for the quick patches, the quick response is much appreciated! 483450 5 rakuco 2011-10-13 13:49:03 -0700 (In reply to comment #3) > The documentation and function seem at odds. I can't tell if the documentation is for the > API's run_open_panel or for this ewk_view_run_open_panel. The parameter names "mostly" > match the API function and not this function. Could you clarify that. Oops, I ended up confusing both too :) > I also found it interesting that you passed the Vector<String> into this function, instead of > an Eina_List, and do the conversion here instead of in ChromeClientEfl. It looks like most > of the ewk functions in this file take Eina* types and not WTF/WebCore types. I suppose > it doesn't matter as long as the API calls have the right types but it would be nice to be > consistent. ewk_view_run_open_panel is an internal function only visible to ewk and WebCoreSupport, so we can use WTF and other data types if we need to. As it is only the child object API that is C and written by third-parties, I chose to keep the vector as long as possible and defer the ugly WTF->EFL glue. > One more consistency question. The rest of the file uses namespace prefixed types for > WTF::Vector and WTF::String. You should probably follow suit there. Will do. Patch following in a second. 483451 6 110898 rakuco 2011-10-13 13:50:50 -0700 Created attachment 110898 Proposed patch, v2 483492 7 110898 joepeck 2011-10-13 14:28:51 -0700 Comment on attachment 110898 Proposed patch, v2 Excellent, this looks much better. Thanks! 483495 8 joepeck 2011-10-13 14:30:16 -0700 (In reply to comment #7) > (From update of attachment 110898 [details]) > Excellent, this looks much better. Thanks! I don't see you in committers.py, do you need me to cq+? 483496 9 rakuco 2011-10-13 14:31:09 -0700 Yes, I was going to ask for a cq+ but you were faster ;) I haven't been nominated for a commit account yet. 483554 10 joepeck 2011-10-13 15:23:55 -0700 (In reply to comment #9) > Yes, I was going to ask for a cq+ but you were faster ;) I haven't been nominated for a commit account yet. With ~50 patches landed you should be eligible at least for commit access! http://trac.webkit.org/search?q=kubo%40profusion.mobi&noquickjump=1&changeset=on Do you know offhand who typically reviews your patches? 483557 11 rakuco 2011-10-13 15:27:26 -0700 (In reply to comment #10) > Do you know offhand who typically reviews your patches? In general, tonikitoo, kenneth and rniwa. tkent and mrobinson have also reviewed some patches over time. 483627 12 110898 webkit.review.bot 2011-10-13 16:36:42 -0700 Comment on attachment 110898 Proposed patch, v2 Clearing flags on attachment: 110898 Committed r97421: <http://trac.webkit.org/changeset/97421> 483628 13 webkit.review.bot 2011-10-13 16:36:47 -0700 All reviewed patches have been landed. Closing bug. 110884 2011-10-13 12:07:05 -0700 2011-10-13 13:50:41 -0700 Proposed patch bug-70002-20111013160718.patch text/plain 6818 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTczNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkODg3YmI4OWJj NTkzNDJmYzdiMzE3MzA1Mzk2MWJjMDMyYjc3NTQ5Li5lN2Y4YjI5YTQ4ZjM0NmVjYzUzYzU5MjA4 OTVmNzZhNTYwNDE1MDYyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEt MTAtMTMgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF06IE1vdmUgZnJvbSBGaWxlQ2hvb3NlclNldHRpbmdzIGRlcHJlY2F0ZWRBY2Nl cHRUeXBlIHRvIGFjY2VwdE1JTUVUeXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzAwMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGFwdCB0byB0aGUgY2hhbmdlcyBpbnRyb2R1Y2VkIGluIHI5NzMz NiBhbmQgcjk3MzM4IGJ5IHVzaW5nIGEgdmVjdG9yCisgICAgICAgIG9mIHN0cmluZ3MgaW5zdGVh ZCBvZiBhIHNpbmdsZSBzdHJpbmcgaW4gcnVuT3BlblBhbmVsKCkuCisKKyAgICAgICAgKiBXZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21l Q2xpZW50RWZsOjpydW5PcGVuUGFuZWwpOgorICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgor ICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19ydW5fb3Blbl9w YW5lbCk6IENoYW5nZSBzaWduYXR1cmU7IGFjY2VwdCBhIFZlY3RvcjxTdHJpbmc+CisgICAgICAg IGluc3RlYWQgb2YgYSBjaGFyKi4gQnVpbGQgYW4gRWluYV9MaXN0IHRvIHBhc3MgZm9yIGNoaWxk IGNsYXNzZXMuCisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTEtMTAtMTIgIEpvc2Vw aCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBQYXNzIFBhcnNlZCBB Y2NlcHQgQXR0cmlidXRlIE1JTUUgVHlwZXMgdG8gV2ViS2l0IENsaWVudHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCmluZGV4 IDg3NWYzNTM2N2RhM2NmMjdkZmY5MjkwYTZjODJmOThkMjBhY2U3ZTYuLjhjOTllOWY4NTVjZmRh ODk4Nzk0MjcxOGFlZTI4MjRlOWNlZmJhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcApAQCAtNDI4LDEzICs0MjgsMTIg QEAgTm90aWZpY2F0aW9uUHJlc2VudGVyKiBDaHJvbWVDbGllbnRFZmw6Om5vdGlmaWNhdGlvblBy ZXNlbnRlcigpIGNvbnN0CiB2b2lkIENocm9tZUNsaWVudEVmbDo6cnVuT3BlblBhbmVsKEZyYW1l KiBmcmFtZSwgUGFzc1JlZlB0cjxGaWxlQ2hvb3Nlcj4gcHJwRmlsZUNob29zZXIpCiB7CiAgICAg UmVmUHRyPEZpbGVDaG9vc2VyPiBjaG9vc2VyID0gcHJwRmlsZUNob29zZXI7Ci0gICAgYm9vbCBj b25maXJtOwogICAgIEVpbmFfTGlzdCogc2VsZWN0ZWRGaWxlbmFtZXMgPSAwOwogICAgIHZvaWQq IGZpbGVuYW1lOwogICAgIFZlY3RvcjxTdHJpbmc+IGZpbGVuYW1lczsKIAotICAgIENTdHJpbmcg YWNjZXB0ID0gY2hvb3Nlci0+c2V0dGluZ3MoKS5kZXByZWNhdGVkQWNjZXB0VHlwZXMudXRmOCgp OwotICAgIGNvbmZpcm0gPSBld2tfdmlld19ydW5fb3Blbl9wYW5lbChtX3ZpZXcsIGtpdChmcmFt ZSksIGNob29zZXItPnNldHRpbmdzKCkuYWxsb3dzTXVsdGlwbGVGaWxlcywgYWNjZXB0LmRhdGEo KSwgJnNlbGVjdGVkRmlsZW5hbWVzKTsKKyAgICBjb25zdCBGaWxlQ2hvb3NlclNldHRpbmdzJiBz ZXR0aW5ncyA9IGNob29zZXItPnNldHRpbmdzKCk7CisgICAgYm9vbCBjb25maXJtID0gZXdrX3Zp ZXdfcnVuX29wZW5fcGFuZWwobV92aWV3LCBraXQoZnJhbWUpLCBzZXR0aW5ncy5hbGxvd3NNdWx0 aXBsZUZpbGVzLCBzZXR0aW5ncy5hY2NlcHRNSU1FVHlwZXMsICZzZWxlY3RlZEZpbGVuYW1lcyk7 CiAKICAgICBpZiAoIWNvbmZpcm0pCiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19wcml2YXRlLmgKaW5kZXggZjM4OTliZGU3ZjEyZmRjYWFkMWNiNmZiNjdmYTVhZDQwNTUyZTQx MS4uYjhmYzk1NzY0OTZlMTNlMWExNWMzZWQ2YzgyYjk0NjBkNThmMGRjYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTEyMSw3ICsxMjEsNyBAQCBFaW5hX0Jvb2wgZXdrX3Zp ZXdfcnVuX2phdmFzY3JpcHRfcHJvbXB0KEV2YXNfT2JqZWN0KiBvLCBFdmFzX09iamVjdCogZnJh bWUsIGNvbgogRWluYV9Cb29sIGV3a192aWV3X3Nob3VsZF9pbnRlcnJ1cHRfamF2YXNjcmlwdChF dmFzX09iamVjdCogbyk7CiB1aW50NjRfdCBld2tfdmlld19leGNlZWRlZF9kYXRhYmFzZV9xdW90 YShFdmFzX09iamVjdCogbywgRXZhc19PYmplY3QqIGZyYW1lLCBjb25zdCBjaGFyKiBkYXRhYmFz ZU5hbWUsIHVpbnQ2NF90IGN1cnJlbnRfc2l6ZSwgdWludDY0X3QgZXhwZWN0ZWRfc2l6ZSk7CiAK LUVpbmFfQm9vbCBld2tfdmlld19ydW5fb3Blbl9wYW5lbChFdmFzX09iamVjdCogbywgRXZhc19P YmplY3QqIGZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzX211bHRpcGxlX2ZpbGVzLCBjb25zdCBjaGFy KiBhY2NlcHRfdHlwZXMsIEVpbmFfTGlzdCoqIHNlbGVjdGVkX2ZpbGVuYW1lcyk7CitFaW5hX0Jv b2wgZXdrX3ZpZXdfcnVuX29wZW5fcGFuZWwoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV2YXNfT2Jq ZWN0KiBmcmFtZSwgRWluYV9Cb29sIGFsbG93c011bHRpcGxlRmlsZXMsIGNvbnN0IFZlY3RvcjxT dHJpbmc+JiBhY2NlcHRNSU1FVHlwZXMsIEVpbmFfTGlzdCoqIHNlbGVjdGVkRmlsZW5hbWVzKTsK IAogdm9pZCBld2tfdmlld19yZXBhaW50KEV2YXNfT2JqZWN0KiBvLCBFdmFzX0Nvb3JkIHgsIEV2 YXNfQ29vcmQgeSwgRXZhc19Db29yZCB3LCBFdmFzX0Nvb3JkIGgpOwogdm9pZCBld2tfdmlld19z Y3JvbGwoRXZhc19PYmplY3QqIG8sIEV2YXNfQ29vcmQgZHgsIEV2YXNfQ29vcmQgZHksIEV2YXNf Q29vcmQgc3gsIEV2YXNfQ29vcmQgc3ksIEV2YXNfQ29vcmQgc3csIEV2YXNfQ29vcmQgc2gsIEV2 YXNfQ29vcmQgY3gsIEV2YXNfQ29vcmQgY3ksIEV2YXNfQ29vcmQgY3csIEV2YXNfQ29vcmQgY2gs IEVpbmFfQm9vbCBtYWluX2ZyYW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4 IGYxOTczZTQzZGQ0ZTdhYzBhNmFiZmNhMDFkNTY3ZjgwYjQzZWQ3NTUuLjRkZWMxYmZhODQ1MGRj OTg5ZGQzMDE1OTlmMTAwNzFjMjVlOTk0MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNw cApAQCAtMzI1NywyNiArMzI1NywzNCBAQCB1aW50NjRfdCBld2tfdmlld19leGNlZWRlZF9kYXRh YmFzZV9xdW90YShFdmFzX09iamVjdCogZXdrVmlldywgRXZhc19PYmplY3QqIGZyYQogICogQHBh cmFtIGZyYW1lIEZyYW1lIGluIHdoaWNoIG9wZXJhdGlvbiBpcyByZXF1aXJlZC4KICAqIEBwYXJh bSBhbGxvd3NfbXVsdGlwbGVfZmlsZXMgQGMgRUlOQV9UUlVFIHdoZW4gbW9yZSB0aGFuIG9uZSBm aWxlIG1heSBiZQogICogc2VsZWN0ZWQsIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3aXNlCi0gKiBAcGFy YW0gYWNjZXB0X3R5cGVzIGFjY2VwdCBtaW1lIHR5cGVzCisgKiBAcGFyYW0gYWNjZXB0X3R5cGVz IEBjIEVpbmFfTGlzdCBvZiBhY2NlcHRlZCBNSU1FIHR5cGVzIGFzIGNoYXIgcG9pbnRlcnMuIFRo ZSBsaXN0IGFuZCB0aGUgaXRlbXMgd2lsbCBiZSBmcmVlZCBhdXRvbWF0aWNhbGx5LgogICogQHNl bGVjdGVkX2ZpbGVuYW1lcyBMaXN0IG9mIGZpbGVzIHNlbGVjdGVkLgogICoKICAqIEByZXR1cm4g QEVJTkFfRkFMU0UgaWYgdXNlciBjYW5jZWxlZCBmaWxlIHNlbGVjdGlvbjsgQEVJTkFfVFJVRSBp ZiBjb25maXJtZWQuCiAgKi8KLUVpbmFfQm9vbCBld2tfdmlld19ydW5fb3Blbl9wYW5lbChFdmFz X09iamVjdCogZXdrVmlldywgRXZhc19PYmplY3QqIGZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzTXVs dGlwbGVGaWxlcywgY29uc3QgY2hhciogYWNjZXB0VHlwZXMsIEVpbmFfTGlzdCoqIHNlbGVjdGVk RmlsZW5hbWVzKQorRWluYV9Cb29sIGV3a192aWV3X3J1bl9vcGVuX3BhbmVsKEV2YXNfT2JqZWN0 KiBld2tWaWV3LCBFdmFzX09iamVjdCogZnJhbWUsIEVpbmFfQm9vbCBhbGxvd3NNdWx0aXBsZUZp bGVzLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgYWNjZXB0TUlNRVR5cGVzLCBFaW5hX0xpc3QqKiBz ZWxlY3RlZEZpbGVuYW1lcykKIHsKICAgICBEQkcoImV3a1ZpZXc9JXAgZnJhbWU9JXAgYWxsb3dz X211bHRpcGxlX2ZpbGVzPSVkIiwgZXdrVmlldywgZnJhbWUsIGFsbG93c011bHRpcGxlRmlsZXMp OwogICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc2QsIEVJTkFfRkFMU0Up OwogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChzZC0+YXBpLCBFSU5BX0ZBTFNF KTsKLSAgICBFaW5hX0Jvb2wgY29uZmlybTsKIAogICAgIGlmICghc2QtPmFwaS0+cnVuX29wZW5f cGFuZWwpCiAgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOwogCiAgICAgKnNlbGVjdGVkRmlsZW5h bWVzID0gMDsKIAotICAgIGNvbmZpcm0gPSBzZC0+YXBpLT5ydW5fb3Blbl9wYW5lbChzZCwgZnJh bWUsIGFsbG93c011bHRpcGxlRmlsZXMsIGFjY2VwdFR5cGVzLCBzZWxlY3RlZEZpbGVuYW1lcyk7 CisgICAgRWluYV9MaXN0KiBjQWNjZXB0TUlNRVR5cGVzID0gMDsKKyAgICBmb3IgKFZlY3RvcjxT dHJpbmc+Ojpjb25zdF9pdGVyYXRvciBpdCA9IGFjY2VwdE1JTUVUeXBlcy5iZWdpbigpOyBpdCAh PSBhY2NlcHRNSU1FVHlwZXMuZW5kKCk7ICsraXQpCisgICAgICAgIGNBY2NlcHRNSU1FVHlwZXMg PSBlaW5hX2xpc3RfYXBwZW5kKGNBY2NlcHRNSU1FVHlwZXMsIHN0cmR1cCgoKml0KS51dGY4KCku ZGF0YSgpKSk7CisKKyAgICBib29sIGNvbmZpcm0gPSBzZC0+YXBpLT5ydW5fb3Blbl9wYW5lbChz ZCwgZnJhbWUsIGFsbG93c011bHRpcGxlRmlsZXMsIGNBY2NlcHRNSU1FVHlwZXMsIHNlbGVjdGVk RmlsZW5hbWVzKTsKICAgICBpZiAoIWNvbmZpcm0gJiYgKnNlbGVjdGVkRmlsZW5hbWVzKQogICAg ICAgICBFUlIoIkNhbmNlbGVkIGZpbGUgc2VsZWN0aW9uLCBidXQgc2VsZWN0ZWQgZmlsZW5hbWVz ICE9IDAuIEZyZWUgbmFtZXMgYmVmb3JlIHJldHVybi4iKTsKKworICAgIHZvaWQqIGl0ZW0gPSAw OworICAgIEVJTkFfTElTVF9GUkVFKGNBY2NlcHRNSU1FVHlwZXMsIGl0ZW0pCisgICAgICAgIGZy ZWUoaXRlbSk7CisKICAgICByZXR1cm4gY29uZmlybTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Zp ZXcuaAppbmRleCA1NWRiYjMyMDE1OWNkYzNkMmZhZmNkNDVkYjM1YTBmOWE4ZjQ1YTg4Li45ZmFi ODZkMmQzNmE2MzQ2ZWE0NThiODIzZGEwOWY3YmRkOTE0YTY0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuaApAQCAtMTU2LDcgKzE1Niw3IEBAIHN0cnVjdCBfRXdrX1ZpZXdfU21hcnRfQ2xhc3Mg ewogICAgIEVpbmFfQm9vbCAoKnNob3VsZF9pbnRlcnJ1cHRfamF2YXNjcmlwdCkoRXdrX1ZpZXdf U21hcnRfRGF0YSAqc2QpOwogICAgIHVpbnQ2NF90ICgqZXhjZWVkZWRfZGF0YWJhc2VfcXVvdGEp KEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkLCBFdmFzX09iamVjdCAqZnJhbWUsIGNvbnN0IGNoYXIg KmRhdGFiYXNlTmFtZSwgdWludDY0X3QgY3VycmVudF9zaXplLCB1aW50NjRfdCBleHBlY3RlZF9z aXplKTsKIAotICAgIEVpbmFfQm9vbCAoKnJ1bl9vcGVuX3BhbmVsKShFd2tfVmlld19TbWFydF9E YXRhICpzZCwgRXZhc19PYmplY3QgKmZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzX211bHRpcGxlX2Zp bGVzLCBjb25zdCBjaGFyICphY2NlcHRfdHlwZXMsIEVpbmFfTGlzdCAqKnNlbGVjdGVkX2ZpbGVu YW1lcyk7CisgICAgRWluYV9Cb29sICgqcnVuX29wZW5fcGFuZWwpKEV3a19WaWV3X1NtYXJ0X0Rh dGEgKnNkLCBFdmFzX09iamVjdCAqZnJhbWUsIEVpbmFfQm9vbCBhbGxvd3NfbXVsdGlwbGVfZmls ZXMsIEVpbmFfTGlzdCAqYWNjZXB0X3R5cGVzLCBFaW5hX0xpc3QgKipzZWxlY3RlZF9maWxlbmFt ZXMpOwogCiAgICAgRWluYV9Cb29sICgqbmF2aWdhdGlvbl9wb2xpY3lfZGVjaXNpb24pKEV3a19W aWV3X1NtYXJ0X0RhdGEgKnNkLCBFd2tfRnJhbWVfUmVzb3VyY2VfUmVxdWVzdCAqcmVxdWVzdCk7 CiAgICAgRWluYV9Cb29sICgqZm9jdXNfY2FuX2N5Y2xlKShFd2tfVmlld19TbWFydF9EYXRhICpz ZCwgRXdrX0ZvY3VzX0RpcmVjdGlvbiBkaXJlY3Rpb24pOwo= 110898 2011-10-13 13:50:50 -0700 2011-10-13 16:36:42 -0700 Proposed patch, v2 bug-70002-20111013175103.patch text/plain 7094 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTczNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkODg3YmI4OWJj NTkzNDJmYzdiMzE3MzA1Mzk2MWJjMDMyYjc3NTQ5Li5lN2Y4YjI5YTQ4ZjM0NmVjYzUzYzU5MjA4 OTVmNzZhNTYwNDE1MDYyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEt MTAtMTMgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF06IE1vdmUgZnJvbSBGaWxlQ2hvb3NlclNldHRpbmdzIGRlcHJlY2F0ZWRBY2Nl cHRUeXBlIHRvIGFjY2VwdE1JTUVUeXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzAwMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGFwdCB0byB0aGUgY2hhbmdlcyBpbnRyb2R1Y2VkIGluIHI5NzMz NiBhbmQgcjk3MzM4IGJ5IHVzaW5nIGEgdmVjdG9yCisgICAgICAgIG9mIHN0cmluZ3MgaW5zdGVh ZCBvZiBhIHNpbmdsZSBzdHJpbmcgaW4gcnVuT3BlblBhbmVsKCkuCisKKyAgICAgICAgKiBXZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21l Q2xpZW50RWZsOjpydW5PcGVuUGFuZWwpOgorICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgor ICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19ydW5fb3Blbl9w YW5lbCk6IENoYW5nZSBzaWduYXR1cmU7IGFjY2VwdCBhIFZlY3RvcjxTdHJpbmc+CisgICAgICAg IGluc3RlYWQgb2YgYSBjaGFyKi4gQnVpbGQgYW4gRWluYV9MaXN0IHRvIHBhc3MgZm9yIGNoaWxk IGNsYXNzZXMuCisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTEtMTAtMTIgIEpvc2Vw aCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBQYXNzIFBhcnNlZCBB Y2NlcHQgQXR0cmlidXRlIE1JTUUgVHlwZXMgdG8gV2ViS2l0IENsaWVudHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCmluZGV4 IDg3NWYzNTM2N2RhM2NmMjdkZmY5MjkwYTZjODJmOThkMjBhY2U3ZTYuLjhjOTllOWY4NTVjZmRh ODk4Nzk0MjcxOGFlZTI4MjRlOWNlZmJhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcApAQCAtNDI4LDEzICs0MjgsMTIg QEAgTm90aWZpY2F0aW9uUHJlc2VudGVyKiBDaHJvbWVDbGllbnRFZmw6Om5vdGlmaWNhdGlvblBy ZXNlbnRlcigpIGNvbnN0CiB2b2lkIENocm9tZUNsaWVudEVmbDo6cnVuT3BlblBhbmVsKEZyYW1l KiBmcmFtZSwgUGFzc1JlZlB0cjxGaWxlQ2hvb3Nlcj4gcHJwRmlsZUNob29zZXIpCiB7CiAgICAg UmVmUHRyPEZpbGVDaG9vc2VyPiBjaG9vc2VyID0gcHJwRmlsZUNob29zZXI7Ci0gICAgYm9vbCBj b25maXJtOwogICAgIEVpbmFfTGlzdCogc2VsZWN0ZWRGaWxlbmFtZXMgPSAwOwogICAgIHZvaWQq IGZpbGVuYW1lOwogICAgIFZlY3RvcjxTdHJpbmc+IGZpbGVuYW1lczsKIAotICAgIENTdHJpbmcg YWNjZXB0ID0gY2hvb3Nlci0+c2V0dGluZ3MoKS5kZXByZWNhdGVkQWNjZXB0VHlwZXMudXRmOCgp OwotICAgIGNvbmZpcm0gPSBld2tfdmlld19ydW5fb3Blbl9wYW5lbChtX3ZpZXcsIGtpdChmcmFt ZSksIGNob29zZXItPnNldHRpbmdzKCkuYWxsb3dzTXVsdGlwbGVGaWxlcywgYWNjZXB0LmRhdGEo KSwgJnNlbGVjdGVkRmlsZW5hbWVzKTsKKyAgICBjb25zdCBGaWxlQ2hvb3NlclNldHRpbmdzJiBz ZXR0aW5ncyA9IGNob29zZXItPnNldHRpbmdzKCk7CisgICAgYm9vbCBjb25maXJtID0gZXdrX3Zp ZXdfcnVuX29wZW5fcGFuZWwobV92aWV3LCBraXQoZnJhbWUpLCBzZXR0aW5ncy5hbGxvd3NNdWx0 aXBsZUZpbGVzLCBzZXR0aW5ncy5hY2NlcHRNSU1FVHlwZXMsICZzZWxlY3RlZEZpbGVuYW1lcyk7 CiAKICAgICBpZiAoIWNvbmZpcm0pCiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19wcml2YXRlLmgKaW5kZXggZjM4OTliZGU3ZjEyZmRjYWFkMWNiNmZiNjdmYTVhZDQwNTUyZTQx MS4uZTk2NmE1MzU5MDkwYzUyODIxNTVkYzgxNjg2NmU4Y2Y2NzNlMjViYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTEyMSw3ICsxMjEsNyBAQCBFaW5hX0Jvb2wgZXdrX3Zp ZXdfcnVuX2phdmFzY3JpcHRfcHJvbXB0KEV2YXNfT2JqZWN0KiBvLCBFdmFzX09iamVjdCogZnJh bWUsIGNvbgogRWluYV9Cb29sIGV3a192aWV3X3Nob3VsZF9pbnRlcnJ1cHRfamF2YXNjcmlwdChF dmFzX09iamVjdCogbyk7CiB1aW50NjRfdCBld2tfdmlld19leGNlZWRlZF9kYXRhYmFzZV9xdW90 YShFdmFzX09iamVjdCogbywgRXZhc19PYmplY3QqIGZyYW1lLCBjb25zdCBjaGFyKiBkYXRhYmFz ZU5hbWUsIHVpbnQ2NF90IGN1cnJlbnRfc2l6ZSwgdWludDY0X3QgZXhwZWN0ZWRfc2l6ZSk7CiAK LUVpbmFfQm9vbCBld2tfdmlld19ydW5fb3Blbl9wYW5lbChFdmFzX09iamVjdCogbywgRXZhc19P YmplY3QqIGZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzX211bHRpcGxlX2ZpbGVzLCBjb25zdCBjaGFy KiBhY2NlcHRfdHlwZXMsIEVpbmFfTGlzdCoqIHNlbGVjdGVkX2ZpbGVuYW1lcyk7CitFaW5hX0Jv b2wgZXdrX3ZpZXdfcnVuX29wZW5fcGFuZWwoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV2YXNfT2Jq ZWN0KiBmcmFtZSwgYm9vbCBhbGxvd3NNdWx0aXBsZUZpbGVzLCBjb25zdCBWZWN0b3I8U3RyaW5n PiYgYWNjZXB0TUlNRVR5cGVzLCBFaW5hX0xpc3QqKiBzZWxlY3RlZEZpbGVuYW1lcyk7CiAKIHZv aWQgZXdrX3ZpZXdfcmVwYWludChFdmFzX09iamVjdCogbywgRXZhc19Db29yZCB4LCBFdmFzX0Nv b3JkIHksIEV2YXNfQ29vcmQgdywgRXZhc19Db29yZCBoKTsKIHZvaWQgZXdrX3ZpZXdfc2Nyb2xs KEV2YXNfT2JqZWN0KiBvLCBFdmFzX0Nvb3JkIGR4LCBFdmFzX0Nvb3JkIGR5LCBFdmFzX0Nvb3Jk IHN4LCBFdmFzX0Nvb3JkIHN5LCBFdmFzX0Nvb3JkIHN3LCBFdmFzX0Nvb3JkIHNoLCBFdmFzX0Nv b3JkIGN4LCBFdmFzX0Nvb3JkIGN5LCBFdmFzX0Nvb3JkIGN3LCBFdmFzX0Nvb3JkIGNoLCBFaW5h X0Jvb2wgbWFpbl9mcmFtZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBmMTk3 M2U0M2RkNGU3YWMwYTZhYmZjYTAxZDU2N2Y4MGI0M2VkNzU1Li5lMGM5M2E4OWQ2ZTgyN2ZmNDYw MzQxM2M3NjVmYTIwNTM3ZGVkMWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAg LTMyNTMsMzAgKzMyNTMsMzcgQEAgdWludDY0X3QgZXdrX3ZpZXdfZXhjZWVkZWRfZGF0YWJhc2Vf cXVvdGEoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV2YXNfT2JqZWN0KiBmcmEKICAqIEBpbnRlcm5h bAogICogT3BlbiBwYW5lbCB0byBjaG9vc2UgYSBmaWxlLgogICoKLSAqIEBwYXJhbSBvIFZpZXcu CisgKiBAcGFyYW0gZXdrVmlldyBWaWV3LgogICogQHBhcmFtIGZyYW1lIEZyYW1lIGluIHdoaWNo IG9wZXJhdGlvbiBpcyByZXF1aXJlZC4KLSAqIEBwYXJhbSBhbGxvd3NfbXVsdGlwbGVfZmlsZXMg QGMgRUlOQV9UUlVFIHdoZW4gbW9yZSB0aGFuIG9uZSBmaWxlIG1heSBiZQotICogc2VsZWN0ZWQs IEBjIEVJTkFfRkFMU0Ugb3RoZXJ3aXNlCi0gKiBAcGFyYW0gYWNjZXB0X3R5cGVzIGFjY2VwdCBt aW1lIHR5cGVzCi0gKiBAc2VsZWN0ZWRfZmlsZW5hbWVzIExpc3Qgb2YgZmlsZXMgc2VsZWN0ZWQu CisgKiBAcGFyYW0gYWxsb3dzTXVsdGlwbGVGaWxlcyBAYyB0cnVlIHdoZW4gbW9yZSB0aGFuIG9u ZSBmaWxlIG1heSBiZSBzZWxlY3RlZCwgQGMgZmFsc2Ugb3RoZXJ3aXNlLgorICogQHBhcmFtIGFj Y2VwdE1JTUVUeXBlcyBMaXN0IG9mIGFjY2VwdGVkIG1pbWUgdHlwZXMuIEl0IGlzIHBhc3NlZCB0 byBjaGlsZCBvYmplY3RzIGFzIGFuIEVpbmFfTGlzdCBvZiBjaGFyIHBvaW50ZXJzIHRoYXQgaXMg ZnJlZWQgYXV0b21hdGljYWxseS4KKyAqIEBwYXJhbSBzZWxlY3RlZEZpbGVuYW1lcyBMaXN0IG9m IGZpbGVzIHNlbGVjdGVkLgogICoKICAqIEByZXR1cm4gQEVJTkFfRkFMU0UgaWYgdXNlciBjYW5j ZWxlZCBmaWxlIHNlbGVjdGlvbjsgQEVJTkFfVFJVRSBpZiBjb25maXJtZWQuCiAgKi8KLUVpbmFf Qm9vbCBld2tfdmlld19ydW5fb3Blbl9wYW5lbChFdmFzX09iamVjdCogZXdrVmlldywgRXZhc19P YmplY3QqIGZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzTXVsdGlwbGVGaWxlcywgY29uc3QgY2hhciog YWNjZXB0VHlwZXMsIEVpbmFfTGlzdCoqIHNlbGVjdGVkRmlsZW5hbWVzKQorRWluYV9Cb29sIGV3 a192aWV3X3J1bl9vcGVuX3BhbmVsKEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFdmFzX09iamVjdCog ZnJhbWUsIGJvb2wgYWxsb3dzTXVsdGlwbGVGaWxlcywgY29uc3QgV1RGOjpWZWN0b3I8V1RGOjpT dHJpbmc+JiBhY2NlcHRNSU1FVHlwZXMsIEVpbmFfTGlzdCoqIHNlbGVjdGVkRmlsZW5hbWVzKQog ewogICAgIERCRygiZXdrVmlldz0lcCBmcmFtZT0lcCBhbGxvd3NfbXVsdGlwbGVfZmlsZXM9JWQi LCBld2tWaWV3LCBmcmFtZSwgYWxsb3dzTXVsdGlwbGVGaWxlcyk7CiAgICAgRVdLX1ZJRVdfU0Rf R0VUX09SX1JFVFVSTihld2tWaWV3LCBzZCwgRUlOQV9GQUxTRSk7CiAgICAgRUlOQV9TQUZFVFlf T05fTlVMTF9SRVRVUk5fVkFMKHNkLT5hcGksIEVJTkFfRkFMU0UpOwotICAgIEVpbmFfQm9vbCBj b25maXJtOwogCiAgICAgaWYgKCFzZC0+YXBpLT5ydW5fb3Blbl9wYW5lbCkKICAgICAgICAgcmV0 dXJuIEVJTkFfRkFMU0U7CiAKICAgICAqc2VsZWN0ZWRGaWxlbmFtZXMgPSAwOwogCi0gICAgY29u ZmlybSA9IHNkLT5hcGktPnJ1bl9vcGVuX3BhbmVsKHNkLCBmcmFtZSwgYWxsb3dzTXVsdGlwbGVG aWxlcywgYWNjZXB0VHlwZXMsIHNlbGVjdGVkRmlsZW5hbWVzKTsKKyAgICBFaW5hX0xpc3QqIGNB Y2NlcHRNSU1FVHlwZXMgPSAwOworICAgIGZvciAoV1RGOjpWZWN0b3I8V1RGOjpTdHJpbmc+Ojpj b25zdF9pdGVyYXRvciBpdCA9IGFjY2VwdE1JTUVUeXBlcy5iZWdpbigpOyBpdCAhPSBhY2NlcHRN SU1FVHlwZXMuZW5kKCk7ICsraXQpCisgICAgICAgIGNBY2NlcHRNSU1FVHlwZXMgPSBlaW5hX2xp c3RfYXBwZW5kKGNBY2NlcHRNSU1FVHlwZXMsIHN0cmR1cCgoKml0KS51dGY4KCkuZGF0YSgpKSk7 CisKKyAgICBib29sIGNvbmZpcm0gPSBzZC0+YXBpLT5ydW5fb3Blbl9wYW5lbChzZCwgZnJhbWUs IGFsbG93c011bHRpcGxlRmlsZXMsIGNBY2NlcHRNSU1FVHlwZXMsIHNlbGVjdGVkRmlsZW5hbWVz KTsKICAgICBpZiAoIWNvbmZpcm0gJiYgKnNlbGVjdGVkRmlsZW5hbWVzKQogICAgICAgICBFUlIo IkNhbmNlbGVkIGZpbGUgc2VsZWN0aW9uLCBidXQgc2VsZWN0ZWQgZmlsZW5hbWVzICE9IDAuIEZy ZWUgbmFtZXMgYmVmb3JlIHJldHVybi4iKTsKKworICAgIHZvaWQqIGl0ZW0gPSAwOworICAgIEVJ TkFfTElTVF9GUkVFKGNBY2NlcHRNSU1FVHlwZXMsIGl0ZW0pCisgICAgICAgIGZyZWUoaXRlbSk7 CisKICAgICByZXR1cm4gY29uZmlybTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAppbmRl eCA1NWRiYjMyMDE1OWNkYzNkMmZhZmNkNDVkYjM1YTBmOWE4ZjQ1YTg4Li45ZmFiODZkMmQzNmE2 MzQ2ZWE0NThiODIzZGEwOWY3YmRkOTE0YTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApA QCAtMTU2LDcgKzE1Niw3IEBAIHN0cnVjdCBfRXdrX1ZpZXdfU21hcnRfQ2xhc3MgewogICAgIEVp bmFfQm9vbCAoKnNob3VsZF9pbnRlcnJ1cHRfamF2YXNjcmlwdCkoRXdrX1ZpZXdfU21hcnRfRGF0 YSAqc2QpOwogICAgIHVpbnQ2NF90ICgqZXhjZWVkZWRfZGF0YWJhc2VfcXVvdGEpKEV3a19WaWV3 X1NtYXJ0X0RhdGEgKnNkLCBFdmFzX09iamVjdCAqZnJhbWUsIGNvbnN0IGNoYXIgKmRhdGFiYXNl TmFtZSwgdWludDY0X3QgY3VycmVudF9zaXplLCB1aW50NjRfdCBleHBlY3RlZF9zaXplKTsKIAot ICAgIEVpbmFfQm9vbCAoKnJ1bl9vcGVuX3BhbmVsKShFd2tfVmlld19TbWFydF9EYXRhICpzZCwg RXZhc19PYmplY3QgKmZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzX211bHRpcGxlX2ZpbGVzLCBjb25z dCBjaGFyICphY2NlcHRfdHlwZXMsIEVpbmFfTGlzdCAqKnNlbGVjdGVkX2ZpbGVuYW1lcyk7Cisg ICAgRWluYV9Cb29sICgqcnVuX29wZW5fcGFuZWwpKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkLCBF dmFzX09iamVjdCAqZnJhbWUsIEVpbmFfQm9vbCBhbGxvd3NfbXVsdGlwbGVfZmlsZXMsIEVpbmFf TGlzdCAqYWNjZXB0X3R5cGVzLCBFaW5hX0xpc3QgKipzZWxlY3RlZF9maWxlbmFtZXMpOwogCiAg ICAgRWluYV9Cb29sICgqbmF2aWdhdGlvbl9wb2xpY3lfZGVjaXNpb24pKEV3a19WaWV3X1NtYXJ0 X0RhdGEgKnNkLCBFd2tfRnJhbWVfUmVzb3VyY2VfUmVxdWVzdCAqcmVxdWVzdCk7CiAgICAgRWlu YV9Cb29sICgqZm9jdXNfY2FuX2N5Y2xlKShFd2tfVmlld19TbWFydF9EYXRhICpzZCwgRXdrX0Zv Y3VzX0RpcmVjdGlvbiBkaXJlY3Rpb24pOwo=