6999 2006-02-01 01:56:06 -0800 Dynamically added link-tag disables the use of change styles dynamically 2006-03-18 03:22:28 -0800 1 1 1 Unclassified WebKit DOM 420+ PC Windows XP RESOLVED FIXED HasReduction, InRadar P2 Major --- 6628 1 sjoerdmulder alice.barraclough alice.barraclough ddkilzer hyatt oldest_to_newest 30929 0 sjoerdmulder 2006-02-01 01:56:06 -0800 If you dynamicly add a link-tag to the head, and after this change for example the href value of this link tag. Safari constantly seems to redraw elements which are change by changing a .style. propery through testcase. For more info see attached testcase 30930 1 6178 sjoerdmulder 2006-02-01 01:56:38 -0800 Created attachment 6178 Testcase 30939 2 ddkilzer 2006-02-01 04:36:09 -0800 Confirmed bug. Added HasReduction keyword. 31129 3 sjoerdmulder 2006-02-03 00:39:36 -0800 This bug is also in Radar: <rdar://4432162> 36170 4 alice.barraclough 2006-03-13 19:23:29 -0800 I tried a test case where the link tag wasn't a style sheet but just an href with the href being updated after appendChild and the flickering isn't observed. Looks like it needs to be a style sheet, but I haven't tried other types of link tags besides that one. 36641 5 7122 alice.barraclough 2006-03-16 20:08:54 -0800 Created attachment 7122 patch uploading patch 36642 6 alice.barraclough 2006-03-16 20:23:51 -0800 hmm, i dont know if i chose the right settings when i uploaded the patch. 36688 7 7122 hyatt 2006-03-17 00:36:35 -0800 Comment on attachment 7122 patch Looks good. One minor style quibble... we leave braces off single-line if statements, so: + if (m_loading) { + getDocument()->stylesheetLoaded(); + } should lose the braces. r=me 36741 8 ddkilzer 2006-03-17 05:38:12 -0800 (In reply to comment #7) > r=me Doesn't this patch need a LayoutTest, or can this not be tested automatically? 36841 9 ddkilzer 2006-03-18 03:22:28 -0800 This patch was applied as r13371. Updating state to RESOLVED FIXED. 6178 2006-02-01 01:56:38 -0800 2006-02-01 01:56:38 -0800 Testcase linkchange.html text/html 2212 sjoerdmulder PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIg0KCSJodHRw Oi8vd3d3LnczLm9yZy9UUi94aHRtbDExL0RURC94aHRtbDExLmR0ZCI+DQo8aHRtbCB4bWxucz0i aHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCIgeG1sOmxhbmc9ImVuIiA+DQo8aGVhZD4NCgk8 bWV0YSBodHRwLWVxdWl2PSJjb250ZW50LXR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNl dD1pc28tODg1OS0xIiAvPg0KCTx0aXRsZT5EcmFnIGZsaWNrZXIgLyBsaW5rIGFwcGVuZCB0ZXN0 PC90aXRsZT4NCg0KCTxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCg0KCQlmdW5jdGlv biBkcmFnc3RhcnQoZUV2ZW50KXsNCgkJCWVFdmVudC50YXJnZXQuYkRyYWcgPSB0cnVlOw0KCQl9 DQoNCgkJZnVuY3Rpb24gZHJhZ3N0b3AoZUV2ZW50KXsNCgkJCWVFdmVudC50YXJnZXQuYkRyYWcg PSBmYWxzZTsNCg0KCQl9DQoJCWZ1bmN0aW9uIGRyYWcoZUV2ZW50KXsNCgkJCWlmKGVFdmVudC50 YXJnZXQuYkRyYWcpew0KCQkJCWVFdmVudC50YXJnZXQuc3R5bGUubGVmdCA9IChlRXZlbnQucGFn ZVggLSAxMDApKydweCc7DQoJCQkJZUV2ZW50LnRhcmdldC5zdHlsZS50b3AgPSAoZUV2ZW50LnBh Z2VZIC0gMTAwKSsncHgnOw0KCQkJfQ0KCQl9DQoJCXZhciBvSGVhZCA9IGRvY3VtZW50LmdldEVs ZW1lbnRzQnlUYWdOYW1lKCdoZWFkJylbMF07DQoNCgkJZnVuY3Rpb24gY3JlYXRlQW5kQXBwZW5k KCl7DQoNCgkJCXZhciBvRWxtID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2JykNCgkJCW9F bG0uc3R5bGUucG9zaXRpb24gPSAnYWJzb2x1dGUnOw0KCQkJb0VsbS5zdHlsZS5ib3JkZXIgPSAn NXB4IHNvbGlkICNDQ0YnOw0KCQkJb0VsbS5zdHlsZS5iYWNrZ3JvdW5kID0gJyNGQ0YnOw0KCQkJ b0VsbS5zdHlsZS53aWR0aCA9ICcyMDBweCc7DQoJCQlvRWxtLnN0eWxlLmhlaWdodCA9ICcyMDBw eCc7DQoJCQlvRWxtLnN0eWxlLmxlZnQgPSAnMjAwcHgnDQoJCQlvRWxtLm9ubW91c2Vkb3duID0g ZHJhZ3N0YXJ0Ow0KCQkJb0VsbS5vbm1vdXNlbW92ZSA9IGRyYWc7DQoJCQlvRWxtLm9ubW91c2V1 cCA9IGRyYWdzdG9wOw0KCQkJb0VsbS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9k ZSgnRHJhZyBtZSBvdmVyIHRoZSBwYWdlIScpKTsNCgkJCWRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQob0VsbSk7DQoNCgkJCXZhciBvTGluayA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2xpbmsn KTsNCg0KCQkJb0xpbmsuc2V0QXR0cmlidXRlKCdyZWwnLCAnc3R5bGVzaGVldCcpOw0KCQkJb0xp bmsuc2V0QXR0cmlidXRlKCd0eXBlJywgJ3RleHQvY3NzJyk7DQoJCQlvTGluay5zZXRBdHRyaWJ1 dGUoJ21lZGlhJywJJ3NjcmVlbicpOw0KCQkJb0xpbmsuc2V0QXR0cmlidXRlKCdocmVmJywnYWJv dXQ6Ymxhbms7Jyk7DQoNCgkJCW9IZWFkLmFwcGVuZENoaWxkKG9MaW5rKTsNCg0KCQkJb0xpbmsu c2V0QXR0cmlidXRlKCdocmVmJywnYWJvdXQ6YmxhbmsyOycpOw0KDQoJCX0NCgk8L3NjcmlwdD4N CjwvaGVhZD4NCg0KPGJvZHkgb25sb2FkPSJjcmVhdGVBbmRBcHBlbmQoKTsiPg0KPGgyPkR5bmFt aWMgZ2VuZXJhdGVkIGxpbmstdGFnIGlzIGRpc2FibGluZyB1c2Ugb2YgU2FmYXJpIHdoZW4gY2hh bmdlIGFuIHByb3BlcnR5IGFmdGVyIGFkZGluZzwvaDI+DQo8cD5UcnkgZHJhZyBhcm91bmQgdGhl IGJveCwgeW91IHdpbGwgc2VlIHRoYXQncyBpdCdzIHZlcnkgaGFyZCB0byBrZWVwIGl0IHZpc2li bGUuIFRoaXMgaGFwcGVucyBiZWNhdXNlIGFmdGVyIGEgZHluYW1pYyBsaW5rLXRhZyBpcyBhZGRl ZCB0byB0aGUgaGVhZC4gVGhlIGhyZWYgaXMgY2hhbmdlZCBieSB1c2luZyA8Y29kZT5zZXRBdHRy aWJ1dGUoKTwvY29kZT4uDQpCdXQgbm90IG9ubHkgc2V0QXR0cmlidXRlLCBhbHNvIHJlbW92aW5n IGl0IC8gYXBwZW5kaW5nIGl0IHRvIHRoZSBib2R5IC8gYXBwZW5kaW5nIGl0IGFnYWluIHRvIHRo ZSBoZWFkIGFzIGZpcnN0IGNoaWxkKGluc2VydEJlZm9yZSgpKSB3aWxsIGNhdXNlIHRoaXMgYmVo YXZpb3IuPC9wPg0KPHA+QWxsIG90aGVyIGJyb3dzZXJzIChPcGVyYSAvIEludGVybmV0IEV4cGxv cmVyIDUueCsgLyBHZWNrbyApIGFyZSBub3QgaGF2aW5nIHRoaXMgcHJvYmxlbS4gVGVzdGVkIG9u IFNhZmFyaSAyLjAuMyBhbmQgVE9ULjwvcD4NCjwvYm9keT4NCg0KPC9odG1sPg== 7122 2006-03-16 20:08:54 -0800 2006-03-17 00:36:35 -0800 patch 6999_patch.txt text/plain 1376 alice.barraclough SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9oZWFkaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2h0bWwv aHRtbC9odG1sX2hlYWRpbXBsLmNwcCAgICAgICAgKHJldmlzaW9uIDEzMzQyKQorKysga2h0bWwv aHRtbC9odG1sX2hlYWRpbXBsLmNwcCAgICAgICAgKHdvcmtpbmcgY29weSkKQEAgLTIzMSw3ICsy MzEsNiBAQCB2b2lkIEhUTUxMaW5rRWxlbWVudEltcGw6OnByb2Nlc3MoKQogICAgICAgICAvLyAj IyMgdGhlcmUgbWF5IGJlIGluIHNvbWUgc2l0dWF0aW9ucyBlLmcuIGZvciBhbiBlZGl0b3Igb3Ig c2NyaXB0IHRvIG1hbmlwdWxhdGUKICAgICAgICAvLyBhbHNvLCBkb24ndCBsb2FkIHN0eWxlIHNo ZWV0cyBmb3Igc3RhbmRhbG9uZSBkb2N1bWVudHMKICAgICAgICAgaWYgKG1fbWVkaWEuaXNOdWxs KCkgfHwgbV9tZWRpYS5jb250YWlucygic2NyZWVuIikgfHwgbV9tZWRpYS5jb250YWlucygiYWxs IikgfHwgbV9tZWRpYS5jb250YWlucygicHJpbnQiKSkgewotICAgICAgICAgICAgbV9sb2FkaW5n ID0gdHJ1ZTsKIAogICAgICAgICAgICAgLy8gQWRkIG91cnNlbHZlcyBhcyBhIHBlbmRpbmcgc2hl ZXQsIGJ1dCBvbmx5IGlmIHdlIGFyZW4ndCBhbiBhbHRlcm5hdGUgCiAgICAgICAgICAgICAvLyBz dHlsZXNoZWV0LiAgQWx0ZXJuYXRlIHN0eWxlc2hlZXRzIGRvbid0IGhvbGQgdXAgcmVuZGVyIHRy ZWUgY29uc3RydWN0aW9uLgpAQCAtMjM5LDggKzIzOCwxMyBAQCB2b2lkIEhUTUxMaW5rRWxlbWVu dEltcGw6OnByb2Nlc3MoKQogICAgICAgICAgICAgICAgIGdldERvY3VtZW50KCktPmFkZFBlbmRp bmdTaGVldCgpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBRU3RyaW5nIGNoc2V0ID0gZ2V0 QXR0cmlidXRlKGNoYXJzZXRBdHRyKS5xc3RyaW5nKCk7Ci0gICAgICAgICAgICBpZiAobV9jYWNo ZWRTaGVldCkKKyAgICAgICAgICAgIGlmIChtX2NhY2hlZFNoZWV0KSB7CisgICAgICAgICAgICAg ICAgaWYgKG1fbG9hZGluZykgeworICAgICAgICAgICAgICAgICAgICBnZXREb2N1bWVudCgpLT5z dHlsZXNoZWV0TG9hZGVkKCk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIG1f Y2FjaGVkU2hlZXQtPmRlcmVmKHRoaXMpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgbV9s b2FkaW5nID0gdHJ1ZTsKICAgICAgICAgICAgIG1fY2FjaGVkU2hlZXQgPSBnZXREb2N1bWVudCgp LT5kb2NMb2FkZXIoKS0+cmVxdWVzdFN0eWxlU2hlZXQobV91cmwsIGNoc2V0KTsKICAgICAgICAg ICAgIGlmIChtX2NhY2hlZFNoZWV0KQogICAgICAgICAgICAgICAgIG1fY2FjaGVkU2hlZXQtPnJl Zih0aGlzKTs=