69976 2011-10-12 16:57:01 -0700 Kill old run-webkit-tests processes in kill-process on Mac 2011-10-12 18:33:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63651 1 rniwa rniwa dpranke eric lforschler simon.fraser tony webkit.review.bot oldest_to_newest 482857 0 rniwa 2011-10-12 16:57:01 -0700 We should kill all python instances executing run-webkit-tests. 482860 1 110771 rniwa 2011-10-12 17:00:17 -0700 Created attachment 110771 adds a new system call to kill-old-processes 482864 2 110771 eric 2011-10-12 17:04:35 -0700 Comment on attachment 110771 adds a new system call to kill-old-processes Um. You want to call this once for each task? Makes no sense. 482871 3 tony 2011-10-12 17:08:13 -0700 What about the buildbot process? 482872 4 rniwa 2011-10-12 17:08:25 -0700 (In reply to comment #2) > (From update of attachment 110771 [details]) > Um. You want to call this once for each task? Makes no sense. I don't quite get what you mean. We need to kill all python instances running run-webkit-tests (in particular child processes created by manager.py). How else can we accomplish this? 482873 5 rniwa 2011-10-12 17:09:02 -0700 (In reply to comment #3) > What about the buildbot process? The bug 63651 will enable kill-old-processes on Mac so this will be a buildbot step. 482875 6 tony 2011-10-12 17:09:52 -0700 (In reply to comment #5) > (In reply to comment #3) > > What about the buildbot process? > > The bug 63651 will enable kill-old-processes on Mac so this will be a buildbot step. I mean, buildbot is a python process. You probably don't want to kill it. 482876 7 rniwa 2011-10-12 17:11:07 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > What about the buildbot process? > > > > The bug 63651 will enable kill-old-processes on Mac so this will be a buildbot step. > > I mean, buildbot is a python process. You probably don't want to kill it. Right, that's why I'm explicitly looking for python process with run-webkit-test string: grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' 482880 8 110771 tony 2011-10-12 17:12:48 -0700 Comment on attachment 110771 adds a new system call to kill-old-processes View in context: https://bugs.webkit.org/attachment.cgi?id=110771&action=review > Tools/BuildSlaveSupport/kill-old-processes:80 > + # Kill all instances of pyhton executing run-webkit-tests typo: pyhton 482884 9 110771 eric 2011-10-12 17:16:27 -0700 Comment on attachment 110771 adds a new system call to kill-old-processes View in context: https://bugs.webkit.org/attachment.cgi?id=110771&action=review > Tools/BuildSlaveSupport/kill-old-processes:81 > + os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill") You're runing this in a loop. Once for every "task" in the array. WHy? 482885 10 110771 rniwa 2011-10-12 17:17:56 -0700 Comment on attachment 110771 adds a new system call to kill-old-processes View in context: https://bugs.webkit.org/attachment.cgi?id=110771&action=review >> Tools/BuildSlaveSupport/kill-old-processes:81 >> + os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill") > > You're runing this in a loop. Once for every "task" in the array. WHy? Oh oops, that's definitely a typo! Will fix. This is why I hate python :( 482888 11 110776 rniwa 2011-10-12 17:22:05 -0700 Created attachment 110776 Fixed indentation and typo 482894 12 110776 dpranke 2011-10-12 17:32:41 -0700 Comment on attachment 110776 Fixed indentation and typo View in context: https://bugs.webkit.org/attachment.cgi?id=110776&action=review > Tools/BuildSlaveSupport/kill-old-processes:81 > + os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill") presumably this should be "ps aux" at the beginning? 482897 13 dpranke 2011-10-12 17:34:12 -0700 (In reply to comment #12) > (From update of attachment 110776 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110776&action=review > > > Tools/BuildSlaveSupport/kill-old-processes:81 > > + os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill") > > presumably this should be "ps aux" at the beginning? Also, if you add this, can you remove 'httpd' from tasksToKill? NRWT should restart httpd itself correctly on the next run, if it started the last one. 482904 14 110780 rniwa 2011-10-12 17:41:46 -0700 Created attachment 110780 new patch 482905 15 110781 rniwa 2011-10-12 17:43:06 -0700 Created attachment 110781 new patch 2 Oops, wrong file. 482928 16 110781 webkit.review.bot 2011-10-12 18:33:05 -0700 Comment on attachment 110781 new patch 2 Clearing flags on attachment: 110781 Committed r97330: <http://trac.webkit.org/changeset/97330> 482929 17 webkit.review.bot 2011-10-12 18:33:10 -0700 All reviewed patches have been landed. Closing bug. 110771 2011-10-12 17:00:17 -0700 2011-10-12 17:22:02 -0700 adds a new system call to kill-old-processes bug-69976-20111012170016.patch text/plain 1430 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk3MzE4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgS2lsbCBvbGQgcnVuLXdlYmtpdC10ZXN0cyBwcm9jZXNzZXMgaW4ga2lsbC1wcm9j ZXNzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njk5NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBzeXN0ZW0gY2FsbCB0byByZW1vdmUgYWxsIHB5dGhvbiBwcm9jZXNzZXMgcnVubmlu ZyBydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1v bGQtcHJvY2Vzc2VzOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L21hYzogUmVtb3ZlZC4K KwogMjAxMS0xMC0xMCAgQWxpY2UgQm94aGFsbCAgPGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGRlZCBteXNlbGYgYXMgYSBjb21taXR0ZXIuCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCShyZXZpc2lvbiA5NzIzNykKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3Nlcwkod29ya2luZyBjb3B5KQpAQCAt NzcsNiArNzcsOCBAQCBkZWYgbWFpbigpOg0KICAgICBpZiBzeXMucGxhdGZvcm0gPT0gJ2Rhcndp bic6DQogICAgICAgICBmb3IgdGFzayBpbiB0YXNrc1RvS2lsbE1hYzoNCiAgICAgICAgICAgICBv cy5zeXN0ZW0oImtpbGxhbGwgLTkgLXYgLW0gIiArIHRhc2spDQorICAgICAgICAgICAgIyBLaWxs IGFsbCBpbnN0YW5jZXMgb2YgcHlodG9uIGV4ZWN1dGluZyBydW4td2Via2l0LXRlc3RzDQorICAg ICAgICAgICAgb3Muc3lzdGVtKCJhdXggfCBncmVwIC1QICcuKy9QeXRob24gLisocnVuX3dlYmtp dF90ZXN0c3xydW4td2Via2l0LXRlc3RzKScgfCBncmVwIC12IGdyZXAgfCBhd2sgJ3twcmludCAk Mn0nIHwgeGFyZ3Mga2lsbCIpDQogICAgIGVsaWYgc3lzLnBsYXRmb3JtID09ICdjeWd3aW4nIG9y IHN5cy5wbGF0Zm9ybSA9PSAnd2luMzInOg0KICAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tp bGxXaW46DQogICAgICAgICAgICAgb3Muc3lzdGVtKCJ0YXNra2lsbCAvdCAvZiAvaW0gIiArIHRh c2spDQo= 110776 2011-10-12 17:22:05 -0700 2011-10-12 17:41:46 -0700 Fixed indentation and typo bug-69976-20111012172204.patch text/plain 1422 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk3MzE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgS2lsbCBvbGQgcnVuLXdlYmtpdC10ZXN0cyBwcm9jZXNzZXMgaW4ga2lsbC1wcm9j ZXNzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njk5NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBzeXN0ZW0gY2FsbCB0byByZW1vdmUgYWxsIHB5dGhvbiBwcm9jZXNzZXMgcnVubmlu ZyBydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1v bGQtcHJvY2Vzc2VzOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L21hYzogUmVtb3ZlZC4K KwogMjAxMS0xMC0xMCAgQWxpY2UgQm94aGFsbCAgPGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGRlZCBteXNlbGYgYXMgYSBjb21taXR0ZXIuCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCShyZXZpc2lvbiA5NzMxOSkKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3Nlcwkod29ya2luZyBjb3B5KQpAQCAt NzcsNiArNzcsOCBAQCBkZWYgbWFpbigpOg0KICAgICBpZiBzeXMucGxhdGZvcm0gPT0gJ2Rhcndp bic6DQogICAgICAgICBmb3IgdGFzayBpbiB0YXNrc1RvS2lsbE1hYzoNCiAgICAgICAgICAgICBv cy5zeXN0ZW0oImtpbGxhbGwgLTkgLXYgLW0gIiArIHRhc2spDQorICAgICAgICAjIEtpbGwgYWxs IGluc3RhbmNlcyBvZiBweXRob24gZXhlY3V0aW5nIHJ1bi13ZWJraXQtdGVzdHMNCisgICAgICAg IG9zLnN5c3RlbSgiYXV4IHwgZ3JlcCAtUCAnLisvUHl0aG9uIC4rKHJ1bl93ZWJraXRfdGVzdHN8 cnVuLXdlYmtpdC10ZXN0cyknIHwgZ3JlcCAtdiBncmVwIHwgYXdrICd7cHJpbnQgJDJ9JyB8IHhh cmdzIGtpbGwiKQ0KICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnY3lnd2luJyBvciBzeXMucGxh dGZvcm0gPT0gJ3dpbjMyJzoNCiAgICAgICAgIGZvciB0YXNrIGluIHRhc2tzVG9LaWxsV2luOg0K ICAgICAgICAgICAgIG9zLnN5c3RlbSgidGFza2tpbGwgL3QgL2YgL2ltICIgKyB0YXNrKQ0K 110780 2011-10-12 17:41:46 -0700 2011-10-12 17:43:06 -0700 new patch fic69976c text/plain 1416 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk3MzE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgS2lsbCBvbGQgcnVuLXdlYmtpdC10ZXN0cyBwcm9jZXNzZXMgaW4ga2lsbC1wcm9j ZXNzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njk5NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBzeXN0ZW0gY2FsbCB0byByZW1vdmUgYWxsIHB5dGhvbiBwcm9jZXNzZXMgcnVubmlu ZyBydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1v bGQtcHJvY2Vzc2VzOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L21hYzogUmVtb3ZlZC4K KwogMjAxMS0xMC0xMCAgQWxpY2UgQm94aGFsbCAgPGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGRlZCBteXNlbGYgYXMgYSBjb21taXR0ZXIuCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCShyZXZpc2lvbiA5NzMxOSkKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3Nlcwkod29ya2luZyBjb3B5KQpAQCAt NzcsNiArNzcsOCBAQCBkZWYgbWFpbigpOgogICAgIGlmIHN5cy5wbGF0Zm9ybSA9PSAnZGFyd2lu JzoKICAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tpbGxNYWM6CiAgICAgICAgICAgICBvcy5z eXN0ZW0oImtpbGxhbGwgLTkgLXYgLW0gIiArIHRhc2spCisgICAgICAgICMgS2lsbCBhbGwgaW5z dGFuY2VzIG9mIHB5dGhvbiBleGVjdXRpbmcgcnVuLXdlYmtpdC10ZXN0cworICAgICAgICBvcy5z eXN0ZW0oInBzIGF1eCB8IGdyZXAgLVAgJy4rL1B5dGhvbiAuKyhydW5fd2Via2l0X3Rlc3RzfHJ1 bi13ZWJraXQtdGVzdHMpJyB8IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50ICQyfScgfCB4YXJn cyBraWxsIikKICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnY3lnd2luJyBvciBzeXMucGxhdGZv cm0gPT0gJ3dpbjMyJzoKICAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tpbGxXaW46CiAgICAg ICAgICAgICBvcy5zeXN0ZW0oInRhc2traWxsIC90IC9mIC9pbSAiICsgdGFzaykK 110781 2011-10-12 17:43:06 -0700 2011-10-12 18:33:05 -0700 new patch 2 69976c text/plain 1630 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk3MzE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgS2lsbCBvbGQgcnVuLXdlYmtpdC10ZXN0cyBwcm9jZXNzZXMgaW4ga2lsbC1wcm9j ZXNzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njk5NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBzeXN0ZW0gY2FsbCB0byByZW1vdmUgYWxsIHB5dGhvbiBwcm9jZXNzZXMgcnVubmlu ZyBydW4td2Via2l0LXRlc3RzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1v bGQtcHJvY2Vzc2VzOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L21hYzogUmVtb3ZlZC4K KwogMjAxMS0xMC0xMCAgQWxpY2UgQm94aGFsbCAgPGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGRlZCBteXNlbGYgYXMgYSBjb21taXR0ZXIuCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCShyZXZpc2lvbiA5NzMxOSkKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3Nlcwkod29ya2luZyBjb3B5KQpAQCAt NTUsNyArNTUsNiBAQAogICAgIF0NCiANCiAgICAgdGFza3NUb0tpbGxNYWMgPSBbDQotICAgICAg ICAiaHR0cGQiLCAjIFRoaXMgc2hvdWxkbid0IGJlIG5lZWRlZCwgZXhjZXB0IGN1cnJlbnRseSB0 aGVyZSBhcmUgYnVncyBpbiBOUldUJ3MgaHR0cCBsb2NraW5nIGNvZGUuDQogICAgICAgICAianNj IiwNCiAgICAgICAgICJtYWtlIiwNCiAgICAgICAgICJwZXI1LjEyIiwNCkBAIC03Nyw2ICs3Niw4 IEBACiAgICAgaWYgc3lzLnBsYXRmb3JtID09ICdkYXJ3aW4nOg0KICAgICAgICAgZm9yIHRhc2sg aW4gdGFza3NUb0tpbGxNYWM6DQogICAgICAgICAgICAgb3Muc3lzdGVtKCJraWxsYWxsIC05IC12 IC1tICIgKyB0YXNrKQ0KKyAgICAgICAgIyBLaWxsIGFsbCBpbnN0YW5jZXMgb2YgcHl0aG9uIGV4 ZWN1dGluZyBydW4td2Via2l0LXRlc3RzDQorICAgICAgICBvcy5zeXN0ZW0oInBzIGF1eCB8IGdy ZXAgLVAgJy4rL1B5dGhvbiAuKyhydW5fd2Via2l0X3Rlc3RzfHJ1bi13ZWJraXQtdGVzdHMpJyB8 IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50ICQyfScgfCB4YXJncyBraWxsIikNCiAgICAgZWxp ZiBzeXMucGxhdGZvcm0gPT0gJ2N5Z3dpbicgb3Igc3lzLnBsYXRmb3JtID09ICd3aW4zMic6DQog ICAgICAgICBmb3IgdGFzayBpbiB0YXNrc1RvS2lsbFdpbjoNCiAgICAgICAgICAgICBvcy5zeXN0 ZW0oInRhc2traWxsIC90IC9mIC9pbSAiICsgdGFzaykNCg==