69975 2011-10-12 16:29:10 -0700 The commit-queue doesn't tell me which tests my patch broke 2011-10-12 17:12:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth eric tomz webkit.review.bot oldest_to_newest 482840 0 abarth 2011-10-12 16:29:10 -0700 The commit-queue doesn't tell me which tests my patch broke 482841 1 110770 abarth 2011-10-12 16:30:11 -0700 Created attachment 110770 Patch 482851 2 110770 eric 2011-10-12 16:46:16 -0700 Comment on attachment 110770 Patch rs=me. 482878 3 110770 abarth 2011-10-12 17:12:27 -0700 Comment on attachment 110770 Patch Clearing flags on attachment: 110770 Committed r97320: <http://trac.webkit.org/changeset/97320> 482879 4 abarth 2011-10-12 17:12:30 -0700 All reviewed patches have been landed. Closing bug. 110770 2011-10-12 16:30:11 -0700 2011-10-12 17:12:27 -0700 Patch bug-69975-20111012163010.patch text/plain 6313 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTczMTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZGRmNjU5ZmFjOGQzNzU1NjZjNzcwOWJlZGQ4MzMyYzZj YjA1Yzc2Li4zOWE4MWRhNzA3MzQ2YzAzMzg5ZTY3YzIwZTE3MmQxM2E3N2IzZDk2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTEtMTAtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBUaGUgY29tbWl0LXF1ZXVlIGRvZXNuJ3QgdGVsbCBtZSB3aGljaCB0ZXN0cyBteSBwYXRjaCBi cm9rZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk5 NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBu b3cgcHJpbnQgdGhlIGxpc3Qgb2YgbmV3bHkgZmFpbGluZyB0ZXN0cywgbGlrZSB3ZSBkbyBmb3Ig dGhlIEVXUy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1 ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191 bml0dGVzdC5weToKKworMjAxMS0xMC0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCiAgICAgICAgIF9ydW5fdGVzdHMgaXMgYSBjb25mdXNpbmcgdmFyaWFibGUgbmFtZSBpbiB3 ZWJraXRweQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Njk5NzEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L3F1ZXVlcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMu cHkKaW5kZXggY2RhN2UzNTc3MTQ1N2I1YTg0ZTYwMGUxZDBiMjg5YzI5OTY4NGEzYi4uYjY0ZmZm ODAwODFkODA1ZTk5ZjEwOTZkNTQ5YjQ4YTgxNWM0NjRhNiAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CkBAIC0yODksMTcgKzI4OSwyNSBAQCBj bGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFu ZGxlciwgQ29tbWl0UXVldWVUYXNrRAogICAgICAgICAgICAgc2VsZi5fZGlkX3JldHJ5KHBhdGNo KQogICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6CiAgICAgICAgICAgICB2YWxpZGF0b3Ig PSBDb21taXR0ZXJWYWxpZGF0b3Ioc2VsZi5fdG9vbC5idWdzKQotICAgICAgICAgICAgdmFsaWRh dG9yLnJlamVjdF9wYXRjaF9mcm9tX2NvbW1pdF9xdWV1ZShwYXRjaC5pZCgpLCBzZWxmLl9lcnJv cl9tZXNzYWdlX2Zvcl9idWcodGFzay5mYWlsdXJlX3N0YXR1c19pZCwgZSkpCisgICAgICAgICAg ICB2YWxpZGF0b3IucmVqZWN0X3BhdGNoX2Zyb21fY29tbWl0X3F1ZXVlKHBhdGNoLmlkKCksIHNl bGYuX2Vycm9yX21lc3NhZ2VfZm9yX2J1Zyh0YXNrLCBwYXRjaCwgZSkpCiAgICAgICAgICAgICBy ZXN1bHRzX2FyY2hpdmUgPSB0YXNrLnJlc3VsdHNfYXJjaGl2ZV9mcm9tX3BhdGNoX3Rlc3RfcnVu KHBhdGNoKQogICAgICAgICAgICAgaWYgcmVzdWx0c19hcmNoaXZlOgogICAgICAgICAgICAgICAg IHNlbGYuX3VwbG9hZF9yZXN1bHRzX2FyY2hpdmVfZm9yX3BhdGNoKHBhdGNoLCByZXN1bHRzX2Fy Y2hpdmUpCiAgICAgICAgICAgICBzZWxmLl9kaWRfZmFpbChwYXRjaCkKIAotICAgIGRlZiBfZXJy b3JfbWVzc2FnZV9mb3JfYnVnKHNlbGYsIHN0YXR1c19pZCwgc2NyaXB0X2Vycm9yKToKLSAgICAg ICAgaWYgbm90IHNjcmlwdF9lcnJvci5vdXRwdXQ6Ci0gICAgICAgICAgICByZXR1cm4gc2NyaXB0 X2Vycm9yLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKQotICAgICAgICByZXN1bHRzX2xpbmsgPSBzZWxm Ll90b29sLnN0YXR1c19zZXJ2ZXIucmVzdWx0c191cmxfZm9yX3N0YXR1cyhzdGF0dXNfaWQpCi0g ICAgICAgIHJldHVybiAiJXNcbkZ1bGwgb3V0cHV0OiAlcyIgJSAoc2NyaXB0X2Vycm9yLm1lc3Nh Z2Vfd2l0aF9vdXRwdXQoKSwgcmVzdWx0c19saW5rKQorICAgIGRlZiBfZmFpbGluZ190ZXN0c19t ZXNzYWdlKHNlbGYsIHRhc2ssIHBhdGNoKToKKyAgICAgICAgcmVzdWx0cyA9IHRhc2sucmVzdWx0 c19mcm9tX3BhdGNoX3Rlc3RfcnVuKHBhdGNoKQorICAgICAgICB1bmV4cGVjdGVkX2ZhaWx1cmVz ID0gc2VsZi5fZXhwZWN0ZWRfZmFpbHVyZXMudW5leHBlY3RlZF9mYWlsdXJlc19vYnNlcnZlZChy ZXN1bHRzKQorICAgICAgICBpZiBub3QgdW5leHBlY3RlZF9mYWlsdXJlczoKKyAgICAgICAgICAg IHJldHVybiBOb25lCisgICAgICAgIHJldHVybiAiTmV3IGZhaWxpbmcgdGVzdHM6XG4lcyIgJSAi XG4iLmpvaW4odW5leHBlY3RlZF9mYWlsdXJlcykKKworICAgIGRlZiBfZXJyb3JfbWVzc2FnZV9m b3JfYnVnKHNlbGYsIHRhc2ssIHBhdGNoLCBzY3JpcHRfZXJyb3IpOgorICAgICAgICBtZXNzYWdl ID0gc2VsZi5fZmFpbGluZ190ZXN0c19tZXNzYWdlKHRhc2ssIHBhdGNoKQorICAgICAgICBpZiBu b3QgbWVzc2FnZToKKyAgICAgICAgICAgIG1lc3NhZ2UgPSBzY3JpcHRfZXJyb3IubWVzc2FnZV93 aXRoX291dHB1dCgpCisgICAgICAgIHJlc3VsdHNfbGluayA9IHNlbGYuX3Rvb2wuc3RhdHVzX3Nl cnZlci5yZXN1bHRzX3VybF9mb3Jfc3RhdHVzKHRhc2suZmFpbHVyZV9zdGF0dXNfaWQpCisgICAg ICAgIHJldHVybiAiJXNcbkZ1bGwgb3V0cHV0OiAlcyIgJSAobWVzc2FnZSwgcmVzdWx0c19saW5r KQogCiAgICAgZGVmIGhhbmRsZV91bmV4cGVjdGVkX2Vycm9yKHNlbGYsIHBhdGNoLCBtZXNzYWdl KToKICAgICAgICAgc2VsZi5jb21taXR0ZXJfdmFsaWRhdG9yLnJlamVjdF9wYXRjaF9mcm9tX2Nv bW1pdF9xdWV1ZShwYXRjaC5pZCgpLCBtZXNzYWdlKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkKaW5kZXggM2ZhNjIy ODMxYmNiOTg1MTlkNWI4YzI4OGQyMjU3ZmJiOTA3NGVjMy4uMGVlMjM3ZTJkYjExYWE1NjBiNjU0 YzE5NTljMWQ5YTcxMjAwMTljNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CkBAIC0yNjEsNyArMjYxLDggQEAg TU9DSzogcmVsZWFzZV93b3JrX2l0ZW06IGNvbW1pdC1xdWV1ZSAxMDAwMAogICAgICAgICAgICAg InByb2Nlc3Nfd29ya19pdGVtIjogIiIiTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVl IENsZWFuZWQgd29ya2luZyBkaXJlY3RvcnkKIE1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNvbW1pdC1x dWV1ZSBVcGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5CiBNT0NLOiB1cGRhdGVfc3RhdHVzOiBjb21t aXQtcXVldWUgUGF0Y2ggZG9lcyBub3QgYXBwbHkKLU1PQ0sgc2V0dGluZyBmbGFnICdjb21taXQt cXVldWUnIHRvICctJyBvbiBhdHRhY2htZW50ICcxMDAwMCcgd2l0aCBjb21tZW50ICdSZWplY3Rp bmcgYXR0YWNobWVudCAxMDAwMCBmcm9tIGNvbW1pdC1xdWV1ZS4nIGFuZCBhZGRpdGlvbmFsIGNv bW1lbnQgJ01PQ0sgc2NyaXB0IGVycm9yJworTU9DSyBzZXR0aW5nIGZsYWcgJ2NvbW1pdC1xdWV1 ZScgdG8gJy0nIG9uIGF0dGFjaG1lbnQgJzEwMDAwJyB3aXRoIGNvbW1lbnQgJ1JlamVjdGluZyBh dHRhY2htZW50IDEwMDAwIGZyb20gY29tbWl0LXF1ZXVlLicgYW5kIGFkZGl0aW9uYWwgY29tbWVu dCAnTU9DSyBzY3JpcHQgZXJyb3IKK0Z1bGwgb3V0cHV0OiBodHRwOi8vZHVtbXlfdXJsJwogTU9D SzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIEZhaWwKIE1PQ0s6IHJlbGVhc2Vfd29ya19p dGVtOiBjb21taXQtcXVldWUgMTAwMDAKICIiIiwKQEAgLTI4MCw2ICsyODEsMzcgQEAgTU9DSzog cmVsZWFzZV93b3JrX2l0ZW06IGNvbW1pdC1xdWV1ZSAxMDAwMAogICAgICAgICBxdWV1ZS5ydW5f d2Via2l0X3BhdGNoID0gbW9ja19ydW5fd2Via2l0X3BhdGNoCiAgICAgICAgIHNlbGYuYXNzZXJ0 X3F1ZXVlX291dHB1dHMocXVldWUsIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAK KyAgICBkZWYgdGVzdF9jb21taXRfcXVldWVfZmFpbHVyZV93aXRoX2ZhaWxpbmdfdGVzdHMoc2Vs Zik6CisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9IHsKKyAgICAgICAgICAgICJiZWdpbl93b3Jr X3F1ZXVlIjogc2VsZi5fZGVmYXVsdF9iZWdpbl93b3JrX3F1ZXVlX3N0ZGVycigiY29tbWl0LXF1 ZXVlIiksCisgICAgICAgICAgICAic2hvdWxkX3Byb2NlZWRfd2l0aF93b3JrX2l0ZW0iOiAiTU9D SzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIFByb2Nlc3NpbmcgcGF0Y2hcbiIsCisgICAg ICAgICAgICAibmV4dF93b3JrX2l0ZW0iOiAiIiwKKyAgICAgICAgICAgICJwcm9jZXNzX3dvcmtf aXRlbSI6ICIiIk1PQ0s6IHVwZGF0ZV9zdGF0dXM6IGNvbW1pdC1xdWV1ZSBDbGVhbmVkIHdvcmtp bmcgZGlyZWN0b3J5CitNT0NLOiB1cGRhdGVfc3RhdHVzOiBjb21taXQtcXVldWUgVXBkYXRlZCB3 b3JraW5nIGRpcmVjdG9yeQorTU9DSzogdXBkYXRlX3N0YXR1czogY29tbWl0LXF1ZXVlIFBhdGNo IGRvZXMgbm90IGFwcGx5CitNT0NLIHNldHRpbmcgZmxhZyAnY29tbWl0LXF1ZXVlJyB0byAnLScg b24gYXR0YWNobWVudCAnMTAwMDAnIHdpdGggY29tbWVudCAnUmVqZWN0aW5nIGF0dGFjaG1lbnQg MTAwMDAgZnJvbSBjb21taXQtcXVldWUuJyBhbmQgYWRkaXRpb25hbCBjb21tZW50ICdOZXcgZmFp bGluZyB0ZXN0czoKK21vY2tfdGVzdF9uYW1lLmh0bWwKK2Fub3RoZXJfdGVzdF9uYW1lLmh0bWwK K0Z1bGwgb3V0cHV0OiBodHRwOi8vZHVtbXlfdXJsJworTU9DSzogdXBkYXRlX3N0YXR1czogY29t bWl0LXF1ZXVlIEZhaWwKK01PQ0s6IHJlbGVhc2Vfd29ya19pdGVtOiBjb21taXQtcXVldWUgMTAw MDAKKyIiIiwKKyAgICAgICAgICAgICJoYW5kbGVfdW5leHBlY3RlZF9lcnJvciI6ICJNT0NLIHNl dHRpbmcgZmxhZyAnY29tbWl0LXF1ZXVlJyB0byAnLScgb24gYXR0YWNobWVudCAnMTAwMDAnIHdp dGggY29tbWVudCAnUmVqZWN0aW5nIGF0dGFjaG1lbnQgMTAwMDAgZnJvbSBjb21taXQtcXVldWUu JyBhbmQgYWRkaXRpb25hbCBjb21tZW50ICdNb2NrIGVycm9yIG1lc3NhZ2UnXG4iLAorICAgICAg ICAgICAgImhhbmRsZV9zY3JpcHRfZXJyb3IiOiAiU2NyaXB0RXJyb3IgZXJyb3IgbWVzc2FnZVxu IiwKKyAgICAgICAgfQorICAgICAgICBxdWV1ZSA9IENvbW1pdFF1ZXVlKCkKKworICAgICAgICBk ZWYgbW9ja19ydW5fd2Via2l0X3BhdGNoKGNvbW1hbmQpOgorICAgICAgICAgICAgaWYgY29tbWFu ZCA9PSBbJ2NsZWFuJ10gb3IgY29tbWFuZCA9PSBbJ3VwZGF0ZSddOgorICAgICAgICAgICAgICAg ICMgV2Ugd2FudCBjbGVhbmluZyB0byBzdWNjZWVkIHNvIHdlIGNhbiBlcnJvciBvdXQgb24gYSBz dGVwCisgICAgICAgICAgICAgICAgIyB0aGF0IGNhdXNlcyB0aGUgY29tbWl0LXF1ZXVlIHRvIHJl amVjdCB0aGUgcGF0Y2guCisgICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICBxdWV1 ZS5fZXhwZWN0ZWRfZmFpbHVyZXMudW5leHBlY3RlZF9mYWlsdXJlc19vYnNlcnZlZCA9IGxhbWJk YSByZXN1bHRzOiBbIm1vY2tfdGVzdF9uYW1lLmh0bWwiLCAiYW5vdGhlcl90ZXN0X25hbWUuaHRt bCJdCisgICAgICAgICAgICByYWlzZSBTY3JpcHRFcnJvcignTU9DSyBzY3JpcHQgZXJyb3InKQor CisgICAgICAgIHF1ZXVlLnJ1bl93ZWJraXRfcGF0Y2ggPSBtb2NrX3J1bl93ZWJraXRfcGF0Y2gK KyAgICAgICAgc2VsZi5hc3NlcnRfcXVldWVfb3V0cHV0cyhxdWV1ZSwgZXhwZWN0ZWRfc3RkZXJy PWV4cGVjdGVkX3N0ZGVycikKKwogICAgIGRlZiB0ZXN0X3JvbGxvdXQoc2VsZik6CiAgICAgICAg IHRvb2wgPSBNb2NrVG9vbChsb2dfZXhlY3V0aXZlPVRydWUpCiAgICAgICAgIHRvb2wuZmlsZXN5 c3RlbS53cml0ZV90ZXh0X2ZpbGUoJy9tb2NrLXJlc3VsdHMvcmVzdWx0cy5odG1sJywgJycpICAj IE90aGVyd2lzZSB0aGUgY29tbWl0LXF1ZXVlIHdpbGwgaGl0IGEgS2V5RXJyb3IgdHJ5aW5nIHRv IHJlYWQgdGhlIHJlc3VsdHMgZnJvbSB0aGUgTW9ja0ZpbGVTeXN0ZW0uCg==