69954 2011-10-12 13:00:49 -0700 garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines. 2011-10-12 14:20:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69227 1 dglazkov dglazkov abarth oldest_to_newest 482629 0 dglazkov 2011-10-12 13:00:49 -0700 garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines. 482635 1 110728 dglazkov 2011-10-12 13:04:01 -0700 Created attachment 110728 Patch 482689 2 110728 abarth 2011-10-12 14:11:32 -0700 Comment on attachment 110728 Patch This doesn't require updating any unit tests? 482695 3 dglazkov 2011-10-12 14:17:27 -0700 (In reply to comment #2) > (From update of attachment 110728 [details]) > This doesn't require updating any unit tests? Apparently not! :) 482702 4 dglazkov 2011-10-12 14:20:53 -0700 Committed r97302: <http://trac.webkit.org/changeset/97302> 110728 2011-10-12 13:04:01 -0700 2011-10-12 14:11:32 -0700 Patch bug-69954-20111012130359.patch text/plain 4372 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTcyOTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL2NvbnRyb2xsZXJzLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvY29udHJvbGxl cnMuanMKaW5kZXggMzk4Mjg2ZjhlMTAyNjEyM2ViZjgzZGUzMGY5YmYyMzVkNjY4YTYwNC4uMDVk YWNkYmViNzU5YzhhNzY2NjQyYzJmMTI5MWI0MTZlNzIwYjdiYyAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvY29udHJvbGxlcnMuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Nj cmlwdHMvY29udHJvbGxlcnMuanMKQEAgLTY3LDcgKzY3LDcgQEAgY29udHJvbGxlcnMuUmVzdWx0 c0RldGFpbHMgPSBiYXNlLmV4dGVuZHMoT2JqZWN0LCB7CiAgICAgICAgICQodGhpcy5fdmlldyku YmluZCgnbmV4dCcsIHRoaXMub25OZXh0LmJpbmQodGhpcykpOwogICAgICAgICAkKHRoaXMuX3Zp ZXcpLmJpbmQoJ3ByZXZpb3VzJywgdGhpcy5vblByZXZpb3VzLmJpbmQodGhpcykpOwogICAgICAg ICAkKHRoaXMuX3ZpZXcpLmJpbmQoJ3JlYmFzZWxpbmUnLCB0aGlzLm9uUmViYXNlbGluZS5iaW5k KHRoaXMpKTsKLSAgICAgICAgJCh0aGlzLl92aWV3KS5iaW5kKCd1cGRhdGVleHBlY3RhdGlvbnMn LCB0aGlzLm9uVXBkYXRlRXhwZWN0YXRpb25zLmJpbmQodGhpcykpOworICAgICAgICAkKHRoaXMu X3ZpZXcpLmJpbmQoJ2V4cGVjdGZhaWx1cmUnLCB0aGlzLm9uVXBkYXRlRXhwZWN0YXRpb25zLmJp bmQodGhpcykpOwogICAgIH0sCiAgICAgb25OZXh0OiBmdW5jdGlvbigpCiAgICAgewpAQCAtMTE5 LDcgKzExOSw3IEBAIHZhciBGYWlsdXJlU3RyZWFtQ29udHJvbGxlciA9IGJhc2UuZXh0ZW5kcyhP YmplY3QsIHsKICAgICAgICAgICAgICQoZmFpbHVyZSkuYmluZCgncmViYXNlbGluZScsIGZ1bmN0 aW9uKCkgewogICAgICAgICAgICAgICAgIHRoaXMub25SZWJhc2VsaW5lKGZhaWx1cmUpOwogICAg ICAgICAgICAgfS5iaW5kKHRoaXMpKTsKLSAgICAgICAgICAgICQoZmFpbHVyZSkuYmluZCgndXBk YXRlZXhwZWN0YXRpb25zJywgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAkKGZhaWx1cmUpLmJp bmQoJ2V4cGVjdGZhaWx1cmUnLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICB0aGlzLm9u VXBkYXRlRXhwZWN0YXRpb25zKGZhaWx1cmUpOwogICAgICAgICAgICAgfS5iaW5kKHRoaXMpKTsK ICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvYWN0aW9u cy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL2FjdGlvbnMuanMKaW5kZXggYTBhY2Fj MDYyMjU0NGYxYTVkZDNkNzliOTE1NjA4MzQyZjNmYTcwNS4uNmViNDA0MTBmYmZmZjBiNzY4OWM5 OGY0YjNiOTM1Y2I0MjNhZTNiOCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMv dWkvYWN0aW9ucy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9hY3Rpb25zLmpz CkBAIC04MywxMSArODMsMTAgQEAgdWkuYWN0aW9ucy5SZWJhc2VsaW5lID0gYmFzZS5leHRlbmRz KEFjdGlvbiwgewogICAgIH0KIH0pOwogCi0vLyBGSVhNRTogUmVuYW1lIGFsbCB0aGUgY29kZSB0 byBtYXRjaCB0aGUgdXNlci12aXNpYmxlIG5hbWUuCi11aS5hY3Rpb25zLlVwZGF0ZUV4cGVjdGF0 aW9ucyA9IGJhc2UuZXh0ZW5kcyhBY3Rpb24sIHsKK3VpLmFjdGlvbnMuRXhwZWN0RmFpbHVyZSA9 IGJhc2UuZXh0ZW5kcyhBY3Rpb24sIHsKICAgICBpbml0OiBmdW5jdGlvbigpIHsKICAgICAgICAg dGhpcy50ZXh0Q29udGVudCA9ICdFeHBlY3QgRmFpbHVyZSc7Ci0gICAgICAgIHRoaXMuX2V2ZW50 TmFtZSA9ICd1cGRhdGVleHBlY3RhdGlvbnMnOworICAgICAgICB0aGlzLl9ldmVudE5hbWUgPSAn ZXhwZWN0ZmFpbHVyZSc7CiAgICAgfQogfSk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9zY3JpcHRzL3VpL3Jlc3VsdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1 bHRzLmpzCmluZGV4IDVkZTNlZTg0NTI3ZmI5NDY5NzFmMGQ3NzI3MWZhMDZkOGUxOGIwNjEuLjM4 YmM3NzA4MDU2OWY0ZTIxNDU1NTQ1ZjVkYTEzY2UzYTU2Nzk0ZDQgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rl c3RGYWlsdXJlcy9zY3JpcHRzL3VpL3Jlc3VsdHMuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Nj cmlwdHMvdWkvcmVzdWx0cy5qcwpAQCAtMTc2LDcgKzE3Niw2IEBAIHVpLnJlc3VsdHMuVGVzdFNl bGVjdG9yID0gYmFzZS5leHRlbmRzKCdkaXYnLCB7CiAgICAgICAgICAgICB2YXIgaGVhZGVyID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnaDMnKTsKICAgICAgICAgICAgICQoaGVhZGVyKS5hcHBl bmQobmV3IHVpLmFjdGlvbnMuTGlzdChbCiAgICAgICAgICAgICAgICAgbmV3IHVpLmFjdGlvbnMu UmViYXNlbGluZSgpLm1ha2VEZWZhdWx0KCksCi0gICAgICAgICAgICAgICAgbmV3IHVpLmFjdGlv bnMuVXBkYXRlRXhwZWN0YXRpb25zKCksCiAgICAgICAgICAgICBdKSkuYXBwZW5kKGxpbmspOwog ICAgICAgICAgICAgdGhpcy5hcHBlbmRDaGlsZChoZWFkZXIpOwogICAgICAgICAgICAgdGhpcy5h cHBlbmRDaGlsZCh0aGlzLl9kZWxlZ2F0ZS5jb250ZW50Rm9yVGVzdCh0ZXN0TmFtZSkpOwpkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIxMTBkNTM2 ZjdkYzJiYjdjMzA5NzAyYTc2YzQ4ZDVkNDZmOWMyY2UuLjE5ZDI4ZTRlMTE0YWQyZjA2YWNjOTFi NzM1MDljOGY5NWMyZjViMDEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0xMC0xMiAgRGltaXRyaSBHbGF6a292 ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGdhcmRlbi1vLW1hdGljJ3MgIkV4 cGVjdCBGYWlsdXJlIiBidXR0b24gZG9lcyBub3Qgd29yayBjb3JyZWN0bHksIHNvIHdlIHNob3Vs ZCByZW1vdmUgaXQgdW50aWwgdGhlIHBsdW1iaW5nIGlzIGZpeGVkIHRvIGF2b2lkIGxhbmRtaW5l cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5OTU0 CisKKyAgICAgICAgQWxzbyByZW5hbWVkIHRoZSBhY3Rpb24gYW5kIGFzc29jaWF0ZWQgZXZlbnQg bmFtZSB0byBhZGRyZXNzIGFuIEZJWE1FLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvY29udHJvbGxlcnMuanM6IFJl bmFtZWQgZXZlbnQgbmFtZS4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9hY3Rpb25z LmpzOiBSZW5hbWVkIHRoZSBhY3Rpb24uCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkv cmVzdWx0cy5qczogUmVtb3ZlZCBhY3Rpb24gdGVtcG9yYXJpbHkuCisKIDIwMTEtMTAtMTIgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgM0QgdHJhbnNm b3JtcyBhcmUgZmxhdHRlbmVkIGluIFdlYktpdDIgc25hcHNob3RzCg==