69948 2011-10-12 11:36:38 -0700 Web Inspector: [Chromium] Heap profiler should designate weak references 2011-12-05 09:31:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 72714 1 mnaganov mnaganov apavlov bweinstein dglazkov joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 482566 0 mnaganov 2011-10-12 11:36:38 -0700 Weak persistent handles doesn't prevent objects from deletion, so they either should not be shown in retaining paths, or should be marked somehow. 505671 1 mnaganov 2011-11-18 04:03:15 -0800 See http://code.google.com/p/v8/issues/detail?id=1832 for details. 515039 2 117869 mnaganov 2011-12-05 05:31:36 -0800 Created attachment 117869 Patch 515042 3 117869 yurys 2011-12-05 05:47:11 -0800 Comment on attachment 117869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117869&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:287 > + case "weak": return "[[" + this.name + "]]"; Can we have a tooltip explaining to the user what this text graphics means? 515098 4 117869 mnaganov 2011-12-05 08:21:20 -0800 Comment on attachment 117869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117869&action=review >> Source/WebCore/inspector/front-end/HeapSnapshot.js:287 >> + case "weak": return "[[" + this.name + "]]"; > > Can we have a tooltip explaining to the user what this text graphics means? This actually should never appear in path traces, as we exclude weak references when building them. So this is mostly for debugging purposes. 515126 5 117869 webkit.review.bot 2011-12-05 09:12:01 -0800 Comment on attachment 117869 Patch Attachment 117869 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10736347 New failing tests: svg/custom/linking-uri-01-b.svg 515138 6 mnaganov 2011-12-05 09:31:10 -0800 Manually committed r102006. 2011-12-05 Mikhail Naganov <mnaganov@chromium.org> Web Inspector: [Chromium] Heap profiler should designate weak references. https://bugs.webkit.org/show_bug.cgi?id=69948 Weak references are now ignored when tracing paths to GC roots. Reviewed by Yury Semikhatsky. * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotEdge.prototype.get isWeak): (WebInspector.HeapSnapshotEdge.prototype.toString): (WebInspector.HeapSnapshotEdge.prototype.get _hasStringName): (WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren): (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge): 117869 2011-12-05 05:31:36 -0800 2011-12-05 09:12:01 -0800 Patch patch-69948 text/plain 3842 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjRhYzNkLi4zODYyOTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMTItMDUgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIEhlYXAgcHJvZmlsZXIgc2hvdWxk IGRlc2lnbmF0ZSB3ZWFrIHJlZmVyZW5jZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTk0OAorCisgICAgICAgIFdlYWsgcmVmZXJlbmNlcyBhcmUg bm93IGlnbm9yZWQgd2hlbiB0cmFjaW5nIHBhdGhzIHRvIEdDIHJvb3RzLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9IZWFwU25hcHNob3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RWRn ZS5wcm90b3R5cGUuZ2V0IGlzV2Vhayk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90RWRnZS5wcm90b3R5cGUudG9TdHJpbmcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBT bmFwc2hvdEVkZ2UucHJvdG90eXBlLmdldCBfaGFzU3RyaW5nTmFtZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuSGVhcFNuYXBzaG90UmV0YWluZXJFZGdlLnByb3RvdHlwZS5nZXQgaXNXZWFrKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlLl9pbml0KToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RQYXRoRmluZGVyLnByb3RvdHlwZS5fZmls bFJvb3RDaGlsZHJlbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90UGF0aEZp bmRlci5wcm90b3R5cGUuX3NraXBFZGdlKToKKwogMjAxMS0xMi0wNSAgUm9sYW5kIFN0ZWluZXIg IDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICA8c3R5bGUgc2NvcGVkPjog QWRkICdzY29wZWQnIGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwppbmRleCA1Mjk0ZDdjLi42OWY0ZWMwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwpA QCAtMjM2LDYgKzIzNiwxMSBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RWRnZS5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHJldHVybiB0aGlzLl90eXBlKCkgPT09IHRoaXMuX3NuYXBzaG90Ll9l ZGdlSGlkZGVuVHlwZTsKICAgICB9LAogCisgICAgZ2V0IGlzV2VhaygpCisgICAgeworICAgICAg ICByZXR1cm4gdGhpcy5fdHlwZSgpID09PSB0aGlzLl9zbmFwc2hvdC5fZWRnZVdlYWtUeXBlOwor ICAgIH0sCisKICAgICBnZXQgaXNJbnRlcm5hbCgpCiAgICAgewogICAgICAgICByZXR1cm4gdGhp cy5fdHlwZSgpID09PSB0aGlzLl9zbmFwc2hvdC5fZWRnZUludGVybmFsVHlwZTsKQEAgLTI3OSw2 ICsyODQsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RWRnZS5wcm90b3R5cGUgPSB7CiAg ICAgICAgIHN3aXRjaCAodGhpcy50eXBlKSB7CiAgICAgICAgIGNhc2UgImNvbnRleHQiOiByZXR1 cm4gIi0+IiArIHRoaXMubmFtZTsKICAgICAgICAgY2FzZSAiZWxlbWVudCI6IHJldHVybiAiWyIg KyB0aGlzLm5hbWUgKyAiXSI7CisgICAgICAgIGNhc2UgIndlYWsiOiByZXR1cm4gIltbIiArIHRo aXMubmFtZSArICJdXSI7CiAgICAgICAgIGNhc2UgInByb3BlcnR5IjoKICAgICAgICAgICAgIHJl dHVybiB0aGlzLm5hbWUuaW5kZXhPZigiICIpID09PSAtMSA/ICIuIiArIHRoaXMubmFtZSA6ICJb XCIiICsgdGhpcy5uYW1lICsgIlwiXSI7CiAgICAgICAgIGNhc2UgInNob3J0Y3V0IjoKQEAgLTMw Miw3ICszMDgsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RWRnZS5wcm90b3R5cGUgPSB7 CiAKICAgICBnZXQgX2hhc1N0cmluZ05hbWUoKQogICAgIHsKLSAgICAgICAgcmV0dXJuICF0aGlz LmlzRWxlbWVudCAmJiAhdGhpcy5pc0hpZGRlbjsKKyAgICAgICAgcmV0dXJuICF0aGlzLmlzRWxl bWVudCAmJiAhdGhpcy5pc0hpZGRlbiAmJiAhdGhpcy5pc1dlYWs7CiAgICAgfSwKIAogICAgIGdl dCBfbmFtZSgpCkBAIC00MDEsNiArNDA3LDExIEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RS ZXRhaW5lckVkZ2UucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gdGhpcy5fZWRnZS5pc1No b3J0Y3V0OwogICAgIH0sCiAKKyAgICBnZXQgaXNXZWFrKCkKKyAgICB7CisgICAgICAgIHJldHVy biB0aGlzLl9lZGdlLmlzV2VhazsKKyAgICB9LAorCiAgICAgZ2V0IG5hbWUoKQogICAgIHsKICAg ICAgICAgcmV0dXJuIHRoaXMuX2VkZ2UubmFtZTsKQEAgLTY5NSw2ICs3MDYsNyBAQCBXZWJJbnNw ZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fZWRnZUhpZGRl blR5cGUgPSB0aGlzLl9lZGdlVHlwZXMuaW5kZXhPZigiaGlkZGVuIik7CiAgICAgICAgIHRoaXMu X2VkZ2VJbnRlcm5hbFR5cGUgPSB0aGlzLl9lZGdlVHlwZXMuaW5kZXhPZigiaW50ZXJuYWwiKTsK ICAgICAgICAgdGhpcy5fZWRnZVNob3J0Y3V0VHlwZSA9IHRoaXMuX2VkZ2VUeXBlcy5pbmRleE9m KCJzaG9ydGN1dCIpOworICAgICAgICB0aGlzLl9lZGdlV2Vha1R5cGUgPSB0aGlzLl9lZGdlVHlw ZXMuaW5kZXhPZigid2VhayIpOwogICAgICAgICB0aGlzLl9lZGdlSW52aXNpYmxlVHlwZSA9IHRo aXMuX2VkZ2VUeXBlcy5sZW5ndGg7CiAgICAgICAgIHRoaXMuX2VkZ2VUeXBlcy5wdXNoKCJpbnZp c2libGUiKTsKIApAQCAtMTQwNiw4ICsxNDE4LDEyIEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RQYXRoRmluZGVyLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHZhciByZXN1bHQgPSBb XTsKICAgICAgICAgZm9yICh2YXIgaXRlciA9IHRoaXMuX3NuYXBzaG90LnJvb3ROb2RlLmVkZ2Vz OyBpdGVyLmhhc05leHQoKTsgaXRlci5uZXh0KCkpIHsKLSAgICAgICAgICAgIGlmICghZmlsdGVy IHx8IGZpbHRlcihpdGVyLmVkZ2Uubm9kZSkpCisgICAgICAgICAgICBpZiAoIWZpbHRlcikgewor ICAgICAgICAgICAgICAgIGlmICghaXRlci5lZGdlLmlzU2hvcnRjdXQpCisgICAgICAgICAgICAg ICAgICAgIHJlc3VsdFtpdGVyLmVkZ2Uubm9kZUluZGV4XSA9IHRydWU7CisgICAgICAgICAgICB9 IGVsc2UgaWYgKGZpbHRlcihpdGVyLmVkZ2Uubm9kZSkpIHsKICAgICAgICAgICAgICAgICByZXN1 bHRbaXRlci5lZGdlLm5vZGVJbmRleF0gPSB0cnVlOworICAgICAgICAgICAgfQogICAgICAgICB9 CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfSwKQEAgLTE0NTAsNiArMTQ2Niw3IEBAIFdl Ykluc3BlY3Rvci5IZWFwU25hcHNob3RQYXRoRmluZGVyLnByb3RvdHlwZSA9IHsKICAgICB7CiAg ICAgICAgIHJldHVybiBlZGdlLmlzSW52aXNpYmxlCiAgICAgICAgICAgICB8fCAodGhpcy5fc2tp cEhpZGRlbiAmJiAoZWRnZS5pc0hpZGRlbiB8fCBlZGdlLm5vZGUuaXNIaWRkZW4pKQorICAgICAg ICAgICAgfHwgZWRnZS5pc1dlYWsKICAgICAgICAgICAgIHx8IHRoaXMuX2hhc0luUGF0aChlZGdl Lm5vZGVJbmRleCk7CiAgICAgfSwKIAo=