69928 2011-10-12 07:41:58 -0700 [WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation. 2011-10-13 06:57:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 nayankk webkit-unassigned cgarcia gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 482403 0 nayankk 2011-10-12 07:41:58 -0700 Fix the following warnings, ./tmpl/WebKitWebContext.sgml:29: warning: Value descriptions for WebKitCacheModel are missing in source code comment block. ../../../../../../../../Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:274: warning: Parameter described in source code comment block but does not exist. FUNCTION: webkit_web_view_reload_bypass_cache Parameter: webView. ../../../../../../../../Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:274: warning: Parameter description for webkit_web_view_reload_bypass_cache::web_view is missing in source code comment block. ./tmpl/WebKitError.sgml:55: warning: Value descriptions for WebKitPluginError are missing in source code comment block. ./tmpl/WebKitError.sgml:67: warning: Value descriptions for WebKitPolicyError are missing in source code comment block. gtk-doc: Building HTML 483084 1 110817 nayankk 2011-10-13 02:52:08 -0700 Created attachment 110817 Warning fix 483106 2 110817 cgarcia 2011-10-13 04:05:46 -0700 Comment on attachment 110817 Warning fix View in context: https://bugs.webkit.org/attachment.cgi?id=110817&action=review Thanks for the patch! > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:63 > +/** > + * WebKitPolicyError: > + * @WEBKIT_POLICY_ERROR_FAILED: Generic load failure due to policy error > + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_MIME_TYPE: Load failure due to unsupported mime type > + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown > + * @WEBKIT_POLICY_ERROR_FRAME_LOAD_INTERRUPTED_BY_POLICY_CHANGE: Load failure due to frame load interruption by policy change > + * @WEBKIT_POLICY_ERROR_CANNOT_USE_RESTRICTED_PORT: Load failure due to port restriction > + * > + * Enum values used to denote the various policy errors. This is not actually fixing a warning (even though it fixes a warning), but documenting WebKitPolicyError enum, so I think this should be another bug. > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:64 > + * Do you really need this empty line here? > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:83 > +/** > + * WebKitPluginError: > + * @WEBKIT_PLUGIN_ERROR_FAILED: Generic plugin load failure > + * @WEBKIT_PLUGIN_ERROR_CANNOT_FIND_PLUGIN: Load failure due to missing plugin > + * @WEBKIT_PLUGIN_ERROR_CANNOT_LOAD_PLUGIN: Load failure due to inability to load plugin > + * @WEBKIT_PLUGIN_ERROR_JAVA_UNAVAILABLE: Load failue due to missing Java support that is required to load plugin > + * @WEBKIT_PLUGIN_ERROR_CONNECTION_CANCELLED: Load failure due to connection cancellation > + * @WEBKIT_PLUGIN_ERROR_WILL_HANDLE_LOAD: Load failure since plugin handles the load > + * > + * Enum values used to denote the various plugin errors. Ditto, I think it would be better to file a new bug report to document missing enums in WebError and include a patch with both PolicyError and PluginError enums documented. > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:84 > + * I don't think we need this empty line. > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:53 > - */ > + * > + **/ Are you sure this produces a warning? I don't think we need either the empty line nor the double ** at the end. 483116 3 110824 nayankk 2011-10-13 04:33:54 -0700 Created attachment 110824 Warning fix 483117 4 110817 nayankk 2011-10-13 04:37:25 -0700 Comment on attachment 110817 Warning fix View in context: https://bugs.webkit.org/attachment.cgi?id=110817&action=review >> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:83 >> + * Enum values used to denote the various plugin errors. > > Ditto, I think it would be better to file a new bug report to document missing enums in WebError and include a patch with both PolicyError and PluginError enums documented. I have raised a new bug for adding this documentation - https://bugs.webkit.org/show_bug.cgi?id=70016 >> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:84 >> + * > > I don't think we need this empty line. Yes, we actually do not need an empty line here. >> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:53 >> + **/ > > Are you sure this produces a warning? I don't think we need either the empty line nor the double ** at the end. You are right. Double ** is needed only in starting the comment block. Removed this and also the empty line. 483162 5 110824 webkit.review.bot 2011-10-13 06:57:55 -0700 Comment on attachment 110824 Warning fix Clearing flags on attachment: 110824 Committed r97364: <http://trac.webkit.org/changeset/97364> 483163 6 webkit.review.bot 2011-10-13 06:57:59 -0700 All reviewed patches have been landed. Closing bug. 110817 2011-10-13 02:52:08 -0700 2011-10-13 04:37:25 -0700 Warning fix WarningFix.diff text/plain 4322 nayankk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YmMzYzQwLi43ZWQyZGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTAtMTMgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KKwor ICAgICAgICBbV2ViS2l0Ml1bZ3RrXSBGaXggd2FybmluZ3Mgd2hpbGUgZ2VuZXJhdGluZyBXZWJL aXQyLUdUSysgZG9jdW1lbnRhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY5OTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUGF0Y2ggZml4ZXMgdGhlIHdhcm5pbmdzIHJlcG9ydGVkIGJ5IGd0ay1k b2Mgd2hpbGUgZ2VuZXJhdGluZworICAgICAgICBXZWJLaXQyLUdUSysgZG9jdW1lbnRhdGlvbi4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVycm9yLmg6IEFkZCBkb2N1bWVu dGF0aW9uIGZvciBXZWJLaXRQb2xpY3lFcnJvciBhbmQgV2ViS2l0UGx1Z2luRXJyb3IgZW51bXMu CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5oOiBDb3JyZWN0 IHRoZSBkb2N1bWVudGF0aW9uIGNvbW1lbnQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5jcHA6IFBhcmFtZXRlciBuYW1lIGNvcnJlY3Rpb24uCisKIDIwMTEtMTAt MTIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBQYXNz IFBhcnNlZCBBY2NlcHQgQXR0cmlidXRlIE1JTUUgVHlwZXMgdG8gV2ViS2l0IENsaWVudHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVycm9yLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFcnJvci5oCmluZGV4IGZh NTA2ZWYuLjVjYTUwNmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRFcnJvci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdEVycm9yLmgKQEAgLTUyLDYgKzUyLDE3IEBAIHR5cGVkZWYgZW51bSB7CiAgICAgV0VC S0lUX05FVFdPUktfRVJST1JfRklMRV9ET0VTX05PVF9FWElTVCA9IDMwMwogfSBXZWJLaXROZXR3 b3JrRXJyb3I7CiAKKy8qKgorICogV2ViS2l0UG9saWN5RXJyb3I6CisgKiBAV0VCS0lUX1BPTElD WV9FUlJPUl9GQUlMRUQ6IEdlbmVyaWMgbG9hZCBmYWlsdXJlIGR1ZSB0byBwb2xpY3kgZXJyb3IK KyAqIEBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9TSE9XX01JTUVfVFlQRTogTG9hZCBmYWls dXJlIGR1ZSB0byB1bnN1cHBvcnRlZCBtaW1lIHR5cGUKKyAqIEBXRUJLSVRfUE9MSUNZX0VSUk9S X0NBTk5PVF9TSE9XX1VSTDogTG9hZCBmYWlsdXJlIGR1ZSB0byB1cmwgdGhhdCBjYW4gbm90IGJl IHNob3duCisgKiBAV0VCS0lUX1BPTElDWV9FUlJPUl9GUkFNRV9MT0FEX0lOVEVSUlVQVEVEX0JZ X1BPTElDWV9DSEFOR0U6IExvYWQgZmFpbHVyZSBkdWUgdG8gZnJhbWUgbG9hZCBpbnRlcnJ1cHRp b24gYnkgcG9saWN5IGNoYW5nZQorICogQFdFQktJVF9QT0xJQ1lfRVJST1JfQ0FOTk9UX1VTRV9S RVNUUklDVEVEX1BPUlQ6IExvYWQgZmFpbHVyZSBkdWUgdG8gcG9ydCByZXN0cmljdGlvbgorICoK KyAqIEVudW0gdmFsdWVzIHVzZWQgdG8gZGVub3RlIHRoZSB2YXJpb3VzIHBvbGljeSBlcnJvcnMu CisgKgorICoqLwogdHlwZWRlZiBlbnVtIHsKICAgICBXRUJLSVRfUE9MSUNZX0VSUk9SX0ZBSUxF RCA9IDE5OSwKICAgICBXRUJLSVRfUE9MSUNZX0VSUk9SX0NBTk5PVF9TSE9XX01JTUVfVFlQRSA9 IDEwMCwKQEAgLTYwLDYgKzcxLDE4IEBAIHR5cGVkZWYgZW51bSB7CiAgICAgV0VCS0lUX1BPTElD WV9FUlJPUl9DQU5OT1RfVVNFX1JFU1RSSUNURURfUE9SVCA9IDEwMwogfSBXZWJLaXRQb2xpY3lF cnJvcjsKIAorLyoqCisgKiBXZWJLaXRQbHVnaW5FcnJvcjoKKyAqIEBXRUJLSVRfUExVR0lOX0VS Uk9SX0ZBSUxFRDogR2VuZXJpYyBwbHVnaW4gbG9hZCBmYWlsdXJlCisgKiBAV0VCS0lUX1BMVUdJ Tl9FUlJPUl9DQU5OT1RfRklORF9QTFVHSU46IExvYWQgZmFpbHVyZSBkdWUgdG8gbWlzc2luZyBw bHVnaW4KKyAqIEBXRUJLSVRfUExVR0lOX0VSUk9SX0NBTk5PVF9MT0FEX1BMVUdJTjogTG9hZCBm YWlsdXJlIGR1ZSB0byBpbmFiaWxpdHkgdG8gbG9hZCBwbHVnaW4KKyAqIEBXRUJLSVRfUExVR0lO X0VSUk9SX0pBVkFfVU5BVkFJTEFCTEU6IExvYWQgZmFpbHVlIGR1ZSB0byBtaXNzaW5nIEphdmEg c3VwcG9ydCB0aGF0IGlzIHJlcXVpcmVkIHRvIGxvYWQgcGx1Z2luCisgKiBAV0VCS0lUX1BMVUdJ Tl9FUlJPUl9DT05ORUNUSU9OX0NBTkNFTExFRDogTG9hZCBmYWlsdXJlIGR1ZSB0byBjb25uZWN0 aW9uIGNhbmNlbGxhdGlvbgorICogQFdFQktJVF9QTFVHSU5fRVJST1JfV0lMTF9IQU5ETEVfTE9B RDogTG9hZCBmYWlsdXJlIHNpbmNlIHBsdWdpbiBoYW5kbGVzIHRoZSBsb2FkCisgKgorICogRW51 bSB2YWx1ZXMgdXNlZCB0byBkZW5vdGUgdGhlIHZhcmlvdXMgcGx1Z2luIGVycm9ycy4KKyAqCisg KiovCiB0eXBlZGVmIGVudW0gewogICAgIFdFQktJVF9QTFVHSU5fRVJST1JfRkFJTEVEID0gMjk5 LAogICAgIFdFQktJVF9QTFVHSU5fRVJST1JfQ0FOTk9UX0ZJTkRfUExVR0lOID0gMjAwLApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4 dC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5o CmluZGV4IDc4NmM5OTkuLjMzOWFiNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmgKQEAgLTM2LDcgKzM2LDcgQEAgR19CRUdJ Tl9ERUNMUwogI2RlZmluZSBXRUJLSVRfSVNfV0VCX0NPTlRFWFRfQ0xBU1Moa2xhc3MpIChHX1RZ UEVfQ0hFQ0tfQ0xBU1NfVFlQRSgoa2xhc3MpLCAgV0VCS0lUX1RZUEVfV0VCX0NPTlRFWFQpKQog I2RlZmluZSBXRUJLSVRfV0VCX0NPTlRFWFRfR0VUX0NMQVNTKG9iaikgIChHX1RZUEVfSU5TVEFO Q0VfR0VUX0NMQVNTKChvYmopLCAgV0VCS0lUX1RZUEVfV0VCX0NPTlRFWFQsIFdlYktpdFdlYkNv bnRleHRDbGFzcykpCiAKLS8qCisvKioKICAqIFdlYktpdENhY2hlTW9kZWw6CiAgKiBAV0VCS0lU X0NBQ0hFX01PREVMX0RPQ1VNRU5UX1ZJRVdFUjogRGlzYWJsZSB0aGUgY2FjaGUgY29tcGxldGVs eSwgd2hpY2gKICAqICAgc3Vic3RhbnRpYWxseSByZWR1Y2VzIG1lbW9yeSB1c2FnZS4gVXNlZnVs IGZvciBhcHBsaWNhdGlvbnMgdGhhdCBvbmx5CkBAIC00OSw3ICs0OSw4IEBAIEdfQkVHSU5fREVD TFMKICAqICAgYnkgY2FjaGluZyBhIHZlcnkgbGFyZ2UgbnVtYmVyIG9mIHJlc291cmNlcyBhbmQg cHJldmlvdXNseSB2aWV3ZWQgY29udGVudC4KICAqCiAgKiBFbnVtIHZhbHVlcyB1c2VkIGZvciBk ZXRlcm1pbmluZyB0aGUgd2VidmlldyBjYWNoZSBtb2RlbC4KLSAqLworICoKKyAqKi8KIHR5cGVk ZWYgZW51bSB7CiAgICAgV0VCS0lUX0NBQ0hFX01PREVMX0RPQ1VNRU5UX1ZJRVdFUiwKICAgICBX RUJLSVRfQ0FDSEVfTU9ERUxfV0VCX0JST1dTRVIsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IDVmZWY1MDguLjJiMDQzMWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXcuY3BwCkBAIC0yNjcsNyArMjY3LDcgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfcmVsb2FkKFdl YktpdFdlYlZpZXcqIHdlYlZpZXcpCiAKIC8qKgogICogd2Via2l0X3dlYl92aWV3X3JlbG9hZF9i eXBhc3NfY2FjaGU6Ci0gKiBAd2ViVmlldzogYSAjV2ViS2l0V2ViVmlldworICogQHdlYl92aWV3 OiBhICNXZWJLaXRXZWJWaWV3CiAgKgogICogUmVsb2FkcyB0aGUgY3VycmVudCBjb250ZW50cyBv ZiBAd2ViX3ZpZXcgd2l0aG91dAogICogdXNpbmcgYW55IGNhY2hlZCBkYXRhLgo= 110824 2011-10-13 04:33:54 -0700 2011-10-13 06:57:55 -0700 Warning fix warning-fix.diff text/plain 2041 nayankk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YmMzYzQwLi43NDkzZDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMTMgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KKwor ICAgICAgICBbV2ViS2l0Ml1bZ3RrXSBGaXggd2FybmluZ3Mgd2hpbGUgZ2VuZXJhdGluZyBXZWJL aXQyLUdUSysgZG9jdW1lbnRhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY5OTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUGF0Y2ggZml4ZXMgdGhlIHdhcm5pbmdzIHJlcG9ydGVkIGJ5IGd0ay1k b2Mgd2hpbGUgZ2VuZXJhdGluZworICAgICAgICBXZWJLaXQyLUdUSysgZG9jdW1lbnRhdGlvbi4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuaDogQ29ycmVj dCB0aGUgZG9jdW1lbnRhdGlvbiBjb21tZW50LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXcuY3BwOiBQYXJhbWV0ZXIgbmFtZSBjb3JyZWN0aW9uLgorCiAyMDExLTEw LTEyICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGFz cyBQYXJzZWQgQWNjZXB0IEF0dHJpYnV0ZSBNSU1FIFR5cGVzIHRvIFdlYktpdCBDbGllbnRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250 ZXh0LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0 LmgKaW5kZXggNzg2Yzk5OS4uMmYzOGRiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuaApAQCAtMzYsNyArMzYsNyBAQCBHX0JF R0lOX0RFQ0xTCiAjZGVmaW5lIFdFQktJVF9JU19XRUJfQ09OVEVYVF9DTEFTUyhrbGFzcykgKEdf VFlQRV9DSEVDS19DTEFTU19UWVBFKChrbGFzcyksICBXRUJLSVRfVFlQRV9XRUJfQ09OVEVYVCkp CiAjZGVmaW5lIFdFQktJVF9XRUJfQ09OVEVYVF9HRVRfQ0xBU1Mob2JqKSAgKEdfVFlQRV9JTlNU QU5DRV9HRVRfQ0xBU1MoKG9iaiksICBXRUJLSVRfVFlQRV9XRUJfQ09OVEVYVCwgV2ViS2l0V2Vi Q29udGV4dENsYXNzKSkKIAotLyoKKy8qKgogICogV2ViS2l0Q2FjaGVNb2RlbDoKICAqIEBXRUJL SVRfQ0FDSEVfTU9ERUxfRE9DVU1FTlRfVklFV0VSOiBEaXNhYmxlIHRoZSBjYWNoZSBjb21wbGV0 ZWx5LCB3aGljaAogICogICBzdWJzdGFudGlhbGx5IHJlZHVjZXMgbWVtb3J5IHVzYWdlLiBVc2Vm dWwgZm9yIGFwcGxpY2F0aW9ucyB0aGF0IG9ubHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggNWZlZjUwOC4uMmIwNDMxYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHAKQEAgLTI2Nyw3ICsyNjcsNyBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19yZWxvYWQoV2Vi S2l0V2ViVmlldyogd2ViVmlldykKIAogLyoqCiAgKiB3ZWJraXRfd2ViX3ZpZXdfcmVsb2FkX2J5 cGFzc19jYWNoZToKLSAqIEB3ZWJWaWV3OiBhICNXZWJLaXRXZWJWaWV3CisgKiBAd2ViX3ZpZXc6 IGEgI1dlYktpdFdlYlZpZXcKICAqCiAgKiBSZWxvYWRzIHRoZSBjdXJyZW50IGNvbnRlbnRzIG9m IEB3ZWJfdmlldyB3aXRob3V0CiAgKiB1c2luZyBhbnkgY2FjaGVkIGRhdGEuCg==