69923 2011-10-12 06:14:49 -0700 [v8] Use V8DOMWrapper::isWrapperOfType for determining global object type 2011-10-12 07:21:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yurys yurys abarth antonm pfeldman webkit.review.bot oldest_to_newest 482371 0 yurys 2011-10-12 06:14:49 -0700 globalObjectPrototypeIsDOMWindow now relies on the difference in internal fields count between DOMWindow and WorkerContext. Would be better to use V8DOMWrapper::isWrapperOfType for determining the global object type. 482376 1 110677 yurys 2011-10-12 06:21:31 -0700 Created attachment 110677 Patch 482378 2 110677 antonm 2011-10-12 06:25:51 -0700 Comment on attachment 110677 Patch lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks. Mind running against Dromaeo with and without this change just to be sure? 482395 3 yurys 2011-10-12 07:18:16 -0700 (In reply to comment #2) > (From update of attachment 110677 [details]) > lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks. Mind running against Dromaeo with and without this change just to be sure? Without the patch: http://dromaeo.com/?id=152544 -- 1147.88runs/s (Total) With the patch applied: http://dromaeo.com/?id=152545 -- 1130.44runs/s (Total) 482397 4 yurys 2011-10-12 07:21:52 -0700 Committed r97260: <http://trac.webkit.org/changeset/97260> 110677 2011-10-12 06:21:31 -0700 2011-10-12 06:40:29 -0700 Patch bug-69923-20111012172129.patch text/plain 3789 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogOTcyNDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMjc3NjUxNGMyNmFhZGNl MWJjNzllNzcwYWE1NzkzZjEzNzVlNWViLi41OTcyZDhjZTJjZTlhYjQwMDU4YTM1ZDRlODI2MDJj ZjliOTVmY2RiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTIgIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW3Y4XSBVc2UgVjhE T01XcmFwcGVyOjppc1dyYXBwZXJPZlR5cGUgZm9yIGRldGVybWluaW5nIGdsb2JhbCBvYmplY3Qg dHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk5 MjMKKworICAgICAgICBHZXQgcmlkIG9mIGdsb2JhbE9iamVjdFByb3RvdHlwZUlzRE9NV2luZG93 LCB1c2UgVjhET01XcmFwcGVyOjppc1dyYXBwZXJPZlR5cGUgaW5zdGVhZC4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9N V3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRl VjhPYmplY3QpOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpnZXRFdmVudExpc3Rl bmVyKToKKwogMjAxMS0xMC0xMiAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyOTQ4MzYpOiBBbiBhc3NlcnRpb24gZmFpbHMgaW4gSFRNTEZv cm1Db250cm9sRWxlbWVudDo6aXNWYWxpZEZvcm1Db250cm9sRWxlbWVudApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKaW5kZXggOTlmYjNmNzA3YTgwMGRhOGQ2 OWQ3NmU1NDcxMWI4N2MwZDEzZmYyMS4uY2NmOTVmNGZmN2FiYTg1ZWU5YjNlNTkzNWI2NzY2ZTBl YzBmZjkwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFw cGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3Bw CkBAIC0yMzAsMjQgKzIzMCw2IEBAIFBhc3NSZWZQdHI8Tm9kZUZpbHRlcj4gVjhET01XcmFwcGVy Ojp3cmFwTmF0aXZlTm9kZUZpbHRlcih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4KICAgICByZXR1cm4g Tm9kZUZpbHRlcjo6Y3JlYXRlKFY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6Y3JlYXRlKGZpbHRlcikp OwogfQogCi1zdGF0aWMgYm9vbCBnbG9iYWxPYmplY3RQcm90b3R5cGVJc0RPTVdpbmRvdyh2ODo6 SGFuZGxlPHY4OjpPYmplY3Q+IG9iamVjdFByb3RvdHlwZSkKLXsKLSAgICAvLyBXZSBjYW4gaWRl bnRpZnkgd2hhdCB0eXBlIG9mIGNvbnRleHQgdGhlIGdsb2JhbCBvYmplY3QgaXMgd3JhcHBpbmcg YnkgbG9va2luZyBhdCB0aGUKLSAgICAvLyBpbnRlcm5hbCBmaWVsZCBjb3VudCBvZiBpdHMgcHJv dG90eXBlLiBUaGlzIGFzc3VtZXMgV29ya2VyQ29udGV4dHMgYW5kIERPTVdpbmRvd3MgaGF2ZSBk aWZmZXJlbnQgbnVtYmVycwotICAgIC8vIG9mIGludGVybmFsIGZpZWxkcywgc28gYSBDT01QSUxF X0FTU0VSVCBpcyBpbmNsdWRlZCB0byB3YXJuIGlmIHRoaXMgZXZlciBjaGFuZ2VzLgotI2lmIEVO QUJMRShXT1JLRVJTKQotICAgIENPTVBJTEVfQVNTRVJUKFY4RE9NV2luZG93OjppbnRlcm5hbEZp ZWxkQ291bnQgIT0gVjhXb3JrZXJDb250ZXh0OjppbnRlcm5hbEZpZWxkQ291bnQsCi0gICAgICAg IERPTVdpbmRvd0FuZFdvcmtlckNvbnRleHRIYXZlVW5lcXVhbEZpZWxkQ291bnRzKTsKLSAgICBD T01QSUxFX0FTU0VSVChWOERPTVdpbmRvdzo6aW50ZXJuYWxGaWVsZENvdW50ICE9IFY4RGVkaWNh dGVkV29ya2VyQ29udGV4dDo6aW50ZXJuYWxGaWVsZENvdW50LAotICAgICAgICBET01XaW5kb3dB bmREZWRpY2F0ZWRXb3JrZXJDb250ZXh0SGF2ZVVuZXF1YWxGaWVsZENvdW50cyk7Ci0jZW5kaWYK LSNpZiBFTkFCTEUoU0hBUkVEX1dPUktFUlMpCi0gICAgQ09NUElMRV9BU1NFUlQoVjhET01XaW5k b3c6OmludGVybmFsRmllbGRDb3VudCAhPSBWOFNoYXJlZFdvcmtlckNvbnRleHQ6OmludGVybmFs RmllbGRDb3VudCwKLSAgICAgICAgRE9NV2luZG93QW5kU2hhcmVkV29ya2VyQ29udGV4dEhhdmVV bmVxdWFsRmllbGRDb3VudHMpOwotI2VuZGlmCi0gICAgcmV0dXJuIG9iamVjdFByb3RvdHlwZS0+ SW50ZXJuYWxGaWVsZENvdW50KCkgPT0gVjhET01XaW5kb3c6OmludGVybmFsRmllbGRDb3VudDsK LX0KLQogdjg6OkxvY2FsPHY4OjpPYmplY3Q+IFY4RE9NV3JhcHBlcjo6aW5zdGFudGlhdGVWOE9i amVjdChWOFByb3h5KiBwcm94eSwgV3JhcHBlclR5cGVJbmZvKiB0eXBlLCB2b2lkKiBpbXBsKQog ewogI2lmIEVOQUJMRShXT1JLRVJTKQpAQCAtMjYzLDcgKzI0NSw3IEBAIHY4OjpMb2NhbDx2ODo6 T2JqZWN0PiBWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhPYmplY3QoVjhQcm94eSogcHJveHks IFdyYXBwZXJUCiAgICAgICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQgPSB2ODo6 Q29udGV4dDo6R2V0Q3VycmVudCgpOwogICAgICAgICBpZiAoIWNvbnRleHQuSXNFbXB0eSgpKSB7 CiAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdsb2JhbFByb3RvdHlwZSA9IHY4 OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QoY29udGV4dC0+R2xvYmFsKCktPkdldFByb3RvdHlw ZSgpKTsKLSAgICAgICAgICAgIGlmIChnbG9iYWxPYmplY3RQcm90b3R5cGVJc0RPTVdpbmRvdyhn bG9iYWxQcm90b3R5cGUpKQorICAgICAgICAgICAgaWYgKGlzV3JhcHBlck9mVHlwZShnbG9iYWxQ cm90b3R5cGUsICZWOERPTVdpbmRvdzo6aW5mbykpCiAgICAgICAgICAgICAgICAgcHJveHkgPSBW OFByb3h5OjpyZXRyaWV2ZShWOERPTVdpbmRvdzo6dG9OYXRpdmUoZ2xvYmFsUHJvdG90eXBlKS0+ ZnJhbWUoKSk7CiAjaWYgRU5BQkxFKFdPUktFUlMpCiAgICAgICAgICAgICBlbHNlCkBAIC00Njgs NyArNDUwLDcgQEAgUGFzc1JlZlB0cjxFdmVudExpc3RlbmVyPiBWOERPTVdyYXBwZXI6OmdldEV2 ZW50TGlzdGVuZXIodjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmEKICAgICBpZiAobG9va3VwID09IExp c3RlbmVyRmluZE9ubHkpCiAgICAgICAgIHJldHVybiBWOEV2ZW50TGlzdGVuZXJMaXN0OjpmaW5k V3JhcHBlcih2YWx1ZSwgaXNBdHRyaWJ1dGUpOwogICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4g Z2xvYmFsUHJvdG90eXBlID0gdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChjb250ZXh0LT5H bG9iYWwoKS0+R2V0UHJvdG90eXBlKCkpOwotICAgIGlmIChnbG9iYWxPYmplY3RQcm90b3R5cGVJ c0RPTVdpbmRvdyhnbG9iYWxQcm90b3R5cGUpKQorICAgIGlmIChpc1dyYXBwZXJPZlR5cGUoZ2xv YmFsUHJvdG90eXBlLCAmVjhET01XaW5kb3c6OmluZm8pKQogICAgICAgICByZXR1cm4gVjhFdmVu dExpc3RlbmVyTGlzdDo6ZmluZE9yQ3JlYXRlV3JhcHBlcjxWOEV2ZW50TGlzdGVuZXI+KHZhbHVl LCBpc0F0dHJpYnV0ZSk7CiAjaWYgRU5BQkxFKFdPUktFUlMpCiAgICAgcmV0dXJuIFY4RXZlbnRM aXN0ZW5lckxpc3Q6OmZpbmRPckNyZWF0ZVdyYXBwZXI8VjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0 ZW5lcj4odmFsdWUsIGlzQXR0cmlidXRlKTsK