69918 2011-10-12 04:01:10 -0700 DFG JIT 32_64 - Fix ArrayPop 2011-10-12 12:27:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 482339 0 yuqiang.xian 2011-10-12 04:01:10 -0700 The storageLengthGPR is polluted by EmptyValueTag and later used to index the array, which results in abnormal behaviors in execution. This fix makes 32_64 DFG pass v8-deltablue and kraken crypto-sha256-iterative on Linux ia32. 482340 1 110662 yuqiang.xian 2011-10-12 04:03:54 -0700 Created attachment 110662 the patch 482360 2 110672 yuqiang.xian 2011-10-12 05:33:30 -0700 Created attachment 110672 the patch I think I was muddled when developing the previous wrong patch... :( Also, please help land it manually if you think it should be r+, as I'm not sure if the commit queue will be happy about the style warnings. Thanks a lot. 482361 3 webkit.review.bot 2011-10-12 05:36:19 -0700 Attachment 110672 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:1069: movl_i32m is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 482565 4 fpizlo 2011-10-12 11:36:01 -0700 Ouch, I can't believe I created that bug. 482604 5 110672 webkit.review.bot 2011-10-12 12:27:18 -0700 Comment on attachment 110672 the patch Clearing flags on attachment: 110672 Committed r97286: <http://trac.webkit.org/changeset/97286> 482605 6 webkit.review.bot 2011-10-12 12:27:22 -0700 All reviewed patches have been landed. Closing bug. 110662 2011-10-12 04:03:54 -0700 2011-10-12 05:33:30 -0700 the patch 69918.patch text/plain 2085 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcyNTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMTAtMTIgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgREZHIEpJVCAzMl82NCAtIEZpeCBBcnJheVBvcAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk5MTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3RvcmFnZUxlbmd0aEdQUiBpcyBwb2xsdXRl ZCBieSBFbXB0eVZhbHVlVGFnIGFuZCBsYXRlciB1c2VkIHRvCisgICAgICAgIGluZGV4IHRoZSBh cnJheSwgd2hpY2ggcmVzdWx0cyBpbiBhYm5vcm1hbCBiZWhhdmlvcnMgaW4gZXhlY3V0aW9uLgor ICAgICAgICBUaGlzIGZpeCBtYWtlcyAzMl82NCBERkcgcGFzcyB2OC1kZWx0YWJsdWUgYW5kIGty YWtlbgorICAgICAgICBjcnlwdG8tc2hhMjU2LWl0ZXJhdGl2ZSBvbiBMaW51eCBpYTMyLgorCisg ICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKwogMjAxMS0xMC0xMiAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCB0ZXN0cyBjcmFzaGluZyBpbiBE RkcgSklUIGNvZGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp dmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gOTcyNDQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNTQ0LDggKzE1NDQsOCBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUm IG5vZGUpCiAKICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6Okp1bXAgaG9sZUNhc2UgPSBtX2ppdC5i cmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6RXF1YWwsIEltbTMyKEpTVmFsdWU6OkVtcHR5VmFsdWVU YWcpLCB2YWx1ZVRhZ0dQUik7CiAgICAgICAgIAotICAgICAgICBtX2ppdC5tb3ZlKEltbTMyKEpT VmFsdWU6OkVtcHR5VmFsdWVUYWcpLCBzdG9yYWdlTGVuZ3RoR1BSKTsKLSAgICAgICAgbV9qaXQu c3RvcmUzMihzdG9yYWdlTGVuZ3RoR1BSLCBNYWNyb0Fzc2VtYmxlcjo6QmFzZUluZGV4KHN0b3Jh Z2VHUFIsIHN0b3JhZ2VMZW5ndGhHUFIsIE1hY3JvQXNzZW1ibGVyOjpUaW1lc0VpZ2h0LCBPQkpF Q1RfT0ZGU0VUT0YoQXJyYXlTdG9yYWdlLCBtX3ZlY3RvclswXSkgKyBPQkpFQ1RfT0ZGU0VUT0Yo SlNWYWx1ZSwgdS5hc0JpdHMudGFnKSkpOworICAgICAgICBtX2ppdC5tb3ZlKEltbTMyKEpTVmFs dWU6OkVtcHR5VmFsdWVUYWcpLCBiYXNlR1BSKTsgLy8gcmV1c2UgYmFzZUdQUiBhcyBpdCB3b24n dCBiZSB1c2VkIGluIHRoaXMgcGF0aAorICAgICAgICBtX2ppdC5zdG9yZTMyKGJhc2VHUFIsIE1h Y3JvQXNzZW1ibGVyOjpCYXNlSW5kZXgoc3RvcmFnZUdQUiwgc3RvcmFnZUxlbmd0aEdQUiwgTWFj cm9Bc3NlbWJsZXI6OlRpbWVzRWlnaHQsIE9CSkVDVF9PRkZTRVRPRihBcnJheVN0b3JhZ2UsIG1f dmVjdG9yWzBdKSArIE9CSkVDVF9PRkZTRVRPRihKU1ZhbHVlLCB1LmFzQml0cy50YWcpKSk7CiAK ICAgICAgICAgbV9qaXQuc3ViMzIoTWFjcm9Bc3NlbWJsZXI6OkltbTMyKDEpLCBNYWNyb0Fzc2Vt Ymxlcjo6QWRkcmVzcyhzdG9yYWdlR1BSLCBPQkpFQ1RfT0ZGU0VUT0YoQXJyYXlTdG9yYWdlLCBt X251bVZhbHVlc0luVmVjdG9yKSkpOwogICAgICAgICAK 110672 2011-10-12 05:33:30 -0700 2011-10-12 12:27:18 -0700 the patch 69918.1.patch text/plain 3557 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcyNTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTEtMTAtMTIgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgREZHIEpJVCAzMl82NCAtIEZpeCBBcnJheVBvcAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk5MTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3RvcmFnZUxlbmd0aEdQUiBpcyBwb2xsdXRl ZCBieSBFbXB0eVZhbHVlVGFnIGFuZCBsYXRlciB1c2VkIHRvCisgICAgICAgIGluZGV4IHRoZSBh cnJheSwgd2hpY2ggcmVzdWx0cyBpbiBhYm5vcm1hbCBiZWhhdmlvcnMgaW4gZXhlY3V0aW9uLgor ICAgICAgICBUaGlzIGZpeCBtYWtlcyAzMl82NCBERkcgcGFzcyB2OC1kZWx0YWJsdWUgYW5kIGty YWtlbgorICAgICAgICBjcnlwdG8tc2hhMjU2LWl0ZXJhdGl2ZSBvbiBMaW51eCBpYTMyLgorCisg ICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmg6CisgICAgICAgIChK U0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpzdG9yZTMyKToKKyAgICAgICAgKiBhc3NlbWJs ZXIvWDg2QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxlcjo6bW92bF9pMzJt KToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDExLTEwLTEyICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IHRlc3RzIGNyYXNoaW5n IGluIERGRyBKSVQgY29kZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAkocmV2aXNpb24gOTcyNDQp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29t bW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTUxMSw2ICs1MTEsMTEgQEAgcHVibGljOgogICAgICAg ICBtX2Fzc2VtYmxlci5tb3ZsX2kzMm0oaW1tLm1fdmFsdWUsIGFkZHJlc3Mub2Zmc2V0LCBhZGRy ZXNzLmJhc2UpOwogICAgIH0KICAgICAKKyAgICB2b2lkIHN0b3JlMzIoVHJ1c3RlZEltbTMyIGlt bSwgQmFzZUluZGV4IGFkZHJlc3MpCisgICAgeworICAgICAgICBtX2Fzc2VtYmxlci5tb3ZsX2kz Mm0oaW1tLm1fdmFsdWUsIGFkZHJlc3Mub2Zmc2V0LCBhZGRyZXNzLmJhc2UsIGFkZHJlc3MuaW5k ZXgsIGFkZHJlc3Muc2NhbGUpOworICAgIH0KKwogICAgIHZvaWQgc3RvcmU4KFRydXN0ZWRJbW0z MiBpbW0sIEFkZHJlc3MgYWRkcmVzcykKICAgICB7CiAgICAgICAgIEFTU0VSVCgtMTI4IDw9IGlt bS5tX3ZhbHVlICYmIGltbS5tX3ZhbHVlIDwgMTI4KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAkocmV2aXNpb24gOTcyNDQpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMDY2LDYgKzEwNjYsMTIgQEAgcHVibGljOgogICAgICAgICBtX2Zvcm1hdHRlci5p bW1lZGlhdGUzMihpbW0pOwogICAgIH0KICAgICAKKyAgICB2b2lkIG1vdmxfaTMybShpbnQgaW1t LCBpbnQgb2Zmc2V0LCBSZWdpc3RlcklEIGJhc2UsIFJlZ2lzdGVySUQgaW5kZXgsIGludCBzY2Fs ZSkKKyAgICB7CisgICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcChPUF9HUk9VUDExX0V2SXos IEdST1VQMTFfTU9WLCBiYXNlLCBpbmRleCwgc2NhbGUsIG9mZnNldCk7CisgICAgICAgIG1fZm9y bWF0dGVyLmltbWVkaWF0ZTMyKGltbSk7CisgICAgfQorCiAgICAgdm9pZCBtb3ZiX2k4bShpbnQg aW1tLCBpbnQgb2Zmc2V0LCBSZWdpc3RlcklEIGJhc2UpCiAgICAgewogICAgICAgICBBU1NFUlQo LTEyOCA8PSBpbW0gJiYgaW1tIDwgMTI4KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gOTcyNDQp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNTQ0LDggKzE1NDQsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklU Ojpjb21waWxlKE5vZGUmIG5vZGUpCiAKICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6Okp1bXAgaG9s ZUNhc2UgPSBtX2ppdC5icmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6RXF1YWwsIEltbTMyKEpTVmFs dWU6OkVtcHR5VmFsdWVUYWcpLCB2YWx1ZVRhZ0dQUik7CiAgICAgICAgIAotICAgICAgICBtX2pp dC5tb3ZlKEltbTMyKEpTVmFsdWU6OkVtcHR5VmFsdWVUYWcpLCBzdG9yYWdlTGVuZ3RoR1BSKTsK LSAgICAgICAgbV9qaXQuc3RvcmUzMihzdG9yYWdlTGVuZ3RoR1BSLCBNYWNyb0Fzc2VtYmxlcjo6 QmFzZUluZGV4KHN0b3JhZ2VHUFIsIHN0b3JhZ2VMZW5ndGhHUFIsIE1hY3JvQXNzZW1ibGVyOjpU aW1lc0VpZ2h0LCBPQkpFQ1RfT0ZGU0VUT0YoQXJyYXlTdG9yYWdlLCBtX3ZlY3RvclswXSkgKyBP QkpFQ1RfT0ZGU0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMudGFnKSkpOworICAgICAgICBtX2ppdC5z dG9yZTMyKFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpFbXB0eVZhbHVlVGFnKSwgTWFjcm9Bc3NlbWJs ZXI6OkJhc2VJbmRleChzdG9yYWdlR1BSLCBzdG9yYWdlTGVuZ3RoR1BSLCBNYWNyb0Fzc2VtYmxl cjo6VGltZXNFaWdodCwgT0JKRUNUX09GRlNFVE9GKEFycmF5U3RvcmFnZSwgbV92ZWN0b3JbMF0p ICsgT0JKRUNUX09GRlNFVE9GKEpTVmFsdWUsIHUuYXNCaXRzLnRhZykpKTsKIAogICAgICAgICBt X2ppdC5zdWIzMihNYWNyb0Fzc2VtYmxlcjo6SW1tMzIoMSksIE1hY3JvQXNzZW1ibGVyOjpBZGRy ZXNzKHN0b3JhZ2VHUFIsIE9CSkVDVF9PRkZTRVRPRihBcnJheVN0b3JhZ2UsIG1fbnVtVmFsdWVz SW5WZWN0b3IpKSk7CiAgICAgICAgIAo=