<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>69904</bug_id>
          
          <creation_ts>2011-10-11 22:51:57 -0700</creation_ts>
          <short_desc>C4481 warning should be disabled for OVERRIDE and FINAL</short_desc>
          <delta_ts>2011-10-12 17:33:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Windows 7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>68654</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kent Tamura">tkent</reporter>
          <assigned_to name="Kent Tamura">tkent</assigned_to>
          <cc>andersca</cc>
    
    <cc>aroben</cc>
    
    <cc>hyatt</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>482233</commentid>
    <comment_count>0</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2011-10-11 22:51:57 -0700</bug_when>
    <thetext>r95823 introduced OVERRIDE. However OVERRIDE produces a warning with MSVC.

http://queues.webkit.org/results/9940611
3&gt;c:\cygwin\home\buildbot\webkit\source\webcore\html\NumberInputType.h(67) : error C2220: warning treated as error - no &apos;object&apos; file generated
3&gt;c:\cygwin\home\buildbot\webkit\source\webcore\html\NumberInputType.h(67) : warning C4481: nonstandard extension used: override specifier &apos;override&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482236</commentid>
    <comment_count>1</comment_count>
      <attachid>110640</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2011-10-11 22:56:44 -0700</bug_when>
    <thetext>Created attachment 110640
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482896</commentid>
    <comment_count>2</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2011-10-12 17:33:41 -0700</bug_when>
    <thetext>Committed r97323: &lt;http://trac.webkit.org/changeset/97323&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>110640</attachid>
            <date>2011-10-11 22:56:44 -0700</date>
            <delta_ts>2011-10-12 04:34:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-69904-20111012145643.patch</filename>
            <type>text/plain</type>
            <size>1504</size>
            <attacher name="Kent Tamura">tkent</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTcyMzIKZGlmZiAtLWdpdCBhL1dlYktpdExpYnJhcmllcy9D
aGFuZ2VMb2cgYi9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCmluZGV4IDc0MTQ0ZjU3NGM1MTdm
ZmExMGYzYTdlODIzODc0ZDY0NTg0YWI0ZDUuLmYzYjRmZDVhM2ZiM2NhZWMxYmQ2NWM2Y2I3NmM0
NGIwNTNmZmI0NGIgMTAwNjQ0Ci0tLSBhL1dlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKKysrIGIv
V2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTEwLTExICBL
ZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBDNDQ4MSB3YXJuaW5n
IHNob3VsZCBiZSBkaXNhYmxlZCBmb3IgT1ZFUlJJREUgYW5kIEZJTkFMLgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk5MDQKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdpbi90b29scy92c3Byb3BzL2Nv
bW1vbi52c3Byb3BzOiBEaXNhYmxlIEM0NDgxLgorCiAyMDExLTEwLTA0ICBLZW50IFRhbXVyYSAg
PHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbnRyb2R1Y2UgZmVhdHVyZSBmbGFncyBm
b3IgaW5jb21wbGV0ZSBpbnB1dCB0eXBlcwpkaWZmIC0tZ2l0IGEvV2ViS2l0TGlicmFyaWVzL3dp
bi90b29scy92c3Byb3BzL2NvbW1vbi52c3Byb3BzIGIvV2ViS2l0TGlicmFyaWVzL3dpbi90b29s
cy92c3Byb3BzL2NvbW1vbi52c3Byb3BzCmluZGV4IGMyYzQxOWMyZDhkODc4NGQwMjI0OWQ0ZWM0
MTYyNDFjNjk2YTkyNDUuLjc5NzQ1MGQwOTNhZDg1M2NjYjE4ZjRiMDZkY2Q2NDA0OGRkMjg0Y2Eg
MTAwNjQ0Ci0tLSBhL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24udnNw
cm9wcworKysgYi9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnZzcHJv
cHMKQEAgLTE1LDcgKzE1LDcgQEAKIAkJV2FybmluZ0xldmVsPSI0IgogCQlXYXJuQXNFcnJvcj0i
dHJ1ZSIKIAkJRGVidWdJbmZvcm1hdGlvbkZvcm1hdD0iMyIKLQkJRGlzYWJsZVNwZWNpZmljV2Fy
bmluZ3M9IjQwMTg7NDA2ODs0MDk5OzQxMDA7NDEyNzs0MTM4OzQxODA7NDE4OTs0MjAxOzQyNDQ7
NDI1MTs0Mjc1OzQyODg7NDI5MTs0MzA1OzQzNDQ7NDM1NTs0Mzg5OzQ1MDM7NDUwNTs0NTEwOzQ1
MTI7NDYxMDs0NzA2OzQ4MDA7NDk1MTs0OTUyOzQ5OTY7NjAxMTs2MDMxOzYyMTE7NjI0Njs2MjU1
OzYzODciCisJCURpc2FibGVTcGVjaWZpY1dhcm5pbmdzPSI0MDE4OzQwNjg7NDA5OTs0MTAwOzQx
Mjc7NDEzODs0MTgwOzQxODk7NDIwMTs0MjQ0OzQyNTE7NDI3NTs0Mjg4OzQyOTE7NDMwNTs0MzQ0
OzQzNTU7NDM4OTs0NDgxOzQ1MDM7NDUwNTs0NTEwOzQ1MTI7NDYxMDs0NzA2OzQ4MDA7NDk1MTs0
OTUyOzQ5OTY7NjAxMTs2MDMxOzYyMTE7NjI0Njs2MjU1OzYzODciCiAJLz4KIAk8VG9vbAogCQlO
YW1lPSJWQ0xpYnJhcmlhblRvb2wiCg==
</data>
<flag name="review"
          id="108199"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>