69898 2011-10-11 21:56:59 -0700 Layout tests asserting in LayoutTestController::pathToLocalResource() 2011-10-12 17:14:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure, MakingBotsRed P2 Normal --- 1 simon.fraser eric ap eric rniwa webkit.review.bot oldest_to_newest 482205 0 simon.fraser 2011-10-11 21:56:59 -0700 Various layout tests are asserting in LayoutTestController::pathToLocalResource() on the SL leaks bot: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r97218%20(19479)/results.html fast/loader/local-CSS-from-local.html stderr crash log (DumpRenderTree: LayoutTestController::pathToLocalResource(OpaqueJSContext const*, OpaqueJSString*) + 601) fast/loader/local-JavaScript-from-local.html stderr crash log (DumpRenderTree: LayoutTestController::pathToLocalResource(OpaqueJSContext const*, OpaqueJSString*) + 601) fast/loader/local-iFrame-source-from-local.html stderr crash log (DumpRenderTree: LayoutTestController::pathToLocalResource(OpaqueJSContext const*, OpaqueJSString*) + 601) fast/loader/local-image-from-local.html stderr crash log (DumpRenderTree: LayoutTestController::pathToLocalResource(OpaqueJSContext const*, OpaqueJSString*) + 601) Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 DumpRenderTree 0x0000000100030c91 LayoutTestController::pathToLocalResource(OpaqueJSContext const*, OpaqueJSString*) + 601 (LayoutTestControllerMac.mm:416) 1 DumpRenderTree 0x00000001000260be pathToLocalResourceCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) + 199 (LayoutTestController.cpp:288) 2 com.apple.JavaScriptCore 0x00000001002c1ef9 JSC::JSCallbackFunction::call(JSC::ExecState*) + 301 (JSCallbackFunction.cpp:73) 3 com.apple.JavaScriptCore 0x00000001002aa570 cti_op_call_NotJSFunction + 425 (JITStubs.cpp:2323) 4 com.apple.JavaScriptCore 0x00000001002a2d2d jscGeneratedNativeCode + 0 (JITStubs.cpp:946) 5 com.apple.JavaScriptCore 0x00000001002819ea JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) + 86 (JITCode.h:103) 6 com.apple.JavaScriptCore 0x000000010027bd1b JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 1359 482208 1 rniwa 2011-10-11 22:00:43 -0700 There is clearly a bug here: http://trac.webkit.org/changeset/95588/trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm 414 // Note: It's important that we keep the file:// or http tests will get confused. 415 if (localResourceString.find("file://") != std::string::npos) { 416 ASSERT(absolutePathToLocalResource[0] == '/'); It should read: 415 if (localResourceString.find("file://") == std::string::npos) { 416 ASSERT(absolutePathToLocalResource[0] == '/'); 482210 2 eric 2011-10-11 22:08:40 -0700 Did this just start? This change was landed long ago, no? 482218 3 rniwa 2011-10-11 22:22:50 -0700 (In reply to comment #1) > There is clearly a bug here: > > http://trac.webkit.org/changeset/95588/trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm > 414 // Note: It's important that we keep the file:// or http tests will get confused. > 415 if (localResourceString.find("file://") != std::string::npos) { > 416 ASSERT(absolutePathToLocalResource[0] == '/'); > > It should read: > > 415 if (localResourceString.find("file://") == std::string::npos) { > 416 ASSERT(absolutePathToLocalResource[0] == '/'); Oh wait, this is not it. I misread the code. 482226 4 rniwa 2011-10-11 22:40:15 -0700 (In reply to comment #2) > Did this just start? This change was landed long ago, no? I think this has always failed. It appears that it's coming from webkit port difference. I can reproduce the crash if I run: Tools/Scripts/run-webkit-tests --debug --leaks fast/loader/local-JavaScript-from-local.html but can't reproduce the crash if I run: Tools/Scripts/run-webkit-tests --debug fast/loader/local-JavaScript-from-local.html 482817 5 eric 2011-10-12 15:56:50 -0700 I am able to reproduce the failure. Not yet sure what's causing it. :) 482819 6 eric 2011-10-12 15:57:54 -0700 Ah. Looks like --leaks is using ORWT. I thought it was using NRWT. I'll make the change to ORWT. 482820 7 rniwa 2011-10-12 15:58:49 -0700 (In reply to comment #6) > Ah. Looks like --leaks is using ORWT. I thought it was using NRWT. I'll make the change to ORWT. No wonder! 482826 8 eric 2011-10-12 16:01:44 -0700 *** Bug 69899 has been marked as a duplicate of this bug. *** 482828 9 110762 eric 2011-10-12 16:04:35 -0700 Created attachment 110762 Patch 482881 10 110762 webkit.review.bot 2011-10-12 17:14:00 -0700 Comment on attachment 110762 Patch Clearing flags on attachment: 110762 Committed r97321: <http://trac.webkit.org/changeset/97321> 482882 11 webkit.review.bot 2011-10-12 17:14:05 -0700 All reviewed patches have been landed. Closing bug. 110762 2011-10-12 16:04:35 -0700 2011-10-12 17:14:00 -0700 Patch bug-69898-20111012160434.patch text/plain 1489 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTczMTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZmZkMGM5NDczMjNhNzAzN2ViMjhiMWNhNTkwYjQ2OGNh NWM3Y2FlLi44NjNlOWE4NWQ4YTRiM2MwZTE1MGRjMjNkZWQ1ODEyM2U1Y2QyMzVlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMTIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IExheW91dCB0ZXN0cyBhc3NlcnRpbmcgaW4gTGF5b3V0VGVzdENvbnRyb2xsZXI6OnBhdGhUb0xv Y2FsUmVzb3VyY2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njk4OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBvbGQtcnVuLXdlYmtpdC10ZXN0cyBqdXN0IGRpZG4ndCBrbm93IHRvIHNldCBMT0NBTF9S RVNPVVJDRV9ST09ULCBvb3BzLgorCisgICAgICAgICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10 ZXN0czoKKyAgICAgICAgKG9wZW5EdW1wVG9vbCk6CisKIDIwMTEtMTAtMTIgIFRvbnkgQ2hhbmcg IDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggdGVzdC13ZWJraXRweSBhZnRlciBy OTczMDcgYW5kIHI5NzI5My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJr aXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IDdhM2Jk N2NjNTk1NjMxYmQyZDA5M2E1M2ViMTgyZGQyN2ViMmQ0YmEuLjc3NTQ0NTA0MzhmMDQxNTE1ZjJk ZjBkNjI0NmExYjc2NWFmZmMxZjkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13 ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAt MTQ3Niw2ICsxNDc2LDcgQEAgc3ViIG9wZW5EdW1wVG9vbCgpCiAgICAgIyB1bmlxdWUgdGVtcG9y YXJ5IGRpcmVjdG9yeSBmb3IgZWFjaCBEdW1wUmVuZGVydHJlZSAtIG5lZWRlZCBmb3IgcnVubmlu ZyBtb3JlIER1bXBSZW5kZXJUcmVlIGluIHBhcmFsbGVsCiAgICAgJENMRUFOX0VOVntEVU1QUkVO REVSVFJFRV9URU1QfSA9IEZpbGU6OlRlbXA6OnRlbXBkaXIoJ0R1bXBSZW5kZXJUcmVlLVhYWFhY WCcsIFRNUERJUiA9PiAxLCBDTEVBTlVQID0+IDEpOwogICAgICRDTEVBTl9FTlZ7WE1MX0NBVEFM T0dfRklMRVN9ID0gIiI7ICMgd29yayBhcm91bmQgbWlzc2luZyAvZXRjL2NhdGFsb2cgPHJkYXI6 Ly9wcm9ibGVtLzQyOTI5OTU+CisgICAgJENMRUFOX0VOVntMT0NBTF9SRVNPVVJDRV9ST09UfSA9 ICR0ZXN0RGlyZWN0b3J5OyAjIFVzZWQgYnkgbGF5b3V0VGVzdENvbnN0cm9sbGVyLnBhdGhUb0xv Y2FsUmVzb3VyY2UoKQogCiAgICAgIyBQbGF0Zm9ybSBzcGVzaWZpY3MKICAgICBpZiAoaXNMaW51 eCgpKSB7Cg==