69890 2011-10-11 18:09:37 -0700 DFG JIT 32_64 - Fix silentFillGPR for non-integer constants. 2011-10-11 18:52:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 482112 0 barraclough 2011-10-11 18:09:37 -0700 Cell constants are currently hitting the valueOfInt32Constant case, there is no constant handling for JSValues. 482113 1 110620 barraclough 2011-10-11 18:10:49 -0700 Created attachment 110620 The patch 482149 2 barraclough 2011-10-11 18:52:46 -0700 Fixed in r97216. 110620 2011-10-11 18:10:49 -0700 2011-10-11 18:13:53 -0700 The patch 69890.patch text/plain 3678 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcyMDUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMTAtMTEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFyYWNsb3VnaEBhcHBsZS5jb20+CisK KyAgICAgICAgREZHIEpJVCAzMl82NCAtIEZpeCBzaWxlbnRGaWxsR1BSIGZvciBub24taW50ZWdl ciBjb25zdGFudHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02OTg5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENlbGwgY29uc3RhbnRzIGFyZSBjdXJyZW50bHkgaGl0dGluZyB0aGUgdmFsdWVPZkludDMy Q29uc3RhbnQgY2FzZSwgdGhlcmUgaXMgbm8gY29uc3RhbnQgaGFuZGxpbmcgZm9yIEpTVmFsdWVz LgorCisgICAgICAgICogZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuaDoKKyAgICAgICAgKEpTQzo6 REZHOjpKSVRDb2RlR2VuZXJhdG9yOjpzaWxlbnRGaWxsR1BSKToKKwogMjAxMS0xMC0xMSAgT2xp dmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFRpZHkgdXAgY2FyZCB3YWxr aW5nIGxvZ2ljCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVHZW5l cmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENv ZGVHZW5lcmF0b3IuaAkocmV2aXNpb24gOTcxODkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOSBA QCBjbGFzcyBTcGVjdWxhdGVCb29sZWFuT3BlcmFuZDsKIGNsYXNzIEpJVENvZGVHZW5lcmF0b3Ig ewogcHJvdGVjdGVkOgogICAgIHR5cGVkZWYgSklUQ29tcGlsZXI6OlRydXN0ZWRJbW0zMiBUcnVz dGVkSW1tMzI7Ci0gICAgdHlwZWRlZiBNYWNyb0Fzc2VtYmxlcjo6SW1tMzIgSW1tMzI7CisgICAg dHlwZWRlZiBKSVRDb21waWxlcjo6SW1tMzIgSW1tMzI7CisgICAgdHlwZWRlZiBKSVRDb21waWxl cjo6VHJ1c3RlZEltbVB0ciBUcnVzdGVkSW1tUHRyOworICAgIHR5cGVkZWYgSklUQ29tcGlsZXI6 OkltbVB0ciBJbW1QdHI7CiAKICAgICAvLyBUaGVzZSBjb25zdGFudHMgYXJlIHVzZWQgdG8gc2V0 IHByaW9yaXRpZXMgZm9yIHNwaWxsIG9yZGVyIGZvcgogICAgIC8vIHRoZSByZWdpc3RlciBhbGxv Y2F0b3IuCkBAIC0zMzYsMzEgKzMzOCwzOCBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIEFTU0VSVChp bmZvLnJlZ2lzdGVyRm9ybWF0KCkgIT0gRGF0YUZvcm1hdERvdWJsZSk7CiAgICAgICAgIERhdGFG b3JtYXQgcmVnaXN0ZXJGb3JtYXQgPSBpbmZvLnJlZ2lzdGVyRm9ybWF0KCk7CiAKLSNpZiBVU0Uo SlNWQUxVRTY0KQogICAgICAgICBpZiAocmVnaXN0ZXJGb3JtYXQgPT0gRGF0YUZvcm1hdEludGVn ZXIpIHsKICAgICAgICAgICAgIGlmIChub2RlLmhhc0NvbnN0YW50KCkpIHsKICAgICAgICAgICAg ICAgICBBU1NFUlQoaXNJbnQzMkNvbnN0YW50KG5vZGVJbmRleCkpOwogICAgICAgICAgICAgICAg IG1faml0Lm1vdmUoSW1tMzIodmFsdWVPZkludDMyQ29uc3RhbnQobm9kZUluZGV4KSksIGluZm8u Z3ByKCkpOwogICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgbV9qaXQubG9hZDMy KEpJVENvbXBpbGVyOjphZGRyZXNzRm9yKHNwaWxsTWUpLCBpbmZvLmdwcigpKTsKKyAgICAgICAg ICAgICAgICBtX2ppdC5sb2FkMzIoSklUQ29tcGlsZXI6OnBheWxvYWRGb3Ioc3BpbGxNZSksIGlu Zm8uZ3ByKCkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKKyAgICAgICAgaWYg KHJlZ2lzdGVyRm9ybWF0ID09IERhdGFGb3JtYXRDZWxsKSB7CisgICAgICAgICAgICBpZiAobm9k ZS5pc0NvbnN0YW50KCkpIHsKKyAgICAgICAgICAgICAgICBKU1ZhbHVlIHZhbHVlID0gdmFsdWVP ZkpTQ29uc3RhbnQobm9kZUluZGV4KTsKKyAgICAgICAgICAgICAgICBBU1NFUlQodmFsdWUuaXND ZWxsKCkpOworICAgICAgICAgICAgICAgIG1faml0Lm1vdmUoSW1tUHRyKHZhbHVlLmFzQ2VsbCgp KSwgaW5mby5ncHIoKSk7CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICBtX2pp dC5sb2FkUHRyKEpJVENvbXBpbGVyOjpwYXlsb2FkRm9yKHNwaWxsTWUpLCBpbmZvLmdwcigpKTsK KyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChyZWdpc3RlckZv cm1hdCA9PSBEYXRhRm9ybWF0U3RvcmFnZSkKKyAgICAgICAgICAgIG1faml0LmxvYWRQdHIoSklU Q29tcGlsZXI6OmFkZHJlc3NGb3Ioc3BpbGxNZSksIGluZm8uZ3ByKCkpOworCisgICAgICAgIEFT U0VSVChyZWdpc3RlckZvcm1hdCAmIERhdGFGb3JtYXRKUyk7CisjaWYgVVNFKEpTVkFMVUU2NCkK ICAgICAgICAgaWYgKG5vZGUuaGFzQ29uc3RhbnQoKSkKICAgICAgICAgICAgIG1faml0Lm1vdmUo dmFsdWVPZkpTQ29uc3RhbnRBc0ltbVB0cihub2RlSW5kZXgpLCBpbmZvLmdwcigpKTsKLSAgICAg ICAgZWxzZSB7Ci0gICAgICAgICAgICBBU1NFUlQocmVnaXN0ZXJGb3JtYXQgJiBEYXRhRm9ybWF0 SlMgfHwgcmVnaXN0ZXJGb3JtYXQgPT0gRGF0YUZvcm1hdENlbGwgfHwgcmVnaXN0ZXJGb3JtYXQg PT0gRGF0YUZvcm1hdFN0b3JhZ2UpOworICAgICAgICBlbHNlCiAgICAgICAgICAgICBtX2ppdC5s b2FkUHRyKEpJVENvbXBpbGVyOjphZGRyZXNzRm9yKHNwaWxsTWUpLCBpbmZvLmdwcigpKTsKLSAg ICAgICAgfQotI2VsaWYgVVNFKEpTVkFMVUUzMl82NCkKLSAgICAgICAgaWYgKHJlZ2lzdGVyRm9y bWF0ID09IERhdGFGb3JtYXRJbnRlZ2VyIHx8IHJlZ2lzdGVyRm9ybWF0ID09IERhdGFGb3JtYXRD ZWxsKSB7Ci0gICAgICAgICAgICBpZiAobm9kZS5pc0NvbnN0YW50KCkpCi0gICAgICAgICAgICAg ICAgbV9qaXQubW92ZShJbW0zMih2YWx1ZU9mSW50MzJDb25zdGFudChub2RlSW5kZXgpKSwgaW5m by5ncHIoKSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgbV9qaXQubG9hZDMy KEpJVENvbXBpbGVyOjpwYXlsb2FkRm9yKHNwaWxsTWUpLCBpbmZvLmdwcigpKTsKLSAgICAgICAg fSBlbHNlIGlmIChyZWdpc3RlckZvcm1hdCA9PSBEYXRhRm9ybWF0U3RvcmFnZSkKLSAgICAgICAg ICAgIG1faml0LmxvYWQzMihKSVRDb21waWxlcjo6YWRkcmVzc0ZvcihzcGlsbE1lKSwgaW5mby5n cHIoKSk7Ci0gICAgICAgIGVsc2UgCisjZWxzZQorICAgICAgICBpZiAobm9kZS5oYXNDb25zdGFu dCgpKQorICAgICAgICAgICAgbV9qaXQuZW1pdExvYWQodmFsdWVPZkpTQ29uc3RhbnQobm9kZUlu ZGV4KSwgaW5mby50YWdHUFIoKSwgaW5mby5wYXlsb2FkR1BSKCkpOworICAgICAgICBlbHNlCiAg ICAgICAgICAgICBtX2ppdC5lbWl0TG9hZChub2RlSW5kZXgsIGluZm8udGFnR1BSKCksIGluZm8u cGF5bG9hZEdQUigpKTsKICNlbmRpZgogICAgIH0K