69889 2011-10-11 17:38:57 -0700 Selection is not collapsed in some WK2 editing tests 2012-03-15 16:22:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified REOPENED MakingBotsRed P2 Normal --- 1 simon.fraser webkit-unassigned ap cshu enrica jberlin rniwa simon.fraser webkit.review.bot oldest_to_newest 482090 0 simon.fraser 2011-10-11 17:38:57 -0700 These tests, and some others, are failing in WK2 because the selection is not collapsed at the end of the test: editing/pasteboard/drag-drop-iframe-refresh-crash.html: pretty diff editing/selection/caret-ltr-right.html: pretty diff editing/selection/caret-rtl-right.html: pretty diff editing/selection/select-across-readonly-input-2.html: pretty diff editing/selection/select-across-readonly-input-3.html: pretty diff editing/selection/select-across-readonly-input-4.html: pretty diff editing/selection/select-across-readonly-input-5.html: pretty diff 482100 1 simon.fraser 2011-10-11 17:45:31 -0700 Also editing/inserting/caret-position.html 482196 2 rniwa 2011-10-11 21:39:56 -0700 Maybe it's something to do with eventSender in WK2? 482374 3 cshu 2011-10-12 06:18:55 -0700 editing/inserting/caret-position.html is calling textInputController.firstRectForCharacterRange(0, 0). But it's not supported yet in WK2. There must be other unsupported textInputController functions used in these tests. 482411 4 simon.fraser 2011-10-12 07:59:38 -0700 I skipped editing/inserting/caret-position.html in WK2 already. The other tests still have the problem described. 482425 5 cshu 2011-10-12 08:36:58 -0700 I believe the failures are related to missing drag-n-drop support in WK2 EventSender. https://bugs.webkit.org/show_bug.cgi?id=68552. 482444 6 simon.fraser 2011-10-12 09:10:10 -0700 But not all those tests involve D&D 482488 7 cshu 2011-10-12 10:12:49 -0700 I think these tests are new and never passed in WK2. We should simply skip them for now. Understanding the cause of the failures will help us to put them in the right category. D&D and textInputController are two root causes I have identified so far. 482491 8 simon.fraser 2011-10-12 10:26:59 -0700 D&D and textInputController tests have already been skipped. These tests are using neither (but do rely on event sender). 482499 9 rniwa 2011-10-12 10:35:03 -0700 (In reply to comment #7) > I think these tests are new and never passed in WK2. We should simply skip them for now. Understanding the cause of the failures will help us to put them in the right category. D&D and textInputController are two root causes I have identified so far. caret-ltr-right and caret-rtl-right should be passing on WK2. 482506 10 cshu 2011-10-12 10:41:14 -0700 (In reply to comment #8) > D&D and textInputController tests have already been skipped. These tests are using neither (but do rely on event sender). LayoutTests/editing/selection/resources/select-across-readonly-input.js should depend on D&D: moveMouseToMiddleOfElement(document.getElementById('from')); eventSender.mouseDown(); eventSender.leapForward(200); moveMouseToMiddleOfElement(document.getElementById('to')); eventSender.mouseUp(); and LayoutTests/editing/inserting/caret-position.html should depend on textInputController.firstRectForCharacterRange: function testCaretPosition(elementId, caretPosition) { e = document.getElementById(elementId, caretPosition); e.focus(); if (window.textInputController) { var caretRect = textInputController.firstRectForCharacterRange(0, 0); assertEqual(elementId, caretRect[0], caretPosition); } } 482508 11 simon.fraser 2011-10-12 10:43:07 -0700 Chang: please make a patch to disable the appropriate tests then. 482512 12 cshu 2011-10-12 10:46:56 -0700 (In reply to comment #11) > Chang: please make a patch to disable the appropriate tests then. No problem. 482557 13 110712 cshu 2011-10-12 11:31:10 -0700 Created attachment 110712 patch 1 Added failed tests to Skip list. I put them into platform-dependent Skipped file instead of the common one because the fix should be platform-dependent. 482670 14 110712 webkit.review.bot 2011-10-12 13:50:32 -0700 Comment on attachment 110712 patch 1 Clearing flags on attachment: 110712 Committed r97297: <http://trac.webkit.org/changeset/97297> 482671 15 webkit.review.bot 2011-10-12 13:50:37 -0700 All reviewed patches have been landed. Closing bug. 482674 16 rniwa 2011-10-12 13:51:34 -0700 Reopen the bug because the patch didn't really fix the tests. 579831 17 jberlin 2012-03-15 15:48:05 -0700 caret-ltr-right and caret-rtl-right are not passing in WK2: http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110889%20(4971)/editing/selection/caret-ltr-right-pretty-diff.html http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110889%20(4971)/editing/selection/caret-rtl-right-pretty-diff.html Ryosuke, why did you think they should be passing? 579865 18 jberlin 2012-03-15 16:22:25 -0700 Added failing expected results for mac-wk2 in http://trac.webkit.org/changeset/110906 110712 2011-10-12 11:31:10 -0700 2011-10-12 13:50:32 -0700 patch 1 69889_1.patch text/plain 2984 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk3Mjc2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTIgIENoYW5nIFNodSAgPGNzaHVA d2Via2l0Lm9yZz4KKworICAgICAgICBTZWxlY3Rpb24gaXMgbm90IGNvbGxhcHNlZCBpbiBzb21l IFdLMiBlZGl0aW5nIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02OTg4OQorCisgICAgICAgIFNraXAgdGVzdHMgZm9yIGtub3duIHJlYXNvbi4K KworICAgICAgICBVbnJldmlld2VkLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9Ta2lw cGVkOgorICAgICAgICAqIHBsYXRmb3JtL3F0LXdrMi9Ta2lwcGVkOgorCiAyMDExLTEwLTEyICBE aW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9t aXVtXSBGaXggZXhwZWN0YXRpb24gYW1iaWd1aXRpZXMuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtd2syL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMi9Ta2lwcGVkCShyZXZpc2lvbiA5NzI3NCkKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMjA0LDYgKzIwNCwxNCBAQCBzY3Jv bGxiYXJzL3Njcm9sbGV2ZW50LWlmcmFtZS1uby1zY3JvbGxpCiBzdmcvY3VzdG9tL2ZvcmVpZ25P YmplY3QtY3Jhc2gtb24taG92ZXIueG1sCiBzdmcvY3VzdG9tL3VzZS1ldmVudHMtY3Jhc2guc3Zn CiAKKyMgW1dLMl0gW01hY10gU3VwcG9ydCBkcmFnIGluIG1vdXNlIGV2ZW50cyBmb3IgV2ViS2l0 MiBFdmVudFNlbmRlcgorIyA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY4NTUyPgorZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC1pZnJhbWUtcmVmcmVzaC1jcmFz aC5odG1sCitlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWNyb3NzLXJlYWRvbmx5LWlucHV0LTIu aHRtbAorZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWFjcm9zcy1yZWFkb25seS1pbnB1dC0zLmh0 bWwKK2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1hY3Jvc3MtcmVhZG9ubHktaW5wdXQtNC5odG1s CitlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWNyb3NzLXJlYWRvbmx5LWlucHV0LTUuaHRtbAor CiAjIyMgRU5EIE9GICgxKSBDbGFzc2lmaWVkIGZhaWx1cmVzIHdpdGggYnVnIHJlcG9ydHMKICMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKIApJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQtd2syL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQtd2syL1NraXBwZWQJKHJldmlzaW9uIDk3Mjc0KQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQtd2syL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTE2MSw2ICsxNjEsMTUgQEAg c3ZnL2N1c3RvbS91c2UtZXZlbnRzLWNyYXNoLnN2Zwogc3ZnL3RleHQvc2VsZWN0aW9uLXRyaXBs ZWNsaWNrLnN2Zwogc3ZnL3pvb20vcGFnZS96b29tLWNvb3Jkcy12aWV3YXR0ci0wMS1iLnN2Zwog CisjIFtXSzJdIFtRdF0gU3VwcG9ydCBkcmFnIGluIG1vdXNlIGV2ZW50cyBmb3IgV2ViS2l0MiBF dmVudFNlbmRlcgorIyA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5 OTQ2PgorZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC1pZnJhbWUtcmVmcmVzaC1jcmFzaC5o dG1sCitlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWNyb3NzLXJlYWRvbmx5LWlucHV0LTEuaHRt bAorZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWFjcm9zcy1yZWFkb25seS1pbnB1dC0yLmh0bWwK K2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1hY3Jvc3MtcmVhZG9ubHktaW5wdXQtMy5odG1sCitl ZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWNyb3NzLXJlYWRvbmx5LWlucHV0LTQuaHRtbAorZWRp dGluZy9zZWxlY3Rpb24vc2VsZWN0LWFjcm9zcy1yZWFkb25seS1pbnB1dC01Lmh0bWwKKwogIyBX ZWJLaXQyIG5lZWRzIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZQogIyA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTk3PgogIyBHZXQgYWNj ZWxlcmF0ZWQgY29tcG9zaXRpbmcgd29ya2luZyB3aXRoIHdlYmtpdDIKQEAgLTc2MCwxMSArNzY5 LDYgQEAgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpYwogaHR0cC90ZXN0 cy91cmkvY3NzLWhyZWYucGhwCiAKICMgdW5za2lwcGVkIGJ5IHI4ODE1MiwgYnV0IGZhaWwgb24g UXQtV0syIHBsYXRmb3JtCi1lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWNyb3NzLXJlYWRvbmx5 LWlucHV0LTEuaHRtbAotZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWFjcm9zcy1yZWFkb25seS1p bnB1dC0yLmh0bWwKLWVkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1hY3Jvc3MtcmVhZG9ubHktaW5w dXQtMy5odG1sCi1lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWNyb3NzLXJlYWRvbmx5LWlucHV0 LTQuaHRtbAotZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWFjcm9zcy1yZWFkb25seS1pbnB1dC01 Lmh0bWwKIHN2Zy9XM0MtU1ZHLTEuMS1TRS9maWx0ZXJzLWZlbGVtLTAxLWIuc3ZnCiBzdmcvVzND LVNWRy0xLjEtU0UvcGFpbnRpbmctbWFya2VyLTA3LWYuc3ZnCiBzdmcvVzNDLVNWRy0xLjEtU0Uv c3RydWN0LXVzZS0xNC1mLnN2Zwo=