69880 2011-10-11 16:25:05 -0700 [Mac] Crash when opening an embedded PDF in a background tab 2011-10-11 17:16:44 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 ap ap oldest_to_newest 482009 0 ap 2011-10-11 16:25:05 -0700 Steps to reproduce: 1. Open http://en.wikipedia.org/wiki/Swing-piston_engine 2. Cmd-click on http://www.freepatentsonline.com/2301667.pdf link at the bottom. 3. Click on the new tab to show it. 482020 1 110602 ap 2011-10-11 16:34:20 -0700 Created attachment 110602 proposed fix 482053 2 110602 darin 2011-10-11 17:06:00 -0700 Comment on attachment 110602 proposed fix Both good changes. I think you should land them separately. 482064 3 ap 2011-10-11 17:16:44 -0700 Committed <http://trac.webkit.org/changeset/97200>, <http://trac.webkit.org/changeset/97201>. 110602 2011-10-11 16:34:20 -0700 2011-10-11 17:06:00 -0700 proposed fix InactivePDFCrash.txt text/plain 3777 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTkzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTAtMTEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQ3Jhc2ggd2hlbiBv cGVuaW5nIGFuIGVtYmVkZGVkIFBERiBpbiBhIGJhY2tncm91bmQgdGFiCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTg4MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1Bs dWdpblZpZXcuY3BwOiAoV2ViS2l0OjpQbHVnaW5WaWV3OjpwYWludCk6IERvbid0IGNhbGwgcGx1 Zy1pbiB0aGF0CisgICAgICAgIGRvZXNuJ3QgZXZlbiBoYXZlIGEgY29udHJvbGxlciB5ZXQuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUERGL0J1aWx0SW5QREZWaWV3LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6QnVpbHRJblBERlZpZXc6OkJ1aWx0SW5QREZWaWV3KToKKyAgICAgICAg KFdlYktpdDo6QnVpbHRJblBERlZpZXc6On5CdWlsdEluUERGVmlldyk6CisgICAgICAgIChXZWJL aXQ6OkJ1aWx0SW5QREZWaWV3Ojppbml0aWFsaXplKToKKyAgICAgICAgKFdlYktpdDo6QnVpbHRJ blBERlZpZXc6OmRlc3Ryb3kpOgorICAgICAgICBNb3ZlZCBpbml0aWFsaXphdGlvbiBhbmQgZGVz dHJ1Y3Rpb24gY29kZSBmcm9tIEMrKyBjb25zdHJ1Y3RvciBhbmQgZGVzdHJ1Y3RvciB0byBkZXNp Z25hdGVkCisgICAgICAgIGZ1bmN0aW9ucy4gTm90IHBhcnQgb2YgdGhlIGZpeCwgYnV0IHNlZW1z IHJlbGF0ZWQgZW5vdWdoIHRvIGZpeC4KKwogMjAxMS0xMC0xMSAgQmV0aCBEYWtpbiAgPGJkYWtp bkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY5ODc0CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1 Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVn aW5zL1BsdWdpblZpZXcuY3BwCShyZXZpc2lvbiA5NzE1NCkKKysrIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTU0LDEx ICs1NTQsMTQgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXRGcmFtZVJlY3QoY29uc3QgV2ViQwogCiB2 b2lkIFBsdWdpblZpZXc6OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50 UmVjdCYgZGlydHlSZWN0KQogewotICAgIGlmIChtX3BsdWdpbiAmJiBjb250ZXh0LT51cGRhdGlu Z0NvbnRyb2xUaW50cygpKQotICAgICAgICBtX3BsdWdpbi0+dXBkYXRlQ29udHJvbFRpbnRzKGNv bnRleHQpOworICAgIGlmICghbV9wbHVnaW4gfHwgIW1faXNJbml0aWFsaXplZCkKKyAgICAgICAg cmV0dXJuOwogCi0gICAgaWYgKGNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSB8fCAhbV9wbHVn aW4gfHwgIW1faXNJbml0aWFsaXplZCkKKyAgICBpZiAoY29udGV4dC0+cGFpbnRpbmdEaXNhYmxl ZCgpKSB7CisgICAgICAgIGlmIChjb250ZXh0LT51cGRhdGluZ0NvbnRyb2xUaW50cygpKQorICAg ICAgICAgICAgbV9wbHVnaW4tPnVwZGF0ZUNvbnRyb2xUaW50cyhjb250ZXh0KTsKICAgICAgICAg cmV0dXJuOworICAgIH0KIAogICAgIEludFJlY3QgZGlydHlSZWN0SW5XaW5kb3dDb29yZGluYXRl cyA9IHBhcmVudCgpLT5jb250ZW50c1RvV2luZG93KGRpcnR5UmVjdCk7CiAgICAgSW50UmVjdCBw YWludFJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzID0gaW50ZXJzZWN0aW9uKGRpcnR5UmVjdEluV2lu ZG93Q29vcmRpbmF0ZXMsIGNsaXBSZWN0SW5XaW5kb3dDb29yZGluYXRlcygpKTsKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvQnVpbHRJblBERlZpZXcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvQnVpbHRJ blBERlZpZXcuY3BwCShyZXZpc2lvbiA5NzE4NCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9QREYvQnVpbHRJblBERlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSwx OCArNjEsMTAgQEAgUGFzc1JlZlB0cjxCdWlsdEluUERGVmlldz4gQnVpbHRJblBERlZpZQogQnVp bHRJblBERlZpZXc6OkJ1aWx0SW5QREZWaWV3KFBhZ2UqIHBhZ2UpCiAgICAgOiBtX3BhZ2UocGFn ZSkKIHsKLSAgICBtX3BhZ2UtPmFkZFNjcm9sbGFibGVBcmVhKHRoaXMpOwogfQogCiBCdWlsdElu UERGVmlldzo6fkJ1aWx0SW5QREZWaWV3KCkKIHsKLSAgICBpZiAobV9wYWdlKQotICAgICAgICBt X3BhZ2UtPnJlbW92ZVNjcm9sbGFibGVBcmVhKHRoaXMpOwotCi0gICAgaWYgKG1faG9yaXpvbnRh bFNjcm9sbGJhcikKLSAgICAgICAgd2lsbFJlbW92ZUhvcml6b250YWxTY3JvbGxiYXIobV9ob3Jp em9udGFsU2Nyb2xsYmFyLmdldCgpKTsKLSAgICBpZiAobV92ZXJ0aWNhbFNjcm9sbGJhcikKLSAg ICAgICAgd2lsbFJlbW92ZVZlcnRpY2FsU2Nyb2xsYmFyKG1fdmVydGljYWxTY3JvbGxiYXIuZ2V0 KCkpOwogfQogCiBQbHVnaW5JbmZvIEJ1aWx0SW5QREZWaWV3OjpwbHVnaW5JbmZvKCkKQEAgLTIw OCw2ICsyMDAsOCBAQCB2b2lkIEJ1aWx0SW5QREZWaWV3OjpjYWxjdWxhdGVTaXplcygpCiAKIGJv b2wgQnVpbHRJblBERlZpZXc6OmluaXRpYWxpemUoY29uc3QgUGFyYW1ldGVycyYgcGFyYW1ldGVy cykKIHsKKyAgICBtX3BhZ2UtPmFkZFNjcm9sbGFibGVBcmVhKHRoaXMpOworCiAgICAgLy8gTG9h ZCB0aGUgc3JjIFVSTCBpZiBuZWVkZWQuCiAgICAgaWYgKCFwYXJhbWV0ZXJzLmxvYWRNYW51YWxs eSAmJiAhcGFyYW1ldGVycy51cmwuaXNFbXB0eSgpKQogICAgICAgICBjb250cm9sbGVyKCktPmxv YWRVUkwocGRmRG9jdW1lbnRSZXF1ZXN0SUQsICJHRVQiLCBwYXJhbWV0ZXJzLnVybC5zdHJpbmco KSwgU3RyaW5nKCksIEhUVFBIZWFkZXJNYXAoKSwgVmVjdG9yPHVpbnQ4X3Q+KCksIGZhbHNlKTsK QEAgLTIxNyw2ICsyMTEsMTMgQEAgYm9vbCBCdWlsdEluUERGVmlldzo6aW5pdGlhbGl6ZShjb25z dCBQYQogCiB2b2lkIEJ1aWx0SW5QREZWaWV3OjpkZXN0cm95KCkKIHsKKyAgICBpZiAobV9wYWdl KQorICAgICAgICBtX3BhZ2UtPnJlbW92ZVNjcm9sbGFibGVBcmVhKHRoaXMpOworCisgICAgaWYg KG1faG9yaXpvbnRhbFNjcm9sbGJhcikKKyAgICAgICAgd2lsbFJlbW92ZUhvcml6b250YWxTY3Jv bGxiYXIobV9ob3Jpem9udGFsU2Nyb2xsYmFyLmdldCgpKTsKKyAgICBpZiAobV92ZXJ0aWNhbFNj cm9sbGJhcikKKyAgICAgICAgd2lsbFJlbW92ZVZlcnRpY2FsU2Nyb2xsYmFyKG1fdmVydGljYWxT Y3JvbGxiYXIuZ2V0KCkpOwogfQogCiB2b2lkIEJ1aWx0SW5QREZWaWV3OjpwYWludChHcmFwaGlj c0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0SW5XaW5k b3dDb29yZGluYXRlcykK