69861 2011-10-11 12:42:48 -0700 [Mac] Small embedded PDFs are not fully repainted when scrolling 2011-10-11 14:13:46 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67774 1 ap ap andersca mitz oldest_to_newest 481835 0 ap 2011-10-11 12:42:48 -0700 When BuiltInPDFView::paintContent decides which pages to draw, it should account for centering. 481836 1 110559 ap 2011-10-11 12:45:13 -0700 Created attachment 110559 proposed fix 481904 2 110559 bweinstein 2011-10-11 14:11:48 -0700 Comment on attachment 110559 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=110559&action=review > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp:293 > +printf("\n"); Might want to get rid of this :-). 481907 3 ap 2011-10-11 14:13:46 -0700 Committed <http://trac.webkit.org/changeset/97184>. 110559 2011-10-11 12:45:13 -0700 2011-10-11 14:12:01 -0700 proposed fix PDFCenteredRepaint.txt text/plain 2545 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTY5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMTEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gU21hbGwgZW1iZWRk ZWQgUERGcyBhcmUgbm90IGZ1bGx5IHJlcGFpbnRlZCB3aGVuIHNjcm9sbGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk4NjEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lu cy9QREYvQnVpbHRJblBERlZpZXcuY3BwOiAoV2ViS2l0OjpCdWlsdEluUERGVmlldzo6cGFpbnRD b250ZW50KToKKyAgICAgICAgQWNjb3VudCBmb3IgdmVydGljYWwgY2VudGVyaW5nIHdoZW4gZGVj aWRpbmcgd2hpY2ggcGFnZXMgdG8gcGFpbnQuCisKIDIwMTEtMTAtMTEgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgRW1iZWRkaW5nIG9mIFBERidzIHdpdGgg PG9iamVjdD4gb3IgPGVtYmVkPiBmYWlscyB3aGVuIHRoZXJlIGlzIG5vIE1JTUUgdHlwZSBzcGVj aWZpZWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvQnVpbHRJ blBERlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9QREYvQnVpbHRJblBERlZpZXcuY3BwCShyZXZpc2lvbiA5NzE1NSkKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvQnVpbHRJblBERlZpZXcuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yNjcsMTQgKzI2NywxNCBAQCB2b2lkIEJ1aWx0SW5QREZWaWV3OjpwYWludENv bnRlbnQoR3JhcGhpCiAgICAgaW50IHBhZ2VUb3AgPSAwOwogICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgbV9wYWdlQm94ZXMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgSW50UmVjdCBwYWdlQm94 ID0gbV9wYWdlQm94ZXNbaV07CisgICAgICAgIGZsb2F0IGV4dHJhT2Zmc2V0Rm9yQ2VudGVyaW5n WCA9IG1heCgobV9mcmFtZVJlY3Qud2lkdGgoKSAtIHBhZ2VCb3gud2lkdGgoKSkgLyAyLjBmLCAw LjBmKTsKKyAgICAgICAgZmxvYXQgZXh0cmFPZmZzZXRGb3JDZW50ZXJpbmdZID0gKG1fcGFnZUJv eGVzLnNpemUoKSA9PSAxKSA/IG1heCgobV9mcmFtZVJlY3QuaGVpZ2h0KCkgLSBwYWdlQm94Lmhl aWdodCgpICsgc2hhZG93T2Zmc2V0WSkgLyAyLjBmLCAwLjBmKSA6IDA7CisKICAgICAgICAgaWYg KHBhZ2VUb3AgPiBjb250ZW50UmVjdC5tYXhZKCkpCiAgICAgICAgICAgICBicmVhazsKLSAgICAg ICAgaWYgKHBhZ2VUb3AgKyBwYWdlQm94LmhlaWdodCgpID49IGNvbnRlbnRSZWN0LnkoKSkgewor ICAgICAgICBpZiAocGFnZVRvcCArIHBhZ2VCb3guaGVpZ2h0KCkgKyBleHRyYU9mZnNldEZvckNl bnRlcmluZ1kgKyBndXR0ZXJIZWlnaHQgPj0gY29udGVudFJlY3QueSgpKSB7CiAgICAgICAgICAg ICBDR1BERlBhZ2VSZWYgcGRmUGFnZSA9IENHUERGRG9jdW1lbnRHZXRQYWdlKG1fcGRmRG9jdW1l bnQuZ2V0KCksIGkgKyAxKTsKIAotICAgICAgICAgICAgZmxvYXQgZXh0cmFPZmZzZXRGb3JDZW50 ZXJpbmdYID0gbWF4KChtX2ZyYW1lUmVjdC53aWR0aCgpIC0gcGFnZUJveC53aWR0aCgpKSAvIDIu MGYsIDAuMGYpOwotICAgICAgICAgICAgZmxvYXQgZXh0cmFPZmZzZXRGb3JDZW50ZXJpbmdZID0g KG1fcGFnZUJveGVzLnNpemUoKSA9PSAxKSA/IG1heCgobV9mcmFtZVJlY3QuaGVpZ2h0KCkgLSBw YWdlQm94LmhlaWdodCgpICsgc2hhZG93T2Zmc2V0WSkgLyAyLjBmLCAwLjBmKSA6IDA7Ci0KICAg ICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+c2F2ZSgpOwogICAgICAgICAgICAgZ3JhcGhpY3ND b250ZXh0LT50cmFuc2xhdGUoZXh0cmFPZmZzZXRGb3JDZW50ZXJpbmdYIC0gcGFnZUJveC54KCks IC1leHRyYU9mZnNldEZvckNlbnRlcmluZ1kgLSBwYWdlQm94LnkoKSAtIHBhZ2VCb3guaGVpZ2h0 KCkpOwogCkBAIC0yOTAsNiArMjkwLDcgQEAgdm9pZCBCdWlsdEluUERGVmlldzo6cGFpbnRDb250 ZW50KEdyYXBoaQogICAgICAgICBwYWdlVG9wICs9IHBhZ2VCb3guaGVpZ2h0KCkgKyBndXR0ZXJI ZWlnaHQ7CiAgICAgICAgIENHQ29udGV4dFRyYW5zbGF0ZUNUTShjb250ZXh0LCAwLCAtcGFnZUJv eC5oZWlnaHQoKSAtIGd1dHRlckhlaWdodCk7CiAgICAgfQorcHJpbnRmKCJcbiIpOwogfQogCiB2 b2lkIEJ1aWx0SW5QREZWaWV3OjpwYWludENvbnRyb2xzKEdyYXBoaWNzQ29udGV4dCogZ3JhcGhp Y3NDb250ZXh0LCBjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3QpCg==