69859 2011-10-11 11:44:16 -0700 [Qt][WK2] ASSERT when displaying context menu in input field 2011-10-18 08:50:42 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob dinu.jacob hausmann webkit.review.bot oldest_to_newest 481777 0 dinu.jacob 2011-10-11 11:44:16 -0700 Right clicking in an input field to display the context menu causes an ASSERT when creating the sub menu and setting the menu as the parent of the sub-menu in WebContextMenuProxyQt::createContextMenu. 481781 1 dinu.jacob 2011-10-11 11:47:53 -0700 QWidget is statically cast to QObject before calling setParent on it. QObject::setParent asserts if the object is a QWidget. 481789 2 110554 dinu.jacob 2011-10-11 11:58:33 -0700 Created attachment 110554 Patch 481791 3 dinu.jacob 2011-10-11 12:00:05 -0700 Patch attached. Not sure why it was being explcitly cast to QObject. I see that the setParent of QWidget does additional things than QObject. Please review and provide your feedback. 483851 4 110554 hausmann 2011-10-14 01:48:33 -0700 Comment on attachment 110554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110554&action=review > Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.cpp:115 > - static_cast<QObject*>(subMenu.get())->setParent(menu.get()); > + subMenu->setParent(menu.get()); Could you explain (for example in the changelog or whereever appropriate) why your patch fixes the assert? Please also mention what assert exactly :) 483854 5 hausmann 2011-10-14 01:52:30 -0700 Argh, I should've read the bug report first, I see that the comments explain it :) 485997 6 111429 dinu.jacob 2011-10-18 06:23:29 -0700 Created attachment 111429 Patch with ChangeLog update (Can't think of why I didn't do it earlier :) ) 486076 7 111429 webkit.review.bot 2011-10-18 08:50:38 -0700 Comment on attachment 111429 Patch with ChangeLog update (Can't think of why I didn't do it earlier :) ) Clearing flags on attachment: 111429 Committed r97760: <http://trac.webkit.org/changeset/97760> 486077 8 webkit.review.bot 2011-10-18 08:50:42 -0700 All reviewed patches have been landed. Closing bug. 110554 2011-10-11 11:58:33 -0700 2011-10-18 06:23:29 -0700 Patch 69859.patch text/plain 1413 dinu.jacob SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTY2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMTEgIERpbnUgSmFj b2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gQVNTRVJUIHdo ZW4gZGlzcGxheWluZyBjb250ZXh0IG1lbnUgaW4gaW5wdXQgZmllbGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5ODU5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvV2ViQ29udGV4 dE1lbnVQcm94eVF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eVF0 OjpjcmVhdGVDb250ZXh0TWVudSk6CisKIDIwMTEtMTAtMTEgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gU2hvdWxkIGJlIGFibGUgdG8gZGlzcGxh eSBtdWx0aS1wYWdlIFBERnMgaW4gc3ViZnJhbWVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvV2ViQ29udGV4dE1lbnVQcm94eVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViQ29udGV4dE1lbnVQcm94eVF0LmNwcAkocmV2aXNpb24g OTcxNTIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViQ29udGV4dE1lbnVQcm94 eVF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDcgKzExMiw3IEBAIFBhc3NPd25QdHI8UU1l bnU+IFdlYkNvbnRleHRNZW51UHJveHlRdDoKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBj YXNlIFdlYkNvcmU6OlN1Ym1lbnVUeXBlOgogICAgICAgICAgICAgaWYgKE93blB0cjxRTWVudT4g c3ViTWVudSA9IGNyZWF0ZUNvbnRleHRNZW51KGl0ZW0uc3VibWVudSgpKSkgewotICAgICAgICAg ICAgICAgIHN0YXRpY19jYXN0PFFPYmplY3QqPihzdWJNZW51LmdldCgpKS0+c2V0UGFyZW50KG1l bnUuZ2V0KCkpOworICAgICAgICAgICAgICAgIHN1Yk1lbnUtPnNldFBhcmVudChtZW51LmdldCgp KTsKICAgICAgICAgICAgICAgICBzdWJNZW51LT5zZXRUaXRsZShpdGVtLnRpdGxlKCkpOwogICAg ICAgICAgICAgICAgIFFNZW51KiBjb25zdCBzdWJNZW51UHRyID0gc3ViTWVudS5sZWFrUHRyKCk7 CiAgICAgICAgICAgICAgICAgbWVudS0+YWRkTWVudShzdWJNZW51UHRyKTsK 111429 2011-10-18 06:23:29 -0700 2011-10-18 08:50:38 -0700 Patch with ChangeLog update (Can't think of why I didn't do it earlier :) ) 69859.patch text/plain 1723 dinu.jacob SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NzQ2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMTggIERpbnUgSmFj b2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gQVNTRVJUIHdo ZW4gZGlzcGxheWluZyBjb250ZXh0IG1lbnUgaW4gaW5wdXQgZmllbGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5ODU5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBjcmVhdGluZyBhIHN1Ym1lbnUg aW4gdGhlIGNvbnRleHQgbWVudSwgdGhlIHN1Ym1lbnUgb2YgdHlwZQorICAgICAgICBRV2lkZ2V0 IGlzIHN0YXRpY2FsbHkgY2FzdCB0byBRT2JqZWN0IGJlZm9yZSBjYWxsaW5nIHNldFBhcmVudCBv bgorICAgICAgICBpdC4gUU9iamVjdDo6c2V0UGFyZW50IGFzc2VydHMgaWYgdGhlIG9iamVjdCBp cyBhIFFXaWRnZXQuIFNvLCBjYWxsCisgICAgICAgIHNldFBhcmVudCBvZiBRV2lkZ2V0IGl0c2Vs Zi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9XZWJDb250ZXh0TWVudVByb3h5UXQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5UXQ6OmNyZWF0ZUNvbnRleHRNZW51 KToKKwogMjAxMS0xMC0xOCAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5v bGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gU2VuZCBtb3VzZSBtb3ZlIGV2 ZW50cyB3aGVuIHdlIGhhbmRsZSBIb3ZlckVudGVyL0xlYXZlIGluIFFEZXNrdG9wV2ViVmlldwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1dlYkNvbnRleHRNZW51UHJveHlRdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1dlYkNvbnRleHRN ZW51UHJveHlRdC5jcHAJKHJldmlzaW9uIDk3NjE5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1dlYkNvbnRleHRNZW51UHJveHlRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMiw3 ICsxMTIsNyBAQCBQYXNzT3duUHRyPFFNZW51PiBXZWJDb250ZXh0TWVudVByb3h5UXQ6CiAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBXZWJDb3JlOjpTdWJtZW51VHlwZToKICAgICAg ICAgICAgIGlmIChPd25QdHI8UU1lbnU+IHN1Yk1lbnUgPSBjcmVhdGVDb250ZXh0TWVudShpdGVt LnN1Ym1lbnUoKSkpIHsKLSAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxRT2JqZWN0Kj4oc3Vi TWVudS5nZXQoKSktPnNldFBhcmVudChtZW51LmdldCgpKTsKKyAgICAgICAgICAgICAgICBzdWJN ZW51LT5zZXRQYXJlbnQobWVudS5nZXQoKSk7CiAgICAgICAgICAgICAgICAgc3ViTWVudS0+c2V0 VGl0bGUoaXRlbS50aXRsZSgpKTsKICAgICAgICAgICAgICAgICBRTWVudSogY29uc3Qgc3ViTWVu dVB0ciA9IHN1Yk1lbnUubGVha1B0cigpOwogICAgICAgICAgICAgICAgIG1lbnUtPmFkZE1lbnUo c3ViTWVudVB0cik7Cg==