69855 2011-10-11 11:25:11 -0700 [Chromium] Prevent fallback fonts from purging while measuring 2011-10-12 06:30:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark aroben brettw eric hyatt msaboff senorblanco webkit.review.bot oldest_to_newest 481755 0 caryclark 2011-10-11 11:25:11 -0700 [Chromium] Prevent fallback fonts from purging while measuring 481757 1 110546 caryclark 2011-10-11 11:29:15 -0700 Created attachment 110546 Patch 481760 2 caryclark 2011-10-11 11:32:12 -0700 obsoleted 69843 that did the same thing in the wrong place 481771 3 110546 senorblanco 2011-10-11 11:40:48 -0700 Comment on attachment 110546 Patch This looks reasonable to me, but it's kind of beyond my expertise. Eric, could you take a look? 481805 4 eric 2011-10-11 12:14:22 -0700 msaboff@apple.com added the original, I see you've CC'd him. Hyatt has historically done the most font-related work, I assume msaboff consulted him in this as well. Brett also did a lot of the font-related bringup for chome. It feels very strange to me that we would need to do this at the WebKit layer like this. It does appear that this is how this object is typically used however, so r+. 482379 5 110546 webkit.review.bot 2011-10-12 06:30:11 -0700 Comment on attachment 110546 Patch Clearing flags on attachment: 110546 Committed r97257: <http://trac.webkit.org/changeset/97257> 482380 6 webkit.review.bot 2011-10-12 06:30:16 -0700 All reviewed patches have been landed. Closing bug. 110546 2011-10-11 11:29:15 -0700 2011-10-12 06:30:11 -0700 Patch bug-69855-20111011142913.patch text/plain 1937 caryclark SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NzE2NCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMTAtMTEgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAg ICAgICBbQ2hyb21pdW1dIFByZXZlbnQgZmFsbGJhY2sgZm9udHMgZnJvbSBwdXJnaW5nIHdoaWxl IG1lYXN1cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njk4NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaGVuIENocm9tZSBjb21wdXRlcyB0aGUgcGFnZSB3aWR0aCwgYW4gaW50ZXJuYXRpb25hbCBw YWdlCisgICAgICAgIG1heSBicmluZyBpbiBhIGZhbGxiYWNrIGZvbnQuIEZvbnRDYWNoZTo6Z2V0 Q2FjaGVkRm9udERhdGEKKyAgICAgICAgZXhwZWN0cyB0aGUgZm9udCBjYWNoZSB0byBiZSBsb2Nr ZWQsIHNvIHRoZSBtZWFzdXJlIHBhdGgKKyAgICAgICAgbmVlZHMgdG8gaW5jbHVkZSBhbiBpbnN0 YW5jZSBvZiBGb250Q2FjaGVQdXJnZVByZXZlbnRlci4KKworICAgICAgICBBZGRpbmcgRm9udENh Y2hlUHVyZ2VQcmV2ZW50ZXIgc3VwcHJlc3NlcyBhIGRlYnVnLXRpbWUgYXNzZXJ0CisgICAgICAg IHdoZW4gcnVubmluZyBQYWdlQ3ljbGVyIG92ZXIgaW50ZXJuYXRpb25hbCB0ZXN0cy4KKworICAg ICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUlt cGw6OmNvbnRlbnRzUHJlZmVycmVkV2lkdGgpOgorCiAyMDExLTEwLTEwICBBZGFtIEtsZWluICA8 YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtNdXRhdGlvbk9ic2VydmVyc10gQWRkIHN0 dWIgaW1wbGVtZW50YXRpb24gb2YgV2ViS2l0TXV0YXRpb25PYnNlcnZlcgpJbmRleDogU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lvbiA5NzA1NikK KysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTg2LDYgKzg2LDcgQEAKICNpbmNsdWRlICJFZGl0b3IuaCIKICNpbmNsdWRlICJF dmVudEhhbmRsZXIuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKKyNpbmNsdWRlICJG b250Q2FjaGUuaCIKICNpbmNsdWRlICJGb3JtU3RhdGUuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRS ZXF1ZXN0LmgiCiAjaW5jbHVkZSAiRnJhbWVMb2FkZXIuaCIKQEAgLTU3OSw4ICs1ODAsMTEgQEAg V2ViU2l6ZSBXZWJGcmFtZUltcGw6OmNvbnRlbnRzU2l6ZSgpIGNvbgogCiBpbnQgV2ViRnJhbWVJ bXBsOjpjb250ZW50c1ByZWZlcnJlZFdpZHRoKCkgY29uc3QKIHsKLSAgICBpZiAobV9mcmFtZS0+ ZG9jdW1lbnQoKSAmJiBtX2ZyYW1lLT5kb2N1bWVudCgpLT5yZW5kZXJWaWV3KCkpCisgICAgaWYg KG1fZnJhbWUtPmRvY3VtZW50KCkgJiYgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+cmVuZGVyVmlldygp KSB7CisgICAgICAgIEZvbnRDYWNoZVB1cmdlUHJldmVudGVyIGZvbnRDYWNoZVB1cmdlUHJldmVu dGVyOworCiAgICAgICAgIHJldHVybiBtX2ZyYW1lLT5kb2N1bWVudCgpLT5yZW5kZXJWaWV3KCkt Pm1pblByZWZlcnJlZExvZ2ljYWxXaWR0aCgpOworICAgIH0KICAgICByZXR1cm4gMDsKIH0KIAo=